Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57378/?format=api
{ "id": 57378, "url": "https://patches.dpdk.org/api/patches/57378/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190802025826.1174-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190802025826.1174-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190802025826.1174-4-stephen@networkplumber.org", "date": "2019-08-02T02:58:25", "name": "[v5,3/4] examples/multi_process/client_server_mp/mp_server: fix style", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3a47f314fc03ef740a1eef668beeff9960981d2c", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190802025826.1174-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 5881, "url": "https://patches.dpdk.org/api/series/5881/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5881", "date": "2019-08-02T02:58:22", "name": "examples/client_server_mp: port id fixes", "version": 5, "mbox": "https://patches.dpdk.org/series/5881/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57378/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/57378/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 479091C220;\n\tFri, 2 Aug 2019 04:58:38 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 8405A1C208\n\tfor <dev@dpdk.org>; Fri, 2 Aug 2019 04:58:33 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id f17so31212970pfn.6\n\tfor <dev@dpdk.org>; Thu, 01 Aug 2019 19:58:33 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ta20sm5788738pjo.0.2019.08.01.19.58.30\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tThu, 01 Aug 2019 19:58:31 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=id3prtgZ4g29GHDINT1hbmHslO10slBJO8OwDHigAZ8=;\n\tb=dNpLeUO4hm2F3BMi1EUCvJRHP3h8AmlTHKI4npPB/3fhHszzhlnTElJJ5MadNXxQ8a\n\tAfjcJIeQyvf1FmXT8b1s3pCS+9x2X9FEzwucNjCKgBGZbPQoh+WreIAITig0TZy4i10x\n\t82i2AahSky+z9DZcMQDo2JbLq61OGPZ5Dz2J8HK1SxCf7tacqLvWLbNVQZlIzO9SXOy/\n\tp4YaO13BG6RH8bvwjV+0M60TfR5K9/L5zOXsdE6wYFEeSKkZ1iYfmbDICVxLeEi2s/b8\n\tx1A1GBdjj+yX9rImPALB4xt5VejzmBZpDgyV3NsF5I/hhWe5oZiM03s7gGt9ugZoX4/v\n\tIWwg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=id3prtgZ4g29GHDINT1hbmHslO10slBJO8OwDHigAZ8=;\n\tb=Lyu9cO8vc9W1JzMUJ13yaGomYtMjdzRmUM5lKnKr4n2LvsqH4Ls64PC0vzvydNAFkK\n\t8W9IU/zrJt83426Gz/po/Rvfu0Fof2cR8JLG53sm/42ZyXA5Mm6up45leh1hnjsmHAfQ\n\t39QaeX0zm3mSSHgStss9f4IlTK03mugh2nEHPaQqJ9MAeXnO6edMavh9puBhdYmKToUQ\n\tGGH1Ly1Z3TpOyWEn3XLG4BQeIUNoVQ9pmkB4EXYP97lCDqPLHOtIrxKnndZtMaKPBid7\n\te4auVcKw7tZv3pRHc+vQ2EDBhYSfAmgBj9M8dFtAas1lU2u6zOnjcyKIYk/og1y+qofT\n\tW9kw==", "X-Gm-Message-State": "APjAAAVEhAX3C+dU/iar2GT0dc2wR8fUEUnV8jaQLd1z12YdNgunRDZ0\n\tyzePoA053iTluR3SLAA/E2urzRLE", "X-Google-Smtp-Source": "APXvYqz6cKvR1IDBSky2eYp29iO9pu5IWx3nK68FjBrDrgfYxXXambSZkla2LZT7SfQ5TajUW9Seog==", "X-Received": "by 2002:a17:90a:24ac:: with SMTP id\n\ti41mr1994747pje.124.1564714712132; \n\tThu, 01 Aug 2019 19:58:32 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 1 Aug 2019 19:58:25 -0700", "Message-Id": "<20190802025826.1174-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190802025826.1174-1-stephen@networkplumber.org>", "References": "<20190726165054.24078-1-stephen@networkplumber.org>\n\t<20190802025826.1174-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 3/4]\n\texamples/multi_process/client_server_mp/mp_server: fix style", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Lots of little style complaints from checkpatch.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n .../client_server_mp/mp_server/args.c | 37 ++++-----\n .../client_server_mp/mp_server/init.c | 79 +++++++++++--------\n .../client_server_mp/mp_server/main.c | 44 ++++++-----\n 3 files changed, 88 insertions(+), 72 deletions(-)", "diff": "diff --git a/examples/multi_process/client_server_mp/mp_server/args.c b/examples/multi_process/client_server_mp/mp_server/args.c\nindex fdc008b3d677..91c823856a72 100644\n--- a/examples/multi_process/client_server_mp/mp_server/args.c\n+++ b/examples/multi_process/client_server_mp/mp_server/args.c\n@@ -112,33 +112,34 @@ parse_app_args(int argc, char *argv[])\n \tprogname = argv[0];\n \n \twhile ((opt = getopt_long(argc, argvopt, \"n:p:\", lgopts,\n-\t\t&option_index)) != EOF){\n-\t\tswitch (opt){\n-\t\t\tcase 'p':\n-\t\t\t\tif (parse_portmask(optarg) != 0) {\n-\t\t\t\t\tusage();\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n-\t\t\t\tbreak;\n-\t\t\tcase 'n':\n-\t\t\t\tif (parse_num_clients(optarg) != 0){\n-\t\t\t\t\tusage();\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n-\t\t\t\tbreak;\n-\t\t\tdefault:\n-\t\t\t\tprintf(\"ERROR: Unknown option '%c'\\n\", opt);\n+\t\t\t\t &option_index)) != EOF) {\n+\n+\t\tswitch (opt) {\n+\t\tcase 'p':\n+\t\t\tif (parse_portmask(optarg) != 0) {\n+\t\t\t\tusage();\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tcase 'n':\n+\t\t\tif (parse_num_clients(optarg) != 0) {\n \t\t\t\tusage();\n \t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tprintf(\"ERROR: Unknown option '%c'\\n\", opt);\n+\t\t\tusage();\n+\t\t\treturn -1;\n \t\t}\n \t}\n \n-\tif (ports->num_ports == 0 || num_clients == 0){\n+\tif (ports->num_ports == 0 || num_clients == 0) {\n \t\tusage();\n \t\treturn -1;\n \t}\n \n-\tif (ports->num_ports % 2 != 0){\n+\tif (ports->num_ports % 2 != 0) {\n \t\tprintf(\"ERROR: application requires an even number of ports to use\\n\");\n \t\treturn -1;\n \t}\ndiff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c\nindex 1b0569937b51..96c35f220a7d 100644\n--- a/examples/multi_process/client_server_mp/mp_server/init.c\n+++ b/examples/multi_process/client_server_mp/mp_server/init.c\n@@ -49,7 +49,7 @@\n struct rte_mempool *pktmbuf_pool;\n \n /* array of info/queues for clients */\n-struct client *clients = NULL;\n+struct client *clients;\n \n /* the port details */\n struct port_info *ports;\n@@ -72,7 +72,8 @@ init_mbuf_pools(void)\n \t\tnum_mbufs_server + num_mbufs_client + num_mbufs_mp_cache;\n \n \t/* don't pass single-producer/single-consumer flags to mbuf create as it\n-\t * seems faster to use a cache instead */\n+\t * seems faster to use a cache instead\n+\t */\n \tprintf(\"Creating mbuf pool '%s' [%u mbufs] ...\\n\",\n \t\t\tPKTMBUF_POOL_NAME, num_mbufs);\n \tpktmbuf_pool = rte_pktmbuf_pool_create(PKTMBUF_POOL_NAME, num_mbufs,\n@@ -108,9 +109,11 @@ init_port(uint16_t port_num)\n \tfflush(stdout);\n \n \t/* Standard DPDK port initialisation - config port, then set up\n-\t * rx and tx rings */\n-\tif ((retval = rte_eth_dev_configure(port_num, rx_rings, tx_rings,\n-\t\t&port_conf)) != 0)\n+\t * rx and tx rings\n+\t */\n+\tretval = rte_eth_dev_configure(port_num, rx_rings, tx_rings,\n+\t\t\t\t &port_conf);\n+\tif (retval != 0)\n \t\treturn retval;\n \n \tretval = rte_eth_dev_adjust_nb_rx_tx_desc(port_num, &rx_ring_size,\n@@ -122,22 +125,25 @@ init_port(uint16_t port_num)\n \t\tretval = rte_eth_rx_queue_setup(port_num, q, rx_ring_size,\n \t\t\t\trte_eth_dev_socket_id(port_num),\n \t\t\t\tNULL, pktmbuf_pool);\n-\t\tif (retval < 0) return retval;\n+\t\tif (retval < 0)\n+\t\t\treturn retval;\n \t}\n \n-\tfor ( q = 0; q < tx_rings; q ++ ) {\n+\tfor (q = 0; q < tx_rings; q++) {\n \t\tretval = rte_eth_tx_queue_setup(port_num, q, tx_ring_size,\n \t\t\t\trte_eth_dev_socket_id(port_num),\n \t\t\t\tNULL);\n-\t\tif (retval < 0) return retval;\n+\t\tif (retval < 0)\n+\t\t\treturn retval;\n \t}\n \n \trte_eth_promiscuous_enable(port_num);\n \n \tretval = rte_eth_dev_start(port_num);\n-\tif (retval < 0) return retval;\n+\tif (retval < 0)\n+\t\treturn retval;\n \n-\tprintf( \"done: \\n\");\n+\tprintf(\"done:\\n\");\n \n \treturn 0;\n }\n@@ -150,15 +156,15 @@ init_port(uint16_t port_num)\n static int\n init_shm_rings(void)\n {\n-\tunsigned i;\n-\tunsigned socket_id;\n-\tconst char * q_name;\n-\tconst unsigned ringsize = CLIENT_QUEUE_RINGSIZE;\n+\tunsigned int i, socket_id;\n+\tconst char *q_name;\n+\tconst unsigned int ringsize = CLIENT_QUEUE_RINGSIZE;\n \n \tclients = rte_malloc(\"client details\",\n \t\tsizeof(*clients) * num_clients, 0);\n \tif (clients == NULL)\n-\t\trte_exit(EXIT_FAILURE, \"Cannot allocate memory for client program details\\n\");\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t \"Cannot allocate memory for client program details\\n\");\n \n \tfor (i = 0; i < num_clients; i++) {\n \t\t/* Create an RX queue for each client */\n@@ -166,13 +172,27 @@ init_shm_rings(void)\n \t\tq_name = get_rx_queue_name(i);\n \t\tclients[i].rx_q = rte_ring_create(q_name,\n \t\t\t\tringsize, socket_id,\n-\t\t\t\tRING_F_SP_ENQ | RING_F_SC_DEQ ); /* single prod, single cons */\n+\t\t\t\tRING_F_SP_ENQ | RING_F_SC_DEQ);\n \t\tif (clients[i].rx_q == NULL)\n-\t\t\trte_exit(EXIT_FAILURE, \"Cannot create rx ring queue for client %u\\n\", i);\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Cannot create rx ring queue for client %u\\n\",\n+\t\t\t\t i);\n \t}\n \treturn 0;\n }\n \n+static void\n+print_link_status(uint16 id, const struct rte_eth_link *link)\n+{\n+\tif (link->link_status)\n+\t\tprintf(\"Port %d Link Up - speed %u Mbps - %s-duplex\\n\",\n+\t\t id, link->link_speed,\n+\t\t (link->link_duplex == ETH_LINK_FULL_DUPLEX) ?\n+\t\t \"full\" : \"half\");\n+\telse\n+\t\tprintf(\"Port %d Link Down\\n\", id);\n+}\n+\n /* Check the link status of all ports in up to 9s, and print them finally */\n static void\n check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n@@ -192,21 +212,11 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)\n \t\t\t\tcontinue;\n \t\t\tmemset(&link, 0, sizeof(link));\n \t\t\trte_eth_link_get_nowait(ports->id[portid], &link);\n+\n \t\t\t/* print link status if flag set */\n-\t\t\tif (print_flag == 1) {\n-\t\t\t\tif (link.link_status)\n-\t\t\t\t\tprintf(\"Port %d Link Up - speed %u \"\n-\t\t\t\t\t\t\"Mbps - %s\\n\", ports->id[portid],\n-\t\t\t\t\t\t(unsigned)link.link_speed,\n-\t\t\t\t(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\t(\"full-duplex\") : (\"half-duplex\\n\"));\n-\t\t\t\telse\n-\t\t\t\t\tprintf(\"Port %d Link Down\\n\",\n-\t\t\t\t\t\t(uint8_t)ports->id[portid]);\n-\t\t\t\tcontinue;\n-\t\t\t}\n-\t\t\t/* clear all_ports_up flag if any link down */\n-\t\t\tif (link.link_status == ETH_LINK_DOWN) {\n+\t\t\tif (print_flag == 1)\n+\t\t\t\tprint_link_status(&link);\n+\t\t\telse if (link.link_status == ETH_LINK_DOWN) {\n \t\t\t\tall_ports_up = 0;\n \t\t\t\tbreak;\n \t\t\t}\n@@ -251,7 +261,8 @@ init(int argc, char *argv[])\n \tmz = rte_memzone_reserve(MZ_PORT_INFO, sizeof(*ports),\n \t\t\t\trte_socket_id(), NO_FLAGS);\n \tif (mz == NULL)\n-\t\trte_exit(EXIT_FAILURE, \"Cannot reserve memory zone for port information\\n\");\n+\t\trte_exit(EXIT_FAILURE,\n+\t\t\t \"Cannot reserve memory zone for port information\\n\");\n \tmemset(mz->addr, 0, sizeof(*ports));\n \tports = mz->addr;\n \n@@ -269,8 +280,8 @@ init(int argc, char *argv[])\n \tfor (i = 0; i < ports->num_ports; i++) {\n \t\tretval = init_port(ports->id[i]);\n \t\tif (retval != 0)\n-\t\t\trte_exit(EXIT_FAILURE, \"Cannot initialise port %u\\n\",\n-\t\t\t\t\t(unsigned)i);\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Cannot initialise port %u\\n\", i);\n \t}\n \n \tcheck_all_ports_link_status(ports->num_ports, (~0x0));\ndiff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c\nindex 0150533700f0..bfec0bef3a71 100644\n--- a/examples/multi_process/client_server_mp/mp_server/main.c\n+++ b/examples/multi_process/client_server_mp/mp_server/main.c\n@@ -64,8 +64,9 @@ get_printable_mac_addr(uint16_t port)\n \n \tif (unlikely(port >= RTE_MAX_ETHPORTS))\n \t\treturn err_address;\n-\tif (unlikely(addresses[port][0]=='\\0')){\n+\tif (unlikely(addresses[port][0] == '\\0')) {\n \t\tstruct rte_ether_addr mac;\n+\n \t\trte_eth_macaddr_get(port, &mac);\n \t\tsnprintf(addresses[port], sizeof(addresses[port]),\n \t\t\t\t\"%02x:%02x:%02x:%02x:%02x:%02x\\n\",\n@@ -85,9 +86,9 @@ get_printable_mac_addr(uint16_t port)\n static void\n do_stats_display(void)\n {\n-\tunsigned i, j;\n+\tunsigned int i, j;\n \tconst char clr[] = { 27, '[', '2', 'J', '\\0' };\n-\tconst char topLeft[] = { 27, '[', '1', ';', '1', 'H','\\0' };\n+\tconst char topLeft[] = { 27, '[', '1', ';', '1', 'H', '\\0' };\n \tuint64_t port_tx[RTE_MAX_ETHPORTS], port_tx_drop[RTE_MAX_ETHPORTS];\n \tuint64_t client_tx[MAX_CLIENTS], client_tx_drop[MAX_CLIENTS];\n \n@@ -97,12 +98,14 @@ do_stats_display(void)\n \tmemset(client_tx, 0, sizeof(client_tx));\n \tmemset(client_tx_drop, 0, sizeof(client_tx_drop));\n \n-\tfor (i = 0; i < num_clients; i++){\n+\tfor (i = 0; i < num_clients; i++) {\n \t\tconst volatile struct tx_stats *tx = &ports->tx_stats[i];\n-\t\tfor (j = 0; j < ports->num_ports; j++){\n+\n+\t\tfor (j = 0; j < ports->num_ports; j++) {\n \t\t\t/* assign to local variables here, save re-reading volatile vars */\n \t\t\tconst uint64_t tx_val = tx->tx[ports->id[j]];\n \t\t\tconst uint64_t drop_val = tx->tx_drop[ports->id[j]];\n+\n \t\t\tport_tx[j] += tx_val;\n \t\t\tport_tx_drop[j] += drop_val;\n \t\t\tclient_tx[i] += tx_val;\n@@ -116,21 +119,21 @@ do_stats_display(void)\n \tprintf(\"PORTS\\n\");\n \tprintf(\"-----\\n\");\n \tfor (i = 0; i < ports->num_ports; i++)\n-\t\tprintf(\"Port %u: '%s'\\t\", (unsigned)ports->id[i],\n-\t\t\t\tget_printable_mac_addr(ports->id[i]));\n+\t\tprintf(\"Port %u: '%s'\\t\", ports->id[i],\n+\t\t get_printable_mac_addr(ports->id[i]));\n \tprintf(\"\\n\\n\");\n-\tfor (i = 0; i < ports->num_ports; i++){\n-\t\tprintf(\"Port %u - rx: %9\"PRIu64\"\\t\"\n-\t\t\t\t\"tx: %9\"PRIu64\"\\n\",\n-\t\t\t\t(unsigned)ports->id[i], ports->rx_stats.rx[i],\n+\tfor (i = 0; i < ports->num_ports; i++) {\n+\t\tprintf(\"Port %u - rx: %9\"PRIu64\"\\ttx: %9\"PRIu64\"\\n\",\n+\t\t\t\tports->id[i], ports->rx_stats.rx[i],\n \t\t\t\tport_tx[i]);\n \t}\n \n \tprintf(\"\\nCLIENTS\\n\");\n \tprintf(\"-------\\n\");\n-\tfor (i = 0; i < num_clients; i++){\n+\tfor (i = 0; i < num_clients; i++) {\n \t\tconst unsigned long long rx = clients[i].stats.rx;\n \t\tconst unsigned long long rx_drop = clients[i].stats.rx_drop;\n+\n \t\tprintf(\"Client %2u - rx: %9llu, rx_drop: %9llu\\n\"\n \t\t\t\t\" tx: %9\"PRIu64\", tx_drop: %9\"PRIu64\"\\n\",\n \t\t\t\ti, rx, rx_drop, client_tx[i], client_tx_drop[i]);\n@@ -153,7 +156,8 @@ sleep_lcore(__attribute__((unused)) void *dummy)\n \n \t/* Only one core should display stats */\n \tif (rte_atomic32_test_and_set(&display_stats)) {\n-\t\tconst unsigned sleeptime = 1;\n+\t\tconst unsigned int sleeptime = 1;\n+\n \t\tprintf(\"Core %u displaying statistics\\n\", rte_lcore_id());\n \n \t\t/* Longer initial pause so above printf is seen */\n@@ -173,7 +177,7 @@ sleep_lcore(__attribute__((unused)) void *dummy)\n static void\n clear_stats(void)\n {\n-\tunsigned i;\n+\tunsigned int i;\n \n \tfor (i = 0; i < num_clients; i++)\n \t\tclients[i].stats.rx = clients[i].stats.rx_drop = 0;\n@@ -194,12 +198,11 @@ flush_rx_queue(uint16_t client)\n \n \tcl = &clients[client];\n \tif (rte_ring_enqueue_bulk(cl->rx_q, (void **)cl_rx_buf[client].buffer,\n-\t\t\tcl_rx_buf[client].count, NULL) == 0){\n+\t\t\tcl_rx_buf[client].count, NULL) == 0) {\n \t\tfor (j = 0; j < cl_rx_buf[client].count; j++)\n \t\t\trte_pktmbuf_free(cl_rx_buf[client].buffer[j]);\n \t\tcl->stats.rx_drop += cl_rx_buf[client].count;\n-\t}\n-\telse\n+\t} else\n \t\tcl->stats.rx += cl_rx_buf[client].count;\n \n \tcl_rx_buf[client].count = 0;\n@@ -243,14 +246,14 @@ process_packets(uint32_t port_num __rte_unused,\n static void\n do_packet_forwarding(void)\n {\n-\tunsigned port_num = 0; /* indexes the port[] array */\n+\tunsigned int port_num = 0; /* indexes the port[] array */\n \n \tfor (;;) {\n \t\tstruct rte_mbuf *buf[PACKET_READ_SIZE];\n \t\tuint16_t rx_count;\n \n \t\t/* read a port */\n-\t\trx_count = rte_eth_rx_burst(ports->id[port_num], 0, \\\n+\t\trx_count = rte_eth_rx_burst(ports->id[port_num], 0,\n \t\t\t\tbuf, PACKET_READ_SIZE);\n \t\tports->rx_stats.rx[port_num] += rx_count;\n \n@@ -281,8 +284,9 @@ int\n main(int argc, char *argv[])\n {\n \tsignal(SIGINT, signal_handler);\n+\n \t/* initialise the system */\n-\tif (init(argc, argv) < 0 )\n+\tif (init(argc, argv) < 0)\n \t\treturn -1;\n \tRTE_LOG(INFO, APP, \"Finished Process Init.\\n\");\n \n", "prefixes": [ "v5", "3/4" ] }