Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57238/?format=api
{ "id": 57238, "url": "https://patches.dpdk.org/api/patches/57238/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1564401209-18752-6-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1564401209-18752-6-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1564401209-18752-6-git-send-email-matan@mellanox.com", "date": "2019-07-29T11:53:23", "name": "[05/11] net/mlx5: fix DevX scattered Rx queue size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "215e5e97d130252ff77fe45d5a4a30d36cd9ccc3", "submitter": { "id": 796, "url": "https://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1564401209-18752-6-git-send-email-matan@mellanox.com/mbox/", "series": [ { "id": 5809, "url": "https://patches.dpdk.org/api/series/5809/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=5809", "date": "2019-07-29T11:53:21", "name": "net/mlx5: LRO fixes and enhancements", "version": 1, "mbox": "https://patches.dpdk.org/series/5809/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/57238/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/57238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1BA0A1BFA4;\n\tMon, 29 Jul 2019 14:17:00 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 5C2D61BF5F\n\tfor <dev@dpdk.org>; Mon, 29 Jul 2019 14:16:35 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tmatan@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 29 Jul 2019 15:16:29 +0300", "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n\t[10.210.16.112])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6TCGS4J021429;\n\tMon, 29 Jul 2019 15:16:29 +0300" ], "From": "Matan Azrad <matan@mellanox.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>, \n\tViacheslav Ovsiienko <viacheslavo@mellanox.com>", "Cc": "dev@dpdk.org, Dekel Peled <dekelp@mellanox.com>", "Date": "Mon, 29 Jul 2019 11:53:23 +0000", "Message-Id": "<1564401209-18752-6-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1564401209-18752-1-git-send-email-matan@mellanox.com>", "References": "<1564401209-18752-1-git-send-email-matan@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 05/11] net/mlx5: fix DevX scattered Rx queue size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The WQ size configuration via DevX didn't take into acount the maximum\nnumber of segments per packet what wrongly caused to configure bigger\nWQE size than the size expected by the PMD in other places.\n\nThe scatter mode stride size should be the size of segment multiplied\nby the number of maximum segments per packet.\nThe number of WQEs per WQ should be the number of descriptors divided by\nthe number of the maximum segments per packet.\n\nFix the size calculations to the above rule.\n\nFixes: dc9ceff73c99 (\"net/mlx5: create advanced RxQ via DevX\")\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 14 ++++----------\n 1 file changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex d10c5c1..c95627e 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1090,7 +1090,7 @@\n \tstruct mlx5_rxq_ctrl *rxq_ctrl =\n \t\tcontainer_of(rxq_data, struct mlx5_rxq_ctrl, rxq);\n \tstruct mlx5_devx_create_rq_attr rq_attr;\n-\tuint32_t wqe_n = 1 << rxq_data->elts_n;\n+\tuint32_t wqe_n = 1 << (rxq_data->elts_n - rxq_data->sges_n);\n \tuint32_t wq_size = 0;\n \tuint32_t wqe_size = 0;\n \tuint32_t log_wqe_size = 0;\n@@ -1118,17 +1118,11 @@\n \t\t\t\tMLX5_MIN_SINGLE_STRIDE_LOG_NUM_BYTES;\n \t\twqe_size = sizeof(struct mlx5_wqe_mprq);\n \t} else {\n-\t\tint max_sge = 0;\n-\t\tint num_scatter = 0;\n-\n-\t\trq_attr.wq_attr.wq_type = MLX5_WQ_TYPE_CYCLIC;\n-\t\tmax_sge = 1 << rxq_data->sges_n;\n-\t\tnum_scatter = RTE_MAX(max_sge, 1);\n-\t\twqe_size = sizeof(struct mlx5_wqe_data_seg) * num_scatter;\n+\t\twqe_size = sizeof(struct mlx5_wqe_data_seg);\n \t}\n-\tlog_wqe_size = log2above(wqe_size);\n+\tlog_wqe_size = log2above(wqe_size) + rxq_data->sges_n;\n \trq_attr.wq_attr.log_wq_stride = log_wqe_size;\n-\trq_attr.wq_attr.log_wq_sz = rxq_data->elts_n;\n+\trq_attr.wq_attr.log_wq_sz = rxq_data->elts_n - rxq_data->sges_n;\n \t/* Calculate and allocate WQ memory space. */\n \twqe_size = 1 << log_wqe_size; /* round up power of two.*/\n \twq_size = wqe_n * wqe_size;\n", "prefixes": [ "05/11" ] }