Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54362/?format=api
{ "id": 54362, "url": "https://patches.dpdk.org/api/patches/54362/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190604185352.28629-2-shshaikh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190604185352.28629-2-shshaikh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190604185352.28629-2-shshaikh@marvell.com", "date": "2019-06-04T18:53:49", "name": "[2/5] net/bnx2x: fix interrupt flood", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0f15d2ca0c5af3e606ce9cba299b1efb8a9d3479", "submitter": { "id": 1210, "url": "https://patches.dpdk.org/api/people/1210/?format=api", "name": "Shahed Shaikh", "email": "shshaikh@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190604185352.28629-2-shshaikh@marvell.com/mbox/", "series": [ { "id": 4894, "url": "https://patches.dpdk.org/api/series/4894/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4894", "date": "2019-06-04T18:53:49", "name": "[1/5] net/bnx2x: fix packet drop", "version": 1, "mbox": "https://patches.dpdk.org/series/4894/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/54362/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/54362/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D5C371B94E;\n\tTue, 4 Jun 2019 20:55:04 +0200 (CEST)", "from NAM04-BN3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr680042.outbound.protection.outlook.com [40.107.68.42])\n\tby dpdk.org (Postfix) with ESMTP id 382582BEA;\n\tTue, 4 Jun 2019 20:55:03 +0200 (CEST)", "from SN4PR0701CA0004.namprd07.prod.outlook.com\n\t(2603:10b6:803:28::14) by BN7PR07MB4433.namprd07.prod.outlook.com\n\t(2603:10b6:406:b6::24) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22;\n\tTue, 4 Jun 2019 18:55:02 +0000", "from BY2NAM05FT033.eop-nam05.prod.protection.outlook.com\n\t(2a01:111:f400:7e52::209) by SN4PR0701CA0004.outlook.office365.com\n\t(2603:10b6:803:28::14) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1943.17 via\n\tFrontend Transport; Tue, 4 Jun 2019 18:55:02 +0000", "from CAEXCH02.caveonetworks.com (199.233.58.38) by\n\tBY2NAM05FT033.mail.protection.outlook.com (10.152.100.170) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id\n\t15.20.1965.10 via Frontend Transport; Tue, 4 Jun 2019 18:55:01 +0000", "from dut1171.mv.qlogic.com (10.112.88.18) by\n\tCAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server\n\t(TLS) id 14.2.347.0; Tue, 4 Jun 2019 11:53:51 -0700", "from dut1171.mv.qlogic.com (localhost [127.0.0.1])\tby\n\tdut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x54Irv5Z028670;\n\tTue, 4 Jun 2019 11:53:57 -0700", "(from root@localhost)\tby dut1171.mv.qlogic.com\n\t(8.14.7/8.14.7/Submit) id x54IrvRx028669;\n\tTue, 4 Jun 2019 11:53:57 -0700" ], "Authentication-Results": "spf=fail (sender IP is 199.233.58.38)\n\tsmtp.mailfrom=marvell.com; dpdk.org; dkim=none (message not signed)\n\theader.d=none; dpdk.org;\n\tdmarc=fail action=none header.from=marvell.com; ", "Received-SPF": "Fail (protection.outlook.com: domain of marvell.com does not\n\tdesignate 199.233.58.38 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com;", "From": "Shahed Shaikh <shshaikh@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<rmody@marvell.com>, <ferruh.yigit@intel.com>,\n\t<GR-Everest-DPDK-Dev@marvell.com>, <stable@dpdk.org>", "Date": "Tue, 4 Jun 2019 11:53:49 -0700", "Message-ID": "<20190604185352.28629-2-shshaikh@marvell.com>", "X-Mailer": "git-send-email 2.12.0", "In-Reply-To": "<20190604185352.28629-1-shshaikh@marvell.com>", "References": "<20190604185352.28629-1-shshaikh@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-EOPAttributedMessage": "0", "X-Matching-Connectors": "132041481018636974;\n\t(abac79dc-c90b-41ba-8033-08d666125e47);\n\t(abac79dc-c90b-41ba-8033-08d666125e47)", "X-Forefront-Antispam-Report": "CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(346002)(376002)(39850400004)(2980300002)(1110001)(339900001)(199004)(189003)(316002)(42186006)(16586007)(36906005)(50466002)(54906003)(76176011)(48376002)(53936002)(336012)(2351001)(2906002)(105606002)(36756003)(450100002)(4326008)(498600001)(70586007)(1076003)(356004)(69596002)(8676002)(85426001)(86362001)(68736007)(47776003)(81156014)(8936002)(50226002)(476003)(80596001)(70206006)(126002)(6916009)(305945005)(51416003)(446003)(11346002)(26005)(2616005)(6666004)(87636003)(26826003)(81166006)(486006)(5660300002)(14444005)(76130400001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4433;\n\tH:CAEXCH02.caveonetworks.com; \n\tFPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; ", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "aded714a-a76a-4399-3cd7-08d6e91e261f", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(5600148)(711020)(4605104)(1401327)(2017052603328);\n\tSRVR:BN7PR07MB4433; ", "X-MS-TrafficTypeDiagnostic": "BN7PR07MB4433:", "X-Microsoft-Antispam-PRVS": "<BN7PR07MB4433570800FA8338EA7F623DD3150@BN7PR07MB4433.namprd07.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:5516;", "X-Forefront-PRVS": "0058ABBBC7", "X-Microsoft-Antispam-Message-Info": "DnqoqBpMnwyMxIHrhBE3RjpjjHYn75waTSfIe+uFNTg5uF4Jb9sYGUt5NdfyjqlPAjVfoZvXTcs0T15zL8UowVJZBG0ytke5Gv6MzORlkQ+pzBKmjvNFRpUDZPKMhueO7+J3QiyRvrwAsK2uDs3tnmZAz2EkARaHjZFbrmrwa+FVmU+P30sbe5oWfUDarxhXz7tQc/SuKo/2UmFMnd4VWSGnwY394CZu9uav6aPq+EFV4NQuZIwvHZgfowvzqWn3gtCCOmGhmMG9BLVo7Jv6fJcGct0BTj60jiljeC73dxhOspoCyCi5OgGWb+WPIe9xu1OeAF8tFduI49dZsUk3Rn/YC3G7ktGT6znVBwNllcdWmcI8qEpaPp/aqwRgL7wijAfKQVvCfOAt2TCDQDwuODNSOLV8YvQt70dFpyPS7d8=", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Jun 2019 18:55:01.4793\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "aded714a-a76a-4399-3cd7-08d6e91e261f", "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[199.233.58.38]; \n\tHelo=[CAEXCH02.caveonetworks.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN7PR07MB4433", "Subject": "[dpdk-dev] [PATCH 2/5] net/bnx2x: fix interrupt flood", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "PMD sets up and clears the slow path interrupt status block in dev_start\nand dev_stop flow and slow path interrupt status block DMA memory for\ndevice is allocated in dev_configure flow.\n\nThis situation creates a state where, after dev_stop is called, and if\nthere is a slow path interrupt from device, PMD sees the old value of\nstatus block consumer in dev_start flow, since DMA memory for status block\nbelongs to old configuration and dev_start will result in\nnew slow path interrupt status block configuration.\nAnd since PMD fails to ack new slow path interrupt with correct status\nblock consumer value, device continues to trigger interrupt causing an\ninterrupt flood.\n\nFix is to create and destroy status block DMA memory in dev_start and\ndev_stop flow instead of dev_configure and dev_close flow.\n\nFixes: 540a211084a7 (\"bnx2x: driver core\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shshaikh@marvell.com>\n---\n drivers/net/bnx2x/bnx2x.c | 10 ++++++++++\n drivers/net/bnx2x/bnx2x_ethdev.c | 10 ----------\n 2 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex 0698b1a8a..e9f05a73a 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -2401,6 +2401,9 @@ static void bnx2x_free_mem(struct bnx2x_softc *sc)\n \tecore_ilt_mem_op(sc, ILT_MEMOP_FREE);\n \n \tbnx2x_free_ilt_lines_mem(sc);\n+\n+\t/* free the host hardware/software hsi structures */\n+\tbnx2x_free_hsi_mem(sc);\n }\n \n static int bnx2x_alloc_mem(struct bnx2x_softc *sc)\n@@ -2451,6 +2454,13 @@ static int bnx2x_alloc_mem(struct bnx2x_softc *sc)\n \t\treturn -1;\n \t}\n \n+\t/* allocate the host hardware/software hsi structures */\n+\tif (bnx2x_alloc_hsi_mem(sc) != 0) {\n+\t\tPMD_DRV_LOG(ERR, sc, \"bnx2x_alloc_hsi_mem was failed\");\n+\t\tbnx2x_free_mem(sc);\n+\t\treturn -ENXIO;\n+\t}\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c\nindex 3063aea64..5dfd708ef 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.c\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.c\n@@ -207,13 +207,6 @@ bnx2x_dev_configure(struct rte_eth_dev *dev)\n \t\treturn -ENXIO;\n \t}\n \n-\t/* allocate the host hardware/software hsi structures */\n-\tif (bnx2x_alloc_hsi_mem(sc) != 0) {\n-\t\tPMD_DRV_LOG(ERR, sc, \"bnx2x_alloc_hsi_mem was failed\");\n-\t\tbnx2x_free_ilt_mem(sc);\n-\t\treturn -ENXIO;\n-\t}\n-\n \tbnx2x_dev_rxtx_init_dummy(dev);\n \treturn 0;\n }\n@@ -294,9 +287,6 @@ bnx2x_dev_close(struct rte_eth_dev *dev)\n \tbnx2x_dev_clear_queues(dev);\n \tmemset(&(dev->data->dev_link), 0 , sizeof(struct rte_eth_link));\n \n-\t/* free the host hardware/software hsi structures */\n-\tbnx2x_free_hsi_mem(sc);\n-\n \t/* free ilt */\n \tbnx2x_free_ilt_mem(sc);\n }\n", "prefixes": [ "2/5" ] }