Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53344,
    "url": "https://patches.dpdk.org/api/patches/53344/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1557386426-57149-1-git-send-email-wei.zhao1@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1557386426-57149-1-git-send-email-wei.zhao1@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1557386426-57149-1-git-send-email-wei.zhao1@intel.com",
    "date": "2019-05-09T07:20:26",
    "name": "app/testpmd: remove port stop check for macsec",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0ec34b18518b61991a2459ff5e04c8e4e9c8530c",
    "submitter": {
        "id": 495,
        "url": "https://patches.dpdk.org/api/people/495/?format=api",
        "name": "Zhao1, Wei",
        "email": "wei.zhao1@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1557386426-57149-1-git-send-email-wei.zhao1@intel.com/mbox/",
    "series": [
        {
            "id": 4612,
            "url": "https://patches.dpdk.org/api/series/4612/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4612",
            "date": "2019-05-09T07:20:26",
            "name": "app/testpmd: remove port stop check for macsec",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4612/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/53344/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/53344/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF0A64D27;\n\tThu,  9 May 2019 09:49:22 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 327292C2B;\n\tThu,  9 May 2019 09:49:21 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 May 2019 00:49:20 -0700",
            "from dpdk6.bj.intel.com ([172.16.182.192])\n\tby orsmga001.jf.intel.com with ESMTP; 09 May 2019 00:49:18 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "Wei Zhao <wei.zhao1@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org, yuan.peng@intel.com, ferruh.yigit@intel.com,\n\twenzhuo.lu@intel.com, Wei Zhao <wei.zhao1@intel.com>",
        "Date": "Thu,  9 May 2019 15:20:26 +0800",
        "Message-Id": "<1557386426-57149-1-git-send-email-wei.zhao1@intel.com>",
        "X-Mailer": "git-send-email 2.7.5",
        "Subject": "[dpdk-dev] [PATCH] app/testpmd: remove port stop check for macsec",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "There is no need to do such a check when set macsec for ixgbe,\nreconfig_device_queueand is also useless. If ew do not delete this\nunnessarycode, users have to sotp port before enable macsec, then\nrestart this port after make configuration. All these process is\nuseless. As this cmdline is a private API only use by ixgbe NIC,\nso remove it.\n\nFixes: 597f9fafe13b (\"app/testpmd: convert to new Tx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n app/test-pmd/cmdline.c | 5 -----\n 1 file changed, 5 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex c1042dd..b969745 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN))\n \t\treturn;\n-\tif (!port_is_stopped(port_id)) {\n-\t\tprintf(\"Please stop port %d first\\n\", port_id);\n-\t\treturn;\n-\t}\n \n \trte_eth_dev_info_get(port_id, &dev_info);\n \tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {\n@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(\n \tcase 0:\n \t\tports[port_id].dev_conf.txmode.offloads |=\n \t\t\t\t\t\tDEV_TX_OFFLOAD_MACSEC_INSERT;\n-\t\tcmd_reconfig_device_queue(port_id, 1, 1);\n \t\tbreak;\n \tcase -ENODEV:\n \t\tprintf(\"invalid port_id %d\\n\", port_id);\n",
    "prefixes": []
}