Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53052,
    "url": "https://patches.dpdk.org/api/patches/53052/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1556116430-22593-1-git-send-email-erik.g.carrillo@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1556116430-22593-1-git-send-email-erik.g.carrillo@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1556116430-22593-1-git-send-email-erik.g.carrillo@intel.com",
    "date": "2019-04-24T14:33:50",
    "name": "timer: fix pointer to local outside scope",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "3d65154f84a10f49ef31eead4d930981d97ad612",
    "submitter": {
        "id": 762,
        "url": "https://patches.dpdk.org/api/people/762/?format=api",
        "name": "Carrillo, Erik G",
        "email": "erik.g.carrillo@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1556116430-22593-1-git-send-email-erik.g.carrillo@intel.com/mbox/",
    "series": [
        {
            "id": 4449,
            "url": "https://patches.dpdk.org/api/series/4449/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=4449",
            "date": "2019-04-24T14:33:50",
            "name": "timer: fix pointer to local outside scope",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/4449/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/53052/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/53052/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2B3B41B4D5;\n\tWed, 24 Apr 2019 16:35:19 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 271101B40F;\n\tWed, 24 Apr 2019 16:35:17 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Apr 2019 07:35:16 -0700",
            "from txasoft-yocto.an.intel.com ([10.123.72.192])\n\tby fmsmga001.fm.intel.com with ESMTP; 24 Apr 2019 07:35:16 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,390,1549958400\"; d=\"scan'208\";a=\"167505381\"",
        "From": "Erik Gabriel Carrillo <erik.g.carrillo@intel.com>",
        "To": "john.mcnamara@intel.com",
        "Cc": "marko.kovacevic@intel.com,\n\tdev@dpdk.org,\n\tstable@dpdk.org",
        "Date": "Wed, 24 Apr 2019 09:33:50 -0500",
        "Message-Id": "<1556116430-22593-1-git-send-email-erik.g.carrillo@intel.com>",
        "X-Mailer": "git-send-email 1.7.10",
        "Subject": "[dpdk-dev] [PATCH] timer: fix pointer to local outside scope",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "A null array is allowed to be passed as one of the parameters to\nrte_timer_alt_manage() as a convenience.  When that happened, an\nanonymous array was created using compound literal syntax, and Coverity\ndetected that the object was out of scope in later uses of it. Create\nan object in the proper scope instead.\n\nCoverity issue: 337919\nFixes: c0749f7096c7 (\"timer: allow management in shared memory\")\nCc: stable@dpdk.org\n\nSigned-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>\n---\n lib/librte_timer/rte_timer.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c\nindex eb46009..d443b8c 100644\n--- a/lib/librte_timer/rte_timer.c\n+++ b/lib/librte_timer/rte_timer.c\n@@ -826,6 +826,7 @@ rte_timer_alt_manage(uint32_t timer_data_id,\n \t\t     int nb_poll_lcores,\n \t\t     rte_timer_alt_manage_cb_t f)\n {\n+\tunsigned int default_poll_lcores[] = {rte_lcore_id()};\n \tunion rte_timer_status status;\n \tstruct rte_timer *tim, *next_tim, **pprev;\n \tstruct rte_timer *run_first_tims[RTE_MAX_LCORE];\n@@ -847,8 +848,8 @@ rte_timer_alt_manage(uint32_t timer_data_id,\n \t__TIMER_STAT_ADD(data->priv_timer, manage, 1);\n \n \tif (poll_lcores == NULL) {\n-\t\tpoll_lcores = (unsigned int []){rte_lcore_id()};\n-\t\tnb_poll_lcores = 1;\n+\t\tpoll_lcores = default_poll_lcores;\n+\t\tnb_poll_lcores = RTE_DIM(default_poll_lcores);\n \t}\n \n \tfor (i = 0; i < nb_poll_lcores; i++) {\n",
    "prefixes": []
}