Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/528/?format=api
{ "id": 528, "url": "https://patches.dpdk.org/api/patches/528/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1411658678-658-4-git-send-email-balazs.nemeth@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1411658678-658-4-git-send-email-balazs.nemeth@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1411658678-658-4-git-send-email-balazs.nemeth@intel.com", "date": "2014-09-25T15:24:37", "name": "[dpdk-dev,3/4] table: fix incorrect t->data_size_shl initialization", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6741f90e5cef038d430c52def8d3ba08936d0d82", "submitter": { "id": 67, "url": "https://patches.dpdk.org/api/people/67/?format=api", "name": "Balazs Nemeth", "email": "balazs.nemeth@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1411658678-658-4-git-send-email-balazs.nemeth@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/528/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/528/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3AAF9B451;\n\tThu, 25 Sep 2014 17:17:44 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 24EE5B43B\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 17:17:38 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 25 Sep 2014 08:23:21 -0700", "from bnemeth-mobl.ger.corp.intel.com (HELO bn-ivy12.localdomain)\n\t([172.22.195.65])\n\tby FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2014 08:17:20 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"391549809\"", "From": "Balazs Nemeth <balazs.nemeth@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 25 Sep 2014 15:24:37 +0000", "Message-Id": "<1411658678-658-4-git-send-email-balazs.nemeth@intel.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1411658678-658-1-git-send-email-balazs.nemeth@intel.com>", "References": "<1411658678-658-1-git-send-email-balazs.nemeth@intel.com>", "Cc": "Balazs Nemeth <balazs.nemeth@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/4] table: fix incorrect t->data_size_shl\n\tinitialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During initialization of rte_hash_table_ext and rte_hash_table_lru,\nt->data_size_shl is calculated. This member contains the number of\nbits to shift left during calculation of the location of entries in\nthe hash table. To determine the number of bits to shift left, the\nsize of the entry (as provided to the rte_table_hash_ext_create and\nrte_table_hash_lru_create) has to be used instead of the size of the\nkey.\n\nAcked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Balazs Nemeth <balazs.nemeth@intel.com>\n---\n lib/librte_table/rte_table_hash_ext.c | 2 +-\n lib/librte_table/rte_table_hash_lru.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.1.0\nIntel Corporation NV/SA\nKings Square, Veldkant 31\n2550 Kontich\nRPM (Bruxelles) 0415.497.718. \nCitibank, Brussels, account 570/1031255/09\n\nThis e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.", "diff": "diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c\nindex 17c16cd..fb3e6d2 100644\n--- a/lib/librte_table/rte_table_hash_ext.c\n+++ b/lib/librte_table/rte_table_hash_ext.c\n@@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)\n \t/* Internal */\n \tt->bucket_mask = t->n_buckets - 1;\n \tt->key_size_shl = __builtin_ctzl(p->key_size);\n-\tt->data_size_shl = __builtin_ctzl(p->key_size);\n+\tt->data_size_shl = __builtin_ctzl(entry_size);\n\n \t/* Tables */\n \ttable_meta_offset = 0;\ndiff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c\nindex d1a4984..bf92e81 100644\n--- a/lib/librte_table/rte_table_hash_lru.c\n+++ b/lib/librte_table/rte_table_hash_lru.c\n@@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)\n \t/* Internal */\n \tt->bucket_mask = t->n_buckets - 1;\n \tt->key_size_shl = __builtin_ctzl(p->key_size);\n-\tt->data_size_shl = __builtin_ctzl(p->key_size);\n+\tt->data_size_shl = __builtin_ctzl(entry_size);\n\n \t/* Tables */\n \ttable_meta_offset = 0;\n", "prefixes": [ "dpdk-dev", "3/4" ] }