Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5175,
    "url": "https://patches.dpdk.org/api/patches/5175/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1433481718-24253-20-git-send-email-wenzhuo.lu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1433481718-24253-20-git-send-email-wenzhuo.lu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1433481718-24253-20-git-send-email-wenzhuo.lu@intel.com",
    "date": "2015-06-05T05:21:51",
    "name": "[dpdk-dev,19/26] ixgbe/base: change return value for ixgbe_setup_internal_phy_t_x550em",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "587b289898d4e9c2d81ec602922d22e07d8e6c3e",
    "submitter": {
        "id": 258,
        "url": "https://patches.dpdk.org/api/people/258/?format=api",
        "name": "Wenzhuo Lu",
        "email": "wenzhuo.lu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1433481718-24253-20-git-send-email-wenzhuo.lu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/5175/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/5175/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AF37FC3BC;\n\tFri,  5 Jun 2015 07:22:50 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 24B3CC3BC\n\tfor <dev@dpdk.org>; Fri,  5 Jun 2015 07:22:48 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 04 Jun 2015 22:22:48 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 04 Jun 2015 22:22:48 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t555MjYO032685;\n\tFri, 5 Jun 2015 13:22:45 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t555MhcL024424; Fri, 5 Jun 2015 13:22:45 +0800",
            "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t555MhQM024420; \n\tFri, 5 Jun 2015 13:22:43 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.13,556,1427785200\"; d=\"scan'208\";a=\"721159578\"",
        "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri,  5 Jun 2015 13:21:51 +0800",
        "Message-Id": "<1433481718-24253-20-git-send-email-wenzhuo.lu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1433481718-24253-1-git-send-email-wenzhuo.lu@intel.com>",
        "References": "<1433481718-24253-1-git-send-email-wenzhuo.lu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 19/26] ixgbe/base: change return value for\n\tixgbe_setup_internal_phy_t_x550em",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch changes the return value for ixgbe_setup_internal_phy_t_x550em\nwhen link is down to IXGBE_SUCCESS.\nThe driver will call ixgbe_setup_internal_phy_t_x550em when a link status\nchange is reported. The links status change can occur on link up or link\ndown, and if the link status change is for link down then there is no iXFI\nsetup necessary and no error condition needs to be returned.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_x550.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex 146b2d4..87942bb 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -1578,9 +1578,9 @@ s32 ixgbe_setup_internal_phy_x550em(struct ixgbe_hw *hw)\n \tif (status != IXGBE_SUCCESS)\n \t\treturn status;\n \n-\t/* If link is not up return an error indicating treat link as down */\n+\t/* If link is not up, then there is no setup necessary so return  */\n \tif (!(autoneg_status & IXGBE_MDIO_AUTO_NEG_LINK_STATUS))\n-\t\treturn IXGBE_ERR_INVALID_LINK_SETTINGS;\n+\t\treturn IXGBE_SUCCESS;\n \n \tstatus = hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_VENDOR_STAT,\n \t\t\t\t      IXGBE_MDIO_AUTO_NEG_DEV_TYPE,\n",
    "prefixes": [
        "dpdk-dev",
        "19/26"
    ]
}