Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50280/?format=api
{ "id": 50280, "url": "https://patches.dpdk.org/api/patches/50280/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1550026132-9244-1-git-send-email-wangyunjian@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1550026132-9244-1-git-send-email-wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1550026132-9244-1-git-send-email-wangyunjian@huawei.com", "date": "2019-02-13T02:48:52", "name": "net/ixgbe: fix crash when on remove", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d30c94ecf4854ffb6f4c6dbc426fb78cd413287d", "submitter": { "id": 551, "url": "https://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1550026132-9244-1-git-send-email-wangyunjian@huawei.com/mbox/", "series": [ { "id": 3431, "url": "https://patches.dpdk.org/api/series/3431/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3431", "date": "2019-02-13T02:48:52", "name": "net/ixgbe: fix crash when on remove", "version": 1, "mbox": "https://patches.dpdk.org/series/3431/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50280/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50280/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8EEE17CE2;\n\tWed, 13 Feb 2019 03:49:40 +0100 (CET)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n\tby dpdk.org (Postfix) with ESMTP id 14DA869D4;\n\tWed, 13 Feb 2019 03:49:38 +0100 (CET)", "from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60])\n\tby Forcepoint Email with ESMTP id C2C5B7509D2B4B8B3F8C;\n\tWed, 13 Feb 2019 10:49:36 +0800 (CST)", "from localhost (10.177.24.66) by DGGEMS413-HUB.china.huawei.com\n\t(10.3.19.213) with Microsoft SMTP Server id 14.3.408.0;\n\tWed, 13 Feb 2019 10:49:29 +0800" ], "From": "wangyunjian <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<qi.z.zhang@intel.com>, <xudingke@huawei.com>, Yunjian Wang\n\t<wangyunjian@huawei.com>, <stable@dpdk.org>", "Date": "Wed, 13 Feb 2019 10:48:52 +0800", "Message-ID": "<1550026132-9244-1-git-send-email-wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.177.24.66]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH] net/ixgbe: fix crash when on remove", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yunjian Wang <wangyunjian@huawei.com>\n\nThe nic's interrupt source has some active handler, when the\nport remove. We should cancel the delay handler before remove\ndev to prevent executing the delay handler.\n\nCall Trace:\n #0 ixgbe_disable_intr (hw=0x0, hw=0x0)\n at /usr/src/debug/dpdk-18.11/drivers/net/ixgbe/ixgbe_ethdev.c:852\n #1 ixgbe_dev_interrupt_delayed_handler (param=0xadb9c0\n <rte_eth_devices@@DPDK_2.2+33024>)\n at /usr/src/debug/dpdk-18.11/drivers/net/ixgbe/ixgbe_ethdev.c:4386\n #2 0x00007f05782147af in eal_alarm_callback (arg=<optimized out>)\n at /usr/src/debug/dpdk-18.11/lib/librte_eal/linuxapp/eal/\n eal_alarm.c:90\n #3 0x00007f057821320a in eal_intr_process_interrupts (nfds=1,\n events=0x7f056cbf3e88) at /usr/src/debug/dpdk-18.11/lib/\n librte_eal/linuxapp/eal/eal_interrupts.c:838\n #4 eal_intr_handle_interrupts (totalfds=<optimized out>, pfd=18)\n at /usr/src/debug/dpdk-18.11/lib/librte_eal/linuxapp/eal/\n eal_interrupts.c:885\n #5 eal_intr_thread_main (arg=<optimized out>)\n at /usr/src/debug/dpdk-18.11/lib/librte_eal/linuxapp/eal/\n eal_interrupts.c:965\n #6 0x00007f05708a0e45 in start_thread () from /usr/lib64/libpthread.so.0\n #7 0x00007f056eb4ab5d in clone () from /usr/lib64/libc.so.6\n\nFixes: 2866c5f1b87e (\"ixgbe: support port hotplug\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 7493110..e9533e5 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1336,6 +1336,9 @@ struct rte_ixgbe_xstats_name_off {\n \t\trte_delay_ms(100);\n \t} while (retries++ < (10 + IXGBE_LINK_UP_TIME));\n \n+\t/* cancel the delay handler before remove dev */\n+\trte_eal_alarm_cancel(ixgbe_dev_interrupt_delayed_handler, eth_dev);\n+\n \t/* uninitialize PF if max_vfs not zero */\n \tixgbe_pf_host_uninit(eth_dev);\n \n", "prefixes": [] }