Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5024/?format=api
{ "id": 5024, "url": "https://patches.dpdk.org/api/patches/5024/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1433144045-30847-19-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1433144045-30847-19-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1433144045-30847-19-git-send-email-helin.zhang@intel.com", "date": "2015-06-01T07:34:05", "name": "[dpdk-dev,v6,18/18] mbuf: remove old packet type bit masks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4448e5891286eac5da288964dd87f2ad9cb04393", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1433144045-30847-19-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/5024/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/5024/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0D2DDC36C;\n\tMon, 1 Jun 2015 09:35:05 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 1E73BC38E\n\tfor <dev@dpdk.org>; Mon, 1 Jun 2015 09:35:02 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP; 01 Jun 2015 00:35:02 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 01 Jun 2015 00:35:01 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t517YxCF007909;\n\tMon, 1 Jun 2015 15:34:59 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t517YtcT031009; Mon, 1 Jun 2015 15:34:57 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t517YtVf031005; \n\tMon, 1 Jun 2015 15:34:55 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.13,531,1427785200\"; d=\"scan'208\";a=\"703143110\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 1 Jun 2015 15:34:05 +0800", "Message-Id": "<1433144045-30847-19-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1433144045-30847-1-git-send-email-helin.zhang@intel.com>", "References": "<1432284264-17376-1-git-send-email-helin.zhang@intel.com>\n\t<1433144045-30847-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 18/18] mbuf: remove old packet type bit masks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As unified packet types are used instead, those old bit masks and\nthe relevant macros for packet type indication need to be removed.\nTo avoid breaking ABI compatibility, all the changes would be\nenabled by RTE_UNIFIED_PKT_TYPE, which is disabled by default.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.c | 4 ++++\n lib/librte_mbuf/rte_mbuf.h | 4 ++++\n 2 files changed, 8 insertions(+)\n\nv2 changes:\n* Used redefined packet types and enlarged packet_type field in mbuf.\n* Redefined the bit masks for packet RX offload flags.\n\nv5 changes:\n* Rolled back the bit masks of RX flags, for ABI compatibility.\n\nv6 changes:\n* Disabled the code changes for unified packet type by default, to\n avoid breaking ABI compatibility.", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex f506517..0b3a4fc 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -251,14 +251,18 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask)\n \t/* case PKT_RX_HBUF_OVERFLOW: return \"PKT_RX_HBUF_OVERFLOW\"; */\n \t/* case PKT_RX_RECIP_ERR: return \"PKT_RX_RECIP_ERR\"; */\n \t/* case PKT_RX_MAC_ERR: return \"PKT_RX_MAC_ERR\"; */\n+#ifndef RTE_UNIFIED_PKT_TYPE\n \tcase PKT_RX_IPV4_HDR: return \"PKT_RX_IPV4_HDR\";\n \tcase PKT_RX_IPV4_HDR_EXT: return \"PKT_RX_IPV4_HDR_EXT\";\n \tcase PKT_RX_IPV6_HDR: return \"PKT_RX_IPV6_HDR\";\n \tcase PKT_RX_IPV6_HDR_EXT: return \"PKT_RX_IPV6_HDR_EXT\";\n+#endif /* RTE_UNIFIED_PKT_TYPE */\n \tcase PKT_RX_IEEE1588_PTP: return \"PKT_RX_IEEE1588_PTP\";\n \tcase PKT_RX_IEEE1588_TMST: return \"PKT_RX_IEEE1588_TMST\";\n+#ifndef RTE_UNIFIED_PKT_TYPE\n \tcase PKT_RX_TUNNEL_IPV4_HDR: return \"PKT_RX_TUNNEL_IPV4_HDR\";\n \tcase PKT_RX_TUNNEL_IPV6_HDR: return \"PKT_RX_TUNNEL_IPV6_HDR\";\n+#endif /* RTE_UNIFIED_PKT_TYPE */\n \tdefault: return NULL;\n \t}\n }\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 94e51cd..d82fc8e 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -91,14 +91,18 @@ extern \"C\" {\n #define PKT_RX_HBUF_OVERFLOW (0ULL << 0) /**< Header buffer overflow. */\n #define PKT_RX_RECIP_ERR (0ULL << 0) /**< Hardware processing error. */\n #define PKT_RX_MAC_ERR (0ULL << 0) /**< MAC error. */\n+#ifndef RTE_UNIFIED_PKT_TYPE\n #define PKT_RX_IPV4_HDR (1ULL << 5) /**< RX packet with IPv4 header. */\n #define PKT_RX_IPV4_HDR_EXT (1ULL << 6) /**< RX packet with extended IPv4 header. */\n #define PKT_RX_IPV6_HDR (1ULL << 7) /**< RX packet with IPv6 header. */\n #define PKT_RX_IPV6_HDR_EXT (1ULL << 8) /**< RX packet with extended IPv6 header. */\n+#endif /* RTE_UNIFIED_PKT_TYPE */\n #define PKT_RX_IEEE1588_PTP (1ULL << 9) /**< RX IEEE1588 L2 Ethernet PT Packet. */\n #define PKT_RX_IEEE1588_TMST (1ULL << 10) /**< RX IEEE1588 L2/L4 timestamped packet.*/\n+#ifndef RTE_UNIFIED_PKT_TYPE\n #define PKT_RX_TUNNEL_IPV4_HDR (1ULL << 11) /**< RX tunnel packet with IPv4 header.*/\n #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with IPv6 header. */\n+#endif /* RTE_UNIFIED_PKT_TYPE */\n #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR match. */\n #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported if FDIR match. */\n /* add new RX flags here */\n", "prefixes": [ "dpdk-dev", "v6", "18/18" ] }