Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45532/?format=api
{ "id": 45532, "url": "https://patches.dpdk.org/api/patches/45532/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1538058330-34990-1-git-send-email-dekelp@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538058330-34990-1-git-send-email-dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538058330-34990-1-git-send-email-dekelp@mellanox.com", "date": "2018-09-27T14:25:30", "name": "net/mlx5: allow flow rule with attribute egress", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9ad8689bddfeb92b01b1229c8562d595d054ed93", "submitter": { "id": 1082, "url": "https://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 6624, "url": "https://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1538058330-34990-1-git-send-email-dekelp@mellanox.com/mbox/", "series": [ { "id": 1554, "url": "https://patches.dpdk.org/api/series/1554/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1554", "date": "2018-09-27T14:25:30", "name": "net/mlx5: allow flow rule with attribute egress", "version": 1, "mbox": "https://patches.dpdk.org/series/1554/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45532/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45532/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 65D1A1B448;\n\tThu, 27 Sep 2018 16:26:58 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 468411B448\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 16:26:57 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 27 Sep 2018 16:31:26 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w8REQqP7016033;\n\tThu, 27 Sep 2018 17:26:52 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "dev@dpdk.org, shahafs@mellanox.com, yskoh@mellanox.com", "Cc": "orika@mellanox.com", "Date": "Thu, 27 Sep 2018 17:25:30 +0300", "Message-Id": "<1538058330-34990-1-git-send-email-dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: allow flow rule with attribute egress", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch complements [1], adding to MLX5 PMD the option to set\nflow rule for egress traffic.\n\n[1] \"net/mlx5: support metadata as flow rule criteria\"\n http://mails.dpdk.org/archives/dev/2018-September/113275.html\n\t\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 54 ++++++++++++++++++++++++++++++++++++++\n drivers/net/mlx5/mlx5_flow.h | 6 +++++\n drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++-------\n drivers/net/mlx5/mlx5_flow_verbs.c | 7 ++++-\n 4 files changed, 80 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 9581691..79a06df 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -644,6 +644,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n *\n * @param[in] action_flags\n * Bit-fields that holds the actions detected until now.\n+ * @param[in] attr\n+ * Attributes of flow that includes this action.\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -652,6 +654,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n */\n int\n mlx5_flow_validate_action_flag(uint64_t action_flags,\n+\t\t\t const struct rte_flow_attr *attr,\n \t\t\t struct rte_flow_error *error)\n {\n \n@@ -668,6 +671,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n \t\t\t\t\t \"can't have 2 flag\"\n \t\t\t\t\t \" actions in same flow\");\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"flag action not supported for \"\n+\t\t\t\t\t \"egress\");\n \treturn 0;\n }\n \n@@ -678,6 +687,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n * Pointer to the queue action.\n * @param[in] action_flags\n * Bit-fields that holds the actions detected until now.\n+ * @param[in] attr\n+ * Attributes of flow that includes this action.\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -687,6 +698,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n int\n mlx5_flow_validate_action_mark(const struct rte_flow_action *action,\n \t\t\t uint64_t action_flags,\n+\t\t\t const struct rte_flow_attr *attr,\n \t\t\t struct rte_flow_error *error)\n {\n \tconst struct rte_flow_action_mark *mark = action->conf;\n@@ -715,6 +727,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n \t\t\t\t\t \"can't have 2 flag actions in same\"\n \t\t\t\t\t \" flow\");\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"mark action not supported for \"\n+\t\t\t\t\t \"egress\");\n \treturn 0;\n }\n \n@@ -723,6 +741,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n *\n * @param[in] action_flags\n * Bit-fields that holds the actions detected until now.\n+ * @param[in] attr\n+ * Attributes of flow that includes this action.\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -731,6 +751,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n */\n int\n mlx5_flow_validate_action_drop(uint64_t action_flags,\n+\t\t\t const struct rte_flow_attr *attr,\n \t\t\t struct rte_flow_error *error)\n {\n \tif (action_flags & MLX5_ACTION_FLAG)\n@@ -747,6 +768,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n \t\t\t\t\t \"can't have 2 fate actions in\"\n \t\t\t\t\t \" same flow\");\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"drop action not supported for \"\n+\t\t\t\t\t \"egress\");\n \treturn 0;\n }\n \n@@ -759,6 +786,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n * Bit-fields that holds the actions detected until now.\n * @param[in] dev\n * Pointer to the Ethernet device structure.\n+ * @param[in] attr\n+ * Attributes of flow that includes this action.\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -769,6 +798,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n mlx5_flow_validate_action_queue(const struct rte_flow_action *action,\n \t\t\t\tuint64_t action_flags,\n \t\t\t\tstruct rte_eth_dev *dev,\n+\t\t\t\tconst struct rte_flow_attr *attr,\n \t\t\t\tstruct rte_flow_error *error)\n {\n \tstruct priv *priv = dev->data->dev_private;\n@@ -790,6 +820,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n \t\t\t\t\t &queue->index,\n \t\t\t\t\t \"queue is not configured\");\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"queue action not supported for \"\n+\t\t\t\t\t \"egress\");\n \treturn 0;\n }\n \n@@ -802,6 +838,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n * Bit-fields that holds the actions detected until now.\n * @param[in] dev\n * Pointer to the Ethernet device structure.\n+ * @param[in] attr\n+ * Attributes of flow that includes this action.\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -812,6 +850,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n mlx5_flow_validate_action_rss(const struct rte_flow_action *action,\n \t\t\t uint64_t action_flags,\n \t\t\t struct rte_eth_dev *dev,\n+\t\t\t const struct rte_flow_attr *attr,\n \t\t\t struct rte_flow_error *error)\n {\n \tstruct priv *priv = dev->data->dev_private;\n@@ -866,6 +905,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n \t\t\t\t &rss->queue[i], \"queue is not configured\");\n \t}\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"rss action not supported for \"\n+\t\t\t\t\t \"egress\");\n \treturn 0;\n }\n \n@@ -874,6 +919,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n *\n * @param[in] dev\n * Pointer to the Ethernet device structure.\n+ * @param[in] attr\n+ * Attributes of flow that includes this action.\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -882,6 +929,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n */\n int\n mlx5_flow_validate_action_count(struct rte_eth_dev *dev,\n+\t\t\t\tconst struct rte_flow_attr *attr,\n \t\t\t\tstruct rte_flow_error *error)\n {\n \tstruct priv *priv = dev->data->dev_private;\n@@ -890,6 +938,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n \t\t\t\t\t \"flow counters are not supported.\");\n+\tif (attr->egress)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"count action not supported for \"\n+\t\t\t\t\t \"egress\");\n \treturn 0;\n }\n \ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex d91ae17..a353d07 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -283,21 +283,27 @@ uint64_t mlx5_flow_hashfields_adjust(struct mlx5_flow *dev_flow, int tunnel,\n uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t uint32_t subpriority);\n int mlx5_flow_validate_action_count(struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_attr *attr,\n \t\t\t\t struct rte_flow_error *error);\n int mlx5_flow_validate_action_drop(uint64_t action_flags,\n+\t\t\t\t const struct rte_flow_attr *attr,\n \t\t\t\t struct rte_flow_error *error);\n int mlx5_flow_validate_action_flag(uint64_t action_flags,\n+\t\t\t\t const struct rte_flow_attr *attr,\n \t\t\t\t struct rte_flow_error *error);\n int mlx5_flow_validate_action_mark(const struct rte_flow_action *action,\n \t\t\t\t uint64_t action_flags,\n+\t\t\t\t const struct rte_flow_attr *attr,\n \t\t\t\t struct rte_flow_error *error);\n int mlx5_flow_validate_action_queue(const struct rte_flow_action *action,\n \t\t\t\t uint64_t action_flags,\n \t\t\t\t struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_attr *attr,\n \t\t\t\t struct rte_flow_error *error);\n int mlx5_flow_validate_action_rss(const struct rte_flow_action *action,\n \t\t\t\t uint64_t action_flags,\n \t\t\t\t struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_attr *attr,\n \t\t\t\t struct rte_flow_error *error);\n int mlx5_flow_validate_attributes(struct rte_eth_dev *dev,\n \t\t\t\t const struct rte_flow_attr *attributes,\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 2439f5e..1f3fcb8 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -117,21 +117,17 @@\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"priority out of range\");\n-\tif (attributes->egress)\n-\t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n-\t\t\t\t\t NULL,\n-\t\t\t\t\t \"egress is not supported\");\n \tif (attributes->transfer)\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"transfer is not supported\");\n-\tif (!attributes->ingress)\n+\tif (!(attributes->egress ^ attributes->ingress))\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR,\n \t\t\t\t\t NULL,\n-\t\t\t\t\t \"ingress attribute is mandatory\");\n+\t\t\t\t\t \"must specify exactly one of \"\n+\t\t\t\t\t \"ingress or egress\");\n \treturn 0;\n }\n \n@@ -288,6 +284,7 @@\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_FLAG:\n \t\t\tret = mlx5_flow_validate_action_flag(action_flags,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -297,6 +294,7 @@\n \t\tcase RTE_FLOW_ACTION_TYPE_MARK:\n \t\t\tret = mlx5_flow_validate_action_mark(actions,\n \t\t\t\t\t\t\t action_flags,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -305,6 +303,7 @@\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_DROP:\n \t\t\tret = mlx5_flow_validate_action_drop(action_flags,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -314,6 +313,7 @@\n \t\tcase RTE_FLOW_ACTION_TYPE_QUEUE:\n \t\t\tret = mlx5_flow_validate_action_queue(actions,\n \t\t\t\t\t\t\t action_flags, dev,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -323,6 +323,7 @@\n \t\tcase RTE_FLOW_ACTION_TYPE_RSS:\n \t\t\tret = mlx5_flow_validate_action_rss(actions,\n \t\t\t\t\t\t\t action_flags, dev,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -330,7 +331,7 @@\n \t\t\t++actions_n;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_COUNT:\n-\t\t\tret = mlx5_flow_validate_action_count(dev, error);\n+\t\t\tret = mlx5_flow_validate_action_count(dev, attr, error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n \t\t\taction_flags |= MLX5_ACTION_COUNT;\n@@ -1080,6 +1081,7 @@\n \t\tqueue = action->conf;\n \t\tflow->rss.queue_num = 1;\n \t\t(*flow->queue)[0] = queue->index;\n+\t\tflow->actions |= MLX5_ACTION_QUEUE;\n \t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_RSS:\n \t\trss = action->conf;\n@@ -1091,6 +1093,7 @@\n \t\tflow->rss.types = rss->types;\n \t\tflow->rss.level = rss->level;\n \t\t/* Added to array only in apply since we need the QP */\n+\t\tflow->actions |= MLX5_ACTION_RSS;\n \t\tbreak;\n \tdefault:\n \t\tbreak;\n@@ -1301,7 +1304,8 @@\n \t\t\tdv->actions[n].type = MLX5DV_FLOW_ACTION_DEST_IBV_QP;\n \t\t\tdv->actions[n].qp = dv->hrxq->qp;\n \t\t\tn++;\n-\t\t} else {\n+\t\t} else if (flow->actions &\n+\t\t\t (MLX5_ACTION_QUEUE | MLX5_ACTION_RSS)) {\n \t\t\tstruct mlx5_hrxq *hrxq;\n \t\t\thrxq = mlx5_hrxq_get(dev, flow->key,\n \t\t\t\t\t MLX5_RSS_HASH_KEY_LEN,\ndiff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c\nindex 05ab5fd..b1aa704 100644\n--- a/drivers/net/mlx5/mlx5_flow_verbs.c\n+++ b/drivers/net/mlx5/mlx5_flow_verbs.c\n@@ -1112,6 +1112,7 @@\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_FLAG:\n \t\t\tret = mlx5_flow_validate_action_flag(action_flags,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -1120,6 +1121,7 @@\n \t\tcase RTE_FLOW_ACTION_TYPE_MARK:\n \t\t\tret = mlx5_flow_validate_action_mark(actions,\n \t\t\t\t\t\t\t action_flags,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -1127,6 +1129,7 @@\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_DROP:\n \t\t\tret = mlx5_flow_validate_action_drop(action_flags,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -1135,6 +1138,7 @@\n \t\tcase RTE_FLOW_ACTION_TYPE_QUEUE:\n \t\t\tret = mlx5_flow_validate_action_queue(actions,\n \t\t\t\t\t\t\t action_flags, dev,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -1143,13 +1147,14 @@\n \t\tcase RTE_FLOW_ACTION_TYPE_RSS:\n \t\t\tret = mlx5_flow_validate_action_rss(actions,\n \t\t\t\t\t\t\t action_flags, dev,\n+\t\t\t\t\t\t\t attr,\n \t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n \t\t\taction_flags |= MLX5_ACTION_RSS;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_COUNT:\n-\t\t\tret = mlx5_flow_validate_action_count(dev, error);\n+\t\t\tret = mlx5_flow_validate_action_count(dev, attr, error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n \t\t\taction_flags |= MLX5_ACTION_COUNT;\n", "prefixes": [] }