Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45147/?format=api
{ "id": 45147, "url": "https://patches.dpdk.org/api/patches/45147/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180921165425.18168-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180921165425.18168-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180921165425.18168-1-stephen@networkplumber.org", "date": "2018-09-21T16:54:25", "name": "netvsc: support multicast/promiscuous settings on VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e5d8d2151e6b191c1d8b5a49e33a2531c4bafe7e", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180921165425.18168-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 1448, "url": "https://patches.dpdk.org/api/series/1448/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1448", "date": "2018-09-21T16:54:25", "name": "netvsc: support multicast/promiscuous settings on VF", "version": 1, "mbox": "https://patches.dpdk.org/series/1448/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45147/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/45147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3C4D61B126;\n\tFri, 21 Sep 2018 18:54:37 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 5246C1B118\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 18:54:35 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id r77-v6so1191421pgr.5\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 09:54:35 -0700 (PDT)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tm21-v6sm48315566pgd.6.2018.09.21.09.54.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 21 Sep 2018 09:54:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=JthBQUMYg/iICmubnvoocs3guqjtTJFqLwpIKCXN7cw=;\n\tb=lBeo5a6tRG+nAq7ksEqfRSFv7iaEE5ZIrJJh4gayH8Ogve8SzFqGlQ035vORFten93\n\tr62RgLYDOlxKRhpT/Ldck3Obf2IUZFjMm//ZyrCRs2rQp+Wxs1R6h2RYvorJ69Y10P0b\n\thmSzfY/UeuXPx06t6vZk1rh+dkwvMCxmMfvvPyQSjOSI5Uu0f0g/81/jW+OzJ+i5o5hY\n\t6vzJ+qyOSwODwIyKXBhSYZMNnOc0CKwbKVef9LUOA0Z990XWcXJW+HskgtGn8fdQrMQR\n\tKDKjwXQXtoVizzL+4sXEWXscTM5iIMcX2uCCgD/RG/O2y1nHIf0HegfQfyXnh01CZAk0\n\tAJTA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=JthBQUMYg/iICmubnvoocs3guqjtTJFqLwpIKCXN7cw=;\n\tb=s/U9r6wNHd2X3kEMBXz+eMgOwlRkXG6vkDBP9mCEmY9co2G//MuB6S5ryFaOf44Q8a\n\tobziOpKf1OPpRgzcUCeEq084DjEmvNHCdL2OwoOxFA+1lpWlQZHznWe0+IAIq03HYiC/\n\tGtFkFY+vTk6TkvchCAXdGeoFEkzlbQbxHvjsjcv5PoBUr4R4Mure0NSBGaWa1cVRdk3f\n\tV7cpYrICc4YSca9RiXzeL8lBvIDXelQpgebyBg1/dx6H9UikaG2Q7pFmsUXiSXfYCdGC\n\t1UKMByfV7+i+jJ37XAMXbKkud1Hl5GuUdoZopnDiqrOJstl5QaSFSeoy3M4GaZu8wRFH\n\tTQPQ==", "X-Gm-Message-State": "APzg51ArsARzS2k9xCjvOJ6c4C6U2GkDYoA6FMDw5j4u/wRl04jXN81B\n\to3ZlehopvuzOvQ4b0h9Kr9hf5QQLq84=", "X-Google-Smtp-Source": "ANB0VdYcdoH7Hq94iNEShqrJg3AYk+cD13C+VRWv32ELUMOLPrRwMmI6J34IqoD1m6MRMZBHWtOe2g==", "X-Received": "by 2002:a62:59d5:: with SMTP id\n\tk82-v6mr46928502pfj.143.1537548874097; \n\tFri, 21 Sep 2018 09:54:34 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Fri, 21 Sep 2018 09:54:25 -0700", "Message-Id": "<20180921165425.18168-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.18.0", "Subject": "[dpdk-dev] [PATCH] netvsc: support multicast/promiscuous settings\n\ton VF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Provide API's to enable allmulticast and promiscuous in Netvsc PMD\nwith VF. This keeps the VF and PV path in sync.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\nPatch against dpdk-net-next\n\n drivers/net/netvsc/hn_ethdev.c | 14 +++++++++++++\n drivers/net/netvsc/hn_var.h | 9 +++++++++\n drivers/net/netvsc/hn_vf.c | 37 ++++++++++++++++++++++++++++++++++\n 3 files changed, 60 insertions(+)", "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex b67cce1ba8f5..3092066ada36 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -255,6 +255,7 @@ hn_dev_promiscuous_enable(struct rte_eth_dev *dev)\n \tstruct hn_data *hv = dev->data->dev_private;\n \n \thn_rndis_set_rxfilter(hv, NDIS_PACKET_TYPE_PROMISCUOUS);\n+\thn_vf_promiscuous_enable(dev);\n }\n \n static void\n@@ -267,6 +268,7 @@ hn_dev_promiscuous_disable(struct rte_eth_dev *dev)\n \tif (dev->data->all_multicast)\n \t\tfilter |= NDIS_PACKET_TYPE_ALL_MULTICAST;\n \thn_rndis_set_rxfilter(hv, filter);\n+\thn_vf_promiscuous_disable(dev);\n }\n \n static void\n@@ -277,6 +279,7 @@ hn_dev_allmulticast_enable(struct rte_eth_dev *dev)\n \thn_rndis_set_rxfilter(hv, NDIS_PACKET_TYPE_DIRECTED |\n \t\t\t NDIS_PACKET_TYPE_ALL_MULTICAST |\n \t\t\tNDIS_PACKET_TYPE_BROADCAST);\n+\thn_vf_allmulticast_enable(dev);\n }\n \n static void\n@@ -286,6 +289,16 @@ hn_dev_allmulticast_disable(struct rte_eth_dev *dev)\n \n \thn_rndis_set_rxfilter(hv, NDIS_PACKET_TYPE_DIRECTED |\n \t\t\t NDIS_PACKET_TYPE_BROADCAST);\n+\thn_vf_allmulticast_disable(dev);\n+}\n+\n+static int\n+hn_dev_mc_addr_list(struct rte_eth_dev *dev,\n+\t\t struct ether_addr *mc_addr_set,\n+\t\t uint32_t nb_mc_addr)\n+{\n+\t/* No filtering on the synthetic path, but can do it on VF */\n+\treturn hn_vf_mc_addr_list(dev, mc_addr_set, nb_mc_addr);\n }\n \n /* Setup shared rx/tx queue data */\n@@ -640,6 +653,7 @@ static const struct eth_dev_ops hn_eth_dev_ops = {\n \t.promiscuous_disable = hn_dev_promiscuous_disable,\n \t.allmulticast_enable = hn_dev_allmulticast_enable,\n \t.allmulticast_disable = hn_dev_allmulticast_disable,\n+\t.set_mc_addr_list\t= hn_dev_mc_addr_list,\n \t.tx_queue_setup\t\t= hn_dev_tx_queue_setup,\n \t.tx_queue_release\t= hn_dev_tx_queue_release,\n \t.tx_done_cleanup = hn_dev_tx_done_cleanup,\ndiff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h\nindex b8d9e5d5c470..e1072c7cfa55 100644\n--- a/drivers/net/netvsc/hn_var.h\n+++ b/drivers/net/netvsc/hn_var.h\n@@ -178,6 +178,15 @@ int\thn_vf_start(struct rte_eth_dev *dev);\n void\thn_vf_reset(struct rte_eth_dev *dev);\n void\thn_vf_stop(struct rte_eth_dev *dev);\n void\thn_vf_close(struct rte_eth_dev *dev);\n+\n+void\thn_vf_allmulticast_enable(struct rte_eth_dev *dev);\n+void\thn_vf_allmulticast_disable(struct rte_eth_dev *dev);\n+void\thn_vf_promiscuous_enable(struct rte_eth_dev *dev);\n+void\thn_vf_promiscuous_disable(struct rte_eth_dev *dev);\n+int\thn_vf_mc_addr_list(struct rte_eth_dev *dev,\n+\t\t\t struct ether_addr *mc_addr_set,\n+\t\t\t uint32_t nb_mc_addr);\n+\n int\thn_vf_link_update(struct rte_eth_dev *dev,\n \t\t\t int wait_to_complete);\n int\thn_vf_tx_queue_setup(struct rte_eth_dev *dev,\ndiff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c\nindex c68d180fd894..7a84ad8c9b8f 100644\n--- a/drivers/net/netvsc/hn_vf.c\n+++ b/drivers/net/netvsc/hn_vf.c\n@@ -373,6 +373,43 @@ void hn_vf_stats_reset(struct rte_eth_dev *dev)\n \tVF_ETHDEV_FUNC(dev, rte_eth_stats_reset);\n }\n \n+void hn_vf_allmulticast_enable(struct rte_eth_dev *dev)\n+{\n+\tVF_ETHDEV_FUNC(dev, rte_eth_allmulticast_enable);\n+}\n+\n+void hn_vf_allmulticast_disable(struct rte_eth_dev *dev)\n+{\n+\tVF_ETHDEV_FUNC(dev, rte_eth_allmulticast_disable);\n+}\n+\n+void hn_vf_promiscuous_enable(struct rte_eth_dev *dev)\n+{\n+\tVF_ETHDEV_FUNC(dev, rte_eth_promiscuous_enable);\n+}\n+\n+void hn_vf_promiscuous_disable(struct rte_eth_dev *dev)\n+{\n+\tVF_ETHDEV_FUNC(dev, rte_eth_promiscuous_disable);\n+}\n+\n+int hn_vf_mc_addr_list(struct rte_eth_dev *dev,\n+\t\t\tstruct ether_addr *mc_addr_set,\n+\t\t\tuint32_t nb_mc_addr)\n+{\n+\tstruct hn_data *hv = dev->data->dev_private;\n+\tstruct rte_eth_dev *vf_dev;\n+\tint ret = 0;\n+\n+\trte_spinlock_lock(&hv->vf_lock);\n+\tvf_dev = hv->vf_dev;\n+\tif (vf_dev)\n+\t\tret = rte_eth_dev_set_mc_addr_list(vf_dev->data->port_id,\n+\t\t\t\t\t\t mc_addr_set, nb_mc_addr);\n+\trte_spinlock_unlock(&hv->vf_lock);\n+\treturn ret;\n+}\n+\n int hn_vf_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t uint16_t queue_idx, uint16_t nb_desc,\n \t\t\t unsigned int socket_id,\n", "prefixes": [] }