Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44914/?format=api
{ "id": 44914, "url": "https://patches.dpdk.org/api/patches/44914/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537363820-3827-3-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537363820-3827-3-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537363820-3827-3-git-send-email-phil.yang@arm.com", "date": "2018-09-19T13:30:20", "name": "[3/3] kni: fix kni kernel fifo synchronization", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "40c70a5b7f536a15937ad996771d5d429e97e936", "submitter": { "id": 1130, "url": "https://patches.dpdk.org/api/people/1130/?format=api", "name": null, "email": "Phil@dpdk.org, \"Yang <phil.yang\"@arm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537363820-3827-3-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 1388, "url": "https://patches.dpdk.org/api/series/1388/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1388", "date": "2018-09-19T13:30:18", "name": "[1/3] config: use one single config option for C11 memory model", "version": 1, "mbox": "https://patches.dpdk.org/series/1388/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44914/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/44914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 59FC04CE4;\n\tWed, 19 Sep 2018 15:31:04 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id 599754CA6\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 15:31:02 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC09B7A9;\n\tWed, 19 Sep 2018 06:31:01 -0700 (PDT)", "from localhost.localdomain (usa-sjc-mx-foss1.foss.arm.com\n\t[217.140.101.70])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t537763F703; Wed, 19 Sep 2018 06:30:59 -0700 (PDT)" ], "From": "Phil@dpdk.org, \"Yang <phil.yang\"@arm.com", "To": "dev@dpdk.org", "Cc": "nd@arm.com, jerin.jacob@caviumnetworks.com,\n\tkkokkilagadda@caviumnetworks.com, Honnappa.Nagarahalli@arm.com,\n\tGavin.Hu@arm.com, Phil Yang <phil.yang@arm.com>", "Date": "Wed, 19 Sep 2018 21:30:20 +0800", "Message-Id": "<1537363820-3827-3-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1537363820-3827-1-git-send-email-phil.yang@arm.com>", "References": "<1537363820-3827-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 3/3] kni: fix kni kernel fifo synchronization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Phil Yang <phil.yang@arm.com>\n\nAdding memory barrier to make sure the values being synced\nbefore updating fifo_write in kni_fifo_put and fifo_read in\nkni_fifo_get.\n\nFixes: 3fc5ca2 (\"kni: initial import\")\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\nReviewed-by: Gavin Hu <Gavin.Hu@arm.com>\n---\n kernel/linux/kni/kni_fifo.h | 16 ++++++++++------\n .../linuxapp/eal/include/exec-env/rte_kni_common.h | 1 +\n 2 files changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_fifo.h b/kernel/linux/kni/kni_fifo.h\nindex 9a4762d..2cb3a4a 100644\n--- a/kernel/linux/kni/kni_fifo.h\n+++ b/kernel/linux/kni/kni_fifo.h\n@@ -16,7 +16,7 @@ kni_fifo_put(struct rte_kni_fifo *fifo, void **data, uint32_t num)\n {\n \tuint32_t i = 0;\n \tuint32_t fifo_write = fifo->write;\n-\tuint32_t fifo_read = fifo->read;\n+\tuint32_t fifo_read = smp_load_acquire(&fifo->read);\n \tuint32_t new_write = fifo_write;\n \n \tfor (i = 0; i < num; i++) {\n@@ -27,7 +27,7 @@ kni_fifo_put(struct rte_kni_fifo *fifo, void **data, uint32_t num)\n \t\tfifo->buffer[fifo_write] = data[i];\n \t\tfifo_write = new_write;\n \t}\n-\tfifo->write = fifo_write;\n+\tsmp_store_release(&fifo->write, fifo_write);\n \n \treturn i;\n }\n@@ -40,7 +40,7 @@ kni_fifo_get(struct rte_kni_fifo *fifo, void **data, uint32_t num)\n {\n \tuint32_t i = 0;\n \tuint32_t new_read = fifo->read;\n-\tuint32_t fifo_write = fifo->write;\n+\tuint32_t fifo_write = smp_load_acquire(&fifo->write);\n \n \tfor (i = 0; i < num; i++) {\n \t\tif (new_read == fifo_write)\n@@ -49,7 +49,7 @@ kni_fifo_get(struct rte_kni_fifo *fifo, void **data, uint32_t num)\n \t\tdata[i] = fifo->buffer[new_read];\n \t\tnew_read = (new_read + 1) & (fifo->len - 1);\n \t}\n-\tfifo->read = new_read;\n+\tsmp_store_release(&fifo->read, new_read);\n \n \treturn i;\n }\n@@ -60,7 +60,9 @@ kni_fifo_get(struct rte_kni_fifo *fifo, void **data, uint32_t num)\n static inline uint32_t\n kni_fifo_count(struct rte_kni_fifo *fifo)\n {\n-\treturn (fifo->len + fifo->write - fifo->read) & (fifo->len - 1);\n+\tuint32_t fifo_write = smp_load_acquire(&fifo->write);\n+\tuint32_t fifo_read = smp_load_acquire(&fifo->read);\n+\treturn (fifo->len + fifo_write - fifo_read) & (fifo->len - 1);\n }\n \n /**\n@@ -69,7 +71,9 @@ kni_fifo_count(struct rte_kni_fifo *fifo)\n static inline uint32_t\n kni_fifo_free_count(struct rte_kni_fifo *fifo)\n {\n-\treturn (fifo->read - fifo->write - 1) & (fifo->len - 1);\n+\tuint32_t fifo_write = smp_load_acquire(&fifo->write);\n+\tuint32_t fifo_read = smp_load_acquire(&fifo->read);\n+\treturn (fifo_read - fifo_write - 1) & (fifo->len - 1);\n }\n \n #endif /* _KNI_FIFO_H_ */\ndiff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h\nindex 1fd713b..5902ae4 100644\n--- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h\n+++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h\n@@ -8,6 +8,7 @@\n \n #ifdef __KERNEL__\n #include <linux/if.h>\n+#include <asm/barrier.h>\n #define RTE_STD_C11\n #else\n #include <rte_common.h>\n", "prefixes": [ "3/3" ] }