Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4338/?format=api
{ "id": 4338, "url": "https://patches.dpdk.org/api/patches/4338/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1429222237-8002-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1429222237-8002-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1429222237-8002-1-git-send-email-thomas.monjalon@6wind.com", "date": "2015-04-16T22:10:36", "name": "[dpdk-dev,v3,1/2] mk: fix build with gcc 4.4 and clang", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2adcc4ec732224abf5c8264d146d9e09cce0186e", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1429222237-8002-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/4338/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/4338/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 471C7C300;\n\tFri, 17 Apr 2015 00:11:31 +0200 (CEST)", "from mail-wg0-f43.google.com (mail-wg0-f43.google.com\n\t[74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 226819A8A\n\tfor <dev@dpdk.org>; Fri, 17 Apr 2015 00:11:30 +0200 (CEST)", "by wgso17 with SMTP id o17so95747121wgs.1\n\tfor <dev@dpdk.org>; Thu, 16 Apr 2015 15:11:30 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136])\n\tby mx.google.com with ESMTPSA id jh1sm83811wid.9.2015.04.16.15.11.28\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 16 Apr 2015 15:11:29 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=HEEp3HZ0K/r5nLpiuXXdUIxyyisBxabJIgDKOWYGPV8=;\n\tb=MghTxpycVlVIvN5I/xCBypZIHmkwHSMCwoiffJ3b6iX8iSAC3rqaOytL5xg64oKfOC\n\th9kdNTuFFNASxYxIh9Obki3LIagOWbtufVoIHQWtuOstR2nuudLywXqDOqfFY4vbBJvC\n\t+f6X15DglAm/H2I2U36iQYhUMUfs2gVb1RJbSgv3146GgwuJaFpQNYdYzE9SFLch6w2s\n\tkqD29qlL/XhpnYoG9EdXfn2HtDAdRZu0Qg9tF1amKMWabteCf99T9l7Tck0brQE46Biv\n\tLXTcX3rFL3J0LwFfj8Ez6aHN6gXF/eHYVkbNGJFhxGQHrDIqwxgnYSUWVSqTPbpMuC4v\n\tVcvQ==", "X-Gm-Message-State": "ALoCoQkWrD4Mfccogt5R2zE4iLQQ84aDuUWx44V3RZTVGxjpaIA9k7qLupmJazGs1hevMAo6NLt3", "X-Received": "by 10.194.24.35 with SMTP id r3mr63422593wjf.125.1429222290006; \n\tThu, 16 Apr 2015 15:11:30 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 17 Apr 2015 00:10:36 +0200", "Message-Id": "<1429222237-8002-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.2.2", "In-Reply-To": "<1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "With GCC 4.4.7 from CentOS 6.5, the following errors arise:\n\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_dev_rx_queue_setup':\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for 'dev_info.driver_name')\n\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_set_rsc':\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for 'dev_info.driver_name')\n\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_recv_pkts_lro_single_alloc':\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: 'next_rsc_entry' may be used uninitialized in this function\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: 'next_rxe' may be used uninitialized in this function\n\nThe \"missing initializer\" warning is a GCC bug which seems fixed in 4.7.\nThe same warning is thrown by clang.\nThe \"may be used uninitialized\" warning is another GCC bug which seems fixed in 4.7.\n\nFixes: 8eecb3295aed (\"ixgbe: add LRO support\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\nchanges in v2:\n- option -Wno-missing-field-initializers for old GCC instead of code workaround\nchanges in v3:\n- option -Wno-missing-field-initializers for clang\n- option -Wno-uninitialized for old GCC instead of code workaround (=NULL)\n- remove redundants -Wno-uninitialized from ixgbe Makefile\n\n lib/librte_pmd_ixgbe/Makefile | 4 ----\n mk/toolchain/clang/rte.vars.mk | 3 +++\n mk/toolchain/gcc/rte.vars.mk | 9 +++++++++\n 3 files changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_pmd_ixgbe/Makefile b/lib/librte_pmd_ixgbe/Makefile\nindex ae36202..fbf6966 100644\n--- a/lib/librte_pmd_ixgbe/Makefile\n+++ b/lib/librte_pmd_ixgbe/Makefile\n@@ -76,10 +76,6 @@ ifeq ($(shell test $(GCC_VERSION) -ge 50 && echo 1), 1)\n CFLAGS_ixgbe_common.o += -Wno-logical-not-parentheses\n endif\n \n-ifeq ($(shell test $(GCC_VERSION) -le 46 && echo 1), 1)\n-CFLAGS_ixgbe_x550.o += -Wno-uninitialized\n-CFLAGS_ixgbe_phy.o += -Wno-uninitialized\n-endif\n endif\n \n #\ndiff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk\nindex 40cb389..245ea7e 100644\n--- a/mk/toolchain/clang/rte.vars.mk\n+++ b/mk/toolchain/clang/rte.vars.mk\n@@ -72,5 +72,8 @@ WERROR_FLAGS += -Wundef -Wwrite-strings\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n \n+# workaround clang bug with warning \"missing field initializer\" for \"= {0}\"\n+WERROR_FLAGS += -Wno-missing-field-initializers\n+\n export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF\n export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS\ndiff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk\nindex 88f235c..0f51c66 100644\n--- a/mk/toolchain/gcc/rte.vars.mk\n+++ b/mk/toolchain/gcc/rte.vars.mk\n@@ -80,5 +80,14 @@ WERROR_FLAGS += -Wundef -Wwrite-strings\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n \n+# workaround GCC bug with warning \"missing initializer\" for \"= {0}\"\n+ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)\n+WERROR_FLAGS += -Wno-missing-field-initializers\n+endif\n+# workaround GCC bug with warning \"may be used uninitialized\"\n+ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)\n+WERROR_FLAGS += -Wno-uninitialized\n+endif\n+\n export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF\n export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS\n", "prefixes": [ "dpdk-dev", "v3", "1/2" ] }