Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41556/?format=api
{ "id": 41556, "url": "https://patches.dpdk.org/api/patches/41556/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com", "date": "2018-06-26T10:53:16", "name": "[v2,5/7] eal: bring forward init of interrupt handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f6a85b4a392cedd09fda8141710dc28ac6ddfe51", "submitter": { "id": 4, "url": "https://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 238, "url": "https://patches.dpdk.org/api/series/238/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=238", "date": "2018-06-26T10:53:12", "name": "Remove asynchronous IPC thread", "version": 2, "mbox": "https://patches.dpdk.org/series/238/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41556/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41556/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 65E171B538;\n\tTue, 26 Jun 2018 12:53:31 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 079051B4BA\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 12:53:23 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 03:53:22 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga006.jf.intel.com with ESMTP; 26 Jun 2018 03:53:20 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw5QArKGp026448; Tue, 26 Jun 2018 11:53:20 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w5QArKIu021217;\n\tTue, 26 Jun 2018 11:53:20 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w5QArKa9021213;\n\tTue, 26 Jun 2018 11:53:20 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"52974030\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Jianfeng Tan <jianfeng.tan@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tkonstantin.ananyev@intel.com, thomas@monjalon.net, qi.z.zhang@intel.com", "Date": "Tue, 26 Jun 2018 11:53:16 +0100", "Message-Id": "<5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1530009564.git.anatoly.burakov@intel.com>", "<cover.1530009564.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1530009564.git.anatoly.burakov@intel.com>", "<cover.1529071026.git.anatoly.burakov@intel.com>\n\t<cover.1530009564.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt\n\thandling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jianfeng Tan <jianfeng.tan@intel.com>\n\nNext commit will make asynchronous IPC requests rely on alarm API,\nwhich in turn relies on interrupts to work. Therefore, move the EAL\ninterrupt initialization before IPC initialization to avoid breaking\nIPC in the next commit.\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/bsdapp/eal/eal.c | 10 +++++-----\n lib/librte_eal/linuxapp/eal/eal.c | 10 +++++-----\n 2 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex dc279542d..f70f7aecd 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -625,6 +625,11 @@ rte_eal_init(int argc, char **argv)\n \n \trte_config_init();\n \n+\tif (rte_eal_intr_init() < 0) {\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n+\t\treturn -1;\n+\t}\n+\n \t/* Put mp channel init before bus scan so that we can init the vdev\n \t * bus through mp channel in the secondary process before the bus scan.\n \t */\n@@ -713,11 +718,6 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n-\tif (rte_eal_intr_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n-\t\treturn -1;\n-\t}\n-\n \tif (rte_eal_timer_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init HPET or TSC timers\\n\");\n \t\trte_errno = ENOTSUP;\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 8655b8691..f8a0c06d7 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -839,6 +839,11 @@ rte_eal_init(int argc, char **argv)\n \n \trte_config_init();\n \n+\tif (rte_eal_intr_init() < 0) {\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n+\t\treturn -1;\n+\t}\n+\n \t/* Put mp channel init before bus scan so that we can init the vdev\n \t * bus through mp channel in the secondary process before the bus scan.\n \t */\n@@ -968,11 +973,6 @@ rte_eal_init(int argc, char **argv)\n \t\trte_config.master_lcore, (int)thread_id, cpuset,\n \t\tret == 0 ? \"\" : \"...\");\n \n-\tif (rte_eal_intr_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n-\t\treturn -1;\n-\t}\n-\n \tRTE_LCORE_FOREACH_SLAVE(i) {\n \n \t\t/*\n", "prefixes": [ "v2", "5/7" ] }