Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4040,
    "url": "https://patches.dpdk.org/api/patches/4040/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1426673208-28670-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1426673208-28670-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1426673208-28670-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2015-03-18T10:06:48",
    "name": "[dpdk-dev] i40e: revert internal switch of PF",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "46ce74df7a9d7a1d14aacf52001668f885f3ab91",
    "submitter": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1426673208-28670-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/4040/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/4040/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CC3D05A72;\n\tWed, 18 Mar 2015 11:07:30 +0100 (CET)",
            "from mail-we0-f170.google.com (mail-we0-f170.google.com\n\t[74.125.82.170]) by dpdk.org (Postfix) with ESMTP id 04D9A37A2\n\tfor <dev@dpdk.org>; Wed, 18 Mar 2015 11:07:29 +0100 (CET)",
            "by wegp1 with SMTP id p1so28045356weg.1\n\tfor <dev@dpdk.org>; Wed, 18 Mar 2015 03:07:28 -0700 (PDT)",
            "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tk1sm23774140wjn.9.2015.03.18.03.07.27\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 18 Mar 2015 03:07:28 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-type:content-transfer-encoding;\n\tbh=6Vv93aF3CJrQ303RsSw/Xi94JjN0QDkWhQDLJIVk8dY=;\n\tb=KsUxKV0B6zbOUqppCgSijX9hLjeTQkNLDlIrgYpxZSxdk0Ybuh7Wx3+jMdKm6XHqIz\n\tT6QiXNAq2DWx0EEleNyItHqNUpODA3GffQsSRZgL+0xZ7PpcUYJTYwPZpPj0Fs57nZUg\n\tiC/V6xUyHbsMKX1uUMWlxrqIstJyW12T6US3NJEpDq5Es4vaQiJaWX/KtGCjUa7JCA+l\n\tKrs0fOOuUc8eT5XuujkxwKfBATo7VxHXIzZiOqeUl2Ea+d07QJ0bOFc0yyBlYqSvEdaW\n\tZFwlAaJ1kghDy+krPpVUH+UoxiSYTcD/yoCODKNf3oTxV5pW05TqubOy1IkdneOZS20N\n\t3qfQ==",
        "X-Gm-Message-State": "ALoCoQkPB0u4AGtG+fGhxCvasq+MPmR9G7HKiBgsjRKpymG1nO2joc3qVS75alDkE+YtNUUqwTqB",
        "X-Received": "by 10.194.110.233 with SMTP id\n\tid9mr141345672wjb.136.1426673248855; \n\tWed, 18 Mar 2015 03:07:28 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "helin.zhang@intel.com",
        "Date": "Wed, 18 Mar 2015 11:06:48 +0100",
        "Message-Id": "<1426673208-28670-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.2.2",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Cc": "dev@dpdk.org",
        "Subject": "[dpdk-dev] [PATCH] i40e: revert internal switch of PF",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "VEB switching is blocking VF.\nIf the source mac address of packet sent from VF is not listed in the\nVEB’s mac table, the VEB will switch the packet back to the VF.\nIt's an hardware issue.\n\nReverts: 2ccabd8cd1f6 (\"i40e: enable internal switch of PF\").\n\nReported-by: Jingjing Wu <jingjing.wu@intel.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 36 ------------------------------------\n 1 file changed, 36 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 6888072..cf6685e 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -2868,40 +2868,6 @@ i40e_vsi_dump_bw_config(struct i40e_vsi *vsi)\n \treturn 0;\n }\n \n-/*\n- * i40e_enable_pf_lb\n- * @pf: pointer to the pf structure\n- *\n- * allow loopback on pf\n- */\n-static inline void\n-i40e_enable_pf_lb(struct i40e_pf *pf)\n-{\n-\tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n-\tstruct i40e_vsi_context ctxt;\n-\tint ret;\n-\n-\tmemset(&ctxt, 0, sizeof(ctxt));\n-\tctxt.seid = pf->main_vsi_seid;\n-\tctxt.pf_num = hw->pf_id;\n-\tret = i40e_aq_get_vsi_params(hw, &ctxt, NULL);\n-\tif (ret) {\n-\t\tPMD_DRV_LOG(ERR, \"couldn't get pf vsi config, err %d, aq_err %d\",\n-\t\t\tret, hw->aq.asq_last_status);\n-\t\treturn;\n-\t}\n-\tctxt.flags = I40E_AQ_VSI_TYPE_PF;\n-\tctxt.info.valid_sections =\n-\t\trte_cpu_to_le_16(I40E_AQ_VSI_PROP_SWITCH_VALID);\n-\tctxt.info.switch_id |=\n-\t\trte_cpu_to_le_16(I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB);\n-\n-\tret = i40e_aq_update_vsi_params(hw, &ctxt, NULL);\n-\tif (ret)\n-\t\tPMD_DRV_LOG(ERR, \"update vsi switch failed, aq_err=%d\\n\",\n-\t\t\thw->aq.asq_last_status);\n-}\n-\n /* Setup a VSI */\n struct i40e_vsi *\n i40e_vsi_setup(struct i40e_pf *pf,\n@@ -2937,8 +2903,6 @@ i40e_vsi_setup(struct i40e_pf *pf,\n \t\t\tPMD_DRV_LOG(ERR, \"VEB setup failed\");\n \t\t\treturn NULL;\n \t\t}\n-\t\t/* set ALLOWLOOPBACk on pf, when veb is created */\n-\t\ti40e_enable_pf_lb(pf);\n \t}\n \n \tvsi = rte_zmalloc(\"i40e_vsi\", sizeof(struct i40e_vsi), 0);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}