Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/39866/?format=api
{ "id": 39866, "url": "https://patches.dpdk.org/api/patches/39866/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1526055955-14027-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1526055955-14027-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1526055955-14027-2-git-send-email-arybchenko@solarflare.com", "date": "2018-05-11T16:25:53", "name": "[dpdk-dev,1/3] ethdev: fail configure if requested offload is not supported", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4dedb103d79f728bca923cee5ec870cc7e701c5b", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1526055955-14027-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/39866/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/39866/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8177C1C82D;\n\tFri, 11 May 2018 18:26:15 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 43BFF1C819\n\tfor <dev@dpdk.org>; Fri, 11 May 2018 18:26:12 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 00210280075; Fri, 11 May 2018 16:26:10 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Fri, 11 May 2018 09:26:00 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Fri, 11 May 2018 09:26:00 -0700", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw4BGPx1Y027511; Fri, 11 May 2018 17:25:59 +0100", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw4BGPxWM014063; Fri, 11 May 2018 17:25:59 +0100" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon\n\t<thomas@monjalon.net>, Shahaf Shuler <shahafs@mellanox.com>, Wei Dai\n\t<wei.dai@intel.com>", "Date": "Fri, 11 May 2018 17:25:53 +0100", "Message-ID": "<1526055955-14027-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1526055955-14027-1-git-send-email-arybchenko@solarflare.com>", "References": "<1526055955-14027-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1526055971-tt2HJc36sdrQ", "Subject": "[dpdk-dev] [PATCH 1/3] ethdev: fail configure if requested offload\n\tis not supported", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Do not allow allow unsupported offload to be passed to PMD since\nin can result in inconsistent NIC configuration and processing\nin the driver.\n\nAll PMDs are converted to the new offload API and must report its\ncapabilties correctly. Both device and queue offloads are listed\nin [rt]x_offload_capa so the check should pass despite of which\nlevel the offload is supported on.\n\nFixes: d04dd6d4ed67 (\"ethdev: new Rx/Tx offloads API\")\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 3ddf3accb..dd36e6270 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -1171,6 +1171,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t\t\tlocal_conf.rxmode.offloads,\n \t\t\t\tdev_info.rx_offload_capa,\n \t\t\t\t__func__);\n+\t\treturn -EINVAL;\n \t}\n \tif ((local_conf.txmode.offloads & dev_info.tx_offload_capa) !=\n \t local_conf.txmode.offloads) {\n@@ -1181,6 +1182,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t\t\tlocal_conf.txmode.offloads,\n \t\t\t\tdev_info.tx_offload_capa,\n \t\t\t\t__func__);\n+\t\treturn -EINVAL;\n \t}\n \n \t/* Check that device supports requested rss hash functions. */\n", "prefixes": [ "dpdk-dev", "1/3" ] }