Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34564/?format=api
{ "id": 34564, "url": "https://patches.dpdk.org/api/patches/34564/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/cfcd9b2f78f4c2988d7824f69737500bd984947b.1516988093.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cfcd9b2f78f4c2988d7824f69737500bd984947b.1516988093.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cfcd9b2f78f4c2988d7824f69737500bd984947b.1516988093.git.anatoly.burakov@intel.com", "date": "2018-01-26T17:40:35", "name": "[dpdk-dev,2/2] test/memzone: handle previously allocated memzones", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "851958334e88cdb1716387a347783e13b9981853", "submitter": { "id": 4, "url": "https://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/cfcd9b2f78f4c2988d7824f69737500bd984947b.1516988093.git.anatoly.burakov@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/34564/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/34564/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 55BFC1B35D;\n\tFri, 26 Jan 2018 18:40:39 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 2943A1B338;\n\tFri, 26 Jan 2018 18:40:37 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jan 2018 09:40:37 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga008.jf.intel.com with ESMTP; 26 Jan 2018 09:40:36 -0800", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw0QHeZdC015142; Fri, 26 Jan 2018 17:40:35 GMT", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w0QHeZKh021614;\n\tFri, 26 Jan 2018 17:40:35 GMT", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w0QHeZLK021610;\n\tFri, 26 Jan 2018 17:40:35 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,417,1511856000\"; d=\"scan'208\";a=\"13304868\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "radoslaw.biernacki@linaro.org, stable@dpdk.org", "Date": "Fri, 26 Jan 2018 17:40:35 +0000", "Message-Id": "<cfcd9b2f78f4c2988d7824f69737500bd984947b.1516988093.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<ec8bf2436653ce9dbbe9e83a364ca44c41bd2a8a.1516988093.git.anatoly.burakov@intel.com>", "<ec8bf2436653ce9dbbe9e83a364ca44c41bd2a8a.1516988093.git.anatoly.burakov@intel.com>" ], "References": [ "<ec8bf2436653ce9dbbe9e83a364ca44c41bd2a8a.1516988093.git.anatoly.burakov@intel.com>", "<ec8bf2436653ce9dbbe9e83a364ca44c41bd2a8a.1516988093.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 2/2] test/memzone: handle previously allocated\n\tmemzones", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, memzone autotest expects there to be no memzones\npresent by the time the test is run. Some hardware drivers\nwill allocate memzones for internal use during initialization,\nresulting in tests failing due to unexpected memzones being\nallocated before the test was run.\n\nFix this by making callback increment a counter instead. This\nalso doubles as a test for correct operation of memzone_walk().\n\nFixes: 71330483a193 (\"test/memzone: fix memory leak\")\nCc: radoslaw.biernacki@linaro.org\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n test/test/test_memzone.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/test/test_memzone.c b/test/test/test_memzone.c\nindex 00d340f..5428b35 100644\n--- a/test/test/test_memzone.c\n+++ b/test/test/test_memzone.c\n@@ -953,16 +953,19 @@ test_memzone_basic(void)\n \treturn 0;\n }\n \n-static int memzone_walk_called;\n+static int memzone_walk_cnt;\n static void memzone_walk_clb(const struct rte_memzone *mz __rte_unused,\n \t\t\t void *arg __rte_unused)\n {\n-\tmemzone_walk_called = 1;\n+\tmemzone_walk_cnt++;\n }\n \n static int\n test_memzone(void)\n {\n+\t/* take note of how many memzones were allocated before running */\n+\tint memzone_cnt = rte_eal_get_configuration()->mem_config->memzone_cnt;\n+\n \tprintf(\"test basic memzone API\\n\");\n \tif (test_memzone_basic() < 0)\n \t\treturn -1;\n@@ -1000,8 +1003,9 @@ test_memzone(void)\n \t\treturn -1;\n \n \tprintf(\"check memzone cleanup\\n\");\n+\tmemzone_walk_cnt = 0;\n \trte_memzone_walk(memzone_walk_clb, NULL);\n-\tif (memzone_walk_called) {\n+\tif (memzone_walk_cnt != memzone_cnt) {\n \t\tprintf(\"there are some memzones left after test\\n\");\n \t\trte_memzone_dump(stdout);\n \t\treturn -1;\n", "prefixes": [ "dpdk-dev", "2/2" ] }