Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/3314/?format=api
https://patches.dpdk.org/api/patches/3314/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1423841989-9090-2-git-send-email-john.mcnamara@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1423841989-9090-2-git-send-email-john.mcnamara@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1423841989-9090-2-git-send-email-john.mcnamara@intel.com", "date": "2015-02-13T15:39:46", "name": "[dpdk-dev,v2,1/4] ethdev: rename callbacks field to intr_cbs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8e21c47f28de9c6f9f8cf4e711f4b96a8a918bef", "submitter": { "id": 154, "url": "https://patches.dpdk.org/api/people/154/?format=api", "name": "John McNamara", "email": "john.mcnamara@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1423841989-9090-2-git-send-email-john.mcnamara@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/3314/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/3314/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2A6AFB4E3;\n\tFri, 13 Feb 2015 16:40:02 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 8B621B4E2\n\tfor <dev@dpdk.org>; Fri, 13 Feb 2015 16:40:00 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 13 Feb 2015 07:34:51 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga003.jf.intel.com with ESMTP; 13 Feb 2015 07:31:40 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt1DFdup8032337; Fri, 13 Feb 2015 15:39:56 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t1DFdth1009141;\n\tFri, 13 Feb 2015 15:39:55 GMT", "(from jmcnam2x@localhost)\n\tby sivswdev02.ir.intel.com with id t1DFdtKB009137;\n\tFri, 13 Feb 2015 15:39:55 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.09,571,1418112000\"; d=\"scan'208\";a=\"527170118\"", "From": "John McNamara <john.mcnamara@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 13 Feb 2015 15:39:46 +0000", "Message-Id": "<1423841989-9090-2-git-send-email-john.mcnamara@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1423841989-9090-1-git-send-email-john.mcnamara@intel.com>", "References": "<1419266844-4848-1-git-send-email-bruce.richardson@intel.com>\n\t<1423841989-9090-1-git-send-email-john.mcnamara@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/4] ethdev: rename callbacks field to intr_cbs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Richardson, Bruce <bruce.richardson@intel.com>\n\nThe callbacks member of the rte_eth_dev structure has been renamed\nto intr_cbs to make it clear that it refers to callbacks from NIC\ninterrupts. This then allows us to add other types of callbacks to\nthe structure without ambiguity.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/virtual_pmd.c | 2 +-\n lib/librte_ether/rte_ethdev.c | 12 ++++++------\n lib/librte_ether/rte_ethdev.h | 2 +-\n lib/librte_pmd_bond/rte_eth_bond_api.c | 2 +-\n 4 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c\nindex 9fac95d..ec2474f 100644\n--- a/app/test/virtual_pmd.c\n+++ b/app/test/virtual_pmd.c\n@@ -576,7 +576,7 @@ virtual_ethdev_create(const char *name, struct ether_addr *mac_addr,\n \teth_dev->data->nb_rx_queues = (uint16_t)1;\n \teth_dev->data->nb_tx_queues = (uint16_t)1;\n \n-\tTAILQ_INIT(&(eth_dev->callbacks));\n+\tTAILQ_INIT(&(eth_dev->intr_cbs));\n \n \teth_dev->data->dev_link.link_status = 0;\n \teth_dev->data->dev_link.link_speed = ETH_LINK_SPEED_10000;\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex ea3a1fb..e4b3315 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -265,7 +265,7 @@ rte_eth_dev_init(struct rte_pci_driver *pci_drv,\n \teth_dev->data->rx_mbuf_alloc_failed = 0;\n \n \t/* init user callbacks */\n-\tTAILQ_INIT(&(eth_dev->callbacks));\n+\tTAILQ_INIT(&(eth_dev->intr_cbs));\n \n \t/*\n \t * Set the default MTU.\n@@ -2738,7 +2738,7 @@ rte_eth_dev_callback_register(uint8_t port_id,\n \tdev = &rte_eth_devices[port_id];\n \trte_spinlock_lock(&rte_eth_dev_cb_lock);\n \n-\tTAILQ_FOREACH(user_cb, &(dev->callbacks), next) {\n+\tTAILQ_FOREACH(user_cb, &(dev->intr_cbs), next) {\n \t\tif (user_cb->cb_fn == cb_fn &&\n \t\t\tuser_cb->cb_arg == cb_arg &&\n \t\t\tuser_cb->event == event) {\n@@ -2752,7 +2752,7 @@ rte_eth_dev_callback_register(uint8_t port_id,\n \t\tuser_cb->cb_fn = cb_fn;\n \t\tuser_cb->cb_arg = cb_arg;\n \t\tuser_cb->event = event;\n-\t\tTAILQ_INSERT_TAIL(&(dev->callbacks), user_cb, next);\n+\t\tTAILQ_INSERT_TAIL(&(dev->intr_cbs), user_cb, next);\n \t}\n \n \trte_spinlock_unlock(&rte_eth_dev_cb_lock);\n@@ -2779,7 +2779,7 @@ rte_eth_dev_callback_unregister(uint8_t port_id,\n \trte_spinlock_lock(&rte_eth_dev_cb_lock);\n \n \tret = 0;\n-\tfor (cb = TAILQ_FIRST(&dev->callbacks); cb != NULL; cb = next) {\n+\tfor (cb = TAILQ_FIRST(&dev->intr_cbs); cb != NULL; cb = next) {\n \n \t\tnext = TAILQ_NEXT(cb, next);\n \n@@ -2793,7 +2793,7 @@ rte_eth_dev_callback_unregister(uint8_t port_id,\n \t\t * then remove it.\n \t\t */\n \t\tif (cb->active == 0) {\n-\t\t\tTAILQ_REMOVE(&(dev->callbacks), cb, next);\n+\t\t\tTAILQ_REMOVE(&(dev->intr_cbs), cb, next);\n \t\t\trte_free(cb);\n \t\t} else {\n \t\t\tret = -EAGAIN;\n@@ -2812,7 +2812,7 @@ _rte_eth_dev_callback_process(struct rte_eth_dev *dev,\n \tstruct rte_eth_dev_callback dev_cb;\n \n \trte_spinlock_lock(&rte_eth_dev_cb_lock);\n-\tTAILQ_FOREACH(cb_lst, &(dev->callbacks), next) {\n+\tTAILQ_FOREACH(cb_lst, &(dev->intr_cbs), next) {\n \t\tif (cb_lst->cb_fn == NULL || cb_lst->event != event)\n \t\t\tcontinue;\n \t\tdev_cb = *cb_lst;\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 1200c1c..9c67488 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -1538,7 +1538,7 @@ struct rte_eth_dev {\n \tconst struct eth_driver *driver;/**< Driver for this device */\n \tstruct eth_dev_ops *dev_ops; /**< Functions exported by PMD */\n \tstruct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */\n-\tstruct rte_eth_dev_cb_list callbacks; /**< User application callbacks */\n+\tstruct rte_eth_dev_cb_list intr_cbs; /**< User application callbacks on interrupt*/\n };\n \n struct rte_eth_dev_sriov {\ndiff --git a/lib/librte_pmd_bond/rte_eth_bond_api.c b/lib/librte_pmd_bond/rte_eth_bond_api.c\nindex 4ab3267..4a66609 100644\n--- a/lib/librte_pmd_bond/rte_eth_bond_api.c\n+++ b/lib/librte_pmd_bond/rte_eth_bond_api.c\n@@ -251,7 +251,7 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id)\n \teth_dev->data->nb_rx_queues = (uint16_t)1;\n \teth_dev->data->nb_tx_queues = (uint16_t)1;\n \n-\tTAILQ_INIT(&(eth_dev->callbacks));\n+\tTAILQ_INIT(&(eth_dev->intr_cbs));\n \n \teth_dev->data->dev_link.link_status = 0;\n \n", "prefixes": [ "dpdk-dev", "v2", "1/4" ] }{ "id": 3314, "url": "