Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 30514,
    "url": "https://patches.dpdk.org/api/patches/30514/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1508319597-21039-1-git-send-email-arybchenko@solarflare.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1508319597-21039-1-git-send-email-arybchenko@solarflare.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1508319597-21039-1-git-send-email-arybchenko@solarflare.com",
    "date": "2017-10-18T09:39:57",
    "name": "[dpdk-dev] net/sfc: fix Tx reap behaviour on port stop on EF10 datapath",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "7805cce3556f059d7bcf1feb4618dbc65fa83b98",
    "submitter": {
        "id": 607,
        "url": "https://patches.dpdk.org/api/people/607/?format=api",
        "name": "Andrew Rybchenko",
        "email": "arybchenko@solarflare.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1508319597-21039-1-git-send-email-arybchenko@solarflare.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/30514/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/30514/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BCC561B5E0;\n\tWed, 18 Oct 2017 11:40:21 +0200 (CEST)",
            "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 842C71B2C1\n\tfor <dev@dpdk.org>; Wed, 18 Oct 2017 11:40:20 +0200 (CEST)",
            "from pure.maildistiller.com (dispatch1.mdlocal [10.7.20.164])\n\tby dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server)\n\twith ESMTP id 170BF60052; Wed, 18 Oct 2017 09:40:20 +0000 (UTC)",
            "from mx2-us3.ppe-hosted.com (us4-filterqueue.mdlocal [10.7.20.246])\n\tby pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 83FC622004F; Wed, 18 Oct 2017 09:40:19 +0000 (UTC)",
            "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx2-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 3C42D8006B; Wed, 18 Oct 2017 09:40:19 +0000 (UTC)",
            "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Wed, 18 Oct 2017 02:40:17 -0700",
            "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Wed, 18 Oct 2017 02:40:16 -0700",
            "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv9I9eFjX011497; Wed, 18 Oct 2017 10:40:15 +0100",
            "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv9I9eFto021535; Wed, 18 Oct 2017 10:40:15 +0100"
        ],
        "X-Virus-Scanned": "Proofpoint Essentials engine",
        "From": "Andrew Rybchenko <arybchenko@solarflare.com>",
        "To": "<dev@dpdk.org>",
        "CC": "Ivan Malov <ivan.malov@oktetlabs.ru>",
        "Date": "Wed, 18 Oct 2017 10:39:57 +0100",
        "Message-ID": "<1508319597-21039-1-git-send-email-arybchenko@solarflare.com>",
        "X-Mailer": "git-send-email 1.8.2.3",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-MDID": "1508319620-F+lPqyESYQea",
        "Subject": "[dpdk-dev] [PATCH] net/sfc: fix Tx reap behaviour on port stop on\n\tEF10 datapath",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Ivan Malov <ivan.malov@oktetlabs.ru>\n\nTx reap mechanism on EF10 native datapath was altered by one\nof the recent patches to introduce performance optimisations\nusing the common technique of freeing mbuf segments in bulks.\n\nFrom this perspective, the way of associating SW descriptors\nwith individual mbuf segments rather than with whole packets\nwas adopted as a key requirement for the entire optimisation.\n\nHowever, only the fast path reap function was amended to fit\nthe new scheme whilst the corresponding function on the port\nstop path was left intact by mistake. This implies incorrect\nusage of rte_pktmbuf_free() with regard to separate segments\nrather than calling rte_pktmbuf_free_seg() and must be fixed.\n\nFixes: d321954343c8 (\"net/sfc: free mbufs in bulks on EF10 native Tx reap\")\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@solarflare.com>\n---\n drivers/net/sfc/sfc_ef10_tx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c\nindex 9047b3e..167c91d 100644\n--- a/drivers/net/sfc/sfc_ef10_tx.c\n+++ b/drivers/net/sfc/sfc_ef10_tx.c\n@@ -602,7 +602,7 @@ sfc_ef10_tx_qreap(struct sfc_dp_txq *dp_txq)\n \n \t\ttxd = &txq->sw_ring[completed & txq->ptr_mask];\n \t\tif (txd->mbuf != NULL) {\n-\t\t\trte_pktmbuf_free(txd->mbuf);\n+\t\t\trte_pktmbuf_free_seg(txd->mbuf);\n \t\t\ttxd->mbuf = NULL;\n \t\t}\n \t}\n",
    "prefixes": [
        "dpdk-dev"
    ]
}