Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30182/?format=api
{ "id": 30182, "url": "https://patches.dpdk.org/api/patches/30182/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/efd19ecd4006ca3366bfcc134b980393e31c688e.1507795823.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<efd19ecd4006ca3366bfcc134b980393e31c688e.1507795823.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/efd19ecd4006ca3366bfcc134b980393e31c688e.1507795823.git.gaetan.rivet@6wind.com", "date": "2017-10-12T08:17:10", "name": "[dpdk-dev,v4,10/16] pci: avoid inlining functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4d29b9c8eace1ce8cef4f18e9701cd39d4f375c7", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/efd19ecd4006ca3366bfcc134b980393e31c688e.1507795823.git.gaetan.rivet@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/30182/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/30182/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C6E3E1B1EC;\n\tThu, 12 Oct 2017 10:17:57 +0200 (CEST)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 0A59B1AEF6\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 10:17:45 +0200 (CEST)", "by mail-wm0-f52.google.com with SMTP id l68so10954145wmd.5\n\tfor <dev@dpdk.org>; Thu, 12 Oct 2017 01:17:45 -0700 (PDT)", "from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t25sm16711227wrv.8.2017.10.12.01.17.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 12 Oct 2017 01:17:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=z0FrpvjolzpmO0GFdQUcTaaPSJq0uDjVsh3Sxaj7T0Y=;\n\tb=zdcy6Ah55pELPDmdfD5qQzvoDy4Z1b0FPkwCIDH5IT1cCmKrCLdgezTeurkA9lYvcA\n\tZPaNgnfBo8q3StJcNQre02bO/zeVaEU75seyzVmzwLUvahNT8V1Q8cONGVMWQNdrk9V9\n\t0mmsII78cFUMl30Md8VWEPTQ3DXc7w/WE5+ayx3G2hq1FqNXMJb3f8EZfdtd4TysCdJj\n\toKnN0y36rgk4HR3I1NBBjXkYpWZEKdVmWciT2MRqZG4H9CyGn+h0KifdKho6qzZDf7Fa\n\t4/xRwW9kNssvsDguo5HgE527+TNSjkOjv+QMPqwULP7G29o+SrDWHzz8FBf4WVoNUJzC\n\tG7eg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=z0FrpvjolzpmO0GFdQUcTaaPSJq0uDjVsh3Sxaj7T0Y=;\n\tb=o3nMJMMHNxuBGIBaDV1u0kCvYPJpICPK9hsI/eJL9hUespou6L6GMDNF9ulegQQIKJ\n\tJOC7DBzMHyCuFj5f88vm47R5ieXMyFdcjlUv8TdkrORBd3mofZq/fukoKEP+/cJrypke\n\tyGcu1DT103G2Iu1HARuV8m5yoW8BXZ7ACIx+CFLRH8ejxyemre497D8TZIZsEEDGN0F7\n\tFk+l6/KRUIfLFj0D44ovRcMzHw/jbMiw8MJMs3mc3DaJBgJL3PQSO/cy0TcQO6v0AeUE\n\tnvwRntsYMC3hOC6g6lfSoBva4EBMgEDy/otAETqA3Oi5vAfJyx2sBhkSnSJdhlFBs34i\n\taBEQ==", "X-Gm-Message-State": "AMCzsaUiiUBMfIgTMsDqVTnYPhpxyYaZw7+d4Dn5HnuM4d+Arc5FcNt1\n\tl82SjAhwCwjuGCvE8/SubEMPVlHP", "X-Google-Smtp-Source": "AOwi7QD9Wz56pbMs5WzFjOysPQr4xB3jXVD10rmcxOXOW47Ye/qH91BzgMhgF8eVw/V0r63DykUHyw==", "X-Received": "by 10.28.232.138 with SMTP id f10mr1100677wmi.130.1507796264076; \n\tThu, 12 Oct 2017 01:17:44 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 12 Oct 2017 10:17:10 +0200", "Message-Id": "<efd19ecd4006ca3366bfcc134b980393e31c688e.1507795823.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": [ "<cover.1507795823.git.gaetan.rivet@6wind.com>", "<cover.1507795823.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1506352670.git.gaetan.rivet@6wind.com>\n\t<cover.1507795823.git.gaetan.rivet@6wind.com>", "<cover.1507795823.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v4 10/16] pci: avoid inlining functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Parsing operations should not happen in performance critical sections.\nHeaders should not propose implementations unless duly required.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_pci/include/rte_pci.h | 69 ++++----------------------------------\n lib/librte_pci/rte_pci.c | 65 +++++++++++++++++++++++++++++++++++\n lib/librte_pci/rte_pci_version.map | 4 +++\n 3 files changed, 75 insertions(+), 63 deletions(-)", "diff": "diff --git a/lib/librte_pci/include/rte_pci.h b/lib/librte_pci/include/rte_pci.h\nindex 2647568..fe4d411 100644\n--- a/lib/librte_pci/include/rte_pci.h\n+++ b/lib/librte_pci/include/rte_pci.h\n@@ -134,19 +134,6 @@ struct mapped_pci_resource {\n /** mapped pci device list */\n TAILQ_HEAD(mapped_pci_res_list, mapped_pci_resource);\n \n-/**< Internal use only - Macro used by pci addr parsing functions **/\n-#define GET_PCIADDR_FIELD(in, fd, lim, dlm) \\\n-do { \\\n-\tunsigned long val; \\\n-\tchar *end; \\\n-\terrno = 0; \\\n-\tval = strtoul((in), &end, 16); \\\n-\tif (errno != 0 || end[0] != (dlm) || val > (lim)) \\\n-\t\treturn -EINVAL; \\\n-\t(fd) = (typeof (fd))val; \\\n-\t(in) = end + 1; \\\n-} while(0)\n-\n /**\n * Utility function to produce a PCI Bus-Device-Function value\n * given a string representation. Assumes that the BDF is provided without\n@@ -160,15 +147,7 @@ do { \\\n * @return\n * 0 on success, negative on error.\n */\n-static inline int\n-eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr)\n-{\n-\tdev_addr->domain = 0;\n-\tGET_PCIADDR_FIELD(input, dev_addr->bus, UINT8_MAX, ':');\n-\tGET_PCIADDR_FIELD(input, dev_addr->devid, UINT8_MAX, '.');\n-\tGET_PCIADDR_FIELD(input, dev_addr->function, UINT8_MAX, 0);\n-\treturn 0;\n-}\n+int eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr);\n \n /**\n * Utility function to produce a PCI Bus-Device-Function value\n@@ -182,16 +161,7 @@ eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr)\n * @return\n * 0 on success, negative on error.\n */\n-static inline int\n-eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr)\n-{\n-\tGET_PCIADDR_FIELD(input, dev_addr->domain, UINT16_MAX, ':');\n-\tGET_PCIADDR_FIELD(input, dev_addr->bus, UINT8_MAX, ':');\n-\tGET_PCIADDR_FIELD(input, dev_addr->devid, UINT8_MAX, '.');\n-\tGET_PCIADDR_FIELD(input, dev_addr->function, UINT8_MAX, 0);\n-\treturn 0;\n-}\n-#undef GET_PCIADDR_FIELD\n+int eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr);\n \n /**\n * Utility function to write a pci device name, this device name can later be\n@@ -205,17 +175,9 @@ eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr)\n * @param size\n *\tThe output buffer size\n */\n-static inline void\n-rte_pci_device_name(const struct rte_pci_addr *addr,\n-\t\tchar *output, size_t size)\n-{\n-\tRTE_VERIFY(size >= PCI_PRI_STR_SIZE);\n-\tRTE_VERIFY(snprintf(output, size, PCI_PRI_FMT,\n-\t\t\t addr->domain, addr->bus,\n-\t\t\t addr->devid, addr->function) >= 0);\n-}\n+void rte_pci_device_name(const struct rte_pci_addr *addr,\n+\t\t\t char *output, size_t size);\n \n-/* Compare two PCI device addresses. */\n /**\n * Utility function to compare two PCI device addresses.\n *\n@@ -228,27 +190,8 @@ rte_pci_device_name(const struct rte_pci_addr *addr,\n *\tPositive on addr is greater than addr2.\n *\tNegative on addr is less than addr2, or error.\n */\n-static inline int\n-rte_eal_compare_pci_addr(const struct rte_pci_addr *addr,\n-\t\t\t const struct rte_pci_addr *addr2)\n-{\n-\tuint64_t dev_addr, dev_addr2;\n-\n-\tif ((addr == NULL) || (addr2 == NULL))\n-\t\treturn -1;\n-\n-\tdev_addr = ((uint64_t)addr->domain << 24) |\n-\t\t(addr->bus << 16) | (addr->devid << 8) | addr->function;\n-\tdev_addr2 = ((uint64_t)addr2->domain << 24) |\n-\t\t(addr2->bus << 16) | (addr2->devid << 8) | addr2->function;\n-\n-\tif (dev_addr > dev_addr2)\n-\t\treturn 1;\n-\telse if (dev_addr < dev_addr2)\n-\t\treturn -1;\n-\telse\n-\t\treturn 0;\n-}\n+int rte_eal_compare_pci_addr(const struct rte_pci_addr *addr,\n+\t\t\t const struct rte_pci_addr *addr2);\n \n /**\n * Map a particular resource from a file.\ndiff --git a/lib/librte_pci/rte_pci.c b/lib/librte_pci/rte_pci.c\nindex 9dfdd3f..8584b55 100644\n--- a/lib/librte_pci/rte_pci.c\n+++ b/lib/librte_pci/rte_pci.c\n@@ -53,6 +53,71 @@\n \n #include \"rte_pci.h\"\n \n+/* Macro used by pci addr parsing functions. **/\n+#define GET_PCIADDR_FIELD(in, fd, lim, dlm) \\\n+do { \\\n+\tunsigned long val; \\\n+\tchar *end; \\\n+\terrno = 0; \\\n+\tval = strtoul((in), &end, 16); \\\n+\tif (errno != 0 || end[0] != (dlm) || val > (lim)) \\\n+\t\treturn -EINVAL; \\\n+\t(fd) = (typeof (fd))val; \\\n+\t(in) = end + 1; \\\n+} while(0)\n+\n+int\n+eal_parse_pci_BDF(const char *input, struct rte_pci_addr *dev_addr)\n+{\n+\tdev_addr->domain = 0;\n+\tGET_PCIADDR_FIELD(input, dev_addr->bus, UINT8_MAX, ':');\n+\tGET_PCIADDR_FIELD(input, dev_addr->devid, UINT8_MAX, '.');\n+\tGET_PCIADDR_FIELD(input, dev_addr->function, UINT8_MAX, 0);\n+\treturn 0;\n+}\n+\n+int\n+eal_parse_pci_DomBDF(const char *input, struct rte_pci_addr *dev_addr)\n+{\n+\tGET_PCIADDR_FIELD(input, dev_addr->domain, UINT16_MAX, ':');\n+\tGET_PCIADDR_FIELD(input, dev_addr->bus, UINT8_MAX, ':');\n+\tGET_PCIADDR_FIELD(input, dev_addr->devid, UINT8_MAX, '.');\n+\tGET_PCIADDR_FIELD(input, dev_addr->function, UINT8_MAX, 0);\n+\treturn 0;\n+}\n+\n+void\n+rte_pci_device_name(const struct rte_pci_addr *addr,\n+\t\t char *output, size_t size)\n+{\n+\tRTE_VERIFY(size >= PCI_PRI_STR_SIZE);\n+\tRTE_VERIFY(snprintf(output, size, PCI_PRI_FMT,\n+\t\t\t addr->domain, addr->bus,\n+\t\t\t addr->devid, addr->function) >= 0);\n+}\n+\n+int\n+rte_eal_compare_pci_addr(const struct rte_pci_addr *addr,\n+\t\t\t const struct rte_pci_addr *addr2)\n+{\n+\tuint64_t dev_addr, dev_addr2;\n+\n+\tif ((addr == NULL) || (addr2 == NULL))\n+\t\treturn -1;\n+\n+\tdev_addr = ((uint64_t)addr->domain << 24) |\n+\t\t(addr->bus << 16) | (addr->devid << 8) | addr->function;\n+\tdev_addr2 = ((uint64_t)addr2->domain << 24) |\n+\t\t(addr2->bus << 16) | (addr2->devid << 8) | addr2->function;\n+\n+\tif (dev_addr > dev_addr2)\n+\t\treturn 1;\n+\telse if (dev_addr < dev_addr2)\n+\t\treturn -1;\n+\telse\n+\t\treturn 0;\n+}\n+\n /* map a particular resource from a file */\n void *\n pci_map_resource(void *requested_addr, int fd, off_t offset, size_t size,\ndiff --git a/lib/librte_pci/rte_pci_version.map b/lib/librte_pci/rte_pci_version.map\nindex 64dec54..a940259 100644\n--- a/lib/librte_pci/rte_pci_version.map\n+++ b/lib/librte_pci/rte_pci_version.map\n@@ -1,8 +1,12 @@\n DPDK_17.11 {\n \tglobal:\n \n+\teal_parse_pci_BDF;\n+\teal_parse_pci_DomBDF;\n \tpci_map_resource;\n \tpci_unmap_resource;\n+\trte_eal_compare_pci_addr;\n+\trte_pci_device_name;\n \n \tlocal: *;\n };\n", "prefixes": [ "dpdk-dev", "v4", "10/16" ] }