Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28657/?format=api
{ "id": 28657, "url": "https://patches.dpdk.org/api/patches/28657/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170913104756.129102-3-shahafs@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170913104756.129102-3-shahafs@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170913104756.129102-3-shahafs@mellanox.com", "date": "2017-09-13T10:47:55", "name": "[dpdk-dev,3/4] net/mlx5: fix Tx stats error counter logic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "666709a89f2a7206d1bca05f16b6bbf20f7c987b", "submitter": { "id": 634, "url": "https://patches.dpdk.org/api/people/634/?format=api", "name": "Shahaf Shuler", "email": "shahafs@mellanox.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170913104756.129102-3-shahafs@mellanox.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/28657/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/28657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6F7651B1BC;\n\tWed, 13 Sep 2017 12:48:11 +0200 (CEST)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur01on0063.outbound.protection.outlook.com [104.47.0.63])\n\tby dpdk.org (Postfix) with ESMTP id 346B91B1B1;\n\tWed, 13 Sep 2017 12:48:09 +0200 (CEST)", "from mellanox.com (82.166.227.17) by\n\tVI1PR05MB3151.eurprd05.prod.outlook.com (2603:10a6:802:1b::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12;\n\tWed, 13 Sep 2017 10:48:06 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=2UIn0FmyZO6vZPypL8FVoxzWa4gyCKy6GTamOSJ+nqw=;\n\tb=POgOl0AnuFTUYi8v5JcNm399HiNBnbFbqGdmWd8Eor4xEdc+ThbRXnGDS9mI3ytWWC7NO201Gw8wbIyPapLLtbNb4o7bLrLoC9sRVHm3/WOqMm66e8ZniShZiRKk/yX+iyJPdvgvSJOV1pcTXVh8W3cDxwuYLttKl3cUWTnTPCo=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=shahafs@mellanox.com; ", "From": "Shahaf Shuler <shahafs@mellanox.com>", "To": "nelio.laranjeiro@6wind.com, yskoh@mellanox.com,\n\tadrien.mazarguil@6wind.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Wed, 13 Sep 2017 13:47:55 +0300", "Message-Id": "<20170913104756.129102-3-shahafs@mellanox.com>", "X-Mailer": "git-send-email 2.12.0", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[82.166.227.17]", "X-ClientProxiedBy": "HE1PR0402CA0047.eurprd04.prod.outlook.com\n\t(2603:10a6:7:7c::36) To VI1PR05MB3151.eurprd05.prod.outlook.com\n\t(2603:10a6:802:1b::16)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "30e3620a-7e4d-49b2-34a4-08d4fa94eb51", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR05MB3151; ", "X-Microsoft-Exchange-Diagnostics": [ "1; VI1PR05MB3151;\n\t3:ak2bvQuirjuINB3tVSBKZ4LzGK5gUIfmRc6M9i4qQ8MJJHXNZt3FfAFQMDV/XhcbL6O1TRzpBaqRqfJRRH7RzTrdw8FEwB1tWyE9dccOkWpOl4dbuTG8jhrCWmGH+hDn+t7vDLo5xaUBnxL1AEJj+lOFF0cRI3xSjkiqXDpAojSI+1DpG19vtiAldGKCU0VcI2ZrQda6cqiQeNeL94aisrELhmxT2G/A2J41/1t4I8h1A/+a0R964kmR86m0bd79;\n\t25:JibTYxBsg9Iw3Vwz3z1UlBa0uoGkqO0ntbc/TEPyTmfHDYAPYYZj0+1Tz3N+vQosI40LDNiUKVcRZgraEQVVIV7mmhwq15JyU5/1RLPRBgpxiCJ2lAAJ24pz7etAdfgmFdx0mQG5KePi40NkDc2FSTL99Wjjr8L/7elH4JAfSNw2akKkcPnG49QrfJQfhbJwo9D715YsYttOlmmjzqsm8G+KKexvmYskSfIlObBaWX6K5WNnruTc+VT5FrCO+HYa9W29U+jvJt7mh2/dMUjWSeeoLjMTkX+cK1o4/USC+fh+8Kd1o5mQpMTbcKFOzVDnwI7GnMGccY629NEnhs0Oqg==;\n\t31:6gMyPPGE7A5KY2uXBU8o1BPdlOMbUTGpQ4PFVRwp5ryWJEEn60TbQB3cJGrWi5Qtd5V8lKviAe/EsnLGIoroelhjgq1whV83Iy71k7V0T+iJ000mXURXnQuztKizmofjp/q5+ZmB6Jpd/5W6RQVLJd+FRioGsARylalo3ufezIkdpS+5KEQ0N8OxQlW+cjtQ7ULXhxfkzgzqJf1Vqbd7h39+ULBumU+hVbyHbVd7B+Y=", "1; VI1PR05MB3151;\n\t20:C4fS+qBnnu4eMvndBSPGFacsz4bnwVuJeZRyu0hzkGFiMKzuWqrGhSVlDzyBh9B21J1ESgM01p0JPWkkCNImjJEh5W48puUggEQLlSrlmoGQto0+9sshxEIjrRRV0qpt+UL0YQEsplQeHFeXHcSHQ8VY5JA2X245PNIO/h49Nv+mteQXx/j9FO3S9xzRjzp6iK/3F4gj6BdGCUQiH152/dOUf2RlkGNgIw62I07Xtrke3PbqW4iMHGLoUDYvubuEjdXNuCYr+uNpMnKPW8Npsi+KqtCgGsiJPUSv21+zp3KSVfmijPIqwmaz+cnKFX7C+nV3uAXBeYaecq0dHfifYMgn9Fruix4RvXz3gEg7R7d8jxXTDOzaEb7lGq6Q14a0JS8UEanm9MobyFqL7yEJXHchETr5TaWuNyiIGH3Ty8PQENL42BgIbV8EdjodczIhAdG9UEeGD82wQjpiQBSr/RpA1rAzGIJqeQpLgTm95Z02hT0MkVFs12N+wTTzMCJQ;\n\t4:yaVMp2rXMKJC7c20HSpRsDOXet9C/7oj/gUrXJoaA74ISAEADg04AcV87S0Ypljb6g1A5lYu/mIzsrfuL3uLhSFTRNScIwf1QyTa87/a4ZoPcF54TtzzNGWO0mqed/6GLzjFeXww3cK6vIhX5hG/Y2cqIQFUErbGqv943qVuSnzwz85YtAJOKwxJOVNM1rZWOXl5eTnrX1IfXZdjGg8Kz7As1wnJwpzxWusLGPPaIFr4cu8Luqk5IEyegtxZsaUX", "=?us-ascii?Q?1; VI1PR05MB3151;\n\t23:Cvdi9ZnsdHHcDNCstEbyyBFB1aJPhz6kGW8O1mnjv?=\n\tfqyrStR8o/43N7KY1MDh6c1bzfZjhc7wPiZ6oFHGZTCBFINvgiAOGo27qLz7oAxDSi31VFCUh3e5cJAT7sgfjZgwJrBqLlg9XRJo/8ctShoMdpfqlyX3KI2QPwVG+TKmr++Y2uD9dMD0i0x44y0ozA9tEy53+G43pWhirMyrVoYkZHbVzUXDBJOk8oMGxK6HSqY2XaKnv4lyvwcpKNl4wWPNL7V8GpIWPSNP/WpFMIlV+9o9A1u/L/5CN5DE52oChdeb8H/xbyRxFkAG5HLLs/05CEYGKhn586hgsE3fwIhBysXPQx/J6Txg/kAMOJji/mzougWgXXgnxhx7OQkjGPGm49Qq6WMI7mIRoNm4mWLCNcuQZfokvKVKNLAK/4XGFoyHDNFGEfXLuosICc28aD3DAJxmgfoFipTuAwFbhA4M3Y9B1WTraaw27opuQMsETkWSOrDfRiH2Udjg8e2/6tv0dtx+kmuCWdRC1R0g2ksLP0mtTryYyRXjkGHopbvg8PC88Mfg1opP8juJYjG33LRzMwdMJLm5mvp13edTQO7AS++QV1zpcq/lWGVOywZ2ydiQfg8JpqEcdi4rvL6gzI1Mh5e9T2W8Wf5h6nMBYGGawwDijoFhaxinGGvInCtDjU9TYUYDMz8IsKw1p4W22Nueumr7z19DKXZ1waBmrARlC+sZRxR2Rkvpng9wuIJLm9m+g01rg88ErsxbNClF+NMG9kZrtmRYPmoN7Zt9r8mgJk3o7/xge3vlFfKq1mK9E3JbujKZr2f0daahq+r2OXjY+TvChxFPsH1wejui+lz7Hckjf14+vN1Gj+vbhKTQZ6t37wMsU3SxIr9vh74nqaGRPsO+fNe2iHwJNc6o5HCf236Wy2pkwIb6duowzbRb3lCt4Koi5uXDjKNUfjDUH4iTEaosvWbBy9wFI4E+cJy2S0QNy3m7l2Ue4f8JHQ2DfC0k1oph5xmfWMMwHhuxtCH+jtOHiBe30dIKdVvovSBDVlisGDPdp5WpnS+7u4qc6VktG99tmbAJjkdWCnw1QReKYOqlavBzrgciRKm1ml+242dHNbSem1DBclLPSuTYRwWnPAKJdAzcs3zrIW1bgYN", "1; VI1PR05MB3151;\n\t6:+/be3zaBSt4kedZDgf9doKL8/Jx45uuIMeY2lbciMRrF/aC8b20+jrIC7GWJUzQibsCW4WTjh7Mv2V3UVS7/DWSF/GWKcqKMkDDum6DpSzaboUOvZycdbzvfJpni5P8FGXvSn0VC6fZmwGIyusCVHG9glnVDnXfgFYuwSxRjId2KPj3dYjiVXJ1421YXI+EjsQeMq/9/ZwhaE85YJiqqRrG4zqTRtHTV8NLnBzDkq1q+HOogQvbOApQwiwJlSXpjNNC0j/WA2GGzYbOQx10yxrtbbtPnjr4ciC1sgB5tJPyq8cninCx6MLlUuLX9UWYp4blVxsvfwuOmJNgagrHUig==;\n\t5:Y4xfERk+Iq4iR90iGL74G46RQ+M76BSIVHNFhxd6PB+VLahjSoK/4WLGhCF3jHjrBEx4tROrGRYDorzR2tUik2e0fcnmmaktRw4zeoFYjU5sLepq3a962OkfIxXURXEkm5GvPn4ctOWUmQ0YdEe6lg==;\n\t24:898O9F9I12Ekme+om/IYWycc3EhaYwIo++OdO2xfcCaMFzp/HPoIOPREltN1fydZWWkUdYBY+c+3WpuPH7Uj17J3HUJ/BGIihviNm0ZCZCo=;\n\t7:s7+Elw7qEqRe5neXPvqzb2m6pEKwMrHd7lO67Y+X+TSFtgWpe84UgjlJ+x0nW06wu87hjYXA6bIqMMerbZNekitZyyjIuZ0zM01f15GxW9PyNZ96yAAKkp7/WR1sxPhE1c8czmQFHEA/0atmekkQxGaAb0z3OPDELW4rEG7If9/I42PCtcD5G0JBX9MSW4D3ru7dtLM5wAkeQ5UKoVleF/sf+k8zn/PHpQJxDFDObzE=" ], "X-MS-TrafficTypeDiagnostic": "VI1PR05MB3151:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Microsoft-Antispam-PRVS": "<VI1PR05MB3151F26872A30607277E8478C36E0@VI1PR05MB3151.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR05MB3151; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR05MB3151; ", "X-Forefront-PRVS": "042957ACD7", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(366002)(376002)(39860400002)(346002)(189002)(199003)(6666003)(110136004)(5003940100001)(4326008)(2906002)(33646002)(50226002)(55016002)(33026002)(305945005)(53936002)(189998001)(97736004)(36756003)(7350300001)(316002)(81156014)(68736007)(5660300001)(81166006)(8676002)(69596002)(50986999)(25786009)(50466002)(105586002)(21086003)(86362001)(48376002)(6116002)(3846002)(7736002)(1076002)(106356001)(101416001)(66066001)(478600001)(47776003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3151; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Sep 2017 10:48:06.5841\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR05MB3151", "Subject": "[dpdk-dev] [PATCH 3/4] net/mlx5: fix Tx stats error counter logic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Tx error counter lacks the logic of incrementation, making it useless for\napplications.\n\nFixes: 87011737b715 (\"mlx5: add software counters\")\nCc: stable@dpdk.org\nCc: adrien.mazarguil@6wind.com\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 20 +++++++++++++++-----\n 1 file changed, 15 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex fe9e7eac0..7567f2329 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -406,8 +406,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n #ifdef MLX5_PMD_SOFT_COUNTERS\n \t\ttotal_length = length;\n #endif\n-\t\tif (length < (MLX5_WQE_DWORD_SIZE + 2))\n+\t\tif (length < (MLX5_WQE_DWORD_SIZE + 2)) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\t/* Update element. */\n \t\t(*txq->elts)[elts_head & elts_m] = buf;\n \t\t/* Prefetch next buffer data. */\n@@ -481,8 +483,10 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\t\t\t\tcs_flags |= MLX5_ETH_WQE_L4_CSUM;\n \t\t\t\t}\n \t\t\t\tif (unlikely(tso_header_sz >\n-\t\t\t\t\t MLX5_MAX_TSO_HEADER))\n+\t\t\t\t\t MLX5_MAX_TSO_HEADER)) {\n+\t\t\t\t\ttxq->stats.oerrors++;\n \t\t\t\t\tbreak;\n+\t\t\t\t}\n \t\t\t\tcopy_b = tso_header_sz - pkt_inline_sz;\n \t\t\t\t/* First seg must contain all headers. */\n \t\t\t\tassert(copy_b <= length);\n@@ -843,8 +847,10 @@ mlx5_tx_burst_mpw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\tif (max_elts < segs_n)\n \t\t\tbreak;\n \t\t/* Do not bother with large packets MPW cannot handle. */\n-\t\tif (segs_n > MLX5_MPW_DSEG_MAX)\n+\t\tif (segs_n > MLX5_MPW_DSEG_MAX) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\tmax_elts -= segs_n;\n \t\t--pkts_n;\n \t\t/* Should we enable HW CKSUM offload */\n@@ -1064,8 +1070,10 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,\n \t\tif (max_elts < segs_n)\n \t\t\tbreak;\n \t\t/* Do not bother with large packets MPW cannot handle. */\n-\t\tif (segs_n > MLX5_MPW_DSEG_MAX)\n+\t\tif (segs_n > MLX5_MPW_DSEG_MAX) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\tmax_elts -= segs_n;\n \t\t--pkts_n;\n \t\t/*\n@@ -1353,8 +1361,10 @@ mlx5_tx_burst_empw(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\tif (max_elts - j < segs_n)\n \t\t\tbreak;\n \t\t/* Do not bother with large packets MPW cannot handle. */\n-\t\tif (segs_n > MLX5_MPW_DSEG_MAX)\n+\t\tif (segs_n > MLX5_MPW_DSEG_MAX) {\n+\t\t\ttxq->stats.oerrors++;\n \t\t\tbreak;\n+\t\t}\n \t\t/* Should we enable HW CKSUM offload. */\n \t\tif (buf->ol_flags &\n \t\t (PKT_TX_IP_CKSUM | PKT_TX_TCP_CKSUM | PKT_TX_UDP_CKSUM))\n", "prefixes": [ "dpdk-dev", "3/4" ] }