Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 28087,
    "url": "https://patches.dpdk.org/api/patches/28087/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1504116634-115687-4-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1504116634-115687-4-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1504116634-115687-4-git-send-email-jianfeng.tan@intel.com",
    "date": "2017-08-30T18:10:31",
    "name": "[dpdk-dev,3/6] xen: remove xen dependency in app, examples, test",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "cbc434a4c520dd59c562fbd63fcaf1fcb2607bc4",
    "submitter": {
        "id": 313,
        "url": "https://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1504116634-115687-4-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/28087/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/28087/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C86A7374F;\n\tWed, 30 Aug 2017 20:09:49 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id CA0612C02\n\tfor <dev@dpdk.org>; Wed, 30 Aug 2017 20:09:46 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga105.jf.intel.com with ESMTP; 30 Aug 2017 11:09:46 -0700",
            "from dpdk06.sh.intel.com ([10.67.110.196])\n\tby orsmga002.jf.intel.com with ESMTP; 30 Aug 2017 11:09:44 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.41,449,1498546800\"; d=\"scan'208\";a=\"130029481\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "xen-devel@lists.xenproject.org, thomas@monjalon.net,\n\tjohn.mcnamara@intel.com, oao.m.martins@oracle.com,\n\tjerin.jacob@caviumnetworks.com, shahafs@mellanox.com,\n\tJianfeng Tan <jianfeng.tan@intel.com>",
        "Date": "Wed, 30 Aug 2017 18:10:31 +0000",
        "Message-Id": "<1504116634-115687-4-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1504116634-115687-1-git-send-email-jianfeng.tan@intel.com>",
        "References": "<1504116634-115687-1-git-send-email-jianfeng.tan@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, \n\ttest",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n app/test-pmd/testpmd.c              |  2 +-\n examples/ip_pipeline/app.h          |  4 --\n examples/ip_pipeline/config_parse.c | 19 ---------\n examples/ip_pipeline/init.c         |  5 ---\n examples/kni/main.c                 |  3 --\n test/test/process.h                 | 10 -----\n test/test/test.c                    |  4 --\n test/test/test_eal_flags.c          | 81 -------------------------------------\n 8 files changed, 1 insertion(+), 127 deletions(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex f8d02ae..d9c785c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -494,7 +494,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,\n \t\t\"create a new mbuf pool <%s>: n=%u, size=%u, socket=%u\\n\",\n \t\tpool_name, nb_mbuf, mbuf_seg_size, socket_id);\n \n-\t/* if the former XEN allocation failed fall back to normal allocation */\n+\t/* if the former allocation failed fall back to normal allocation */\n \tif (rte_mp == NULL) {\n \t\tif (mp_anon != 0) {\n \t\t\trte_mp = rte_mempool_create_empty(pool_name, nb_mbuf,\ndiff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h\nindex e41290e..94e7a6d 100644\n--- a/examples/ip_pipeline/app.h\n+++ b/examples/ip_pipeline/app.h\n@@ -428,10 +428,6 @@ struct app_eal_params {\n \t/* Interrupt mode for VFIO (legacy|msi|msix) */\n \tchar *vfio_intr;\n \n-\t/* Support running on Xen dom0 without hugetlbfs */\n-\tuint32_t xen_dom0_present;\n-\tint xen_dom0;\n-\n \tuint32_t parsed;\n };\n \ndiff --git a/examples/ip_pipeline/config_parse.c b/examples/ip_pipeline/config_parse.c\nindex 0b76134..3211c6a 100644\n--- a/examples/ip_pipeline/config_parse.c\n+++ b/examples/ip_pipeline/config_parse.c\n@@ -809,21 +809,6 @@ parse_eal(struct app_params *app,\n \t\t\tcontinue;\n \t\t}\n \n-\t\t/* xen_dom0 */\n-\t\tif (strcmp(entry->name, \"xen_dom0\") == 0) {\n-\t\t\tint val;\n-\n-\t\t\tPARSE_ERROR_DUPLICATE((p->xen_dom0_present == 0),\n-\t\t\t\tsection_name,\n-\t\t\t\tentry->name);\n-\t\t\tp->xen_dom0_present = 1;\n-\n-\t\t\tval = parser_read_arg_bool(entry->value);\n-\t\t\tPARSE_ERROR((val >= 0), section_name, entry->name);\n-\t\t\tp->xen_dom0 = val;\n-\t\t\tcontinue;\n-\t\t}\n-\n \t\t/* unrecognized */\n \t\tPARSE_ERROR_INVALID(0, section_name, entry->name);\n \t}\n@@ -2643,10 +2628,6 @@ save_eal_params(struct app_params *app, FILE *f)\n \tif (p->vfio_intr)\n \t\tfprintf(f, \"%s = %s\\n\", \"vfio_intr\", p->vfio_intr);\n \n-\tif (p->xen_dom0_present)\n-\t\tfprintf(f, \"%s = %s\\n\", \"xen_dom0\",\n-\t\t\t(p->xen_dom0) ? \"yes\" : \"no\");\n-\n \tfputc('\\n', f);\n }\n \ndiff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c\nindex 7cde49a..034c238 100644\n--- a/examples/ip_pipeline/init.c\n+++ b/examples/ip_pipeline/init.c\n@@ -296,11 +296,6 @@ app_init_eal(struct app_params *app)\n \t\tapp->eal_argv[n_args++] = strdup(buffer);\n \t}\n \n-\tif ((p->xen_dom0_present) && (p->xen_dom0)) {\n-\t\tsnprintf(buffer, sizeof(buffer), \"--xen-dom0\");\n-\t\tapp->eal_argv[n_args++] = strdup(buffer);\n-\t}\n-\n \tsnprintf(buffer, sizeof(buffer), \"--\");\n \tapp->eal_argv[n_args++] = strdup(buffer);\n \ndiff --git a/examples/kni/main.c b/examples/kni/main.c\nindex e3bc2fb..9f9d227 100644\n--- a/examples/kni/main.c\n+++ b/examples/kni/main.c\n@@ -919,9 +919,6 @@ main(int argc, char** argv)\n \t\t\tcontinue;\n \t\tkni_free_kni(port);\n \t}\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\trte_kni_close();\n-#endif\n \tfor (i = 0; i < RTE_MAX_ETHPORTS; i++)\n \t\tif (kni_port_params_array[i]) {\n \t\t\trte_free(kni_port_params_array[i]);\ndiff --git a/test/test/process.h b/test/test/process.h\nindex 4f8d121..51ced12 100644\n--- a/test/test/process.h\n+++ b/test/test/process.h\n@@ -52,11 +52,7 @@ static inline int\n process_dup(const char *const argv[], int numargs, const char *env_value)\n {\n \tint num;\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\tchar *argv_cpy[numargs + 2];\n-#else\n \tchar *argv_cpy[numargs + 1];\n-#endif\n \tint i, fd, status;\n \tchar path[32];\n \n@@ -67,14 +63,8 @@ process_dup(const char *const argv[], int numargs, const char *env_value)\n \t\t/* make a copy of the arguments to be passed to exec */\n \t\tfor (i = 0; i < numargs; i++)\n \t\t\targv_cpy[i] = strdup(argv[i]);\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\t\targv_cpy[i] = strdup(\"--xen-dom0\");\n-\t\targv_cpy[i + 1] = NULL;\n-\t\tnum = numargs + 1;\n-#else\n \t\targv_cpy[i] = NULL;\n \t\tnum = numargs;\n-#endif\n \n \t\t/* close all open file descriptors, check /proc/self/fd to only\n \t\t * call close on open fds. Exclude fds 0, 1 and 2*/\ndiff --git a/test/test/test.c b/test/test/test.c\nindex c561eb5..9accbd1 100644\n--- a/test/test/test.c\n+++ b/test/test/test.c\n@@ -87,11 +87,7 @@ do_recursive_call(void)\n \t\t\t{ \"test_invalid_b_flag\", no_action },\n \t\t\t{ \"test_invalid_vdev_flag\", no_action },\n \t\t\t{ \"test_invalid_r_flag\", no_action },\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\t\t\t{ \"test_dom0_misc_flags\", no_action },\n-#else\n \t\t\t{ \"test_misc_flags\", no_action },\n-#endif\n \t\t\t{ \"test_memory_flags\", no_action },\n \t\t\t{ \"test_file_prefix\", no_action },\n \t\t\t{ \"test_no_huge_flag\", no_action },\ndiff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c\nindex 594d79d..310109e 100644\n--- a/test/test/test_eal_flags.c\n+++ b/test/test/test_eal_flags.c\n@@ -51,11 +51,7 @@\n \n #include \"process.h\"\n \n-#ifdef RTE_LIBRTE_XEN_DOM0\n-#define DEFAULT_MEM_SIZE \"30\"\n-#else\n #define DEFAULT_MEM_SIZE \"18\"\n-#endif\n #define mp_flag \"--proc-type=secondary\"\n #define no_hpet \"--no-hpet\"\n #define no_huge \"--no-huge\"\n@@ -809,72 +805,6 @@ test_no_huge_flag(void)\n \treturn 0;\n }\n \n-#ifdef RTE_LIBRTE_XEN_DOM0\n-static int\n-test_dom0_misc_flags(void)\n-{\n-\tchar prefix[PATH_MAX], tmp[PATH_MAX];\n-\n-\tif (get_current_prefix(tmp, sizeof(tmp)) == NULL) {\n-\t\tprintf(\"Error - unable to get current prefix!\\n\");\n-\t\treturn -1;\n-\t}\n-\tsnprintf(prefix, sizeof(prefix), \"--file-prefix=%s\", tmp);\n-\n-\t/* check that some general flags don't prevent things from working.\n-\t * All cases, apart from the first, app should run.\n-\t * No further testing of output done.\n-\t */\n-\t/* sanity check - failure with invalid option */\n-\tconst char *argv0[] = {prgname, prefix, mp_flag, \"-c\", \"1\", \"--invalid-opt\"};\n-\n-\t/* With --no-pci */\n-\tconst char *argv1[] = {prgname, prefix, mp_flag, \"-c\", \"1\", \"--no-pci\"};\n-\t/* With -v */\n-\tconst char *argv2[] = {prgname, prefix, mp_flag, \"-c\", \"1\", \"-v\"};\n-\t/* With valid --syslog */\n-\tconst char *argv3[] = {prgname, prefix, mp_flag, \"-c\", \"1\",\n-\t\t\t\"--syslog\", \"syslog\"};\n-\t/* With empty --syslog (should fail) */\n-\tconst char *argv4[] = {prgname, prefix, mp_flag, \"-c\", \"1\", \"--syslog\"};\n-\t/* With invalid --syslog */\n-\tconst char *argv5[] = {prgname, prefix, mp_flag, \"-c\", \"1\", \"--syslog\", \"error\"};\n-\t/* With no-sh-conf */\n-\tconst char *argv6[] = {prgname, \"-c\", \"1\", \"-n\", \"2\", \"-m\", \"20\",\n-\t\t\t\"--no-shconf\", \"--file-prefix=noshconf\" };\n-\n-\tif (launch_proc(argv0) == 0) {\n-\t\tprintf(\"Error - process ran ok with invalid flag\\n\");\n-\t\treturn -1;\n-\t}\n-\tif (launch_proc(argv1) != 0) {\n-\t\tprintf(\"Error - process did not run ok with --no-pci flag\\n\");\n-\t\treturn -1;\n-\t}\n-\tif (launch_proc(argv2) != 0) {\n-\t\tprintf(\"Error - process did not run ok with -v flag\\n\");\n-\t\treturn -1;\n-\t}\n-\tif (launch_proc(argv3) != 0) {\n-\t\tprintf(\"Error - process did not run ok with --syslog flag\\n\");\n-\t\treturn -1;\n-\t}\n-\tif (launch_proc(argv4) == 0) {\n-\t\tprintf(\"Error - process run ok with empty --syslog flag\\n\");\n-\t\treturn -1;\n-\t}\n-\tif (launch_proc(argv5) == 0) {\n-\t\tprintf(\"Error - process run ok with invalid --syslog flag\\n\");\n-\t\treturn -1;\n-\t}\n-\tif (launch_proc(argv6) != 0) {\n-\t\tprintf(\"Error - process did not run ok with --no-shconf flag\\n\");\n-\t\treturn -1;\n-\t}\n-\n-\treturn 0;\n-}\n-#else\n static int\n test_misc_flags(void)\n {\n@@ -1061,7 +991,6 @@ test_misc_flags(void)\n \t}\n \treturn 0;\n }\n-#endif\n \n static int\n test_file_prefix(void)\n@@ -1098,9 +1027,6 @@ test_file_prefix(void)\n \t\tprintf(\"Error - unable to get current prefix!\\n\");\n \t\treturn -1;\n \t}\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\treturn 0;\n-#endif\n \n \t/* check if files for current prefix are present */\n \tif (process_hugefiles(prefix, HUGEPAGE_CHECK_EXISTS) != 1) {\n@@ -1299,9 +1225,6 @@ test_memory_flags(void)\n \t\tprintf(\"Error - process failed with valid -m flag!\\n\");\n \t\treturn -1;\n \t}\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\treturn 0;\n-#endif\n \tif (launch_proc(argv2) == 0) {\n \t\tprintf(\"Error - process run ok with invalid (zero) --socket-mem!\\n\");\n \t\treturn -1;\n@@ -1427,11 +1350,7 @@ test_eal_flags(void)\n \t\treturn ret;\n \t}\n \n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\tret = test_dom0_misc_flags();\n-#else\n \tret = test_misc_flags();\n-#endif\n \tif (ret < 0) {\n \t\tprintf(\"Error in test_misc_flags()\");\n \t\treturn ret;\n",
    "prefixes": [
        "dpdk-dev",
        "3/6"
    ]
}