Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27321/?format=api
{ "id": 27321, "url": "https://patches.dpdk.org/api/patches/27321/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/e312a557643ac0819284b5e0db5773599cef66f2.1501598384.git.adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e312a557643ac0819284b5e0db5773599cef66f2.1501598384.git.adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e312a557643ac0819284b5e0db5773599cef66f2.1501598384.git.adrien.mazarguil@6wind.com", "date": "2017-08-01T16:53:56", "name": "[dpdk-dev,v1,09/48] net/mlx4: remove Tx inline compilation option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b293114afe3fe306aecfcb28a7aacf5ecd7935d", "submitter": { "id": 165, "url": "https://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/e312a557643ac0819284b5e0db5773599cef66f2.1501598384.git.adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/27321/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/27321/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9FFC0A0F0;\n\tTue, 1 Aug 2017 18:55:17 +0200 (CEST)", "from mail-wm0-f54.google.com (mail-wm0-f54.google.com\n\t[74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 30BDE9B93\n\tfor <dev@dpdk.org>; Tue, 1 Aug 2017 18:55:02 +0200 (CEST)", "by mail-wm0-f54.google.com with SMTP id t138so34935205wmt.1\n\tfor <dev@dpdk.org>; Tue, 01 Aug 2017 09:55:02 -0700 (PDT)", "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t90sm29602058wrk.38.2017.08.01.09.55.01\n\tfor <dev@dpdk.org> (version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tTue, 01 Aug 2017 09:55:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=QlRnwehP8sbYYbrwZODZ6RITawam+Vl3knz+KxNuAWA=;\n\tb=tpn6uR0n4yV8mjSAWjYfNjDUpdyTyOYaKM1Gf7llWokT6xlOwOkSRJQnaSu1FKXXND\n\tN8ezG22jdC/cftDN+PjacaJ/h/BR+P1Tjew/Bncm4ly/NxIcBJZFkcK1tBQpKDDOTOso\n\tfclSgeGQqK2UonrCRLkbKo2TffKJMjL9rRy9LFaiP7mgJFhLvVVALNiIpl5ySLSRa+Ii\n\tpAB7AlYaU7lgHUH1UO1DosW59U8t9EsOZwbOAfq2tHhGEO87WZBiAZIED8IIhTi8TcfF\n\t2s5X9fsoi1PGtKXNSrbFAsKwfxb9ahE2mxB23uanq31cxSErn4hnKrULQq4Bhg4/IBJW\n\tB5SA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=QlRnwehP8sbYYbrwZODZ6RITawam+Vl3knz+KxNuAWA=;\n\tb=tfmc1wk6Yez6hjxLzJJnPH4DC3I8fpZS5jS3zZ83KWsugkVPkQ4My6NawnFZ1RjnZw\n\t2rVSBIrj2NQN1uN+WxHh1tQc1nxQOy5fefCwqil0sQ8zX63FJfiyuJR5Qk0AEstDjIAP\n\tqFbYPzpgRK8S8Jt56Pf7jOwRQ4YnHzYpy32vHWkRPhZdWGyXAVHElAqkJB63uBj8b4a2\n\tVkqzAlSeWfOhAcsyN20T8TE2QkRv+3jK4F0JMaVH9vsr/sSRGRaSjczjA47bi3SUAhe/\n\t2LvJ21H8gwy0y04vuKk4h1b+XYgbj/rSHz4lKi+Hv/zN8pqf3J30OD8nVoL55mN05EXD\n\t07yg==", "X-Gm-Message-State": "AIVw110B9dXYc/LOCKfZOvPwGPjNm/MTQBrgs/houbYPG1h88nKUT13Q\n\thh/TyInHm5ZIDLgTAfQ=", "X-Received": "by 10.28.98.137 with SMTP id w131mr1823589wmb.158.1501606502410; \n\tTue, 01 Aug 2017 09:55:02 -0700 (PDT)", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "dev@dpdk.org", "Date": "Tue, 1 Aug 2017 18:53:56 +0200", "Message-Id": "<e312a557643ac0819284b5e0db5773599cef66f2.1501598384.git.adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<cover.1501598383.git.adrien.mazarguil@6wind.com>", "References": "<cover.1501598383.git.adrien.mazarguil@6wind.com>", "Subject": "[dpdk-dev] [PATCH v1 09/48] net/mlx4: remove Tx inline compilation\n\toption", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This should be a run-time parameter.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n config/common_base | 1 -\n drivers/net/mlx4/Makefile | 4 ----\n drivers/net/mlx4/mlx4.c | 6 ------\n drivers/net/mlx4/mlx4.h | 4 ----\n 4 files changed, 15 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex 2520bd1..b6e322c 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -213,7 +213,6 @@ CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y\n #\n CONFIG_RTE_LIBRTE_MLX4_PMD=n\n CONFIG_RTE_LIBRTE_MLX4_DEBUG=n\n-CONFIG_RTE_LIBRTE_MLX4_MAX_INLINE=0\n CONFIG_RTE_LIBRTE_MLX4_TX_MP_CACHE=8\n \n #\ndiff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile\nindex a9c44ca..8406ba2 100644\n--- a/drivers/net/mlx4/Makefile\n+++ b/drivers/net/mlx4/Makefile\n@@ -68,10 +68,6 @@ else\n CFLAGS += -DNDEBUG -UPEDANTIC\n endif\n \n-ifdef CONFIG_RTE_LIBRTE_MLX4_MAX_INLINE\n-CFLAGS += -DMLX4_PMD_MAX_INLINE=$(CONFIG_RTE_LIBRTE_MLX4_MAX_INLINE)\n-endif\n-\n ifdef CONFIG_RTE_LIBRTE_MLX4_TX_MP_CACHE\n CFLAGS += -DMLX4_PMD_TX_MP_CACHE=$(CONFIG_RTE_LIBRTE_MLX4_TX_MP_CACHE)\n endif\ndiff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 6dd0863..d00ddc6 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -1428,7 +1428,6 @@ mlx4_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\t\t\t\t (uintptr_t)addr);\n \t\t\tRTE_MBUF_PREFETCH_TO_FREE(elt_next->buf);\n \t\t\t/* Put packet into send queue. */\n-#if MLX4_PMD_MAX_INLINE > 0\n \t\t\tif (length <= txq->max_inline)\n \t\t\t\terr = txq->if_qp->send_pending_inline\n \t\t\t\t\t(txq->qp,\n@@ -1436,7 +1435,6 @@ mlx4_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\t\t\t\t length,\n \t\t\t\t\t send_flags);\n \t\t\telse\n-#endif\n \t\t\t\terr = txq->if_qp->send_pending\n \t\t\t\t\t(txq->qp,\n \t\t\t\t\t addr,\n@@ -1578,9 +1576,7 @@ txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc,\n \t\t\t\t\t MLX4_PMD_SGE_WR_N) ?\n \t\t\t\t\t priv->device_attr.max_sge :\n \t\t\t\t\t MLX4_PMD_SGE_WR_N),\n-#if MLX4_PMD_MAX_INLINE > 0\n \t\t\t.max_inline_data = MLX4_PMD_MAX_INLINE,\n-#endif\n \t\t},\n \t\t.qp_type = IBV_QPT_RAW_PACKET,\n \t\t/* Do *NOT* enable this, completions events are managed per\n@@ -1598,10 +1594,8 @@ txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc,\n \t\t (void *)dev, strerror(ret));\n \t\tgoto error;\n \t}\n-#if MLX4_PMD_MAX_INLINE > 0\n \t/* ibv_create_qp() updates this value. */\n \ttmpl.max_inline = attr.init.cap.max_inline_data;\n-#endif\n \tattr.mod = (struct ibv_exp_qp_attr){\n \t\t/* Move the QP to this state. */\n \t\t.qp_state = IBV_QPS_INIT,\ndiff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h\nindex 785b2ac..469ab4b 100644\n--- a/drivers/net/mlx4/mlx4.h\n+++ b/drivers/net/mlx4/mlx4.h\n@@ -84,9 +84,7 @@\n #define MLX4_PMD_SGE_WR_N 4\n \n /* Maximum size for inline data. */\n-#ifndef MLX4_PMD_MAX_INLINE\n #define MLX4_PMD_MAX_INLINE 0\n-#endif\n \n /*\n * Maximum number of cached Memory Pools (MPs) per TX queue. Each RTE MP\n@@ -261,9 +259,7 @@ struct txq {\n \tstruct ibv_qp *qp; /* Queue Pair. */\n \tstruct ibv_exp_qp_burst_family *if_qp; /* QP burst interface. */\n \tstruct ibv_exp_cq_family *if_cq; /* CQ interface. */\n-#if MLX4_PMD_MAX_INLINE > 0\n \tuint32_t max_inline; /* Max inline send size <= MLX4_PMD_MAX_INLINE. */\n-#endif\n \tunsigned int elts_n; /* (*elts)[] length. */\n \tstruct txq_elt (*elts)[]; /* TX elements. */\n \tunsigned int elts_head; /* Current index in (*elts)[]. */\n", "prefixes": [ "dpdk-dev", "v1", "09/48" ] }