Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26040/?format=api
{ "id": 26040, "url": "https://patches.dpdk.org/api/patches/26040/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170629113521.5560-27-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170629113521.5560-27-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170629113521.5560-27-pablo.de.lara.guarch@intel.com", "date": "2017-06-29T11:35:21", "name": "[dpdk-dev,v3,26/26] cryptodev: remove AAD from authentication structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c4b0489a72c2b97a2c92301096715532f274b5c7", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "https://patches.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170629113521.5560-27-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/26040/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/26040/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7EE7C7D0D;\n\tThu, 29 Jun 2017 21:36:52 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 53D847CC2\n\tfor <dev@dpdk.org>; Thu, 29 Jun 2017 21:36:13 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jun 2017 12:36:12 -0700", "from silpixa00399464.ir.intel.com (HELO\n\tsilpixa00399464.ger.corp.intel.com) ([10.237.222.157])\n\tby FMSMGA003.fm.intel.com with ESMTP; 29 Jun 2017 12:36:10 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,282,1496127600\"; d=\"scan'208\";a=\"873176762\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com, zbigniew.bodek@caviumnetworks.com,\n\tjerin.jacob@caviumnetworks.com, akhil.goyal@nxp.com,\n\themant.agrawal@nxp.com, fiona.trahe@intel.com, john.griffin@intel.com,\n\tdeepak.k.jain@intel.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Thu, 29 Jun 2017 12:35:21 +0100", "Message-Id": "<20170629113521.5560-27-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170629113521.5560-1-pablo.de.lara.guarch@intel.com>", "References": "<20170626102300.56637-1-pablo.de.lara.guarch@intel.com>\n\t<20170629113521.5560-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 26/26] cryptodev: remove AAD from\n\tauthentication structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now that AAD is only used in AEAD algorithms,\nthere is no need to keep AAD in the authentication\nstructure.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n app/test-crypto-perf/cperf_ops.c | 2 --\n doc/guides/prog_guide/cryptodev_lib.rst | 6 ------\n doc/guides/rel_notes/release_17_08.rst | 3 +++\n drivers/crypto/openssl/rte_openssl_pmd.c | 1 -\n lib/librte_cryptodev/rte_crypto_sym.h | 26 --------------------------\n test/test/test_cryptodev.c | 4 ----\n test/test/test_cryptodev_perf.c | 1 -\n 7 files changed, 3 insertions(+), 40 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c\nindex a63fd83..8407503 100644\n--- a/app/test-crypto-perf/cperf_ops.c\n+++ b/app/test-crypto-perf/cperf_ops.c\n@@ -425,7 +425,6 @@ cperf_create_session(uint8_t dev_id,\n \t\t\t\t\ttest_vector->auth_iv.length;\n \t\t} else {\n \t\t\tauth_xform.auth.digest_length = 0;\n-\t\t\tauth_xform.auth.add_auth_data_length = 0;\n \t\t\tauth_xform.auth.key.length = 0;\n \t\t\tauth_xform.auth.key.data = NULL;\n \t\t\tauth_xform.auth.iv.length = 0;\n@@ -478,7 +477,6 @@ cperf_create_session(uint8_t dev_id,\n \t\t\t\t\ttest_vector->auth_key.data;\n \t\t} else {\n \t\t\tauth_xform.auth.digest_length = 0;\n-\t\t\tauth_xform.auth.add_auth_data_length = 0;\n \t\t\tauth_xform.auth.key.length = 0;\n \t\t\tauth_xform.auth.key.data = NULL;\n \t\t\tauth_xform.auth.iv.length = 0;\ndiff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst\nindex 5048839..f250c00 100644\n--- a/doc/guides/prog_guide/cryptodev_lib.rst\n+++ b/doc/guides/prog_guide/cryptodev_lib.rst\n@@ -567,12 +567,6 @@ chain.\n uint8_t *data;\n phys_addr_t phys_addr;\n } digest; /**< Digest parameters */\n-\n- struct {\n- uint8_t *data;\n- phys_addr_t phys_addr;\n- } aad;\n- /**< Additional authentication parameters */\n } auth;\n };\n };\ndiff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst\nindex 2c6bef5..d29b203 100644\n--- a/doc/guides/rel_notes/release_17_08.rst\n+++ b/doc/guides/rel_notes/release_17_08.rst\n@@ -176,6 +176,9 @@ API Changes\n * Changed field size of digest length in ``rte_crypto_auth_xform``,\n from uint32_t to uint16_t.\n * Added AEAD structure in ``rte_crypto_sym_op``.\n+ * Removed AAD length from ``rte_crypto_auth_xform``.\n+ * Removed AAD pointer and physical address from auth structure\n+ in ``rte_crypto_sym_op``.\n \n \n ABI Changes\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex 7f5c6aa..73e7ff1 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -413,7 +413,6 @@ openssl_set_session_auth_parameters(struct openssl_session *sess,\n \t\treturn -EINVAL;\n \t}\n \n-\tsess->auth.aad_length = xform->auth.add_auth_data_length;\n \tsess->auth.digest_length = xform->auth.digest_length;\n \n \treturn 0;\ndiff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h\nindex dab042b..742dc34 100644\n--- a/lib/librte_cryptodev/rte_crypto_sym.h\n+++ b/lib/librte_cryptodev/rte_crypto_sym.h\n@@ -326,13 +326,6 @@ struct rte_crypto_auth_xform {\n \t * the result shall be truncated.\n \t */\n \n-\tuint16_t add_auth_data_length;\n-\t/**< The length of the additional authenticated data (AAD) in bytes.\n-\t * The maximum permitted value is 65535 (2^16 - 1) bytes, unless\n-\t * otherwise specified below.\n-\t *\n-\t */\n-\n \tstruct {\n \t\tuint16_t offset;\n \t\t/**< Starting point for Initialisation Vector or Counter,\n@@ -670,25 +663,6 @@ struct rte_crypto_sym_op {\n \t\t\t\t\tphys_addr_t phys_addr;\n \t\t\t\t\t/**< Physical address of digest */\n \t\t\t\t} digest; /**< Digest parameters */\n-\n-\t\t\t\tstruct {\n-\t\t\t\t\tuint8_t *data;\n-\t\t\t\t\t/**< Pointer to Additional Authenticated\n-\t\t\t\t\t * Data (AAD) needed for authenticated cipher\n-\t\t\t\t\t * mechanisms (CCM and GCM).\n-\t\t\t\t\t *\n-\t\t\t\t\t * The length of the data pointed to by this\n-\t\t\t\t\t * field is set up for the session in the @ref\n-\t\t\t\t\t * rte_crypto_auth_xform structure as part of\n-\t\t\t\t\t * the @ref rte_cryptodev_sym_session_create\n-\t\t\t\t\t * function call.\n-\t\t\t\t\t * This length must not exceed 65535 (2^16-1)\n-\t\t\t\t\t * bytes.\n-\t\t\t\t\t *\n-\t\t\t\t\t */\n-\t\t\t\t\tphys_addr_t phys_addr;\t/**< physical address */\n-\t\t\t\t} aad;\n-\t\t\t\t/**< Additional authentication parameters */\n \t\t\t} auth;\n \t\t};\n \t};\ndiff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c\nindex 21c6270..db0999e 100644\n--- a/test/test/test_cryptodev.c\n+++ b/test/test/test_cryptodev.c\n@@ -5530,7 +5530,6 @@ static int MD5_HMAC_create_session(struct crypto_testsuite_params *ts_params,\n \tut_params->auth_xform.auth.algo = RTE_CRYPTO_AUTH_MD5_HMAC;\n \n \tut_params->auth_xform.auth.digest_length = MD5_DIGEST_LEN;\n-\tut_params->auth_xform.auth.add_auth_data_length = 0;\n \tut_params->auth_xform.auth.key.length = test_case->key.len;\n \tut_params->auth_xform.auth.key.data = key;\n \n@@ -6303,7 +6302,6 @@ static int create_gmac_session(uint8_t dev_id,\n \tut_params->auth_xform.auth.algo = RTE_CRYPTO_AUTH_AES_GMAC;\n \tut_params->auth_xform.auth.op = auth_op;\n \tut_params->auth_xform.auth.digest_length = tdata->gmac_tag.len;\n-\tut_params->auth_xform.auth.add_auth_data_length = 0;\n \tut_params->auth_xform.auth.key.length = tdata->key.len;\n \tut_params->auth_xform.auth.key.data = auth_key;\n \tut_params->auth_xform.auth.iv.offset = IV_OFFSET;\n@@ -6683,7 +6681,6 @@ create_auth_session(struct crypto_unittest_params *ut_params,\n \tut_params->auth_xform.auth.key.length = reference->auth_key.len;\n \tut_params->auth_xform.auth.key.data = auth_key;\n \tut_params->auth_xform.auth.digest_length = reference->digest.len;\n-\tut_params->auth_xform.auth.add_auth_data_length = reference->aad.len;\n \n \t/* Create Crypto session*/\n \tut_params->sess = rte_cryptodev_sym_session_create(dev_id,\n@@ -6721,7 +6718,6 @@ create_auth_cipher_session(struct crypto_unittest_params *ut_params,\n \t\tut_params->auth_xform.auth.iv.length = reference->iv.len;\n \t} else {\n \t\tut_params->auth_xform.next = &ut_params->cipher_xform;\n-\t\tut_params->auth_xform.auth.add_auth_data_length = reference->aad.len;\n \n \t\t/* Setup Cipher Parameters */\n \t\tut_params->cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;\ndiff --git a/test/test/test_cryptodev_perf.c b/test/test/test_cryptodev_perf.c\nindex 5b2468d..7ae1ae9 100644\n--- a/test/test/test_cryptodev_perf.c\n+++ b/test/test/test_cryptodev_perf.c\n@@ -2936,7 +2936,6 @@ test_perf_set_crypto_op_aes(struct rte_crypto_op *op, struct rte_mbuf *m,\n \tif (chain == CIPHER_ONLY) {\n \t\top->sym->auth.digest.data = NULL;\n \t\top->sym->auth.digest.phys_addr = 0;\n-\t\top->sym->auth.aad.data = NULL;\n \t\top->sym->auth.data.offset = 0;\n \t\top->sym->auth.data.length = 0;\n \t} else {\n", "prefixes": [ "dpdk-dev", "v3", "26/26" ] }