Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/23979/?format=api
{ "id": 23979, "url": "https://patches.dpdk.org/api/patches/23979/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1493327571-48435-1-git-send-email-jyu@vmware.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1493327571-48435-1-git-send-email-jyu@vmware.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1493327571-48435-1-git-send-email-jyu@vmware.com", "date": "2017-04-27T21:12:51", "name": "[dpdk-dev] ixgbe: check scatter_enable in set_mtu", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "99431c0457f76f778b05cbcdcfa95d9e266b5312", "submitter": { "id": 111, "url": "https://patches.dpdk.org/api/people/111/?format=api", "name": "Jia Yu", "email": "jyu@vmware.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1493327571-48435-1-git-send-email-jyu@vmware.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/23979/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/23979/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3462737B2;\n\tThu, 27 Apr 2017 23:29:04 +0200 (CEST)", "from EX13-EDG-OU-001.vmware.com (ex13-edg-ou-001.vmware.com\n\t[208.91.0.189]) by dpdk.org (Postfix) with ESMTP id 921B22935\n\tfor <dev@dpdk.org>; Thu, 27 Apr 2017 23:29:02 +0200 (CEST)", "from sc9-mailhost3.vmware.com (10.113.161.73) by\n\tEX13-EDG-OU-001.vmware.com (10.113.208.155) with Microsoft SMTP\n\tServer id 15.0.1156.6; Thu, 27 Apr 2017 14:27:10 -0700", "from localhost.localdomain (sc2-edge-ivybridge-13.eng.vmware.com\n\t[10.172.139.176])\n\tby sc9-mailhost3.vmware.com (Postfix) with ESMTP id B723940347;\n\tThu, 27 Apr 2017 14:29:01 -0700 (PDT)" ], "From": "Jia Yu <jyu@vmware.com>", "To": "<wenzhuo.lu@intel.com>, <konstantin.ananyev@intel.com>", "CC": "<dev@dpdk.org>, Jia Yu <jyu@vmware.com>", "Date": "Thu, 27 Apr 2017 14:12:51 -0700", "Message-ID": "<1493327571-48435-1-git-send-email-jyu@vmware.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain", "Received-SPF": "None (EX13-EDG-OU-001.vmware.com: jyu@vmware.com does not\n\tdesignate permitted sender hosts)", "Subject": "[dpdk-dev] [PATCH] ixgbe: check scatter_enable in set_mtu", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There exists case that software sets mtu (i.e jumbo frame) of\nixgbe device when it's stopped. Before the fix, scattered_rx\nis cleared during device stop, and setting jumbo frame mtu\nafter device stop will always fail as scattered_rx is 0.\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 7b856bb..aa5ba8c 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -4671,6 +4671,7 @@ ixgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \tstruct ixgbe_hw *hw;\n \tstruct rte_eth_dev_info dev_info;\n \tuint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;\n+\tstruct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;\n \n \tixgbe_dev_info_get(dev, &dev_info);\n \n@@ -4681,7 +4682,7 @@ ixgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t/* refuse mtu that requires the support of scattered packets when this\n \t * feature has not been enabled before.\n \t */\n-\tif (!dev->data->scattered_rx &&\n+\tif (!rx_conf->enable_scatter &&\n \t (frame_size + 2 * IXGBE_VLAN_TAG_SIZE >\n \t dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM))\n \t\treturn -EINVAL;\n@@ -5939,6 +5940,7 @@ ixgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n {\n \tstruct ixgbe_hw *hw;\n \tuint32_t max_frame = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;\n+\tstruct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;\n \n \thw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -5948,7 +5950,7 @@ ixgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n \t/* refuse mtu that requires the support of scattered packets when this\n \t * feature has not been enabled before.\n \t */\n-\tif (!dev->data->scattered_rx &&\n+\tif (!rx_conf->enable_scatter &&\n \t (max_frame + 2 * IXGBE_VLAN_TAG_SIZE >\n \t dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM))\n \t\treturn -EINVAL;\n", "prefixes": [ "dpdk-dev" ] }