Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23948,
    "url": "https://patches.dpdk.org/api/patches/23948/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1493278539-44617-2-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1493278539-44617-2-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1493278539-44617-2-git-send-email-jianfeng.tan@intel.com",
    "date": "2017-04-27T07:35:36",
    "name": "[dpdk-dev,v2,1/4] net/virtio: fix wrong MSI-X for modern devices",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8372061aaff7e3ea2c1d9fa8a45a7dc479afb343",
    "submitter": {
        "id": 313,
        "url": "https://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "https://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1493278539-44617-2-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/23948/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/23948/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0DE54CF9C;\n\tThu, 27 Apr 2017 09:34:59 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id CB183CF66;\n\tThu, 27 Apr 2017 09:34:53 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga104.jf.intel.com with ESMTP; 27 Apr 2017 00:34:53 -0700",
            "from dpdk06.sh.intel.com ([10.239.129.195])\n\tby orsmga002.jf.intel.com with ESMTP; 27 Apr 2017 00:34:51 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.37,257,1488873600\"; d=\"scan'208\";a=\"79495846\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com,\n\tthomas@monjalon.net, Jianfeng Tan <jianfeng.tan@intel.com>,\n\tstable@dpdk.org",
        "Date": "Thu, 27 Apr 2017 07:35:36 +0000",
        "Message-Id": "<1493278539-44617-2-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1493278539-44617-1-git-send-email-jianfeng.tan@intel.com>",
        "References": "<1493182371-34295-1-git-send-email-jianfeng.tan@intel.com>\n\t<1493278539-44617-1-git-send-email-jianfeng.tan@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 1/4] net/virtio: fix wrong MSI-X for modern\n\tdevices",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The field, use_msix, in struct virtio_hw is not updated for modern\ndevice, and is always zero. And now we depend on the status feature\nand MSI-X to report LSC support (which is also not a correct\nbehavior). As a result, LSC is always disabled for modern devices.\n\nTe fix this, we just recognize MSI-X capability when going through\ncapability list, and update the info in virtio.\n\nFixes: 6ba1f63b5ab0 (\"virtio: support specification 1.0\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/net/virtio/virtio_pci.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex b767c03..ecad46e 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -50,6 +50,7 @@\n  */\n #define PCI_CAPABILITY_LIST\t0x34\n #define PCI_CAP_ID_VNDR\t\t0x09\n+#define PCI_CAP_ID_MSIX\t\t0x11\n \n /*\n  * The remaining space is defined by each driver as the per-driver\n@@ -650,6 +651,9 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n \t\t\tbreak;\n \t\t}\n \n+\t\tif (cap.cap_vndr == PCI_CAP_ID_MSIX)\n+\t\t\thw->use_msix = 1;\n+\n \t\tif (cap.cap_vndr != PCI_CAP_ID_VNDR) {\n \t\t\tPMD_INIT_LOG(DEBUG,\n \t\t\t\t\"[%2x] skipping non VNDR cap id: %02x\",\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "1/4"
    ]
}