Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/23322/?format=api
{ "id": 23322, "url": "https://patches.dpdk.org/api/patches/23322/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com", "date": "2017-04-07T11:02:05", "name": "[dpdk-dev,v3] ether: use a default for max Rx frame size in configure()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e542a13d8bc7f4b2e216dadbe3a7c9b26ea8ec7c", "submitter": { "id": 708, "url": "https://patches.dpdk.org/api/people/708/?format=api", "name": "Andriy Berestovskyy", "email": "Andriy.Berestovskyy@caviumnetworks.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/23322/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/23322/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D1194326C;\n\tFri, 7 Apr 2017 13:02:36 +0200 (CEST)", "from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam01on0079.outbound.protection.outlook.com [104.47.32.79])\n\tby dpdk.org (Postfix) with ESMTP id 3C7A02BD1\n\tfor <dev@dpdk.org>; Fri, 7 Apr 2017 13:02:35 +0200 (CEST)", "from b.semihalf.local (31.172.191.173) by\n\tSN2PR0701MB1039.namprd07.prod.outlook.com (10.160.58.146) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1005.10; Fri, 7 Apr 2017 11:02:32 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=pX7CUS0m+HtoY6ixZloW7zK4hpZpB9YaVsHiZnsO6Xk=;\n\tb=FwAOpCxf9EU1Kfi62bo0/RNW9EvY+fAmKyeUI/gHP4Z7VzJQaSEh9ajBt6IOyZurLpm9R53ZJtHa7DtgVKmO5jJLXB0W2KN0UfOi18mWmjO4eSIfJMEsz+Gf00zdYOXC81EoyIlFzA6LvwRQaIXnXo5V+gtcS0ef/G9AS9R3TPM=", "Authentication-Results": "6wind.com; dkim=none (message not signed)\n\theader.d=none;6wind.com; dmarc=none action=none\n\theader.from=caviumnetworks.com;", "From": "Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 7 Apr 2017 13:02:05 +0200", "Message-Id": "<1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com>", "References": "<1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[31.172.191.173]", "X-ClientProxiedBy": "HE1PR0202CA0006.eurprd02.prod.outlook.com (10.168.182.16)\n\tTo SN2PR0701MB1039.namprd07.prod.outlook.com\n\t(10.160.58.146)", "X-MS-Office365-Filtering-Correlation-Id": "5c590ffd-6111-413a-500e-08d47da59768", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(201703131423075)(201703031133081); SRVR:SN2PR0701MB1039;", "X-Microsoft-Exchange-Diagnostics": [ "1; SN2PR0701MB1039;\n\t3:QEmK2PxUcL7h33eCufGxPP0USHUdgnROZ2fvfQl1AfVxaLx5r1z1BAUuR23upCUryFSuejAiicWHUMA1vUP3E8EqMnatdokpLxTYuZQMV7dgx5qYN1TB8ZZ5GH0o6x6sw3vbAXAuqItSVy51LoyG2mDUeZzAVDvLROAd2RMLx2kCpBRPIONNbTD0bVY3CdCxl/cv7Xmb9iSs/NbGxPHsnq/8WXMOTZUIWg7I8plkazrfdd/0ZyBvsbrH12SmbQQo/hdOScUaLPKFMOIdBIWgd3AORqNGvl6xAYQzUBDUQtQ3hU16S8iSZ9lK8yKqCr98043h+29UZHrQS47PRCMOhw==;\n\t25:GbFOfQX+tpIOpSB3kEtLaqeX+77MXN23BVO/NmWyZITrqen0Qm2sUwK1t/TrgNYIPbEGNaGbxljFNUwYqEb0STLvlECAwISGLPmBRwJ669xemClqQ4AhxK0wFEfU91cTUWZZhjL95WgCWu0R1w5245ZxegN9ebPyDjB32QrCDogGv/M5EWsfjegytJ8NnpB3/TYfucEesUvKdO1xbIhyK+Xjagcjsyu0Oh8884w+Bmxq9LPM6FUsRtLWL1kV77OMfXrYxL/+5ptytYkx/zUUXJOhfccjs0zXRvtnwHsvvZpb5q46tLVBKI/ebjh857mY7vZnYn/4EMl/O72XH6tKbuiinYh0cgk1H53OSp8gkV9YcatmwsjLCIZbNoRiwwPmJEP6a+87CgWVdownaN2GM3VmTh6rnk/UwBdV7eEZWew6uzZk4U+KBHcGSfcbeiDWe6Bx4xd5mpS/3M3pNQDrUQ==", "1; SN2PR0701MB1039;\n\t31:K2nDvi21aJzXwZktIDA8kiVkMmtGUd0YjWl8PUMTlCiY7AKa4wH2eyez0go7v67uLIWxrQh1rJFp6J0+o3KJpAdNGm8NH7INrHWl7fbm24nhEB/wykar4ARaqyCHod40F+pCCFVh9/FDM+crMsqbjhZcGoTiaQ9bSIseJfQcd1QZBbEEtTXSoSRUGU7ijOjF8jEyMGdsfuwATYT+EgQUo1fjswRj6CXAca/lsyTQJbEnvpPsLQKrCCiYjNN6fzlyyISe7czVsqwvkjo1uLgRs+GG9xY2UxYD0wkTBSFZxhw=;\n\t20:KA8BiwHjmDvuWddkQ29N1TV8G+CgUwcSwTsLGi0qdq9A0fjJps2ZrNCz2Bgt+EyUax0ROEt6e5wsLPL1J+86erHPVRGlXg+q8vTqOZI7nq0D3fSM7gD9qtjChm3eTR3BAId5z9tVyiAwqjrUpwwM8+1gER4+Zg1v5X0m/0OkijreUZbn0/rCZ0rarE2Dx6bNqMExeHjMAypj8GyPaAgVYP6xkOnNZyG60G/njbafPMdCI+xKE5i447WIYhX6eRhtzvO/+EYLHsGK1DYlX5ZA9YkryCUX2KSrkbcxf/izHr0SMOj/KGuJk1iGcnQHYPv+Q7CMC76tNq07e+csQBV5TELkZhurb4UIZXc4Krh1Imf1RVoO63WV9RvGU4z7tSKsWBoI6sKBSb2bD97CjxcJtfDBNn/F7/AHlEsOlCOxdbcoTwz8X/6omx01gziAsziD4KjcjLlI/TSahoFItUvc3lZGBR3ErtorCrhFDLgqmZOMzx9S93FNI6QYyamRPRlYWiVFWTczyY5nIcg9IHGqzwkHOFEKv7FscVa2ys/gHaCH29eRNS7hPy6COxP9k0skBs9gb7xVpFLMnSs2IfRylGihtO6kGOrvF23NufQKWMw=", "1; SN2PR0701MB1039;\n\t4:Unz5/fj28eYts0dD/2bpQ7IAUbmYWb8bY5EPloN9u3pS17QgIsZQgJjLVerh6R2Q2gqiiH/PVyCD60LykND4AHpxCS6x0wZFphyM3LQaSAIVRV3C8ADB6t4sohaf5jKgwTNOYnNxfNyrtDAXCp3sQw3a8L/N8FCvBZM2+C8MdmD+fsw83NzoFccU1rjEXdXLh8GLviKuEJvZveZ3QS+vAYzCtpTtqoPaAszRNa33MkMbuT+AM9Myfq7w7SsCgl/loziZTIEx5WPafRDkbMxcK46jbxOO9uoZzQIQXXMIwXVJFWOqQPtA67g0RETku3vUMJBPhYkGxPonTrZPXvWGjjsXLR6ngYUV4sBozT7C/ToGbiMwMC1DXy/TOy3eRA7BgA0vVFBQEqdizBcPN6NyxvC7IplqMHN1m+wWjYV+QL0ylKRu2Vgak3uvJfFlXZ+WO+ZBYJMPufLsBog6FdXou18TekURDR/I8kJUEoJBijYmQNWuyk/qqo3jd+cHk69o38mjjqrXbRw66Xpd6doMHf4COjpL619LycqRz+Mfsh8mD3pr9p6hgZ/dotfCgIZudsGC1ESA4xQbEVzIAJHW+3bJns7v1hDJKmCWBUlD9TN6NOznyW6mDuDnp3UEtoP/+W8obNeHeEqc5cipucg4Cj4646R5cac2L3KaD/nMwQtj7B5+K+JSeY3ptSM2G/4o", "=?us-ascii?Q?1; SN2PR0701MB1039;\n\t23:tzwQcl8TtUy7qFq3CBw9/H9+9w7EoWAoH3KS/AH?=\n\tEH99js9D6QAavoyr6Aku0AnBUZqDlwyacmbc9FansADSRsmyGcuqn+mliC3v4o77tnl3s5ifRaujGtCC+XmjoGrp8YYKff1l4CnYtbpG1pbw/EhkmMxURKBifbjT7A9Y1MIGRd54kDLjpptbRegnLGsfpWT95ZR9TYqJHlexMFleG+Gi+xaxP2MlQRaiZMw7zvXwQG9l6M7oDtHSMgkhLudZN32pFBCLWqwwzxDp8qK0uuZ33nQcB1nnRIjjh4IBpViDimpdKwJHw3o3NJZajrcCVkFPS6qcgL2T20h3DgK5cG5CJ5U3wdvvSlHisaS5bV+t6DF4PVJlVS4IueX73PPL4eRO+VehGYievGZz5uAiiKG0mLPV8wK2gWMImAVl+AnT5ctaMQHspjZfPoIb/+mDt/iUokHw5IAY4dFLtjg69mza3pxSHf70yuCJhcYNZyj8ztiV8zNBj7red8DUqAiRb/lb+CdLGSRSiFoX4SUecDcXdplsPRNoeUMA9SOE1My5uX4pQ6XpyEZtlv1hggzAaFxixW1hTv0S5xYC3KkUo+S1iii5xNnJbuUtOdk7niHyDMnQMuZfH2O5PIwVwh5PpDvh23lHzjag5bqFN7z9M8wlNM4+pLUctC2XEXGrqxL1x1ruoOMRKyJX6jYjfbJzfq1cMMx5TspBJCF2WpFTaHkK2eYVxGt5J6YWSzlyntfFOOZoJXiJ3FLrizcW03oLmaB3Vx26bjR50+tgWte3CTi2i8+22LVllIBUPT4bual9BtqM200tPGjESje5VnfG3WD+oNwoo+kZoMlaFQ4kSgzhkAVa2Z8ZUlf+aadNd+THIytTLx6w14YRldAcjcl5GmgOcDcpjmC+VdcBX4W5vkikZG5ojbKg57yDe3aJ+pSvklxfc72rD2G757hZ3+vEBe+tyW3cfaYS5oMZJ6ZrjhL/T5q5PaHFlliEXfRHFMPY=", "1; SN2PR0701MB1039;\n\t6:6OUCOuvQ2uyhXf58bqaGoG7rfKnG6hztW2/oMhHD5a0n0m+GBhBEH2v2Wi4DwHDl8UsfwlKCxD5TYOBCUcS1rJ6jBKgf/8WqKffJ0sYGUknGLG8oOX4UZ4u5vprXArwAjJcGLV3uJghu7rM9SblV7bOdLyiiQ0YqFqDoBczH/yqXAT9wLboTpGiSELBk97Y1vJn/ksfd0UfBBTWY3ZRqFD9G5unLVzWBv+0I0BWZK8DQWl8M3RJZpokUaL44eriLtcApNsGW6dEXTXyaAT4AwMVPhfzXdxQbi6H/Ft4F0IMiN+dt0dmGgev3CaJuGLLGPjFhzy1BTJLhM3AipB6xyFslpJ+hMydc3mT0GV0OOlhn75Z1hiCA1a54zXRfn3g0IKHUVQecZpdtzEMx2P4pWNwwNphjEDVMctBpMnOBLFn0i0eS+G6AbuVhNqPvkCFVYk/XFAyAry9bmdQZGbByEA==;\n\t5:3VL+rv0FG9MYlC36NCPsO67KMu7XDKaWZmcNaGa+YEX96QWS/1KvEIzGvz1m5l+FJKDv4vciPuHFmwEk+YGWJRdM37tHrnEcyzcjVKPHZ1C0ADw3tKzthF78Kd5QbGwP0vmcEgdJEl0QxoQ3tdbA8g==;\n\t24:sB/11pBz04LRF8n26YzmRDLPsfSWLOEustWHTfkzi/p2jR5VpMpVZgdfcvwS1JCN+BVdaiaYUxDF4bd2negNv/1L2MrO+urjlFrx6fsC36Q=", "1; SN2PR0701MB1039;\n\t7:cPJJJxC/6c3rRlRRK78Szg5BYfKASdQsB7X702RN6cAwRJY1HQezX6hEILuLVpLiFsi8XQD+0o8Jjx6EHLUJgAnNDtqlBWfydfByVWhlfp51KPykOjFYHrTnBlpdAcawYlQNmDVomr2Bb5RWWKHWTUivH1cp/T2g2nSj2Foh8a6AmZC3kGN+3it5pTBZrgGjxWfPBzsT3fcPiQHKEG1wniC0aJ96s2tI1mekJkOlU2n8ccuv7gS1qGkUC+0wOclm8MZ07yTLJNpi2ontXNq/Fs9dlodj4v8IZ2uaYVQRBI8BiLnwkEE+BDOQENTF2B4TkAfwS33Cf5ES8LAb5PY6mQ==" ], "X-Microsoft-Antispam-PRVS": "<SN2PR0701MB1039775FC921A6CAD1058AF7810C0@SN2PR0701MB1039.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123564025)(20161123560025)(6072148);\n\tSRVR:SN2PR0701MB1039; BCL:0; PCL:0; RULEID:; SRVR:SN2PR0701MB1039; ", "X-Forefront-PRVS": "0270ED2845", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(4630300001)(6009001)(39850400002)(39410400002)(39450400003)(39400400002)(39840400002)(6486002)(48376002)(6116002)(3846002)(53936002)(8676002)(110136004)(38730400002)(81166006)(5003940100001)(42186005)(25786009)(50466002)(66066001)(189998001)(50226002)(4326008)(47776003)(2950100002)(42882006)(6916009)(6666003)(5660300001)(2906002)(6506006)(6512007)(50986999)(36756003)(76176999)(7736002)(305945005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR0701MB1039; H:b.semihalf.local;\n\tFPR:; SPF:None; MLV:sfv; LANG:en; ", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "caviumnetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Apr 2017 11:02:32.1858\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN2PR0701MB1039", "Subject": "[dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in\n\tconfigure()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "At the moment rte_eth_dev_configure() behaves inconsistent:\n - for normal frames: zero max_rx_pkt_len uses a default\n - for jumbo frames: zero max_rx_pkt_len gives an error\n\nThis patch fixes this inconsistency by using a default value\nif max_rx_pkt_len is zero both for normal and jumbo frames.\n\nSigned-off-by: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>\n---\n\nNotes:\n v3 changes:\n - use a default only if max_rx_pkt_len is zero\n \n v2 changes:\n - reword the commit title according to the check-git-log.sh\n\n lib/librte_ether/rte_ethdev.c | 23 ++++++++++++-----------\n lib/librte_ether/rte_ethdev.h | 2 +-\n 2 files changed, 13 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 4e1e6dc..2700c69 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -790,6 +790,7 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n {\n \tstruct rte_eth_dev *dev;\n \tstruct rte_eth_dev_info dev_info;\n+\tuint32_t max_len;\n \tint diag;\n \n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);\n@@ -858,17 +859,23 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t}\n \n \t/*\n-\t * If jumbo frames are enabled, check that the maximum RX packet\n-\t * length is supported by the configured device.\n+\t * Check that the maximum RX packet length is supported\n+\t * by the configured device.\n \t */\n \tif (dev_conf->rxmode.jumbo_frame == 1) {\n-\t\tif (dev_conf->rxmode.max_rx_pkt_len >\n-\t\t dev_info.max_rx_pktlen) {\n+\t\tmax_len = dev_info.max_rx_pktlen;\n+\t} else {\n+\t\tmax_len = ETHER_MAX_LEN;\n+\t}\n+\tif (dev_conf->rxmode.max_rx_pkt_len == 0) {\n+\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len = max_len;\n+\t} else {\n+\t\tif (dev_conf->rxmode.max_rx_pkt_len > max_len) {\n \t\t\tRTE_PMD_DEBUG_TRACE(\"ethdev port_id=%d max_rx_pkt_len %u\"\n \t\t\t\t\" > max valid value %u\\n\",\n \t\t\t\tport_id,\n \t\t\t\t(unsigned)dev_conf->rxmode.max_rx_pkt_len,\n-\t\t\t\t(unsigned)dev_info.max_rx_pktlen);\n+\t\t\t\t(unsigned int)max_len);\n \t\t\treturn -EINVAL;\n \t\t} else if (dev_conf->rxmode.max_rx_pkt_len < ETHER_MIN_LEN) {\n \t\t\tRTE_PMD_DEBUG_TRACE(\"ethdev port_id=%d max_rx_pkt_len %u\"\n@@ -878,12 +885,6 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t\t\t(unsigned)ETHER_MIN_LEN);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t} else {\n-\t\tif (dev_conf->rxmode.max_rx_pkt_len < ETHER_MIN_LEN ||\n-\t\t\tdev_conf->rxmode.max_rx_pkt_len > ETHER_MAX_LEN)\n-\t\t\t/* Use default value */\n-\t\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len =\n-\t\t\t\t\t\t\tETHER_MAX_LEN;\n \t}\n \n \t/*\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex d072538..ea760dc 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -349,7 +349,7 @@ enum rte_eth_tx_mq_mode {\n struct rte_eth_rxmode {\n \t/** The multi-queue packet distribution mode to be used, e.g. RSS. */\n \tenum rte_eth_rx_mq_mode mq_mode;\n-\tuint32_t max_rx_pkt_len; /**< Only used if jumbo_frame enabled. */\n+\tuint32_t max_rx_pkt_len; /**< If zero, use a default packet length. */\n \tuint16_t split_hdr_size; /**< hdr buf size (header_split enabled).*/\n \t__extension__\n \tuint16_t header_split : 1, /**< Header Split enable. */\n", "prefixes": [ "dpdk-dev", "v3" ] }