Patch Comment List
List patch comments
GET /api/patches/23/comments/?format=api
[ { "id": 1577, "web_url": "https://patches.dpdk.org/comment/1577/", "msgid": "<9BB6961774997848B5B42BEC655768F8B07D44@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9BB6961774997848B5B42BEC655768F8B07D44@SHSMSX104.ccr.corp.intel.com", "date": "2014-10-11T08:31:16", "subject": "Re: [dpdk-dev] [PATCH] i40e: warnings should include i40e in\n\tsome\texample applications", "submitter": { "id": 47, "url": "https://patches.dpdk.org/api/people/47/?format=api", "name": "Jingjing Wu", "email": "jingjing.wu@intel.com" }, "content": "Acked-by: Jingjing Wu <jingjing.wu@intel.com>\n\n> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang\n> Sent: Thursday, July 3, 2014 3:55 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH] i40e: warnings should include i40e in some example applications\n> \n> As i40e introduced recently in DPDK, the warnings should include\n> i40e when no supported NIC port found during initialization at\n> least in below example applications.\n> * app/testpmd\n> * exception_path\n> * kni\n> \n> Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n> ---\n> app/test-pmd/testpmd.c | 3 ++-\n> examples/exception_path/main.c | 5 +++--\n> examples/kni/main.c | 5 +++--\n> 3 files changed, 8 insertions(+), 5 deletions(-)\n> \n> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\n> index e8a4b45..0c0ac77 100644\n> --- a/app/test-pmd/testpmd.c\n> +++ b/app/test-pmd/testpmd.c\n> @@ -1859,7 +1859,8 @@ main(int argc, char** argv)\n> \t\t\t\t\t\t\t\"check that \"\n> \t\t\t \"CONFIG_RTE_LIBRTE_IGB_PMD=y and that \"\n> \t\t\t \"CONFIG_RTE_LIBRTE_EM_PMD=y and that \"\n> -\t\t\t \"CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your \"\n> +\t\t\t \"CONFIG_RTE_LIBRTE_IXGBE_PMD=y and that \"\n> +\t\t\t \"CONFIG_RTE_LIBRTE_I40E_PMD=y in your \"\n> \t\t\t \"configuration file\\n\");\n> \n> \tset_def_fwd_config();\n> diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c\n> index 0204116..c4245a3 100644\n> --- a/examples/exception_path/main.c\n> +++ b/examples/exception_path/main.c\n> @@ -575,8 +575,9 @@ main(int argc, char** argv)\n> \tnb_sys_ports = rte_eth_dev_count();\n> \tif (nb_sys_ports == 0)\n> \t\tFATAL_ERROR(\"No supported Ethernet devices found - check that \"\n> -\t\t \"CONFIG_RTE_LIBRTE_IGB_PMD=y and/or \"\n> -\t\t \"CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\");\n> +\t\t \"CONFIG_RTE_LIBRTE_IGB_PMD=y, \"\n> +\t\t \"CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or \"\n> +\t\t\t \"CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file\");\n> \t/* Find highest port set in portmask */\n> \tfor (high_port = (sizeof(ports_mask) * 8) - 1;\n> \t\t\t(high_port != 0) && !(ports_mask & (1 << high_port));\n> diff --git a/examples/kni/main.c b/examples/kni/main.c\n> index 7df1b36..f3666e2 100644\n> --- a/examples/kni/main.c\n> +++ b/examples/kni/main.c\n> @@ -898,8 +898,9 @@ main(int argc, char** argv)\n> \tnb_sys_ports = rte_eth_dev_count();\n> \tif (nb_sys_ports == 0)\n> \t\trte_exit(EXIT_FAILURE, \"No supported Ethernet devices found - \"\n> -\t\t\t\"check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or \"\n> -\t\t\t\"CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\\n\");\n> +\t\t\t\"check that CONFIG_RTE_LIBRTE_IGB_PMD=y, \"\n> +\t\t\t\"CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or \"\n> +\t\t\t\"CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file\\n\");\n> \n> \t/* Check if the configured port ID is valid */\n> \tfor (i = 0; i < RTE_MAX_ETHPORTS; i++)\n> --\n> 1.8.1.4", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A27B28AF0;\n\tSat, 11 Oct 2014 10:23:51 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id F285B8AEF\n\tfor <dev@dpdk.org>; Sat, 11 Oct 2014 10:23:49 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 11 Oct 2014 01:31:19 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n\tby fmsmga001.fm.intel.com with ESMTP; 11 Oct 2014 01:31:18 -0700", "from fmsmsx156.amr.corp.intel.com (10.18.116.74) by\n\tFMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Sat, 11 Oct 2014 01:31:18 -0700", "from shsmsx152.ccr.corp.intel.com (10.239.6.52) by\n\tfmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Sat, 11 Oct 2014 01:31:18 -0700", "from shsmsx104.ccr.corp.intel.com ([169.254.5.230]) by\n\tSHSMSX152.ccr.corp.intel.com ([169.254.6.190]) with mapi id\n\t14.03.0195.001; Sat, 11 Oct 2014 16:31:16 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,697,1406617200\"; d=\"scan'208\";a=\"603793089\"", "From": "\"Wu, Jingjing\" <jingjing.wu@intel.com>", "To": "\"Zhang, Helin\" <helin.zhang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] i40e: warnings should include i40e in some\n\texample applications", "Thread-Index": "AQHPlpQ2B53pX04bzkqKI/UWhSse65wrLdnA", "Date": "Sat, 11 Oct 2014 08:31:16 +0000", "Message-ID": "<9BB6961774997848B5B42BEC655768F8B07D44@SHSMSX104.ccr.corp.intel.com>", "References": "<1404374093-29710-1-git-send-email-helin.zhang@intel.com>", "In-Reply-To": "<1404374093-29710-1-git-send-email-helin.zhang@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] i40e: warnings should include i40e in\n\tsome\texample applications", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2452, "web_url": "https://patches.dpdk.org/comment/2452/", "msgid": "<2198476.pCE1W7mTMz@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2198476.pCE1W7mTMz@xps13", "date": "2014-11-07T12:48:28", "subject": "Re: [dpdk-dev] [PATCH] i40e: warnings should include i40e in some\n\texample applications", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-07-03 15:54, Helin Zhang:\n> As i40e introduced recently in DPDK, the warnings should include\n> i40e when no supported NIC port found during initialization at\n> least in below example applications.\n> * app/testpmd\n> * exception_path\n> * kni\n> \n> Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n\nI think it's better to remove these warnings.\nI am going to send a patch. Please ack if you agree.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E95FC7F39;\n\tFri, 7 Nov 2014 13:39:19 +0100 (CET)", "from mail-wg0-f49.google.com (mail-wg0-f49.google.com\n\t[74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 0E1827F34\n\tfor <dev@dpdk.org>; Fri, 7 Nov 2014 13:39:18 +0100 (CET)", "by mail-wg0-f49.google.com with SMTP id x13so3595722wgg.22\n\tfor <dev@dpdk.org>; Fri, 07 Nov 2014 04:48:49 -0800 (PST)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\ts2sm1952574wia.3.2014.11.07.04.48.46 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 07 Nov 2014 04:48:47 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=h0ppRpjlfo0T1+baQ+xCuLI7M/I1fYh8kOWUt09FuTI=;\n\tb=QLxmjxWXgoQu+LwWs/yvBX3OqQ8O7NAb1G4pb+22NhWWYBs7AeAPSaFcIPRPPUqyHZ\n\t9p2vC129aIL2cImW3dRgvnGlFVLWjLf8H3IvQialFZijgMvEKrLfVJ4vK67tX5BCyM+R\n\t0F4LOrKbRerdkbaGxeRNMN0GONQxpN2nz0cFveqD4+CocwJ8pxHvylcDf5LmGr1vJtWL\n\tpX4Q+52jsVRarWLlUQwH5zpbOASaOP/u1lGsZ9BDT2LaD0sACrGGl9VPNs/0DqWgsT6F\n\ta8liPpXAeBcg5FUMEk4Bm8J8Y49oJDNArsmZwQHR0XZJXHs4YAQ4wXMujJPmiIkoLXF4\n\txTUg==", "X-Gm-Message-State": "ALoCoQkwSOIj5JhMmV3k+8Hxybtnneti5d5U3QBsMNFdL/LZmvoO3mt2DwY69CejZAqy/qRRLwdj", "X-Received": "by 10.180.101.102 with SMTP id ff6mr4938351wib.0.1415364527886; \n\tFri, 07 Nov 2014 04:48:47 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Helin Zhang <helin.zhang@intel.com>", "Date": "Fri, 07 Nov 2014 13:48:28 +0100", "Message-ID": "<2198476.pCE1W7mTMz@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )", "In-Reply-To": "<1404374093-29710-1-git-send-email-helin.zhang@intel.com>", "References": "<1404374093-29710-1-git-send-email-helin.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] i40e: warnings should include i40e in some\n\texample applications", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]