Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 22481,
    "url": "https://patches.dpdk.org/api/patches/22481/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20170328034903.41482-23-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170328034903.41482-23-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170328034903.41482-23-ajit.khaparde@broadcom.com",
    "date": "2017-03-28T03:48:57",
    "name": "[dpdk-dev,22/28] bnxt: Add newlines to all RTE_LOG() format strings",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "cd9adb280f64ab3873b8314e59f19272d8935304",
    "submitter": {
        "id": 501,
        "url": "https://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20170328034903.41482-23-ajit.khaparde@broadcom.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/22481/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/22481/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A0044D25B;\n\tTue, 28 Mar 2017 05:50:15 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (lpdvrndsmtp01.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 6B4B82C1A\n\tfor <dev@dpdk.org>; Tue, 28 Mar 2017 05:49:21 +0200 (CEST)",
            "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n\t[10.75.224.233])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 7381C30CD10;\n\tMon, 27 Mar 2017 20:49:20 -0700 (PDT)",
            "from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.10.115.230])\n\tby mail-irv-17.broadcom.com (Postfix) with ESMTP id C3CFB81E9F;\n\tMon, 27 Mar 2017 20:49:19 -0700 (PDT)"
        ],
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hurd <stephen.hurd@broadcom.com>",
        "Date": "Mon, 27 Mar 2017 22:48:57 -0500",
        "Message-Id": "<20170328034903.41482-23-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.10.1 (Apple Git-78)",
        "In-Reply-To": "<20170328034903.41482-1-ajit.khaparde@broadcom.com>",
        "References": "<20170328034903.41482-1-ajit.khaparde@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH 22/28] bnxt: Add newlines to all RTE_LOG() format\n\tstrings",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add newline to the RTE_LOG() messages for better readability.\n\nSigned-off-by: Stephen Hurd <stephen.hurd@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----\n drivers/net/bnxt/bnxt_filter.c |  2 +-\n drivers/net/bnxt/bnxt_irq.c    |  2 +-\n drivers/net/bnxt/bnxt_ring.c   |  2 +-\n drivers/net/bnxt/bnxt_rxq.c    |  7 ++++---\n drivers/net/bnxt/bnxt_vnic.c   |  2 +-\n 6 files changed, 13 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7bbda68..ee13ed6 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -881,7 +881,7 @@ static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev,\n \t\t}\n \t\tif (hash_types) {\n \t\t\tRTE_LOG(ERR, PMD,\n-\t\t\t\t\"Unknwon RSS config from firmware (%08x), RSS disabled\",\n+\t\t\t\t\"Unknwon RSS config from firmware (%08x), RSS disabled\\n\",\n \t\t\t\tvnic->hash_type);\n \t\t\treturn -ENOTSUP;\n \t\t}\n@@ -1071,7 +1071,7 @@ bnxt_udp_tunnel_port_del_op(struct rte_eth_dev *eth_dev,\n \t\tport = bp->geneve_fw_dst_port_id;\n \t\tbreak;\n \tdefault:\n-\t\tRTE_LOG(ERR, PMD, \"Tunnel type is not supported\");\n+\t\tRTE_LOG(ERR, PMD, \"Tunnel type is not supported\\n\");\n \t\treturn -ENOTSUP;\n \t}\n \n@@ -1181,7 +1181,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \tint rc;\n \n \tif (version_printed++ == 0)\n-\t\tRTE_LOG(INFO, PMD, \"%s\", bnxt_version);\n+\t\tRTE_LOG(INFO, PMD, \"%s\\n\", bnxt_version);\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n \teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n@@ -1231,7 +1231,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\t\t\tETHER_ADDR_LEN * MAX_NUM_MAC_ADDR, 0);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tRTE_LOG(ERR, PMD,\n-\t\t\t\"Failed to alloc %u bytes needed to store MAC addr tbl\",\n+\t\t\t\"Failed to alloc %u bytes needed to store MAC addr tbl\\n\",\n \t\t\tETHER_ADDR_LEN * MAX_NUM_MAC_ADDR);\n \t\trc = -ENOMEM;\n \t\tgoto error_free;\n@@ -1275,7 +1275,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \trc = bnxt_hwrm_func_driver_register(bp);\n \tif (rc) {\n \t\tRTE_LOG(ERR, PMD,\n-\t\t\t\"Failed to register driver\");\n+\t\t\t\"Failed to register driver\\n\");\n \t\trc = -EBUSY;\n \t\tgoto error_free;\n \t}\ndiff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c\nindex 137c7b7..efadc0c 100644\n--- a/drivers/net/bnxt/bnxt_filter.c\n+++ b/drivers/net/bnxt/bnxt_filter.c\n@@ -145,7 +145,7 @@ int bnxt_alloc_filter_mem(struct bnxt *bp)\n \t\t\t\t max_filters * sizeof(struct bnxt_filter_info),\n \t\t\t\t 0);\n \tif (filter_mem == NULL) {\n-\t\tRTE_LOG(ERR, PMD, \"Failed to alloc memory for %d filters\",\n+\t\tRTE_LOG(ERR, PMD, \"Failed to alloc memory for %d filters\\n\",\n \t\t\tmax_filters);\n \t\treturn -ENOMEM;\n \t}\ndiff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c\nindex 880af95..ea09582 100644\n--- a/drivers/net/bnxt/bnxt_irq.c\n+++ b/drivers/net/bnxt/bnxt_irq.c\n@@ -141,7 +141,7 @@ int bnxt_setup_int(struct bnxt *bp)\n \treturn 0;\n \n setup_exit:\n-\tRTE_LOG(ERR, PMD, \"bnxt_irq_tbl setup failed\");\n+\tRTE_LOG(ERR, PMD, \"bnxt_irq_tbl setup failed\\n\");\n \treturn rc;\n }\n \ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex cace73b..bd7b4b6 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -258,7 +258,7 @@ int bnxt_alloc_hwrm_rings(struct bnxt *bp)\n \t\tbp->grp_info[idx].rx_fw_ring_id = ring->fw_ring_id;\n \t\tB_RX_DB(rxr->rx_doorbell, rxr->rx_prod);\n \t\tif (bnxt_init_one_rx_ring(rxq)) {\n-\t\t\tRTE_LOG(ERR, PMD, \"bnxt_init_one_rx_ring failed!\");\n+\t\t\tRTE_LOG(ERR, PMD, \"bnxt_init_one_rx_ring failed!\\n\");\n \t\t\tbnxt_rx_queue_release_op(rxq);\n \t\t\treturn -ENOMEM;\n \t\t}\ndiff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex f710aed..9862d18 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -278,7 +278,7 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \tint rc = 0;\n \n \tif (!nb_desc || nb_desc > MAX_RX_DESC_CNT) {\n-\t\tRTE_LOG(ERR, PMD, \"nb_desc %d is invalid\", nb_desc);\n+\t\tRTE_LOG(ERR, PMD, \"nb_desc %d is invalid\\n\", nb_desc);\n \t\trc = -EINVAL;\n \t\tgoto out;\n \t}\n@@ -291,7 +291,7 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \trxq = rte_zmalloc_socket(\"bnxt_rx_queue\", sizeof(struct bnxt_rx_queue),\n \t\t\t\t RTE_CACHE_LINE_SIZE, socket_id);\n \tif (!rxq) {\n-\t\tRTE_LOG(ERR, PMD, \"bnxt_rx_queue allocation failed!\");\n+\t\tRTE_LOG(ERR, PMD, \"bnxt_rx_queue allocation failed!\\n\");\n \t\trc = -ENOMEM;\n \t\tgoto out;\n \t}\n@@ -313,7 +313,8 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \t/* Allocate RX ring hardware descriptors */\n \tif (bnxt_alloc_rings(bp, queue_idx, NULL, rxq->rx_ring, rxq->cp_ring,\n \t\t\t\"rxr\")) {\n-\t\tRTE_LOG(ERR, PMD, \"ring_dma_zone_reserve for rx_ring failed!\");\n+\t\tRTE_LOG(ERR, PMD,\n+\t\t\t\"ring_dma_zone_reserve for rx_ring failed!\\n\");\n \t\tbnxt_rx_queue_release_op(rxq);\n \t\trc = -ENOMEM;\n \t\tgoto out;\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex dfbaedb..1f9e152 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -253,7 +253,7 @@ int bnxt_alloc_vnic_mem(struct bnxt *bp)\n \tvnic_mem = rte_zmalloc(\"bnxt_vnic_info\",\n \t\t\t       max_vnics * sizeof(struct bnxt_vnic_info), 0);\n \tif (vnic_mem == NULL) {\n-\t\tRTE_LOG(ERR, PMD, \"Failed to alloc memory for %d VNICs\",\n+\t\tRTE_LOG(ERR, PMD, \"Failed to alloc memory for %d VNICs\\n\",\n \t\t\tmax_vnics);\n \t\treturn -ENOMEM;\n \t}\n",
    "prefixes": [
        "dpdk-dev",
        "22/28"
    ]
}