Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/20983/?format=api
{ "id": 20983, "url": "https://patches.dpdk.org/api/patches/20983/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1488364919-22897-1-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1488364919-22897-1-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1488364919-22897-1-git-send-email-yuanhan.liu@linux.intel.com", "date": "2017-03-01T10:41:58", "name": "[dpdk-dev,v2,1/2] vhost: fix multiple queue not being enabled for older kernels", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1187372485dbaefedbfb0f141cfc4fd962c6b3a3", "submitter": { "id": 307, "url": "https://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": { "id": 355, "url": "https://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1488364919-22897-1-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/20983/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/20983/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2E9706CB4;\n\tWed, 1 Mar 2017 11:43:20 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 160066CB4;\n\tWed, 1 Mar 2017 11:43:17 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Mar 2017 02:43:17 -0800", "from yliu-dev.sh.intel.com ([10.239.67.162])\n\tby orsmga001.jf.intel.com with ESMTP; 01 Mar 2017 02:43:16 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.35,225,1484035200\"; d=\"scan'208\";\n\ta=\"1103530193\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tYuanhan Liu <yuanhan.liu@linux.intel.com>, stable@dpdk.org", "Date": "Wed, 1 Mar 2017 18:41:58 +0800", "Message-Id": "<1488364919-22897-1-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1487839550-21800-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1487839550-21800-1-git-send-email-yuanhan.liu@linux.intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/2] vhost: fix multiple queue not being\n\tenabled for older kernels", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some macros (say VIRTIO_NET_F_MQ) are needed for enabling multiple queue,\nhowever they are introduced since kernel v3.8, meaning build error happens\nif we build DPDK vhost on those platforms.\n\n71dfdbe66a66 (\"vhost: fix build with kernel < 3.8\") meant to fix it, but\nin a wrong way: it completely disables the MQ features for those kernels.\nHowever, the MQ feature doesn't depend on the kernel at all (except the\nmacros dependency stated above), that we could still enable the MQ feature\neven the host kernel has no such support.\n\nThe right fix is to define the macro if it's not defined.\n\nFixes: 71dfdbe66a66 (\"vhost: fix build with kernel < 3.8\")\n\nCc: stable@dpdk.org\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n\n- v2: do not remove the VHOST_MAX_QUEUE_PAIRS macro. The value which\n in turn will be fixed in next patch.\n---\n lib/librte_vhost/vhost.c | 2 +-\n lib/librte_vhost/vhost.h | 7 +++----\n 2 files changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c\nindex e415093..3c3f6a4 100644\n--- a/lib/librte_vhost/vhost.c\n+++ b/lib/librte_vhost/vhost.c\n@@ -56,7 +56,7 @@\n \t\t\t\t(1ULL << VIRTIO_NET_F_CTRL_VQ) | \\\n \t\t\t\t(1ULL << VIRTIO_NET_F_CTRL_RX) | \\\n \t\t\t\t(1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE) | \\\n-\t\t\t\t(VHOST_SUPPORTS_MQ) | \\\n+\t\t\t\t(1ULL << VIRTIO_NET_F_MQ) | \\\n \t\t\t\t(1ULL << VIRTIO_F_VERSION_1) | \\\n \t\t\t\t(1ULL << VHOST_F_LOG_ALL) | \\\n \t\t\t\t(1ULL << VHOST_USER_F_PROTOCOL_FEATURES) | \\\ndiff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h\nindex 22564f1..4391e62 100644\n--- a/lib/librte_vhost/vhost.h\n+++ b/lib/librte_vhost/vhost.h\n@@ -123,11 +123,10 @@ struct vhost_virtqueue {\n * code buildable for older kernel.\n */\n #ifdef VIRTIO_NET_F_MQ\n- #define VHOST_MAX_QUEUE_PAIRS\tVIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX\n- #define VHOST_SUPPORTS_MQ\t(1ULL << VIRTIO_NET_F_MQ)\n+ #define VHOST_MAX_QUEUE_PAIRS\t\tVIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX\n #else\n- #define VHOST_MAX_QUEUE_PAIRS\t1\n- #define VHOST_SUPPORTS_MQ\t0\n+ #define VIRTIO_NET_F_MQ\t\t22\n+ #define VHOST_MAX_QUEUE_PAIRS\t\t0x8000\n #endif\n \n /*\n", "prefixes": [ "dpdk-dev", "v2", "1/2" ] }