Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 19868,
    "url": "https://patches.dpdk.org/api/patches/19868/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1485156509-4919-1-git-send-email-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1485156509-4919-1-git-send-email-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1485156509-4919-1-git-send-email-yong.liu@intel.com",
    "date": "2017-01-23T07:28:29",
    "name": "[dpdk-dev,v2] examples: fix ip_reassembly not work with some NICs",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c523e402b66f7621240d32c0320ccb7bc9a17810",
    "submitter": {
        "id": 17,
        "url": "https://patches.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1485156509-4919-1-git-send-email-yong.liu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/19868/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/19868/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E83032C57;\n\tMon, 23 Jan 2017 08:27:28 +0100 (CET)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 1556B2C38\n\tfor <dev@dpdk.org>; Mon, 23 Jan 2017 08:27:26 +0100 (CET)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 22 Jan 2017 23:27:25 -0800",
            "from unknown (HELO dpdk-fedora20.icx.intel.com) ([10.240.176.135])\n\tby orsmga002.jf.intel.com with ESMTP; 22 Jan 2017 23:27:24 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.33,273,1477983600\"; d=\"scan'208\";a=\"34126450\"",
        "From": "Yong Liu <yong.liu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Yong Liu <yong.liu@intel.com>",
        "Date": "Mon, 23 Jan 2017 15:28:29 +0800",
        "Message-Id": "<1485156509-4919-1-git-send-email-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "Subject": "[dpdk-dev] [PATCH v2] examples: fix ip_reassembly not work with\n\tsome NICs",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Some network device drivers like Fortville may not fill packet type by\ndefault. Changed the method for detecting packet type from mbuf packet\ntype to ethernet header MAC type will make sure this example compatible\nwith all NICs.\n\nFixes: b84fb4cb88ff (\"examples/ip_reassembly: overhaul\")\n\nv2:\n* fix code style issue\n\nSigned-off-by: Yong Liu <yong.liu@intel.com>",
    "diff": "diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c\nindex 50fe422..974fabc 100644\n--- a/examples/ip_reassembly/main.c\n+++ b/examples/ip_reassembly/main.c\n@@ -356,7 +356,7 @@ struct rte_lpm6_config lpm6_config = {\n \tdst_port = portid;\n \n \t/* if packet is IPv4 */\n-\tif (RTE_ETH_IS_IPV4_HDR(m->packet_type)) {\n+\tif (eth_hdr->ether_type == rte_cpu_to_be_16(ETHER_TYPE_IPv4)) {\n \t\tstruct ipv4_hdr *ip_hdr;\n \t\tuint32_t ip_dst;\n \n@@ -395,8 +395,7 @@ struct rte_lpm6_config lpm6_config = {\n \t\t\tdst_port = next_hop_ipv4;\n \t\t}\n \n-\t\teth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv4);\n-\t} else if (RTE_ETH_IS_IPV6_HDR(m->packet_type)) {\n+\t} else if (eth_hdr->ether_type == rte_cpu_to_be_16(ETHER_TYPE_IPv6)) {\n \t\t/* if packet is IPv6 */\n \t\tstruct ipv6_extension_fragment *frag_hdr;\n \t\tstruct ipv6_hdr *ip_hdr;\n@@ -431,8 +430,6 @@ struct rte_lpm6_config lpm6_config = {\n \t\t\t\t(enabled_port_mask & 1 << next_hop_ipv6) != 0) {\n \t\t\tdst_port = next_hop_ipv6;\n \t\t}\n-\n-\t\teth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv6);\n \t}\n \t/* if packet wasn't IPv4 or IPv6, it's forwarded to the port it came from */\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}