Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17246/?format=api
{ "id": 17246, "url": "https://patches.dpdk.org/api/patches/17246/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1479986809-14934-6-git-send-email-jblunck@infradead.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479986809-14934-6-git-send-email-jblunck@infradead.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1479986809-14934-6-git-send-email-jblunck@infradead.org", "date": "2016-11-24T11:26:49", "name": "[dpdk-dev,v2,5/5] Revert \"bonding: use existing enslaved device queues\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "67ee0379bbc1a807a106ef04d64f6e1bb57c9b59", "submitter": { "id": 249, "url": "https://patches.dpdk.org/api/people/249/?format=api", "name": "Jan Blunck", "email": "jblunck@infradead.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1479986809-14934-6-git-send-email-jblunck@infradead.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/17246/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/17246/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7B58E5686;\n\tThu, 24 Nov 2016 12:36:44 +0100 (CET)", "from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66]) by dpdk.org (Postfix) with ESMTP id B3270558D;\n\tThu, 24 Nov 2016 12:35:44 +0100 (CET)", "by mail-wm0-f66.google.com with SMTP id g23so4729479wme.1;\n\tThu, 24 Nov 2016 03:35:44 -0800 (PST)", "from weierstrass.local.net ([91.200.110.70])\n\tby smtp.gmail.com with ESMTPSA id\n\tl74sm7786020wmg.2.2016.11.24.03.35.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 24 Nov 2016 03:35:43 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=gVGz/iWsvLXHDFwg4mXnkyJRhnsqDxGVFV9+CetXsko=;\n\tb=E6PZi5yx/Lhxm9Z5PIGlWWrnEPdpq9ZY07KbdycqrGgxHBaduc1M3P3/HYOiGLR61Q\n\tUlm9OM+ZgpHPgkT8izw4+bYzi/Gab/W4armpANeGt4dwH+KEJSZyWyQoGkAr9Sk5pz90\n\tB5fdtSPa6h8vN0nb0B6ZS2gV3UOUyCV3F0q2V+DXFZcJB/hYApfxPG5MNn7mqfhvl00g\n\tOUIPEJ539rmPdNOHQ7e74xOpGKU40MxKW3wt3inVhNgQh+LNbjV588l9RDi182s08vPJ\n\tV6CIHRzea5e1ceANDfg8tH60jdTIYbbgbb/fZia+7rZ3RM87j+rzSU2r1tBSNUnREEwh\n\tlF3g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=gVGz/iWsvLXHDFwg4mXnkyJRhnsqDxGVFV9+CetXsko=;\n\tb=d5aQuyKPUb43I9y/+2Dc3LaBCj7YBJv9J9xBcade1BqTTvBbvqctc1QNtacaLadF2t\n\to8+o1hsffV1GhCI9j4puFb6xnYyxl6hW1isNDunG+VKoIYyrqX4wQj54Zi/w9XFFF7Zq\n\ttyqyX25vkd6viE5esPhFlMLC3lP8xD1vOkv9/f2YkZ84u3KSCDOM3myc0CW3x34PGK7l\n\tv6h0jtJK4suM8XiPnb6o5L+MSndZcEDlVx5phRF2E9LWfRsMwgQI5p2R/nmhkhWSNJLZ\n\toLoYTpCEYSgfT8VujgTjCC7FTvma7vW29iFujxzox5SQF8zjg+30FUDyFDN7yU2xdl8v\n\tezhA==", "X-Gm-Message-State": "AKaTC01FmoUrU+r/rkkAY+aJwSxrUtgF4RiD1oVIb7exvUeWAjkyfnCvbxmSsUhvvu3kWg==", "X-Received": "by 10.28.189.69 with SMTP id n66mr1880672wmf.35.1479987344402;\n\tThu, 24 Nov 2016 03:35:44 -0800 (PST)", "From": "Jan Blunck <jblunck@infradead.org>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, i.maximets@samsung.com,\n\tbruce.richardson@intel.com, \n\tdeclan.doherty@intel.com, ehkinzie@gmail.com,\n\tbernard.iremonger@intel.com, stable@dpdk.org", "Date": "Thu, 24 Nov 2016 12:26:49 +0100", "Message-Id": "<1479986809-14934-6-git-send-email-jblunck@infradead.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1479986809-14934-1-git-send-email-jblunck@infradead.org>", "References": "<1479986809-14934-1-git-send-email-jblunck@infradead.org>", "Subject": "[dpdk-dev] [PATCH v2 5/5] Revert \"bonding: use existing enslaved\n\tdevice queues\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ilya Maximets <i.maximets@samsung.com>\n\nThis reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5.\n\nIt is necessary to reconfigure all queues every time because configuration\ncan be changed.\n\nFor example, if we're reconfiguring bonding device with new memory pool,\nalready configured queues will still use the old one. And if the old\nmempool be freed, application likely will panic in attempt to use\nfreed mempool.\n\nThis happens when we use the bonding device with OVS 2.6 while MTU\nreconfiguration:\n\nPANIC in rte_mempool_get_ops():\nassert \"(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)\" failed\n\nCc: <stable@dpdk.org>\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\nAcked-by: Declan Doherty <declan.doherty@intel.com>\nAcked-by: Declan Doherty <declan.doherty@intel.com>\nAcked-by: Jan Blunck <jblunck@infradead.org>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex e61afc9..b604642 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1317,8 +1317,6 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \tstruct bond_rx_queue *bd_rx_q;\n \tstruct bond_tx_queue *bd_tx_q;\n \n-\tuint16_t old_nb_tx_queues = slave_eth_dev->data->nb_tx_queues;\n-\tuint16_t old_nb_rx_queues = slave_eth_dev->data->nb_rx_queues;\n \tint errval;\n \tuint16_t q_id;\n \n@@ -1362,9 +1360,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \t}\n \n \t/* Setup Rx Queues */\n-\t/* Use existing queues, if any */\n-\tfor (q_id = old_nb_rx_queues;\n-\t q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) {\n+\tfor (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) {\n \t\tbd_rx_q = (struct bond_rx_queue *)bonded_eth_dev->data->rx_queues[q_id];\n \n \t\terrval = rte_eth_rx_queue_setup(slave_eth_dev->data->port_id, q_id,\n@@ -1380,9 +1376,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \t}\n \n \t/* Setup Tx Queues */\n-\t/* Use existing queues, if any */\n-\tfor (q_id = old_nb_tx_queues;\n-\t q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) {\n+\tfor (q_id = 0; q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) {\n \t\tbd_tx_q = (struct bond_tx_queue *)bonded_eth_dev->data->tx_queues[q_id];\n \n \t\terrval = rte_eth_tx_queue_setup(slave_eth_dev->data->port_id, q_id,\n", "prefixes": [ "dpdk-dev", "v2", "5/5" ] }