Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17038,
    "url": "https://patches.dpdk.org/api/patches/17038/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/3bb5f6dcd2ae514d878b39ed904c30dbf5868a1d.1479309720.git.adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<3bb5f6dcd2ae514d878b39ed904c30dbf5868a1d.1479309720.git.adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/3bb5f6dcd2ae514d878b39ed904c30dbf5868a1d.1479309720.git.adrien.mazarguil@6wind.com",
    "date": "2016-11-16T16:23:40",
    "name": "[dpdk-dev,14/22] app/testpmd: add rte_flow bit-field support",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "758a841d65c05ad2626e7682238898fcf0d62307",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/3bb5f6dcd2ae514d878b39ed904c30dbf5868a1d.1479309720.git.adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/17038/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/17038/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 76946D4C2;\n\tWed, 16 Nov 2016 17:25:33 +0100 (CET)",
            "from mail-wm0-f51.google.com (mail-wm0-f51.google.com\n\t[74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 928575684\n\tfor <dev@dpdk.org>; Wed, 16 Nov 2016 17:24:39 +0100 (CET)",
            "by mail-wm0-f51.google.com with SMTP id g23so250224729wme.1\n\tfor <dev@dpdk.org>; Wed, 16 Nov 2016 08:24:39 -0800 (PST)",
            "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tn17sm319025wjq.6.2016.11.16.08.24.38\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tWed, 16 Nov 2016 08:24:38 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=c6gF8TuGD8kHq5ox5WIwjQiktpcI5YJsNK4+fkkUH2E=;\n\tb=OYhohAe7BhXktVPnMX2MnplyNYTYRcO4ilBLD2eAgW/wRWCRr9btsm0UQeYxUh54JW\n\tQ7UQcb5qUa3mlI0UZ1BdcBUlyIgrFFmFI/BQFjnD6OVsHCoh6wIwd+Sg4QfBf4PQNaeV\n\tccr0Hs55p7/LKkr7gleOn/5EmGK7p5J8nlsevTPm/hhWXHBU3x7MI9GKn4gaU9vaNuI4\n\to7d9KbQbboJZn8PLdwPHD3cc2S24hlqLZcqU7qbN82MVYH9lUyQD6a11LH5JpF7l2QdY\n\todUFtMGZoJCPt6SysMiHqmgvsYMvUt/9WrHVr97JJEb6H/GZVB+fUUNoX4dUk4tL6rHi\n\tGBDQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=c6gF8TuGD8kHq5ox5WIwjQiktpcI5YJsNK4+fkkUH2E=;\n\tb=Vw4XLLtMeFPRlhh4ci0jrrJYtsXzEmfMp1TANrvhT9GgDWHmbtYe2C8L4zN+3AidZm\n\tMCvRR3SNMghn0G6tLLzU9dYI0bpFLToNdbqiJ1KZ39riqByP5OKdnTP9A0LznqiEZyhF\n\toyG15IfjFo2l4p2WFbWELffll+LMRMOndjo9K/eKXx/7/BBmn1P7WQlLINIb+AzidtZy\n\tHV3neIBZFD+nwMCkraOsJjVqddGnjhoacpeCluoj6NT6z9cxuTFVlPQVfYPtN8cq1Ylx\n\ttkw7uPtFx0aa/WM2sQRKNNzH1vC55QlWdh8k2DdjTlA3CMqDyrqxo5bzsqXM3ozMxJGo\n\ttsIg==",
        "X-Gm-Message-State": "ABUngvd3mT/Qcpj8iGIg1y3fGD32ze6RZFaL9Py4g2qB3hqp/zfsaj9RVdHWynYE77VI/UR7",
        "X-Received": "by 10.28.71.1 with SMTP id u1mr10534626wma.128.1479313479098;\n\tWed, 16 Nov 2016 08:24:39 -0800 (PST)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>,\n\tOlivier Matz <olivier.matz@6wind.com>",
        "Date": "Wed, 16 Nov 2016 17:23:40 +0100",
        "Message-Id": "<3bb5f6dcd2ae514d878b39ed904c30dbf5868a1d.1479309720.git.adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<cover.1479309719.git.adrien.mazarguil@6wind.com>",
        "References": "<cover.1471632644.git.adrien.mazarguil@6wind.com>\n\t<cover.1479309719.git.adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 14/22] app/testpmd: add rte_flow bit-field support",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Several rte_flow structures expose bit-fields that cannot be set in a\ngeneric fashion at byte level. Add bit-mask support to handle them.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n app/test-pmd/cmdline_flow.c | 59 ++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 59 insertions(+)",
    "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 89307cb..81930e1 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -136,6 +136,7 @@ struct arg {\n \tuint32_t sign:1; /**< Value is signed. */\n \tuint32_t offset; /**< Relative offset from ctx->object. */\n \tuint32_t size; /**< Field size. */\n+\tconst uint8_t *mask; /**< Bit-mask to use instead of offset/size. */\n };\n \n /** Parser token definition. */\n@@ -195,6 +196,13 @@ struct token {\n \t\t.size = sizeof(((s *)0)->f), \\\n \t})\n \n+/** Static initializer for ARGS() to target a bit-field. */\n+#define ARGS_ENTRY_BF(s, f) \\\n+\t(&(const struct arg){ \\\n+\t\t.size = sizeof(s), \\\n+\t\t.mask = (const void *)&(const s){ .f = -1 }, \\\n+\t})\n+\n /** Static initializer for ARGS() to target a pointer. */\n #define ARGS_ENTRY_PTR(s, f) \\\n \t(&(const struct arg){ \\\n@@ -622,6 +630,34 @@ push_args(struct context *ctx, const struct arg *arg)\n \treturn 0;\n }\n \n+/** Spread value into buffer according to bit-mask. */\n+static size_t\n+arg_entry_bf_fill(void *dst, uintmax_t val, const struct arg *arg)\n+{\n+\tuint32_t i;\n+\tsize_t len = 0;\n+\n+\t/* Endian conversion is not supported on bit-fields. */\n+\tif (!arg->mask || arg->hton)\n+\t\treturn 0;\n+\tfor (i = 0; i != arg->size; ++i) {\n+\t\tunsigned int shift = 0;\n+\t\tuint8_t *buf = (uint8_t *)dst + i;\n+\n+\t\tfor (shift = 0; arg->mask[i] >> shift; ++shift) {\n+\t\t\tif (!(arg->mask[i] & (1 << shift)))\n+\t\t\t\tcontinue;\n+\t\t\t++len;\n+\t\t\tif (!dst)\n+\t\t\t\tcontinue;\n+\t\t\t*buf &= ~(1 << shift);\n+\t\t\t*buf |= (val & 1) << shift;\n+\t\t\tval >>= 1;\n+\t\t}\n+\t}\n+\treturn len;\n+}\n+\n /**\n  * Parse a prefix length and generate a bit-mask.\n  *\n@@ -648,6 +684,23 @@ parse_prefix(struct context *ctx, const struct token *token,\n \tu = strtoumax(str, &end, 0);\n \tif (errno || (size_t)(end - str) != len)\n \t\tgoto error;\n+\tif (arg->mask) {\n+\t\tuintmax_t v = 0;\n+\n+\t\textra = arg_entry_bf_fill(NULL, 0, arg);\n+\t\tif (u > extra)\n+\t\t\tgoto error;\n+\t\tif (!ctx->object)\n+\t\t\treturn len;\n+\t\textra -= u;\n+\t\twhile (u--)\n+\t\t\t(v <<= 1, v |= 1);\n+\t\tv <<= extra;\n+\t\tif (!arg_entry_bf_fill(ctx->object, v, arg) ||\n+\t\t    !arg_entry_bf_fill(ctx->objmask, -1, arg))\n+\t\t\tgoto error;\n+\t\treturn len;\n+\t}\n \tbytes = u / 8;\n \textra = u % 8;\n \tsize = arg->size;\n@@ -1071,6 +1124,12 @@ parse_int(struct context *ctx, const struct token *token,\n \t\tgoto error;\n \tif (!ctx->object)\n \t\treturn len;\n+\tif (arg->mask) {\n+\t\tif (!arg_entry_bf_fill(ctx->object, u, arg) ||\n+\t\t    !arg_entry_bf_fill(ctx->objmask, -1, arg))\n+\t\t\tgoto error;\n+\t\treturn len;\n+\t}\n \tbuf = (uint8_t *)ctx->object + arg->offset;\n \tsize = arg->size;\n objmask:\n",
    "prefixes": [
        "dpdk-dev",
        "14/22"
    ]
}