Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 16991,
    "url": "https://patches.dpdk.org/api/patches/16991/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478785884-29273-1-git-send-email-david.marchand@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1478785884-29273-1-git-send-email-david.marchand@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1478785884-29273-1-git-send-email-david.marchand@6wind.com",
    "date": "2016-11-10T13:51:23",
    "name": "[dpdk-dev,1/2] net: remove dead driver names",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "f30e7d692e7cb852f12dc7087506146c76c2fe94",
    "submitter": {
        "id": 3,
        "url": "https://patches.dpdk.org/api/people/3/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478785884-29273-1-git-send-email-david.marchand@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/16991/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/16991/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 4361F6CB8;\n\tThu, 10 Nov 2016 14:51:39 +0100 (CET)",
            "from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 2488CB62\n\tfor <dev@dpdk.org>; Thu, 10 Nov 2016 14:51:36 +0100 (CET)",
            "by mail-wm0-f47.google.com with SMTP id t79so32822658wmt.0\n\tfor <dev@dpdk.org>; Thu, 10 Nov 2016 05:51:36 -0800 (PST)",
            "from gloops.dev.6wind.com (89.156.119.78.rev.sfr.net.\n\t[78.119.156.89]) by smtp.gmail.com with ESMTPSA id\n\ti132sm13067312wmf.14.2016.11.10.05.51.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 10 Nov 2016 05:51:35 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=vaf++urAlxu0dsKsAtlNfsK2OTxhwrCgFMzBIm8uDzQ=;\n\tb=cwdVhm6lYE2aZVCKUL6Y3E6cCWXPca/iDC+xz0c+2s3+P/177+61tfGEA5YF8nGLsp\n\txconox0fB+sBidL3T5kIE3ut6ue2CHOEk1LYETvGcpB0iBM6bWWfiTgmPnNxJCQWYRqi\n\tnyh30BybyRz7o1T5IIa1IcmQZ4zHsKBIL6sORMX8rSINxbh3CmGVdUpW/yLaIjltyzXB\n\tLElymqgPIAPigMHyVbxVhpObsUpJiKuumICSM/yfY4NI6ftrFR4AzQ4yKGZBpjzzDDYf\n\tn4AyoOLiHVxbLEEPkk5Mq1edfzuFHaQaA6p+YaUeMA5sPFd9yCHXkCnPbFnIdcWIpE/f\n\twwqw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=vaf++urAlxu0dsKsAtlNfsK2OTxhwrCgFMzBIm8uDzQ=;\n\tb=ESkuDcZxqxiDKMUXcjpBA1Z+CQOWij6ZkbW4O8kLX67kD3a21elP3RPDiTjLShO/bI\n\tkhJH3I6EWafJODmc9nYovMAbvrSm78aEr8k/Yx5QcW2VukKMBLUNttmBXHX3dgd8853L\n\t9rCNNxbMEma6UBwW1jhDFfsA1GAD2IMwr1+rwzmuTG80u/8jZ02Gh8uWAjcUN3uGlDRn\n\t3CLH1xrUpuUvTE0HyNGRfxSsRRer4AHGFyazSt7txLtE5ZKcVhQ2SUIrNalx4C9Y/h1d\n\tpF+fTHBXoMk8LuM+BshvrE1ZdVOX8BUWPSLb/J8KPhe5vT/7R7mz/himPbjttNZdyvXl\n\thTSA==",
        "X-Gm-Message-State": "ABUngvfHMdjmKH49dp9Akf5JCrbkQjk61vUnkdBDNwDuGfODSd5+5LTptppI3suDpGOK2zTo",
        "X-Received": "by 10.28.40.67 with SMTP id o64mr25103916wmo.5.1478785896387;\n\tThu, 10 Nov 2016 05:51:36 -0800 (PST)",
        "From": "David Marchand <david.marchand@6wind.com>",
        "To": "thomas.monjalon@6wind.com",
        "Cc": "dev@dpdk.org, linville@tuxdriver.com, declan.doherty@intel.com,\n\tzlu@ezchip.com, lsun@ezchip.com, alejandro.lucero@netronome.com,\n\tmtetsuyah@gmail.com, nicolas.pernas.maradei@emutex.com,\n\tferruh.yigit@intel.com, harish.patil@qlogic.com, rasesh.mody@qlogic.com, \n\tsony.chacko@qlogic.com, bruce.richardson@intel.com,\n\thuawei.xie@intel.com, \n\tyuanhan.liu@linux.intel.com, jianfeng.tan@intel.com",
        "Date": "Thu, 10 Nov 2016 14:51:23 +0100",
        "Message-Id": "<1478785884-29273-1-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH 1/2] net: remove dead driver names",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since b1fb53a39d88 (\"ethdev: remove some PCI specific handling\"),\nrte_eth_dev_info_get() relies on dev->data->drv_name to report the driver\nname to caller.\n\nHaving the pmds set driver_info->driver_name in the pmds is useless,\nsince ethdev overwrites it right after.\nThe only thing the pmd must do is:\n- for pci drivers, call rte_eth_copy_pci_info() which then sets\n  data->drv_name\n- for vdev drivers, manually set data->drv_name\n\nAt this stage, virtio-user does not properly report a driver name (fixed in\nnext commit).\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 5 +----\n drivers/net/nfp/nfp_net.c                 | 1 -\n drivers/net/null/rte_eth_null.c           | 4 +---\n drivers/net/pcap/rte_eth_pcap.c           | 4 +---\n drivers/net/qede/qede_ethdev.c            | 1 -\n drivers/net/ring/rte_eth_ring.c           | 4 +---\n drivers/net/vhost/rte_eth_vhost.c         | 3 ---\n drivers/net/virtio/virtio_ethdev.c        | 4 ----\n drivers/net/xenvirt/rte_eth_xenvirt.c     | 5 +----\n 9 files changed, 5 insertions(+), 26 deletions(-)",
    "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex ff45068..a66a657 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -115,8 +115,6 @@ static const char *valid_arguments[] = {\n \tNULL\n };\n \n-static const char *drivername = \"AF_PACKET PMD\";\n-\n static struct rte_eth_link pmd_link = {\n \t.link_speed = ETH_SPEED_NUM_10G,\n \t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -280,7 +278,6 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n \n-\tdev_info->driver_name = drivername;\n \tdev_info->if_index = internals->if_index;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)ETH_FRAME_LEN;\n@@ -693,7 +690,7 @@ rte_pmd_init_internals(const char *name,\n \t(*eth_dev)->dev_ops = &ops;\n \t(*eth_dev)->driver = NULL;\n \t(*eth_dev)->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n-\t(*eth_dev)->data->drv_name = drivername;\n+\t(*eth_dev)->data->drv_name = \"AF_PACKET PMD\";\n \t(*eth_dev)->data->kdrv = RTE_KDRV_NONE;\n \t(*eth_dev)->data->numa_node = numa_node;\n \ndiff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex c6b1587..0c342ab 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -1006,7 +1006,6 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tdev_info->driver_name = dev->driver->pci_drv.driver.name;\n \tdev_info->max_rx_queues = (uint16_t)hw->max_rx_queues;\n \tdev_info->max_tx_queues = (uint16_t)hw->max_tx_queues;\n \tdev_info->min_rx_bufsize = ETHER_MIN_MTU;\ndiff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 836d982..09d77fd 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -88,7 +88,6 @@ struct pmd_internals {\n \n \n static struct ether_addr eth_addr = { .addr_bytes = {0} };\n-static const char *drivername = \"Null PMD\";\n static struct rte_eth_link pmd_link = {\n \t.link_speed = ETH_SPEED_NUM_10G,\n \t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -295,7 +294,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \t\treturn;\n \n \tinternals = dev->data->dev_private;\n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\n \tdev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);\n@@ -555,7 +553,7 @@ eth_dev_null_create(const char *name,\n \teth_dev->driver = NULL;\n \tdata->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \tdata->kdrv = RTE_KDRV_NONE;\n-\tdata->drv_name = drivername;\n+\tdata->drv_name = \"Null PMD\";\n \tdata->numa_node = numa_node;\n \n \t/* finally assign rx and tx ops */\ndiff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex 0162f44..8b4fba7 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -119,7 +119,6 @@ static struct ether_addr eth_addr = {\n \t.addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 }\n };\n \n-static const char *drivername = \"Pcap PMD\";\n static struct rte_eth_link pmd_link = {\n \t\t.link_speed = ETH_SPEED_NUM_10G,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -552,7 +551,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n \n-\tdev_info->driver_name = drivername;\n \tdev_info->if_index = internals->if_index;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t) -1;\n@@ -842,7 +840,7 @@ pmd_init_internals(const char *name, const unsigned int nb_rx_queues,\n \t(*eth_dev)->driver = NULL;\n \tdata->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \tdata->kdrv = RTE_KDRV_NONE;\n-\tdata->drv_name = drivername;\n+\tdata->drv_name = \"Pcap PMD\";\n \tdata->numa_node = numa_node;\n \n \treturn 0;\ndiff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 59129f2..a56ba90 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -662,7 +662,6 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev,\n \t\tdev_info->max_vfs = 0;\n \telse\n \t\tdev_info->max_vfs = (uint16_t)NUM_OF_VFS(&qdev->edev);\n-\tdev_info->driver_name = qdev->drv_ver;\n \tdev_info->reta_size = ECORE_RSS_IND_TABLE_SIZE;\n \tdev_info->flow_type_rss_offloads = (uint64_t)QEDE_RSS_OFFLOAD_ALL;\n \ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex c1767c4..56afaf2 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -75,7 +75,6 @@ struct pmd_internals {\n };\n \n \n-static const char *drivername = \"Rings PMD\";\n static struct rte_eth_link pmd_link = {\n \t\t.link_speed = ETH_SPEED_NUM_10G,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -173,7 +172,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_dev_info *dev_info)\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\n \tdev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;\n@@ -343,7 +341,7 @@ do_eth_dev_ring_create(const char *name,\n \teth_dev->dev_ops = &ops;\n \tdata->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \tdata->kdrv = RTE_KDRV_NONE;\n-\tdata->drv_name = drivername;\n+\tdata->drv_name = \"Rings PMD\";\n \tdata->numa_node = numa_node;\n \n \tTAILQ_INIT(&(eth_dev->link_intr_cbs));\ndiff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 766d4ef..96bf391 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -53,8 +53,6 @@\n #define ETH_VHOST_CLIENT_ARG\t\t\"client\"\n #define ETH_VHOST_DEQUEUE_ZERO_COPY\t\"dequeue-zero-copy\"\n \n-static const char *drivername = \"VHOST PMD\";\n-\n static const char *valid_arguments[] = {\n \tETH_VHOST_IFACE_ARG,\n \tETH_VHOST_QUEUES_ARG,\n@@ -861,7 +859,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \t\treturn;\n \t}\n \n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\n \tdev_info->max_rx_queues = internal->max_queues;\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 079fd6c..741688e 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tuint64_t tso_mask;\n \tstruct virtio_hw *hw = dev->data->dev_private;\n \n-\tif (dev->pci_dev)\n-\t\tdev_info->driver_name = dev->driver->pci_drv.driver.name;\n-\telse\n-\t\tdev_info->driver_name = \"virtio_user PMD\";\n \tdev_info->max_rx_queues =\n \t\tRTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES);\n \tdev_info->max_tx_queues =\ndiff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c\nindex c08a056..f74d72c 100644\n--- a/drivers/net/xenvirt/rte_eth_xenvirt.c\n+++ b/drivers/net/xenvirt/rte_eth_xenvirt.c\n@@ -70,8 +70,6 @@\n /* virtio_idx is increased after new device is created.*/\n static int virtio_idx = 0;\n \n-static const char *drivername = \"xen virtio PMD\";\n-\n static struct rte_eth_link pmd_link = {\n \t\t.link_speed = ETH_SPEED_NUM_10G,\n \t\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n@@ -331,7 +329,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \tstruct pmd_internals *internals = dev->data->dev_private;\n \n \tRTE_SET_USED(internals);\n-\tdev_info->driver_name = drivername;\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)2048;\n \tdev_info->max_rx_queues = (uint16_t)1;\n@@ -675,7 +672,7 @@ eth_dev_xenvirt_create(const char *name, const char *params,\n \n \teth_dev->data->dev_flags = RTE_PCI_DRV_DETACHABLE;\n \teth_dev->data->kdrv = RTE_KDRV_NONE;\n-\teth_dev->data->drv_name = drivername;\n+\teth_dev->data->drv_name = \"xen virtio PMD\";\n \teth_dev->driver = NULL;\n \teth_dev->data->numa_node = numa_node;\n \n",
    "prefixes": [
        "dpdk-dev",
        "1/2"
    ]
}