Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/16978/?format=api
{ "id": 16978, "url": "https://patches.dpdk.org/api/patches/16978/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1478674773-40898-1-git-send-email-wei.zhao1@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1478674773-40898-1-git-send-email-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1478674773-40898-1-git-send-email-wei.zhao1@intel.com", "date": "2016-11-09T06:59:33", "name": "[dpdk-dev] net/ixgbe: fix link never come up problem with x552", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d7b30e104c984fbc36a471c697d5768074e06310", "submitter": { "id": 495, "url": "https://patches.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1478674773-40898-1-git-send-email-wei.zhao1@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/16978/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/16978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E15FA377A;\n\tWed, 9 Nov 2016 08:02:43 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id ABBD83238\n\tfor <dev@dpdk.org>; Wed, 9 Nov 2016 08:02:41 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 08 Nov 2016 23:02:40 -0800", "from dpdk1.bj.intel.com ([172.16.182.84])\n\tby orsmga003.jf.intel.com with ESMTP; 08 Nov 2016 23:02:39 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,465,1473145200\"; d=\"scan'208\";a=\"899378088\"", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "zhao wei <wei.zhao1@intel.com>", "Date": "Wed, 9 Nov 2016 14:59:33 +0800", "Message-Id": "<1478674773-40898-1-git-send-email-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.5.5", "Subject": "[dpdk-dev] [PATCH] net/ixgbe: fix link never come up problem with\n\tx552", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: zhao wei <wei.zhao1@intel.com>\n\nThe links never coming up with DPDK16.11 when bring up x552 NIC,\ndevice id is 15ac.This is caused by delete some code which casing\nremoves X550em SFP iXFI setup for the drivers in function\nixgbe_setup_mac_link_sfp_x550em().Fix methord is recover\nthe deleted code.\n\nFixes: 1726b9cd9c40 (\"net/ixgbe/base: remove X550em SFP iXFI setup\")\nSigned-off-by: zhao wei <wei.zhao1@intel.com>\n---\n drivers/net/ixgbe/base/ixgbe_x550.c | 57 ++++++++++++++++++++++++++++++-------\n 1 file changed, 46 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex 87d4302..acb8140 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -2762,18 +2762,53 @@ s32 ixgbe_setup_mac_link_sfp_x550em(struct ixgbe_hw *hw,\n \tif (ret_val != IXGBE_SUCCESS)\n \t\treturn ret_val;\n \n-\t/* Configure internal PHY for KR/KX. */\n-\tixgbe_setup_kr_speed_x550em(hw, speed);\n-\n-\t/* Configure CS4227 LINE side to proper mode. */\n-\treg_slice = IXGBE_CS4227_LINE_SPARE24_LSB +\n-\t\t (hw->bus.lan_id << 12);\n-\tif (setup_linear)\n-\t\treg_val = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;\n-\telse\n+\tif (!(hw->phy.nw_mng_if_sel & IXGBE_NW_MNG_IF_SEL_INT_PHY_MODE)) {\n+\t\t/* Configure CS4227 LINE side to 10G SR. */\n+\t\treg_slice = IXGBE_CS4227_LINE_SPARE22_MSB +\n+\t\t\t (hw->bus.lan_id << 12);\n+\t\treg_val = IXGBE_CS4227_SPEED_10G;\n+\t\tret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,\n+\t\t\t\t\t\t reg_val);\n+\n+\t\treg_slice = IXGBE_CS4227_LINE_SPARE24_LSB +\n+\t\t\t (hw->bus.lan_id << 12);\n \t\treg_val = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;\n-\tret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,\n-\t\t\t\t\t reg_val);\n+\t\tret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,\n+\t\t\t\t\t\t reg_val);\n+\n+\t\t/* Configure CS4227 for HOST connection rate then type. */\n+\t\treg_slice = IXGBE_CS4227_HOST_SPARE22_MSB +\n+\t\t\t (hw->bus.lan_id << 12);\n+\t\treg_val = (speed & IXGBE_LINK_SPEED_10GB_FULL) ?\n+\t\tIXGBE_CS4227_SPEED_10G : IXGBE_CS4227_SPEED_1G;\n+\t\tret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,\n+\t\t\t\t\t\t reg_val);\n+\n+\t\treg_slice = IXGBE_CS4227_HOST_SPARE24_LSB +\n+\t\t\t (hw->bus.lan_id << 12);\n+\t\tif (setup_linear)\n+\t\t\treg_val = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;\n+\t\telse\n+\t\t\treg_val = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;\n+\t\tret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,\n+\t\t\t\t\t\t reg_val);\n+\n+\t\t/* Setup XFI internal link. */\n+\t\tret_val = ixgbe_setup_ixfi_x550em(hw, &speed);\n+\t} else {\n+\t\t/* Configure internal PHY for KR/KX. */\n+\t\tixgbe_setup_kr_speed_x550em(hw, speed);\n+\n+\t\t/* Configure CS4227 LINE side to proper mode. */\n+\t\treg_slice = IXGBE_CS4227_LINE_SPARE24_LSB +\n+\t\t\t (hw->bus.lan_id << 12);\n+\t\tif (setup_linear)\n+\t\t\treg_val = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;\n+\t\telse\n+\t\t\treg_val = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;\n+\t\tret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,\n+\t\t\t\t\t\t reg_val);\n+\t}\n \treturn ret_val;\n }\n \n", "prefixes": [ "dpdk-dev" ] }