Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1659/?format=api
{ "id": 1659, "url": "https://patches.dpdk.org/api/patches/1659/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1417105695-8531-2-git-send-email-jijiang.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1417105695-8531-2-git-send-email-jijiang.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1417105695-8531-2-git-send-email-jijiang.liu@intel.com", "date": "2014-11-27T16:28:12", "name": "[dpdk-dev,v2,1/4] mbuf:add three TX offload flags and change three fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4d311e12e4790f75e8557a51b5f8026624eaa7bd", "submitter": { "id": 52, "url": "https://patches.dpdk.org/api/people/52/?format=api", "name": "Jijiang Liu", "email": "jijiang.liu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1417105695-8531-2-git-send-email-jijiang.liu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1659/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1659/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BAAE2803C;\n\tThu, 27 Nov 2014 17:28:37 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 113178036\n\tfor <dev@dpdk.org>; Thu, 27 Nov 2014 17:28:32 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 27 Nov 2014 08:28:29 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 27 Nov 2014 08:28:25 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sARGSOCJ007071;\n\tFri, 28 Nov 2014 00:28:24 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sARGSMCj008573; Fri, 28 Nov 2014 00:28:24 +0800", "(from jijiangl@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sARGSLep008569; \n\tFri, 28 Nov 2014 00:28:21 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,470,1413270000\"; d=\"scan'208\";a=\"629275918\"", "From": "Jijiang Liu <jijiang.liu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 28 Nov 2014 00:28:12 +0800", "Message-Id": "<1417105695-8531-2-git-send-email-jijiang.liu@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1417105695-8531-1-git-send-email-jijiang.liu@intel.com>", "References": "<1417105695-8531-1-git-send-email-jijiang.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/4] mbuf:add three TX offload flags and\n\tchange three fields", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In place of removing the PKT_TX_VXLAN_CKSUM, we introduce 3 new flags: PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV6 and PKT_TX_UDP_TUNNEL_PKT, and a new field: l4_tun_len.\nReplace the inner_l2_len and the inner_l3_len field with the outer_l2_len and outer_l3_len field.\n \nPKT_TX_OUTER_IP_CKSUM: is not used for non-tunnelling packet;hardware outer checksum for tunnelling packet.\nPKT_TX_OUTER_IPV6: Tell the NIC it's an outer IPv6 packet for tunneling packet.\nPKT_TX_UDP_TUNNEL_PKT: is used to tell PMD that the transmit packet is a UDP tunneling packet.\nl4_tun_len: for VXLAN packet, it should be udp header length plus VXLAN header length.\n\n\nSigned-off-by: Jijiang Liu <jijiang.liu@intel.com>\n---\n lib/librte_mbuf/rte_mbuf.c | 6 +++++-\n lib/librte_mbuf/rte_mbuf.h | 18 +++++++++++-------\n 2 files changed, 16 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 87c2963..3c47477 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -240,7 +240,11 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask)\n \tcase PKT_TX_SCTP_CKSUM: return \"PKT_TX_SCTP_CKSUM\";\n \tcase PKT_TX_UDP_CKSUM: return \"PKT_TX_UDP_CKSUM\";\n \tcase PKT_TX_IEEE1588_TMST: return \"PKT_TX_IEEE1588_TMST\";\n-\tcase PKT_TX_VXLAN_CKSUM: return \"PKT_TX_VXLAN_CKSUM\";\n+\tcase PKT_TX_UDP_TUNNEL_PKT: return \"PKT_TX_UDP_TUNNEL_PKT\";\n+\tcase PKT_TX_IPV4: return \"PKT_TX_IPV4\";\n+\tcase PKT_TX_IPV6: return \"PKT_TX_IPV6\";\n+\tcase PKT_TX_OUTER_IP_CKSUM: return \"PKT_TX_OUTER_IP_CKSUM\";\n+\tcase PKT_TX_OUTER_IPV6: return \"PKT_TX_OUTER_IPV6\";\n \tcase PKT_TX_TCP_SEG: return \"PKT_TX_TCP_SEG\";\n \tdefault: return NULL;\n \t}\ndiff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex 367fc56..22ee555 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -99,10 +99,9 @@ extern \"C\" {\n #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with IPv6 header. */\n #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR match. */\n #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported if FDIR match. */\n-/* add new RX flags here */\n \n /* add new TX flags here */\n-#define PKT_TX_VXLAN_CKSUM (1ULL << 50) /**< TX checksum of VXLAN computed by NIC */\n+#define PKT_TX_UDP_TUNNEL_PKT (1ULL << 50) /**< TX packet is an UDP tunneling packet */\n #define PKT_TX_IEEE1588_TMST (1ULL << 51) /**< TX IEEE1588 packet to timestamp. */\n \n /**\n@@ -125,13 +124,19 @@ extern \"C\" {\n #define PKT_TX_IP_CKSUM (1ULL << 54) /**< IP cksum of TX pkt. computed by NIC. */\n #define PKT_TX_IPV4_CSUM PKT_TX_IP_CKSUM /**< Alias of PKT_TX_IP_CKSUM. */\n \n+#define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q VLAN packet. */\n+\n /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offload or TSO. */\n #define PKT_TX_IPV4 PKT_RX_IPV4_HDR\n \n /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offload or TSO. */\n #define PKT_TX_IPV6 PKT_RX_IPV6_HDR\n \n-#define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q VLAN packet. */\n+/** Outer IP cksum of TX pkt. computed by NIC for tunneling packet */\n+#define PKT_TX_OUTER_IP_CKSUM (1ULL << 58)\n+\n+/** Tell the NIC it's an outer IPv6 packet for tunneling packet.*/\n+#define PKT_TX_OUTER_IPV6 (1ULL << 59)\n \n /**\n * TCP segmentation offload. To enable this offload feature for a\n@@ -266,10 +271,9 @@ struct rte_mbuf {\n \t\t\tuint64_t tso_segsz:16; /**< TCP TSO segment size */\n \n \t\t\t/* fields for TX offloading of tunnels */\n-\t\t\tuint64_t inner_l3_len:9; /**< inner L3 (IP) Hdr Length. */\n-\t\t\tuint64_t inner_l2_len:7; /**< inner L2 (MAC) Hdr Length. */\n-\n-\t\t\t/* uint64_t unused:8; */\n+\t\t\tuint64_t outer_l3_len:9; /**< outer L3 (IP) Hdr Length. */\n+\t\t\tuint64_t outer_l2_len:7; /**< outer L2 (MAC) Hdr Length. */\n+\t\t\tuint64_t l4_tun_len:8; /**< L4 tunnelling header length */\n \t\t};\n \t};\n } __rte_cache_aligned;\n", "prefixes": [ "dpdk-dev", "v2", "1/4" ] }