Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/15356/?format=api
{ "id": 15356, "url": "https://patches.dpdk.org/api/patches/15356/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1472210279-8286-2-git-send-email-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1472210279-8286-2-git-send-email-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1472210279-8286-2-git-send-email-ferruh.yigit@intel.com", "date": "2016-08-26T11:17:38", "name": "[dpdk-dev,01/22] net/pcap: convert config option to a macro", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5d05192df00af97ea947e1968e6462a0d00275b9", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1472210279-8286-2-git-send-email-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/15356/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/15356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 708F858DF;\n\tFri, 26 Aug 2016 13:18:51 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id BA4C958D8\n\tfor <dev@dpdk.org>; Fri, 26 Aug 2016 13:18:49 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga105.jf.intel.com with ESMTP; 26 Aug 2016 04:18:48 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 26 Aug 2016 04:18:48 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tu7QBIlGA029922 for <dev@dpdk.org>; Fri, 26 Aug 2016 12:18:47 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id u7QBIlBF008343\n\tfor <dev@dpdk.org>; Fri, 26 Aug 2016 12:18:47 +0100", "(from fyigit@localhost)\n\tby sivswdev02.ir.intel.com with id u7QBIlqd008339\n\tfor dev@dpdk.org; Fri, 26 Aug 2016 12:18:47 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.28,580,1464678000\"; d=\"scan'208\";\n\ta=\"1031638607\"", "X-Authentication-Warning": "sivswdev02.ir.intel.com: fyigit set sender to\n\tferruh.yigit@intel.com using -f", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 26 Aug 2016 12:17:38 +0100", "Message-Id": "<1472210279-8286-2-git-send-email-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1472210279-8286-1-git-send-email-ferruh.yigit@intel.com>", "References": "<1472210279-8286-1-git-send-email-ferruh.yigit@intel.com>", "Subject": "[dpdk-dev] [PATCH 01/22] net/pcap: convert config option to a macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "pcap pmd is using ring pmd configuration parameters to set max number of\nqueues. This creates an unnecessary dependency and confusion.\n\nStop using configuration parameter to set max number of queues and\nconvert this variable into a macro within source code, to simplify\nconfiguration file.\n\nDefault value of macro is same as ring parameter default.\n\npcap pmd doesn't need to be configured in a detail to set rx and tx max\nqueue numbers separately, so using same macro for both queues.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/net/pcap/rte_eth_pcap.c | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex 7e213eb..a0ed1bf 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -1,7 +1,7 @@\n /*-\n * BSD LICENSE\n *\n- * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.\n+ * Copyright(c) 2010-2016 Intel Corporation. All rights reserved.\n * Copyright(c) 2014 6WIND S.A.\n * All rights reserved.\n *\n@@ -58,6 +58,8 @@\n \n #define ETH_PCAP_ARG_MAXLEN\t64\n \n+#define RTE_PMD_PCAP_MAX_QUEUES 16\n+\n static char errbuf[PCAP_ERRBUF_SIZE];\n static unsigned char tx_pcap_data[RTE_ETH_PCAP_SNAPLEN];\n static struct timeval start_time;\n@@ -87,22 +89,22 @@ struct pcap_tx_queue {\n \n struct rx_pcaps {\n \tunsigned num_of_rx;\n-\tpcap_t *pcaps[RTE_PMD_RING_MAX_RX_RINGS];\n-\tconst char *names[RTE_PMD_RING_MAX_RX_RINGS];\n-\tconst char *types[RTE_PMD_RING_MAX_RX_RINGS];\n+\tpcap_t *pcaps[RTE_PMD_PCAP_MAX_QUEUES];\n+\tconst char *names[RTE_PMD_PCAP_MAX_QUEUES];\n+\tconst char *types[RTE_PMD_PCAP_MAX_QUEUES];\n };\n \n struct tx_pcaps {\n \tunsigned num_of_tx;\n-\tpcap_dumper_t *dumpers[RTE_PMD_RING_MAX_TX_RINGS];\n-\tpcap_t *pcaps[RTE_PMD_RING_MAX_RX_RINGS];\n-\tconst char *names[RTE_PMD_RING_MAX_RX_RINGS];\n-\tconst char *types[RTE_PMD_RING_MAX_RX_RINGS];\n+\tpcap_dumper_t *dumpers[RTE_PMD_PCAP_MAX_QUEUES];\n+\tpcap_t *pcaps[RTE_PMD_PCAP_MAX_QUEUES];\n+\tconst char *names[RTE_PMD_PCAP_MAX_QUEUES];\n+\tconst char *types[RTE_PMD_PCAP_MAX_QUEUES];\n };\n \n struct pmd_internals {\n-\tstruct pcap_rx_queue rx_queue[RTE_PMD_RING_MAX_RX_RINGS];\n-\tstruct pcap_tx_queue tx_queue[RTE_PMD_RING_MAX_TX_RINGS];\n+\tstruct pcap_rx_queue rx_queue[RTE_PMD_PCAP_MAX_QUEUES];\n+\tstruct pcap_tx_queue tx_queue[RTE_PMD_PCAP_MAX_QUEUES];\n \tint if_index;\n \tint single_iface;\n };\n", "prefixes": [ "dpdk-dev", "01/22" ] }