Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14305/?format=api
{ "id": 14305, "url": "https://patches.dpdk.org/api/patches/14305/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1466721363-24546-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1466721363-24546-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1466721363-24546-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-06-23T22:36:03", "name": "[dpdk-dev] mk: fix parallel build of test resources", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "574eac5208c0359e56426c90305301acdde1ef7d", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1466721363-24546-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/14305/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/14305/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 93F78C63A;\n\tFri, 24 Jun 2016 00:36:14 +0200 (CEST)", "from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 1C5F7C628\n\tfor <dev@dpdk.org>; Fri, 24 Jun 2016 00:36:13 +0200 (CEST)", "by mail-wm0-f47.google.com with SMTP id 187so6207242wmz.1\n\tfor <dev@dpdk.org>; Thu, 23 Jun 2016 15:36:13 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tk3sm2104661wju.29.2016.06.23.15.36.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 23 Jun 2016 15:36:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=EpLxKL9fTtTfof63HfcJZz/CppQiJF7O/UtKUYrlhCk=;\n\tb=poj1OApGS4EnuYPZbFd+qeWxLVR4sAUYzCzAwHipKJKpQAtdVtA0Unaz08Dk83HOki\n\tN7T4kuzl7+RgBjvvkbHGGTxU4WUyQmfxURJn61dKezLa0wYS8lFcA8USGOBCQs7cYn8e\n\tWIM21TM8sVNHe4OrtvDXFx0hMJsuuxMmKuNy8M1ET+GYsxR3z+NgZDQnD3kIz0pCux6I\n\tc5O1qU9foponRTpJI02VgIlOM0ppNWVXd+Iiap/SDRVMCA4p7q7BIzXMquT06vkcdyQc\n\tHpfeJCDiPR8ByLGvv5RzM8teyUJMOLKlsZTrM++OTIeoqErDWsuMhqYJmuvTui6FDLUR\n\t35hA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=EpLxKL9fTtTfof63HfcJZz/CppQiJF7O/UtKUYrlhCk=;\n\tb=FEoddDsmkG/jlQ25wypI37ASkClXYVriihE8tzoeP7y9w0A8HXFevrjh+7c+ak4JMc\n\tpD9lRX1x1EGp5Q6k7kO30rb5e0n2UN711JsDH9PmT5fUCdu1hOz1d/5vSy0slGZfliBp\n\t0UXz9qKmp0J3STOo8hgKu/MsvfV+tGRTwG61BYBQ+D9oPEnXJVbKJpSWolmAzlXUpBzE\n\trLGxgbXvZAFp2TIt7VUBVaK1WoAjdYU3pDiwjnKelcusCL+4s+1vS7vpe5XiZgZ94FHn\n\tdrAzUz06EG+3LxKgEl0uZrG9RJuoHqrRIuNjqUNS/Nx/aRwBNUb7uSEzy+F4mUHRgrR6\n\tY7PA==", "X-Gm-Message-State": "ALyK8tJIHvjl0Fz0JCZSP6+rIpoiqgfGAmLW2fLTNQwGY4nROah/irNq66rx/4e6jmIs03Aa", "X-Received": "by 10.28.138.85 with SMTP id m82mr2850827wmd.88.1466721372648;\n\tThu, 23 Jun 2016 15:36:12 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Jan Viktorin <viktorin@rehivetech.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 24 Jun 2016 00:36:03 +0200", "Message-Id": "<1466721363-24546-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "Subject": "[dpdk-dev] [PATCH] mk: fix parallel build of test resources", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The build was failing sometimes when building with multiple\nparallel jobs:\n # rm build/build/app/test/*res*\n # make -j6\n objcopy: 'resource.tmp': No such file\n\nThe reason is that each resource was built from the same temporary file.\nThe failure is seen because of a race condition when removing the\ntemporary file after each resource creation.\nIt also means that some resources may be created from the wrong source.\n\nThe fix is to have a different temporary file for each resource.\nWe do not use the original source file because it has a long path\nwhich is used by objcopy to name the symbols after some transformations.\nThe trick is to create a symbolic link of the source file if it is not\nalready in the current build directory. Then we just have to replace\nthe dot by an underscore to predict the symbol names to redefine.\n\nFixes: 1e9e0a6270 (\"app/test: fix resource creation with objcopy on FreeBSD\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n app/test/Makefile | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/Makefile b/app/test/Makefile\nindex 9fa03fb..46f6005 100644\n--- a/app/test/Makefile\n+++ b/app/test/Makefile\n@@ -43,14 +43,14 @@ define linked_resource\n SRCS-y += $(1).res.o\n $(1).res.o: $(2)\n \t@ echo ' MKRES $$@'\n-\t$Q ln -fs $$< resource.tmp\n+\t$Q [ \"$$(<D)\" = . ] || ln -fs $$<\n \t$Q $(OBJCOPY) -I binary -B $(RTE_OBJCOPY_ARCH) -O $(RTE_OBJCOPY_TARGET) \\\n \t\t--rename-section \\\n \t\t\t.data=.rodata,alloc,load,data,contents,readonly \\\n-\t\t--redefine-sym _binary_resource_tmp_start=beg_$(1) \\\n-\t\t--redefine-sym _binary_resource_tmp_end=end_$(1) \\\n-\t\t--redefine-sym _binary_resource_tmp_size=siz_$(1) \\\n-\t\tresource.tmp $$@ && rm -f resource.tmp\n+\t\t--redefine-sym _binary_$$(subst .,_,$$(<F))_start=beg_$(1) \\\n+\t\t--redefine-sym _binary_$$(subst .,_,$$(<F))_end=end_$(1) \\\n+\t\t--redefine-sym _binary_$$(subst .,_,$$(<F))_size=siz_$(1) \\\n+\t\t$$(<F) $$@\n endef\n \n ifeq ($(CONFIG_RTE_APP_TEST_RESOURCE_TAR),y)\n", "prefixes": [ "dpdk-dev" ] }