Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139531/?format=api
{ "id": 139531, "url": "https://patches.dpdk.org/api/patches/139531/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419052349.1294696-7-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419052349.1294696-7-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419052349.1294696-7-chaoyong.he@corigine.com", "date": "2024-04-19T05:23:47", "name": "[v2,6/8] net/nfp: unify CPP acquire method", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7087b549661168aac7da4621616e5f692a4bfe5c", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419052349.1294696-7-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31788, "url": "https://patches.dpdk.org/api/series/31788/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31788", "date": "2024-04-19T05:23:42", "name": "[v2,1/8] net/nfp: fix resource leak of secondary process", "version": 2, "mbox": "https://patches.dpdk.org/series/31788/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139531/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139531/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A79E43EAA;\n\tFri, 19 Apr 2024 07:25:04 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 797B340A6C;\n\tFri, 19 Apr 2024 07:24:35 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2111.outbound.protection.outlook.com [40.107.237.111])\n by mails.dpdk.org (Postfix) with ESMTP id D8CD4406B7\n for <dev@dpdk.org>; Fri, 19 Apr 2024 07:24:30 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MW3PR13MB3961.namprd13.prod.outlook.com (2603:10b6:303:2c::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.42; Fri, 19 Apr\n 2024 05:24:29 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7472.042; Fri, 19 Apr 2024\n 05:24:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=L1pxkYoGamXTjnXt3rCkiUcx95On4zGpavTepfJpBc1r0c4OmqKlBEKTpyJ+PN1AFHlmFAbzyXstw7PvUU30AclJ3IttCWIAKZKdO7zGtYC5O4VsKCX2R61cZzwyRf24TC+oqTZxGdWXz8E78oJWsRMWvkApCWAwbPOQXHCZetCosJcGksheFluixuopmNy0us2E9QfVsZ1tNjtUNSJ3s/H5HjdPivmfDeZ5hyyVbBiU5g89kcwTfNDIaiTI+qqXu9DMJbE9hVsCfFr2xXdjGGPMNyWSrjHoKhuv/7uTQLJYnpYDDBIHLBGLLoCP4g959XwwHj3wPZ9fC/vGFOhq7w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=i+jehXNxCdv3Dj+dqEDZ2lob5TqR0HJaQX27VH6ioLg=;\n b=RSsauX12WLLcUz9rYtArf+SeFmG0nlrwbvETpp/8aTHlVDbc3IPSTre+0OvF3Fw/PCkBAucKWB7FoWTkIGDyeOkFupfN72yxmh7Cvon91hd/MnU3xqMeIDy/BzwMeo9Z9Nu17mIM9luzTnunsU0tR1gmmmo9VKfZYRR9LsfqVv+WJ/sKeMO/jzY1VvVrmlBAH8IX+7+uRgFnrha/A5qsmBVDSf7UVaGyQE14cNO+atHOT1mGNxB3+jkr+LAMcg46OCJ5kXi254R6vhKKkc8XuF+6HJ279eQYZx7i5RceXEexi92kfppBez/uwZWYtLvng6uWuE3YrAXMLiceNxDDXQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=i+jehXNxCdv3Dj+dqEDZ2lob5TqR0HJaQX27VH6ioLg=;\n b=WCXFR1npLXrQJ1BBspxhLCbIfrHXWBdoS33uZY9n9T2bs9zZs+2N9zc77Mbc2e1HqFYQt6vQczfEuYpvqYg5DDFZvTEmH3M1CHgCWmsrkwulPepJin04bDva7l3ULjGjazArh8pWSscSf6YwlcU9p33J7Vel7BqgrA5kJQOjxhQ=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v2 6/8] net/nfp: unify CPP acquire method", "Date": "Fri, 19 Apr 2024 13:23:47 +0800", "Message-Id": "<20240419052349.1294696-7-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240419052349.1294696-1-chaoyong.he@corigine.com>", "References": "<20240419031226.1191069-1-chaoyong.he@corigine.com>\n <20240419052349.1294696-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR03CA0087.apcprd03.prod.outlook.com\n (2603:1096:4:7c::15) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MW3PR13MB3961:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8e17b39c-687c-4e78-d5db-08dc6030fc43", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n CLrz2YVfv9OWHIG61lLfBMWw6UYmXHw1m5vswsMTyGK/e0NBNIPaVgzhNx+UVQNirBX1SWwHOXWbpMVGWSRaUK1wX0+6jMIB378Wc4xUY65sraEDyGTeyo9YxbPkuBA9AfguUMSCMHBPoI4AUjUbQSUKn+xLHdS4kb3ZYDLgWOTKGarNwJyFNfiL/Vt8oO+ULGS8p6wvjXCFqu17EqH9BgHPHlfTEYArNkCUyXb2cEXwA39ptdhsAKD4vYy/MhA28xMrtwYTXPoSSeXy1ShZGcUnjRsoqFS9nJpcJy7PTQJk60FnUnNUS1j0Mr0Tib/GRdnSIIsftCiGS4VVhSh466qumuKM9NbHB17JBdQ1K51wNqkSleYWerC6nAy4xvKU+/pi2AVoTJFb8j3g5PV4yZ9v7gfqoE2Pyo/4wGh/itW3OyDey3V3FF0gND2brjIoO/t2rr8mjwWhE3wLAZCCzMxGQyvMjfgspmpSTPkCwkALQ4thAIPKBbIw9qfrMEwbHxlskSf3x5uxzUBOhD2Z9h6x8PRKVHHcV2NT1oUSPKeW/sa68ybwoPw1DYAVlYarEI0R0DkAW7jEnmUCl83L1cntOmQt41hsCYudXePg5JhnhO/nOFPyYxOuh2tiAphwLefLz/Ui8e6EkrOwyEFiXM3BYDtN5St3Iy6jPb/zD8RyZgblGq7sH0eQNxgL/EIj/cjwCkPX/r9dHN7vLNNTR91jvrZpCVgXbWNNFnLL7sDlakVvhlEiEmxQM+S1IWKVkyl72Lh0iJ8kX5pZhLFlE1Hwav8IT5vLgWOamhpL9f7BCtQN+8BJpmPcfkYIRZBr7GdbI921gjKCflejy71ahHIzKv3+dIamyGzRBPL1hte9vo/0XYhMwhBXEPASj9EIF8vQvZ2AzOqmJ/lqnNJnWmgs/gEHNpQUB6f5yc5L+xmshkeJR/qD4gT8mm2CloGkowWQU6lywFZBGNDTms/3m09EBG1dmj5k1VdrxUOeNfaBLMCwXp/B7E57gYkTd3aHYZaRymFhBGP6szUUq1zFa08/TGpqnw2m4MgTMm81Mfux779vEY191zexW4MFiLA9kOs/V5fyqukBEocF7Z3O4t1rCYcDHESNL6G++HRiQGU9T/ANEHv8uL7u+vPjunCE0knJVzmEcdYqxU4N51O2X303SlCnosN6lvvOA/12Dkzbd0AYE3AvN6bGki/Yyi1MVJGMKdrU7RECV0W66TEdcRMm3Gd9G9l3aYmX67sHbdw7yI63vGpFWmDoNXEeFG/IuMnOV0rj4u5TCwRY+c6zM2KA7xRfJyvWAXVRI9TXv7Y2Go7McjTApKrkygKvA1ZM32TNohGzbVxpfR/D+JZpqA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(52116005)(1800799015)(366007)(376005)(38350700005); DIR:OUT;\n SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n W9YZD+aZGYEyC27hQDV6vZ0Ls0BPehp6nlzUQgBBsHK6dNeQU+tSpPtDSzBtoRiL1f1GTdUo6ZXm1REndQzLjXVGbBkromTcUyjt9WFMs+l9PnQPM2D3C2mInDwukeX9SrOT9FZOLDkNfPqiHtjTp8uOaTKSTwLdL8jHSObzDPFt4+hd7MYE8m2zVtXAWB/UnZLMtLA2uuLbpChlfl4bCN39PMgkT1/nBdMNgyEkokTVaPGjwY7gMiCg+4v69sMf7NIN2xmJQy1NqX+oGrzZY2rZkvENYesoyaBZOMj7EKyX5xtXDNh+I6/YRvJI5yWpZPQqiCATsxDroU2TAJryhMCLEUoWoweMustLJW0rImOv/+sE5dmQNizjUeNoG4wKBhrPg8HmqDSInUzJmOS8SdeNX9oUVrc3vyjo8vwHoIR3yI3s/MaapmmYQDcQM6Lshpe8PRS0QFBV9XTjb7tT6Bw1QD1E/N5oNMvRNe2F5yWeSDeYWx33RaqA6IHgL+IIvLcdknItL9VBq3utg/bK8M4qKfyf20KfGldizd6ce1WXUIUDunSZOV/CCzy9X6H6MFaEoSiHiJ+f0I93Fxlbk55nwDvm9bzjy1Vj6MKRPq4NmnNGi6bbCrSofaa7pHxjN9ytIaaJATKFyELeVJFj3k4Tmt7ZJvoqOvvFqWKjOVIobWIDWZkHZrE9+d21x1O22+f08/Itd+BvGrgpHNwnr/MHvAY9eWtms87ZnjQ4Oh2VkSzSqwHHeWRJyI7YPAWISjbbSIe6lGjRT7R6hgCvFs0wgDwVQFKnkn8XL1tDXs2kasIBOC+NZ1gbt3O28lYuKyNClruVrr0yjAUtmuXDGYcUL6zTa2lQ+GYvsMReQaFZBghMqImnB+/8l68Ql9IV6F8XAfIeEFFc4jMicHnvKD5nFp6jtsJ71FoJVkm1TYKRwZaCJAFXf2hqUJ4zmSczomtXhwTpBIW0BTzIMW9OwcGMc40MeGMhAbCIfLcb4nb0Zl22sYofDffDWKg1u5ZGzpmvS55PIHqqMTSivBa/Fc3DAN+VQUBDj6ccbEPIYGylv5Z25oGjpKYX/vZEQbW0buccH6Xq/kbK88oihtisITt8yzIsSMaxYTG+xZ1TVhdu+NZZmL9bIJMXOrnaVhAI8A4Pz07a9t/oCbFU5gtHMcdgIy/x1eagqefW3gL1aEZ2Tj92IlwXpD1cKaSvAjDj4amxU9kKTYYEJyA1xzP74lJ1Zk1zoSbSv9QKuTD8FbfPMMY+LwUG4tQMZMLA1xIdEp8HDrIxgJXu3zP9c7PYOtEiJ+j9B+XV8/dbOXx/MhnQ6c1PA/oO1eEgRNit5rE4bWX0F9qsRsgbOyYy3aPqcO0SfnTCxrqyxYmUjnEHFP0s8aycTbawy7giZCxIh9J8ynYMSXFROX3EGZAoZ+posiAiFcH4pLqmFAK8l9lO3rylwN++5GEQhxCsMpZECYuYZeNaeNI00KOZXqdAqBLGk/QWs14vBfYGQbo91+AxIgbPI/4jmYxXw1CCoJhAc0xO9Xp0SSv4zCLyng5SWyd9sBgVrfxEwLMxObQUh/+GJk3pM23bIMtK/kCciuZiFpgwuQ8PLA05ESWOD47nT5KqPw==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8e17b39c-687c-4e78-d5db-08dc6030fc43", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Apr 2024 05:24:29.4386 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n ld8D+6gU913FuYPbPZQVimhqD7hqkUj0CnfpEsxcu6zJIs0i3uNHWIb2fgXoc3WfCwwVjeg0X1+oFKFnwlNNPD/xyD5FXntFSPYCenl5i/k=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW3PR13MB3961", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Getting CPP from 'struct nfp_net_hw' is not right in multiple process\nuser case. Modify the data structure and related logic to get it from\nprocess private data structure.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower.c | 4 ---\n .../net/nfp/flower/nfp_flower_representor.c | 2 +-\n drivers/net/nfp/nfp_ethdev.c | 31 +++-------------\n drivers/net/nfp/nfp_net_common.c | 36 ++++++++-----------\n drivers/net/nfp/nfp_net_common.h | 3 +-\n 5 files changed, 22 insertions(+), 54 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c\nindex 80874e23de..83249feedb 100644\n--- a/drivers/net/nfp/flower/nfp_flower.c\n+++ b/drivers/net/nfp/flower/nfp_flower.c\n@@ -707,7 +707,6 @@ nfp_init_app_fw_flower(struct nfp_net_hw_priv *hw_priv)\n \t/* Fill in the PF vNIC and populate app struct */\n \tapp_fw_flower->pf_hw = pf_hw;\n \tpf_hw->super.ctrl_bar = pf_dev->ctrl_bar;\n-\tpf_hw->cpp = pf_dev->cpp;\n \n \tret = nfp_flower_init_vnic_common(hw_priv, pf_hw, \"pf_vnic\");\n \tif (ret != 0) {\n@@ -730,9 +729,6 @@ nfp_init_app_fw_flower(struct nfp_net_hw_priv *hw_priv)\n \t\tgoto pf_cpp_area_cleanup;\n \t}\n \n-\t/* Now populate the ctrl vNIC */\n-\tctrl_hw->cpp = pf_dev->cpp;\n-\n \tret = nfp_flower_init_ctrl_vnic(app_fw_flower, hw_priv);\n \tif (ret != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Could not initialize flower ctrl vNIC\");\ndiff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c\nindex 934f078dca..0e19723f57 100644\n--- a/drivers/net/nfp/flower/nfp_flower_representor.c\n+++ b/drivers/net/nfp/flower/nfp_flower_representor.c\n@@ -826,7 +826,7 @@ nfp_flower_repr_alloc(struct nfp_app_fw_flower *app_fw_flower,\n \t */\n \tfor (i = 0; i < app_fw_flower->num_vf_reprs; i++) {\n \t\tflower_repr.repr_type = NFP_REPR_TYPE_VF;\n-\t\tflower_repr.port_id = nfp_get_pcie_port_id(app_fw_flower->pf_hw->cpp,\n+\t\tflower_repr.port_id = nfp_get_pcie_port_id(hw_priv->pf_dev->cpp,\n \t\t\t\tNFP_FLOWER_CMSG_PORT_VNIC_TYPE_VF, i, 0);\n \t\tflower_repr.nfp_idx = 0;\n \t\tflower_repr.vf_id = i;\ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 38fe153ab4..258b617eb2 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -224,7 +224,7 @@ nfp_net_speed_configure(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n-\tnsp = nfp_eth_config_start(net_hw->cpp, eth_port->index);\n+\tnsp = nfp_eth_config_start(hw_priv->pf_dev->cpp, eth_port->index);\n \tif (nsp == NULL) {\n \t\tPMD_DRV_LOG(ERR, \"Couldn't get NSP.\");\n \t\treturn -EIO;\n@@ -267,7 +267,6 @@ nfp_net_start(struct rte_eth_dev *dev)\n \tuint16_t i;\n \tstruct nfp_hw *hw;\n \tuint32_t new_ctrl;\n-\tstruct nfp_cpp *cpp;\n \tuint32_t update = 0;\n \tuint32_t cap_extend;\n \tuint32_t intr_vector;\n@@ -402,13 +401,8 @@ nfp_net_start(struct rte_eth_dev *dev)\n \t\tgoto error;\n \t}\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\tcpp = net_hw->cpp;\n-\telse\n-\t\tcpp = pf_dev->cpp;\n-\n \t/* Configure the physical port up */\n-\tnfp_eth_set_configured(cpp, net_hw->nfp_idx, 1);\n+\tnfp_eth_set_configured(pf_dev->cpp, net_hw->nfp_idx, 1);\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n \t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n@@ -440,38 +434,26 @@ nfp_net_start(struct rte_eth_dev *dev)\n static int\n nfp_net_set_link_up(struct rte_eth_dev *dev)\n {\n-\tstruct nfp_cpp *cpp;\n \tstruct nfp_net_hw *hw;\n \tstruct nfp_net_hw_priv *hw_priv;\n \n \thw = dev->data->dev_private;\n \thw_priv = dev->process_private;\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\tcpp = hw->cpp;\n-\telse\n-\t\tcpp = hw_priv->pf_dev->cpp;\n-\n-\treturn nfp_eth_set_configured(cpp, hw->nfp_idx, 1);\n+\treturn nfp_eth_set_configured(hw_priv->pf_dev->cpp, hw->nfp_idx, 1);\n }\n \n /* Set the link down. */\n static int\n nfp_net_set_link_down(struct rte_eth_dev *dev)\n {\n-\tstruct nfp_cpp *cpp;\n \tstruct nfp_net_hw *hw;\n \tstruct nfp_net_hw_priv *hw_priv;\n \n \thw = dev->data->dev_private;\n \thw_priv = dev->process_private;\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\tcpp = hw->cpp;\n-\telse\n-\t\tcpp = hw_priv->pf_dev->cpp;\n-\n-\treturn nfp_eth_set_configured(cpp, hw->nfp_idx, 0);\n+\treturn nfp_eth_set_configured(hw_priv->pf_dev->cpp, hw->nfp_idx, 0);\n }\n \n static uint8_t\n@@ -1178,7 +1160,6 @@ nfp_fw_check_change(struct nfp_cpp *cpp,\n \t\tbool *fw_changed)\n {\n \tint ret;\n-\tstruct nfp_net_hw hw;\n \tuint32_t new_version = 0;\n \tuint32_t old_version = 0;\n \n@@ -1186,8 +1167,7 @@ nfp_fw_check_change(struct nfp_cpp *cpp,\n \tif (ret != 0)\n \t\treturn ret;\n \n-\thw.cpp = cpp;\n-\tnfp_net_get_fw_version(&hw, &old_version);\n+\tnfp_net_get_fw_version(cpp, &old_version);\n \n \tif (new_version != old_version) {\n \t\tPMD_DRV_LOG(INFO, \"FW version is changed, new %u, old %u\",\n@@ -1600,7 +1580,6 @@ nfp_init_app_fw_nic(struct nfp_net_hw_priv *hw_priv)\n \t\t/* Add this device to the PF's array of physical ports */\n \t\tapp_fw_nic->ports[id] = hw;\n \n-\t\thw->cpp = pf_dev->cpp;\n \t\thw->eth_dev = eth_dev;\n \t\thw->idx = id;\n \t\thw->nfp_idx = nfp_eth_table->ports[id].index;\ndiff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex 8cc8b77318..7541afa235 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -695,7 +695,7 @@ nfp_net_speed_aneg_update(struct rte_eth_dev *dev,\n \n \t/* Compare whether the current status has changed. */\n \tif (dev->data->dev_link.link_status != link->link_status) {\n-\t\tnfp_eth_table = nfp_eth_read_ports(hw->cpp);\n+\t\tnfp_eth_table = nfp_eth_read_ports(hw_priv->pf_dev->cpp);\n \t\tif (nfp_eth_table == NULL) {\n \t\t\tPMD_DRV_LOG(DEBUG, \"Error reading NFP ethernet table.\");\n \t\t\treturn -EIO;\n@@ -2094,12 +2094,12 @@ nfp_net_cfg_read_version(struct nfp_net_hw *hw)\n }\n \n static void\n-nfp_net_get_nsp_info(struct nfp_net_hw *hw,\n+nfp_net_get_nsp_info(struct nfp_net_hw_priv *hw_priv,\n \t\tchar *nsp_version)\n {\n \tstruct nfp_nsp *nsp;\n \n-\tnsp = nfp_nsp_open(hw->cpp);\n+\tnsp = nfp_nsp_open(hw_priv->pf_dev->cpp);\n \tif (nsp == NULL)\n \t\treturn;\n \n@@ -2111,12 +2111,12 @@ nfp_net_get_nsp_info(struct nfp_net_hw *hw,\n }\n \n void\n-nfp_net_get_fw_version(struct nfp_net_hw *hw,\n+nfp_net_get_fw_version(struct nfp_cpp *cpp,\n \t\tuint32_t *mip_version)\n {\n \tstruct nfp_mip *mip;\n \n-\tmip = nfp_mip_open(hw->cpp);\n+\tmip = nfp_mip_open(cpp);\n \tif (mip == NULL) {\n \t\t*mip_version = 0;\n \t\treturn;\n@@ -2128,12 +2128,12 @@ nfp_net_get_fw_version(struct nfp_net_hw *hw,\n }\n \n static void\n-nfp_net_get_mip_name(struct nfp_net_hw *hw,\n+nfp_net_get_mip_name(struct nfp_net_hw_priv *hw_priv,\n \t\tchar *mip_name)\n {\n \tstruct nfp_mip *mip;\n \n-\tmip = nfp_mip_open(hw->cpp);\n+\tmip = nfp_mip_open(hw_priv->pf_dev->cpp);\n \tif (mip == NULL)\n \t\treturn;\n \n@@ -2185,8 +2185,8 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,\n \t\tsnprintf(vnic_version, FW_VER_LEN, \"*\");\n \t}\n \n-\tnfp_net_get_nsp_info(hw, nsp_version);\n-\tnfp_net_get_mip_name(hw, mip_name);\n+\tnfp_net_get_nsp_info(hw_priv, nsp_version);\n+\tnfp_net_get_mip_name(hw_priv, mip_name);\n \tnfp_net_get_app_name(hw_priv, app_name);\n \n \tsnprintf(fw_version, FW_VER_LEN, \"%s %s %s %s\",\n@@ -2220,7 +2220,6 @@ nfp_net_is_valid_nfd_version(struct nfp_net_fw_ver version)\n int\n nfp_net_stop(struct rte_eth_dev *dev)\n {\n-\tstruct nfp_cpp *cpp;\n \tstruct nfp_net_hw *hw;\n \tstruct nfp_net_hw_priv *hw_priv;\n \n@@ -2233,12 +2232,7 @@ nfp_net_stop(struct rte_eth_dev *dev)\n \tnfp_net_stop_tx_queue(dev);\n \tnfp_net_stop_rx_queue(dev);\n \n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\tcpp = hw->cpp;\n-\telse\n-\t\tcpp = hw_priv->pf_dev->cpp;\n-\n-\tnfp_eth_set_configured(cpp, hw->nfp_idx, 0);\n+\tnfp_eth_set_configured(hw_priv->pf_dev->cpp, hw->nfp_idx, 0);\n \n \treturn 0;\n }\n@@ -2285,7 +2279,7 @@ nfp_net_flow_ctrl_get(struct rte_eth_dev *dev,\n }\n \n static int\n-nfp_net_pause_frame_set(struct nfp_net_hw *net_hw,\n+nfp_net_pause_frame_set(struct nfp_net_hw_priv *hw_priv,\n \t\tstruct nfp_eth_table_port *eth_port,\n \t\tenum rte_eth_fc_mode mode)\n {\n@@ -2293,7 +2287,7 @@ nfp_net_pause_frame_set(struct nfp_net_hw *net_hw,\n \tbool flag;\n \tstruct nfp_nsp *nsp;\n \n-\tnsp = nfp_eth_config_start(net_hw->cpp, eth_port->index);\n+\tnsp = nfp_eth_config_start(hw_priv->pf_dev->cpp, eth_port->index);\n \tif (nsp == NULL) {\n \t\tPMD_DRV_LOG(ERR, \"NFP error when obtaining NSP handle.\");\n \t\treturn -EIO;\n@@ -2350,7 +2344,7 @@ nfp_net_flow_ctrl_set(struct rte_eth_dev *dev,\n \tif (set_mode == original_mode)\n \t\treturn 0;\n \n-\tret = nfp_net_pause_frame_set(net_hw, eth_port, set_mode);\n+\tret = nfp_net_pause_frame_set(hw_priv, eth_port, set_mode);\n \tif (ret != 0)\n \t\treturn ret;\n \n@@ -2438,7 +2432,7 @@ nfp_net_fec_get(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \n \tif (dev->data->dev_link.link_status == RTE_ETH_LINK_DOWN) {\n-\t\tnfp_eth_table = nfp_eth_read_ports(hw->cpp);\n+\t\tnfp_eth_table = nfp_eth_read_ports(hw_priv->pf_dev->cpp);\n \t\thw_priv->pf_dev->nfp_eth_table->ports[hw->idx] = nfp_eth_table->ports[hw->idx];\n \t\tfree(nfp_eth_table);\n \t}\n@@ -2520,5 +2514,5 @@ nfp_net_fec_set(struct rte_eth_dev *dev,\n \t\treturn -EIO;\n \t}\n \n-\treturn nfp_eth_set_fec(hw->cpp, eth_port->index, fec);\n+\treturn nfp_eth_set_fec(hw_priv->pf_dev->cpp, eth_port->index, fec);\n }\ndiff --git a/drivers/net/nfp/nfp_net_common.h b/drivers/net/nfp/nfp_net_common.h\nindex 31deeb43ce..40f314af0a 100644\n--- a/drivers/net/nfp/nfp_net_common.h\n+++ b/drivers/net/nfp/nfp_net_common.h\n@@ -201,7 +201,6 @@ struct nfp_net_hw {\n \tstruct rte_eth_stats eth_stats_base;\n \tstruct rte_eth_xstat *eth_xstats_base;\n \n-\tstruct nfp_cpp *cpp;\n \tstruct nfp_cpp_area *ctrl_area;\n \tstruct nfp_cpp_area *mac_stats_area;\n \tuint8_t *mac_stats_bar;\n@@ -322,7 +321,7 @@ int nfp_net_fec_get(struct rte_eth_dev *dev,\n \t\tuint32_t *fec_capa);\n int nfp_net_fec_set(struct rte_eth_dev *dev,\n \t\tuint32_t fec_capa);\n-void nfp_net_get_fw_version(struct nfp_net_hw *hw,\n+void nfp_net_get_fw_version(struct nfp_cpp *cpp,\n \t\tuint32_t *fw_version);\n int nfp_net_txrwb_alloc(struct rte_eth_dev *eth_dev);\n void nfp_net_txrwb_free(struct rte_eth_dev *eth_dev);\n", "prefixes": [ "v2", "6/8" ] }