Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139528/?format=api
{ "id": 139528, "url": "https://patches.dpdk.org/api/patches/139528/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240419052349.1294696-4-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240419052349.1294696-4-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240419052349.1294696-4-chaoyong.he@corigine.com", "date": "2024-04-19T05:23:44", "name": "[v2,3/8] net/nfp: adjust the data field of Rx/Tx queue", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "53f7a42580068d92f851f7c2ef97eae5f8fa8d60", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240419052349.1294696-4-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31788, "url": "https://patches.dpdk.org/api/series/31788/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31788", "date": "2024-04-19T05:23:42", "name": "[v2,1/8] net/nfp: fix resource leak of secondary process", "version": 2, "mbox": "https://patches.dpdk.org/series/31788/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139528/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139528/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 75FC643EAA;\n\tFri, 19 Apr 2024 07:24:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 148F040273;\n\tFri, 19 Apr 2024 07:24:20 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2117.outbound.protection.outlook.com [40.107.237.117])\n by mails.dpdk.org (Postfix) with ESMTP id 4D5E0402F2\n for <dev@dpdk.org>; Fri, 19 Apr 2024 07:24:17 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by MW3PR13MB3961.namprd13.prod.outlook.com (2603:10b6:303:2c::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.42; Fri, 19 Apr\n 2024 05:24:15 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7472.042; Fri, 19 Apr 2024\n 05:24:15 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=KHxg34T8qRTjDClUARc68rHE92X1S9HWw6ja2dJJZ+bzJq0ctkngYoyItDo4kft3qIe/nF63WuT9TIzuSrOXtfhvIR8CdfSLkXquGRejJMQg2TTtlghEwPeqaFFH6pwETdOuPa/lT5873Ki+BaWoaWR4Rc+cdvqtpxofczQlKXeSm2eoaYyi2lZuw6zrWZOpf/GMFm72IH5eyutnL0lpMg6tDrQzvzcbcl7eRauD5/RYuO/ARB2LT7AqA5sFYEwCSBaoXpMmgM7Rtt29zRiTcq5lg4WuIO9aYXen93PAyMyw7JXaIkbD/3IvLxEOKnnafNzrAHd9TCVLCAoXDPExGA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=qLrU4LDRZRZFvGKPWtuEx+PpBj+Wc6LuAtSEPf/cUb0=;\n b=ClG87oNsF1TXbK6Jmj15O8mQp/EoThamV+wR7EeAt94H31/h1PxLA1pvCqzdhcpyoIw8s4spPVMSPTkDmzycMFVp6hKCBGAIbl8Ae6kSdvPdHalGN0IWopjTM/4acynPR2bgRaWipMJEiWrr3Oa9QcaHyvG1GyEt12SFd7hhSoyOtBXMkkZzkNDdahNnRZBcCWKh/bzUk7O6ofQiGf38uKR8vjTpJ7GZLeRblUKcFMJwP8VbxH2+/khfw05iifhcQmm5VgaFh6mxQSb0KywQLjVJOKiyO8/zm6K9jv6C6fFU1EpQRFohq5fiQ89f/uUVgjwspr/Ij+fEXlVRyLcCWw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qLrU4LDRZRZFvGKPWtuEx+PpBj+Wc6LuAtSEPf/cUb0=;\n b=jQ/9jrfdzoJtiYbVniuYEzOw4BJ1wHYujqi5Y0jxtSRU3NTPVwQrdvpVxqA/vESsBXJzjaw8VTUV3hRdAirMcK4Fo7y8XBUYt+5DxBwf3NN5VmQpqefnQSUG0BnrP1yD+qJZ0S9hHz8kwUU3Hqeqwjjyuk0RGoghOA0mKASciC8=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v2 3/8] net/nfp: adjust the data field of Rx/Tx queue", "Date": "Fri, 19 Apr 2024 13:23:44 +0800", "Message-Id": "<20240419052349.1294696-4-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240419052349.1294696-1-chaoyong.he@corigine.com>", "References": "<20240419031226.1191069-1-chaoyong.he@corigine.com>\n <20240419052349.1294696-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR03CA0087.apcprd03.prod.outlook.com\n (2603:1096:4:7c::15) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|MW3PR13MB3961:EE_", "X-MS-Office365-Filtering-Correlation-Id": "191a63ca-8c92-4db5-1598-08dc6030f475", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n CAae8E1ZQ1xXuAv4nEUwxO/nnF4XrLyme5lJ1iX/Jtsd+4Aw8wpzZ9xfgn20behtyCYdCjuepegZUIZim4rNFDiMsm2zIb3DuZOQYnwNHUC1Sk60aiJaCIACnrzfAVyrKfUw/ymbAD0lRu+K/8uHqVXyyiahsdF8h+HJRoEU75M5gRCj+C4zUzn3z4RDvVGYzh62ABq6mgVqHKGeXUVfbLVrQhcgmL8MXNzT9q1V4hANaFLf9GI+bRObDl+nc85c+QWEAdtXJdbqEeHRaKjDlsRgBBSvwX6u5u3TG1hAMZZBSyHa3MlWgOuUMVuO0BAEbMk5XhLbux1bMsFpklOHQ5/PwoBIttCVTq7OjiY97ZNCntNRpCMXpHFsfCOSdInGxCD5Fez/boEQsadQiEA2W+df/CQPG7n1kbKITNc79N/PMYGX6ShgPKCx0RPQBc7tlKOtYlPbjQHN/ugl8yHsvbBMvrzFb5cSIFkI/+tabWrbQcjA85aLhH8AteAyt+N96Xh72Wb0vl1n2QKxZ7KaMt+Gd5I2guqeJAX7OLacYGnuZP1DPaNZXbRUFQPoF3eOSlVH9TrommAfR1xdL+tNm773EcFjhIphZayDMfED5dHn88Q/rknHxQPfYjXY81izpA/d2KdWPOrJAVsHcpPyRxLC/ek997j2FtFhBcerj1P3DWWpR+yYOXA7fUSkdpUE6UypnWbyU01WCsRnTda+xNZA/NU1Rgq4Tb6mZ4Nv1ujCD2o1B0tNv/LRngG2m7pryQtC2vk4Iwli6Ra54ttqinuQi/WljIkXyERCIIo2U4jLApEOFE452Dj4rTTFvISumGfVyZS2hSkhyx7MuzhjuXQdtnrZSBQ1ifjg+mgZZfxsQXYteUc0EW9SIrEPNBM3NW8hff5xWSst9aQpm3T4t2z8SI2F9fG/vchbACKAO/uvfqosYYzxBJV8jX1GlUBKYWlG/gLde/65FypSIHeF7mlVp9/1zXralMMGIim83Ny9uxYISKAA+0OdrxMGrpcPKG+dc9E/iboXsNfRD3kYCQLCqKQRKAuJdfhdsEADPggYRqAzDFHLRBS6vv35TlO2i6Sk5/QROmkp80K/z9x0dKciVbGUyCeIjoAwhdgcxfk8qO2U0ZU6OQC8k4CjSEIiK7E0GekT3AJDt3yHl3qh0GLahbUStCXWOFw6u5wuNsVQNBCMX7+UI1o+MhtOidvOpgHCxYLwoLww41ocExVQF+D+5wUfzBiKAORWffQSc/Hv7ZUAG/GBbyej1wjrBMgNEAJ2Jb3gNOHnJEddF+fhzfXrbvEY6qOj0U8ndi+jXBfaAM3VTUczzgSLm4J7/klKZqNWmqWc7dy2f3u4LaTyyw==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(52116005)(1800799015)(366007)(376005)(38350700005); DIR:OUT;\n SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n ELH6Hy1V4Kar8Bx8/gCg0qOfZq8svalAhUXsa+1WEF66AyjPEAvCG2p3r2wHErTtmyAJaF7OcFnmA/Z4SS2IVA4WABpfMHDHYJ2ZCHNUcwIP7oZ4qrwFM5chf8LVN4+Y7CQIgA2374UI8GsifVjlEZjiNef0i3En8U1AsPOFaMCBvxsswOQFVJ6r2KqNN4bb3Z2fnuV/BlGWvRjp2XJD7/+vSf1OqNs7z8L6ctxkV/gW4+sHsSiDrXIrZh4P3TkZEesNq75gZ18oKuA20x0enRR2hkORa8KbbmFeSG9qWXXR0erJvQN6TzxB43rhEmndgS9I9KVCfYsPJiRHGaIDB8fCQ0Ln2/QCQUmMDF5Bck1Un+LHR01GQZHzQJOxgl+d0DpLc+Cs+mz/3+eC0/A7JagwyPBfMJOq3pmkCD0gjL+x5ENpz1vyRfJZKSDATdTUBl23km4kMUJ0HXaLqDmIiiwXh5fR78q4vHrWc0X+6ykl9Sl6kz5if5ck1yfOfkGix4QVXmH5wPqe66rOwg8TL12dX1ofL7GF5auza/6yre0kExvmsZC3Vgab2GQvP0ofk52K+E2O0fi+rcHoj77NtmDa+kSZxf5w3Yrx+I+dLOVoekqwx2mFsVQftuFmDcDVCby+VFaqjCUWTC5sUZuBk9cnm69UfcUpmOC4M0ymxNAu1DMCloKSB4DH4GvK9hKwvmyih95sCo4N0qMz6bD9tl9/fC/PMhrJuhLOW0bOcYWaMXyteM2B7G71fUymtjHnqqbRgJy5eCX1AcarIDp0O0xIjo7KOvGgHwBHtqw0D5OYqc9c0q0XQ2Qi1P6OamuUPIxCDJQ/qtR6qLAqntRMIfAoXzOm2tXE/UAjVpEbchLVY3W2tdjjyF7XwdI9ldsFeGuqkmV9Yx0XaZvtby299Pc5ELYQsZVDRwjaUEzIFs//QTBYfnonHrFJ9pLvzJw2TAqceexchkPu2mpNW3L8otya9Id9FbVPhtNMSUHRhJTFdhAQ0RGOkXQUo31SUT3q0QtWldrJYbhw7nOOEicH1N9UDsDFy6QyW2dTP4XcLbw32S40Dp098QXaa08MhW+v91HtUQ7vLbLaLauuXHXCKFbTnnXPqOxtX7Fc/08hZ3GQ1A6gTRV5q7S+fl4oo/+RoZNNFoyIJpZjKpmUf/HsgyWQazRSVzCvM9gnvfDEv9NO5WK11ran6aG9Mx/cKL0tVoMNFd1QfvxziENDZ287+YYkdulxTQ0nsckclbmGzsa88/eC0bBJ1cscJEIBYBcI5RoUf9A74PTNTBENsM1wpDxNDoT2ewKNrMem8pxhy157E4LVd3501wpd7wXanJA3jvtnUqjAI04FyuRATnuIXPuaExYJ1HX9Pt3NycB9Azt3Lmy1VpudgfbHOsYmPlz+SmeIKkpwb8fSi146Fmh2xF4Af+LY3C4SyCqQqP2royfimxqeV+vqN5OepvvOHiKIquN8H98ZYMPZktCKzNqDWdSGxdBZB24kcjouMgr2fzXSNMeeBa+BE/7f9+jdvXhtata8/wl9hEgKoDSEjoJ032BKm57aDePxU0Et8Q8/fuJgL4AWRpBkAZQnxmdItq0W8ymM+EYsTJPZUpYtYH0xnQ==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 191a63ca-8c92-4db5-1598-08dc6030f475", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Apr 2024 05:24:15.7143 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n YpqP9oUK5ktEukldSAzYlM1kVdQFZEkY3LwO1Jhk+vHwSgfe3jrAtDzCwzqNtPPwDcwLlzO/RNADRQhyqpc9pBD+eOEjyXddZhlllOq5WaA=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW3PR13MB3961", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Adjust the data field of Rx/Tx queue structure, move the cold data back\nand hold position for hot data.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfp_rxtx.h | 71 +++++++++++++++++++-------------------\n 1 file changed, 36 insertions(+), 35 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h\nindex f463b9cf75..0aa73a6432 100644\n--- a/drivers/net/nfp/nfp_rxtx.h\n+++ b/drivers/net/nfp/nfp_rxtx.h\n@@ -31,21 +31,6 @@ struct nfp_net_txq {\n \t/** Backpointer to nfp_net structure */\n \tstruct nfp_net_hw *hw;\n \n-\t/** Point to the base of the queue structure on the NFP. */\n-\tuint8_t *qcp_q;\n-\n-\t/**\n-\t * Host side read and write pointer, they are free running and\n-\t * have little relation to the QCP pointers.\n-\t */\n-\tuint32_t wr_p;\n-\tuint32_t rd_p;\n-\n-\t/** The size of the queue in number of descriptors. */\n-\tuint32_t tx_count;\n-\n-\tuint32_t tx_free_thresh;\n-\n \t/**\n \t * For each descriptor keep a reference to the mbuf and\n \t * DMA address used until completion is signalled.\n@@ -61,6 +46,18 @@ struct nfp_net_txq {\n \t\tstruct nfp_net_nfdk_tx_desc *ktxds;\n \t};\n \n+\t/**\n+\t * Host side read and write pointer, they are free running and\n+\t * have little relation to the QCP pointers.\n+\t */\n+\tuint32_t wr_p;\n+\tuint32_t rd_p;\n+\n+\t/** The size of the queue in number of descriptors. */\n+\tuint32_t tx_count;\n+\n+\tuint32_t tx_free_thresh;\n+\n \t/** The index of the QCP queue relative to the TX queue BAR. */\n \tuint32_t tx_qcidx;\n \n@@ -72,8 +69,8 @@ struct nfp_net_txq {\n \tuint16_t data_pending;\n \n \t/**\n-\t * At this point 58 bytes have been used for all the fields in the\n-\t * TX critical path. We have room for 6 bytes and still all placed\n+\t * At this point 50 bytes have been used for all the fields in the\n+\t * TX critical path. We have room for 14 bytes and still all placed\n \t * in a cache line.\n \t */\n \tuint64_t dma;\n@@ -83,6 +80,9 @@ struct nfp_net_txq {\n \n \t/** TX pointer ring write back area DMA address */\n \tuint64_t txrwb_dma;\n+\n+\t/** Point to the base of the queue structure on the NFP. */\n+\tuint8_t *qcp_q;\n } __rte_aligned(64);\n \n /* RX and freelist descriptor format */\n@@ -145,19 +145,6 @@ struct nfp_net_rxq {\n \t */\n \tuint8_t *qcp_fl;\n \n-\t/**\n-\t * Host side read pointer, free running and have little relation\n-\t * to the QCP pointers. It is where the driver start reading\n-\t * descriptors for newly arrive packets from.\n-\t */\n-\tuint32_t rd_p;\n-\n-\t/**\n-\t * The index of the QCP queue relative to the RX queue BAR\n-\t * used for the freelist.\n-\t */\n-\tuint32_t fl_qcidx;\n-\n \t/**\n \t * For each buffer placed on the freelist, record the\n \t * associated mbuf.\n@@ -177,6 +164,14 @@ struct nfp_net_rxq {\n \t * safely copied to the mbuf using the NFP_NET_RX_OFFSET.\n \t */\n \tstruct rte_mempool *mem_pool;\n+\n+\t/**\n+\t * Host side read pointer, free running and have little relation\n+\t * to the QCP pointers. It is where the driver start reading\n+\t * descriptors for newly arrive packets from.\n+\t */\n+\tuint32_t rd_p;\n+\n \tuint16_t mbuf_size;\n \n \t/**\n@@ -186,9 +181,6 @@ struct nfp_net_rxq {\n \tuint16_t rx_free_thresh;\n \tuint16_t nb_rx_hold;\n \n-\t /** The size of the queue in number of descriptors */\n-\tuint16_t rx_count;\n-\n \t/** Referencing dev->data->port_id */\n \tuint16_t port_id;\n \n@@ -196,11 +188,20 @@ struct nfp_net_rxq {\n \tuint16_t qidx;\n \n \t/**\n-\t * At this point 60 bytes have been used for all the fields in the\n-\t * RX critical path. We have room for 4 bytes and still all placed\n+\t * At this point 54 bytes have been used for all the fields in the\n+\t * RX critical path. We have room for 10 bytes and still all placed\n \t * in a cache line.\n \t */\n \n+\t/** The size of the queue in number of descriptors */\n+\tuint16_t rx_count;\n+\n+\t/**\n+\t * The index of the QCP queue relative to the RX queue BAR\n+\t * used for the freelist.\n+\t */\n+\tuint32_t fl_qcidx;\n+\n \t/** DMA address of the queue */\n \tuint64_t dma;\n } __rte_aligned(64);\n", "prefixes": [ "v2", "3/8" ] }