Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139255/?format=api
{ "id": 139255, "url": "https://patches.dpdk.org/api/patches/139255/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-6-VenkatKumar.Ande@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240412125249.10625-6-VenkatKumar.Ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240412125249.10625-6-VenkatKumar.Ande@amd.com", "date": "2024-04-12T12:52:31", "name": "[06/24] net/axgbe: reset link when the link never comes back", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "ef9a1d845f93dca6e6545fa292aff38355c41aba", "submitter": { "id": 3256, "url": "https://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240412125249.10625-6-VenkatKumar.Ande@amd.com/mbox/", "series": [ { "id": 31734, "url": "https://patches.dpdk.org/api/series/31734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31734", "date": "2024-04-12T12:52:26", "name": "[01/24] net/axgbe: remove use of comm_owned field", "version": 1, "mbox": "https://patches.dpdk.org/series/31734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/139255/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/139255/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 107DF43E52;\n\tFri, 12 Apr 2024 14:54:01 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EF737410E7;\n\tFri, 12 Apr 2024 14:54:00 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2074.outbound.protection.outlook.com [40.107.92.74])\n by mails.dpdk.org (Postfix) with ESMTP id 1ECFA402A2\n for <dev@dpdk.org>; Fri, 12 Apr 2024 14:53:59 +0200 (CEST)", "from MN2PR22CA0030.namprd22.prod.outlook.com (2603:10b6:208:238::35)\n by CY5PR12MB6204.namprd12.prod.outlook.com (2603:10b6:930:23::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr\n 2024 12:53:57 +0000", "from BL6PEPF00020E5F.namprd04.prod.outlook.com\n (2603:10b6:208:238:cafe::91) by MN2PR22CA0030.outlook.office365.com\n (2603:10b6:208:238::35) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend\n Transport; Fri, 12 Apr 2024 12:53:56 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:53:56 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr\n 2024 07:53:45 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=F/Hld/sa7cPg9nqleUdXoS78xg3X5ghzS5q7j4QBNsVBTDwCh1kv/lk8672fAuB5ju8oHT8CcWa+U5z9t2O3U4yMKHpc27JB8rbs2m+vj0MswBZWInHbxLpnrk9EC4NtVY7nOxL825xlabgJPw6GOxNJDce+Zx45N+sHpQuGX92El3aS8IkQAxNbOUjoerC5nI0RCtTASi4wtM4DYWeazkO8wO522yNCOYuI50l3NYMOwocE9EIW28S3JmhqX4mGb65SEmL1yaYTe7QtP9kRK5sIgs3LLmSHUsIyVXDSV3OF+eMyv9IMIn2mef7sZyDEDdwKS3eH294C9XStMen+3w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=VQjHns85YtttoxKKn81iuuCQmTvr+acC0U7smYN5RUU=;\n b=SWT7t7Sy26KYLoMQh/KUJzuSLSGYzEKVlnOZTOunomLUQ60brfuR/8+2LNCCtup0rilr0pNh3scEs1N+0U3avMINwobil93RxFURgqlzGAdoakNI/YjoA3+qmVVBOQiwnoaVxEKX5sEc+rKOF9nTEbg/kyvNX4vsYgTyCK70FYVudMzxjPY519otUhe2f8mGYkdFcDWK+35E/yCmi4kJBs9fwNvyXADufn/VOb+M4LsKHSK1bIloLeRolfh4dFiyETWsw9eZZ2Cx/2WBhy0951qRTEKR6TdGaY9kiRq6ILgeFq3Sz1nF7PWbZ9EYEP+0CgpHCHOGAW4QEklnE3VEmg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=VQjHns85YtttoxKKn81iuuCQmTvr+acC0U7smYN5RUU=;\n b=ITPXS0Rzuy0Y9S0fiyXUVIRgNAaofXUeaSdhyUwRoJhwCtdrTjxevtOXb5fMtRgSHGc60yEqEJDRSW+/hhUWtqXgyU7BW+4Vvkz5usBr3Gmnp+4ja23zSkIaM6uphBquikUF+IqGuZHy46oGcMeNGgCpojCULMvGCJIBx3iNZP0=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <VenkatKumar.Ande@amd.com>", "Subject": "[PATCH 06/24] net/axgbe: reset link when the link never comes back", "Date": "Fri, 12 Apr 2024 08:52:31 -0400", "Message-ID": "<20240412125249.10625-6-VenkatKumar.Ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "References": "<20240412125249.10625-1-VenkatKumar.Ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF00020E5F:EE_|CY5PR12MB6204:EE_", "X-MS-Office365-Filtering-Correlation-Id": "724ffb69-d98f-464d-1ff8-08dc5aef9db0", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n /G1bsjpZnnOJD8OehEWOtIyK01YPhKhR9JTkXiHIbAlxm4l5iaA4dDLbSj5ZLHpvyHoHzZ/AYPJi6IdjNh1OmP2trHV8ZSWTxPNQJWCtdc5fIwX8hqf48IrDCVLOAy+EYXrp8+uADbpykdvo2Wg5w6FQnQQNQ4Y7GefLroCa7HU32wofzW2de9VllVhRqBw1ATBl+RKDTQ00nSeY6tsMjfduUv05ifO/R3p1qB7R9B1rCPqz/qi/vy9Br9RB3c+TTnMhnJjMisOUftJuGugX0haG3MnNqaNbynVpMI3uqbkakEde7p8nR+euFUzeGPAxzUWiVxYwc4pBF9FOPCBrNzUDHUfW3Ht1KnNOyw+tztfoaOfv6vjluLV1coiUS63u7Sf4ghftNkrAsIhrP69/7FETL5xX1vIflbFJ5x7hVj39MXYsdgv2+Popcp+bLg3mcg4VFE65sUibKOgjG3Z8JUY2TvuyDcQ37sgkMvGTbqXYZ2eqQ5di9ydd99OezNF3ndjQOlLYc8iPz0PyfQ9jmay7oK6HBILK5BsFatHNqVSWfFSZDtewFzaz6bPaVpKWqOkOSzkyZHj+TN8wn14VUBVKuOUM6EYaGsC8B4JR1X/z89Ye1tpIV6y5Kn7ydAT8dpE1UxB9g+pYw3Z9/7IFJu09Tz8owSj2DonIpL7dg9jrjaCpgLei4Ok60ZYWFBQUm0c1arbUV9LwqB6SQK7RkuVMB3n5kNmxXNRroF8F7aPjoGltek8AfO8mHrFGMo01", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Apr 2024 12:53:56.8548 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 724ffb69-d98f-464d-1ff8-08dc5aef9db0", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF00020E5F.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY5PR12MB6204", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Normally, auto negotiation and reconnect should be automatically done by\nthe hardware. But there seems to be an issue where auto negotiation has\nto be restarted manually. This happens because of link training and so\neven though still connected to the partner the link never \"comes back\".\nThis needs an auto-negotiation restart.\n\nSigned-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>\n---\n drivers/net/axgbe/axgbe_mdio.c | 2 +-\n drivers/net/axgbe/axgbe_phy_impl.c | 7 +++++++\n 2 files changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_mdio.c b/drivers/net/axgbe/axgbe_mdio.c\nindex 0beeb1d0f5..151b30e2ab 100644\n--- a/drivers/net/axgbe/axgbe_mdio.c\n+++ b/drivers/net/axgbe/axgbe_mdio.c\n@@ -1058,7 +1058,7 @@ static void axgbe_phy_status(struct axgbe_port *pdata)\n \t\t\t\t\t\t\t &an_restart);\n \tif (an_restart) {\n \t\taxgbe_phy_config_aneg(pdata);\n-\t\treturn;\n+\t\tgoto adjust_link;\n \t}\n \n \tif (pdata->phy.link) {\ndiff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex b5796b13e0..968ff1f867 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -1676,6 +1676,13 @@ static int axgbe_phy_link_status(struct axgbe_port *pdata, int *an_restart)\n \tif (reg & MDIO_STAT1_LSTATUS)\n \t\treturn 1;\n \n+\tif (pdata->phy.autoneg == AUTONEG_ENABLE &&\n+\t\t\tphy_data->port_mode == AXGBE_PORT_MODE_BACKPLANE) {\n+\t\tif (rte_bit_relaxed_get32(AXGBE_LINK_INIT, &pdata->dev_state)) {\n+\t\t\t*an_restart = 1;\n+\t\t}\n+\t}\n+\n \t/* No link, attempt a receiver reset cycle */\n \tif (phy_data->rrc_count++) {\n \t\tphy_data->rrc_count = 0;\n", "prefixes": [ "06/24" ] }