Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/138800/?format=api
{ "id": 138800, "url": "https://patches.dpdk.org/api/patches/138800/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20240326125554.138840-5-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326125554.138840-5-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326125554.138840-5-sivaprasad.tummala@amd.com", "date": "2024-03-26T12:55:43", "name": "[v7,04/14] examples/ipsec-secgw: fix queue ID restriction", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "db94f566947bb533f809d2161b7342a4df17efa2", "submitter": { "id": 2510, "url": "https://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20240326125554.138840-5-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 31619, "url": "https://patches.dpdk.org/api/series/31619/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=31619", "date": "2024-03-26T12:55:39", "name": "fix lcore ID restriction", "version": 7, "mbox": "https://patches.dpdk.org/series/31619/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/138800/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/138800/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8879443D51;\n\tTue, 26 Mar 2024 13:56:54 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0B29F40ED3;\n\tTue, 26 Mar 2024 13:56:48 +0100 (CET)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2087.outbound.protection.outlook.com [40.107.92.87])\n by mails.dpdk.org (Postfix) with ESMTP id 03E2740ED2\n for <dev@dpdk.org>; Tue, 26 Mar 2024 13:56:47 +0100 (CET)", "from BN0PR04CA0033.namprd04.prod.outlook.com (2603:10b6:408:e8::8)\n by CH3PR12MB8996.namprd12.prod.outlook.com (2603:10b6:610:170::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar\n 2024 12:56:39 +0000", "from BN1PEPF0000468C.namprd05.prod.outlook.com\n (2603:10b6:408:e8:cafe::b5) by BN0PR04CA0033.outlook.office365.com\n (2603:10b6:408:e8::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend\n Transport; Tue, 26 Mar 2024 12:56:39 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BN1PEPF0000468C.mail.protection.outlook.com (10.167.243.137) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7409.10 via Frontend Transport; Tue, 26 Mar 2024 12:56:39 +0000", "from ubuntu2004.linuxvmimages.local (10.180.168.240) by\n SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Tue, 26 Mar 2024 07:56:34 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=eLf/MW6JmdNN6QmGKxAeqh68z7YzgMjvSqiZvf4+pZd2WC8D72PZRuk+aqtFdI1Wa7H1yy4plSKOcbG0q05iUdTcayqur2po622shdA4DdodudEKsmSclPLtI2Hcs48Qvsh5pqBrprsrYulomV2Kv8vjweGg2Xmlx3J2QcY6lNMjzbFITRMEu6F9RZUAlmvjSNFGNeczW7YcOY8o+ULtBjT9kMKA1TYQuA9cRABZ+FmssrKenxgbU79GuXDz2dDamZqzeDGAWY/HagaUuyU/ql0BknCgD4oP515qS6z1oIm2IwIREuyirbcRbPsDZBcDcgV2UE6cGc8CrmsMNz7QYQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Dk323s/FjWY9+Xsjurt3mOL46okCWg+ts+npA9HcNyw=;\n b=GmpAEZ5SyNhUuqjqxaXxgs723z2Xl0KPUgVeQHhE7YwCNDzvSEbsrWjpwWI/UxnMCmRuZwZvqpdafbCBz5Lb+XV8B+0d/W/oPyGbQRspvHXiVhqUGrGPMaGN6i48dYmmyjyHVC/W7SDjhRFdSdJ6Xu++VWF4+T6Ky53BrHf8Tnsv5z9v9YMwy5m0ALSD5mfdVR+Cv1aVug1PEfg9o7a1CQOZAl1+21kJLvEkhxwXKAooAw521IWEjvbTsQ/6x//Kc9HkZTzSwceJtD2EjkjnZ0s41+YTzrNLrxBRm4Fgc3PifpaZADSFQ+4ibdTqL6eZ3W5F6RiNxlaZ7reozrlbBg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Dk323s/FjWY9+Xsjurt3mOL46okCWg+ts+npA9HcNyw=;\n b=dTgLCM+U71FB7Dyj51TtrumaB5uOAjCp99RwDvwtG8rIcvcUWJYdXD1OBHCnL1MuOr0yZ4Q8LcHeUpyQ501MiKM0g8a+v3ty6ONmPAY+QntMq8Fqky06BNCXIotco55q8qxdIrpPBy5QzqkgN0G4YrOYLTtxU6Ue3tpAL3S5KIU=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>,\n <radu.nicolau@intel.com>, <gakhil@marvell.com>,\n <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>,\n <konstantin.ananyev@huawei.com>, <stephen@networkplumber.org>,\n <mb@smartsharesystems.com>, <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH v7 04/14] examples/ipsec-secgw: fix queue ID restriction", "Date": "Tue, 26 Mar 2024 13:55:43 +0100", "Message-ID": "<20240326125554.138840-5-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240326125554.138840-1-sivaprasad.tummala@amd.com>", "References": "<20240321184721.69040-1-sivaprasad.tummala@amd.com>\n <20240326125554.138840-1-sivaprasad.tummala@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN1PEPF0000468C:EE_|CH3PR12MB8996:EE_", "X-MS-Office365-Filtering-Correlation-Id": "206e4ede-8d14-4ca7-1c3d-08dc4d942d6e", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n XAQ8VGjr3lXRKpnnaozPfglqk1DbXzGemiu3rnxx0IZjt7m6S1zFS1HZwDp87pFeRgtOZASqa4pnzuWwnD1x3t0CavvzJjN6VJZzI1uJ0RZYXc2VGcIsCAmt3xxObDBUVnlIOn0MFGPM9WkCa4zL52+gYhNc+LSPxc8VYiUjcJW8GMjk87xdnbQqgrk1AKLy4xQrr0RORIwNAoY4ZoLpj5gbxOQ3I7jIaZg/npfmIbUAp15nZBnSV3Rbk2pQyuE7TLwZO2OA/SirsIWNTEvDohOkad5P4tSlpJBg1xwOvVgZG1usJV8jQZqe7pGryU1+LXIPH8y/hPpydzZR3ZVJciAY7RK4cp3Ajzw0LE861y327Yo6+El+Zt+E/oTLUWzHWW3+nFvRvu1GhIroyJdyU2h5LytCcqQQLF5E3pLNGLRLVwDxCTt4PufsUh1nIpsfcArvgTBDNagSCSqhMuL5x3iEqtRMrx5MBoil4BgUH0fXwhh4PPx49Gnf8gY30YvJ8sQctezGhH6kLczC+k3HgfGC0sl3Q1Lmex+29U6eQNrtTCwH5OdPqQ8bVgaAtE1o+gvlOof2BAggvWIxx4P9JdWe8QyY5qbtgz13ORaR9X4dtnPihHWQJjNc0H7/tQQmwFMNwBDNvZHVPvKjpt9A5uteJ7RhUgN5ihaZikPGYGAQVVof6v9VJrjv4iYHV/0uHJzBV94vG+8nAeaidG0VewsJ2qwOffEWI8pJxEfINw/ku7a2k3tD97B5ZR78nXmdAI8Db/CAQKUC8li9ah9MYg==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(376005)(36860700004)(7416005)(82310400014)(1800799015)(921011);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Mar 2024 12:56:39.2144 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 206e4ede-8d14-4ca7-1c3d-08dc4d942d6e", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN1PEPF0000468C.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH3PR12MB8996", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently application supports rx queue IDs up to 255\nand max queues of 256 irrespective of device support.\nThis limits the number of active lcores to 256.\n\nThe patch fixes these constraints by increasing the\nrx queue IDs to support up to 65535.\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 19 +++++++++----------\n examples/ipsec-secgw/ipsec.h | 2 +-\n examples/ipsec-secgw/ipsec_worker.c | 10 ++++------\n 3 files changed, 14 insertions(+), 17 deletions(-)", "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 45a303850d..782535f4b5 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -220,7 +220,7 @@ static const char *cfgfile;\n \n struct lcore_params {\n \tuint16_t port_id;\n-\tuint8_t queue_id;\n+\tuint16_t queue_id;\n \tuint8_t lcore_id;\n } __rte_cache_aligned;\n \n@@ -695,8 +695,7 @@ ipsec_poll_mode_worker(void)\n \tstruct rte_mbuf *pkts[MAX_PKT_BURST];\n \tuint32_t lcore_id;\n \tuint64_t prev_tsc, diff_tsc, cur_tsc;\n-\tuint16_t i, nb_rx, portid;\n-\tuint8_t queueid;\n+\tuint16_t i, nb_rx, portid, queueid;\n \tstruct lcore_conf *qconf;\n \tint32_t rc, socket_id;\n \tconst uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1)\n@@ -743,7 +742,7 @@ ipsec_poll_mode_worker(void)\n \t\tportid = rxql[i].port_id;\n \t\tqueueid = rxql[i].queue_id;\n \t\tRTE_LOG(INFO, IPSEC,\n-\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hhu\\n\",\n+\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%\" PRIu16 \"\\n\",\n \t\t\tlcore_id, portid, queueid);\n \t}\n \n@@ -788,8 +787,7 @@ int\n check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid)\n {\n \tuint16_t i;\n-\tuint16_t portid;\n-\tuint8_t queueid;\n+\tuint16_t portid, queueid;\n \n \tfor (i = 0; i < nb_lcore_params; ++i) {\n \t\tportid = lcore_params_array[i].port_id;\n@@ -851,7 +849,7 @@ check_poll_mode_params(struct eh_conf *eh_conf)\n \treturn 0;\n }\n \n-static uint8_t\n+static uint16_t\n get_port_nb_rx_queues(const uint16_t port)\n {\n \tint32_t queue = -1;\n@@ -862,7 +860,7 @@ get_port_nb_rx_queues(const uint16_t port)\n \t\t\t\tlcore_params[i].queue_id > queue)\n \t\t\tqueue = lcore_params[i].queue_id;\n \t}\n-\treturn (uint8_t)(++queue);\n+\treturn (uint16_t)(++queue);\n }\n \n static int32_t\n@@ -1050,6 +1048,7 @@ parse_config(const char *q_arg)\n \tchar *str_fld[_NUM_FLD];\n \tint32_t i;\n \tuint32_t size;\n+\tuint32_t max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255};\n \n \tnb_lcore_params = 0;\n \n@@ -1070,7 +1069,7 @@ parse_config(const char *q_arg)\n \t\tfor (i = 0; i < _NUM_FLD; i++) {\n \t\t\terrno = 0;\n \t\t\tint_fld[i] = strtoul(str_fld[i], &end, 0);\n-\t\t\tif (errno != 0 || end == str_fld[i] || int_fld[i] > 255)\n+\t\t\tif (errno != 0 || end == str_fld[i] || int_fld[i] > max_fld[i])\n \t\t\t\treturn -1;\n \t\t}\n \t\tif (nb_lcore_params >= MAX_LCORE_PARAMS) {\n@@ -1081,7 +1080,7 @@ parse_config(const char *q_arg)\n \t\tlcore_params_array[nb_lcore_params].port_id =\n \t\t\t(uint8_t)int_fld[FLD_PORT];\n \t\tlcore_params_array[nb_lcore_params].queue_id =\n-\t\t\t(uint8_t)int_fld[FLD_QUEUE];\n+\t\t\t(uint16_t)int_fld[FLD_QUEUE];\n \t\tlcore_params_array[nb_lcore_params].lcore_id =\n \t\t\t(uint8_t)int_fld[FLD_LCORE];\n \t\t++nb_lcore_params;\ndiff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h\nindex bdcada1c40..29b9b283f0 100644\n--- a/examples/ipsec-secgw/ipsec.h\n+++ b/examples/ipsec-secgw/ipsec.h\n@@ -285,7 +285,7 @@ struct cnt_blk {\n \n struct lcore_rx_queue {\n \tuint16_t port_id;\n-\tuint8_t queue_id;\n+\tuint16_t queue_id;\n \tvoid *sec_ctx;\n } __rte_cache_aligned;\n \ndiff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c\nindex 8d122e8519..c9c43ebd2b 100644\n--- a/examples/ipsec-secgw/ipsec_worker.c\n+++ b/examples/ipsec-secgw/ipsec_worker.c\n@@ -1598,8 +1598,7 @@ ipsec_poll_mode_wrkr_inl_pr(void)\n \tint32_t socket_id;\n \tuint32_t lcore_id;\n \tint32_t i, nb_rx;\n-\tuint16_t portid;\n-\tuint8_t queueid;\n+\tuint16_t portid, queueid;\n \n \tprev_tsc = 0;\n \tlcore_id = rte_lcore_id();\n@@ -1633,7 +1632,7 @@ ipsec_poll_mode_wrkr_inl_pr(void)\n \t\tportid = rxql[i].port_id;\n \t\tqueueid = rxql[i].queue_id;\n \t\tRTE_LOG(INFO, IPSEC,\n-\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hhu\\n\",\n+\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%\" PRIu16 \"\\n\",\n \t\t\tlcore_id, portid, queueid);\n \t}\n \n@@ -1729,8 +1728,7 @@ ipsec_poll_mode_wrkr_inl_pr_ss(void)\n \tuint32_t i, nb_rx, j;\n \tint32_t socket_id;\n \tuint32_t lcore_id;\n-\tuint16_t portid;\n-\tuint8_t queueid;\n+\tuint16_t portid, queueid;\n \n \tprev_tsc = 0;\n \tlcore_id = rte_lcore_id();\n@@ -1764,7 +1762,7 @@ ipsec_poll_mode_wrkr_inl_pr_ss(void)\n \t\tportid = rxql[i].port_id;\n \t\tqueueid = rxql[i].queue_id;\n \t\tRTE_LOG(INFO, IPSEC,\n-\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%hhu\\n\",\n+\t\t\t\" -- lcoreid=%u portid=%u rxqueueid=%\" PRIu16 \"\\n\",\n \t\t\tlcore_id, portid, queueid);\n \t}\n \n", "prefixes": [ "v7", "04/14" ] }