Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 135209,
    "url": "https://patches.dpdk.org/api/patches/135209/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231214164135.2193863-1-brian.dooley@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231214164135.2193863-1-brian.dooley@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231214164135.2193863-1-brian.dooley@intel.com",
    "date": "2023-12-14T16:41:35",
    "name": "[v1] crypto/ipsec_mb: use new ipad/opad calculation API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "ae47ed5e1402366d50a1c7eaf548402e6d967f12",
    "submitter": {
        "id": 2520,
        "url": "https://patches.dpdk.org/api/people/2520/?format=api",
        "name": "Dooley, Brian",
        "email": "brian.dooley@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "https://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231214164135.2193863-1-brian.dooley@intel.com/mbox/",
    "series": [
        {
            "id": 30560,
            "url": "https://patches.dpdk.org/api/series/30560/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30560",
            "date": "2023-12-14T16:41:35",
            "name": "[v1] crypto/ipsec_mb: use new ipad/opad calculation API",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/30560/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/135209/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/135209/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7348D436F1;\n\tThu, 14 Dec 2023 17:41:50 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6093C4326C;\n\tThu, 14 Dec 2023 17:41:50 +0100 (CET)",
            "from mgamail.intel.com (mgamail.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 2900B402C2\n for <dev@dpdk.org>; Thu, 14 Dec 2023 17:41:48 +0100 (CET)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Dec 2023 08:41:47 -0800",
            "from unknown (HELO silpixa00400886.ir.intel.com) ([10.243.23.150])\n by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2023 08:41:45 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1702572108; x=1734108108;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=OI+EadLW73tGYZ4L8yQtiBzsYwrKueBKNtsnycrKaZg=;\n b=bNv7h7HHjzFcI6L/dnRSlWfn8rNy5uxIGu//zIPp9b5YwlMPsl24DV8e\n qiTtcC8TJCxnQEEZqVh3ca3sLHFWkRDyhG9mt4+VqfnVlCqxx2Zn/dBXA\n lVuOes7uR+gDco7JT0txspmOOKoS1+/X2tRgHjTvRjIs+tboIg8TEOOIN\n duLg5/lXoS1d6k260CU7pgNlkSLR/OpXUikXExLTIax2LKPr8l4CdkUsB\n pjVH+iGgBJC0jSA2svXTpL2LuuwWWbeHYyE/itReNlyUn8vXgyLuzhDed\n p2CPFBgYnpa7fjhjq8R0yxuAsPF3ePIUsfYkOqWLb2xSWERSTK8Ub0k7W Q==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,10924\"; a=\"392320603\"",
            "E=Sophos;i=\"6.04,276,1695711600\"; d=\"scan'208\";a=\"392320603\"",
            "E=McAfee;i=\"6600,9927,10924\"; a=\"918106101\"",
            "E=Sophos;i=\"6.04,276,1695711600\"; d=\"scan'208\";a=\"918106101\""
        ],
        "X-ExtLoop1": "1",
        "From": "Brian Dooley <brian.dooley@intel.com>",
        "To": "Kai Ji <kai.ji@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>",
        "Cc": "dev@dpdk.org,\n\tgakhil@marvell.com,\n\tBrian Dooley <brian.dooley@intel.com>",
        "Subject": "[PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API",
        "Date": "Thu, 14 Dec 2023 16:41:35 +0000",
        "Message-Id": "<20231214164135.2193863-1-brian.dooley@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n\nIPSec Multi-buffer library v1.4 added a new API to\ncalculate inner/outer padding for HMAC-SHAx/MD5.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nSigned-off-by: Brian Dooley <brian.dooley@intel.com>\n---\n drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 34 +++++++++++++++++++++++++-\n 1 file changed, 33 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\nindex 4de4866cf3..0410d2785b 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n@@ -13,6 +13,7 @@ struct aesni_mb_op_buf_data {\n \tuint32_t offset;\n };\n \n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n /**\n  * Calculate the authentication pre-computes\n  *\n@@ -55,6 +56,7 @@ calculate_auth_precomputes(hash_one_block_t one_block_hash,\n \tmemset(ipad_buf, 0, blocksize);\n \tmemset(opad_buf, 0, blocksize);\n }\n+#endif\n \n static inline int\n is_aead_algo(IMB_HASH_ALG hash_alg, IMB_CIPHER_MODE cipher_mode)\n@@ -66,12 +68,14 @@ is_aead_algo(IMB_HASH_ALG hash_alg, IMB_CIPHER_MODE cipher_mode)\n \n /** Set session authentication parameters */\n static int\n-aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n+aesni_mb_set_session_auth_parameters(IMB_MGR *mb_mgr,\n \t\tstruct aesni_mb_session *sess,\n \t\tconst struct rte_crypto_sym_xform *xform)\n {\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \thash_one_block_t hash_oneblock_fn = NULL;\n \tunsigned int key_larger_block_size = 0;\n+#endif\n \tuint8_t hashed_key[HMAC_MAX_BLOCK_SIZE] = { 0 };\n \tuint32_t auth_precompute = 1;\n \n@@ -267,18 +271,24 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \tswitch (xform->auth.algo) {\n \tcase RTE_CRYPTO_AUTH_MD5_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_MD5;\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\thash_oneblock_fn = mb_mgr->md5_one_block;\n+#endif\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA1_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_1;\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\thash_oneblock_fn = mb_mgr->sha1_one_block;\n+#endif\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_1)) {\n \t\t\tIMB_SHA1(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\t\tkey_larger_block_size = 1;\n+#endif\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA1:\n@@ -287,14 +297,18 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA224_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_224;\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\thash_oneblock_fn = mb_mgr->sha224_one_block;\n+#endif\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_224)) {\n \t\t\tIMB_SHA224(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\t\tkey_larger_block_size = 1;\n+#endif\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA224:\n@@ -303,14 +317,18 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA256_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_256;\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\thash_oneblock_fn = mb_mgr->sha256_one_block;\n+#endif\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_256)) {\n \t\t\tIMB_SHA256(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\t\tkey_larger_block_size = 1;\n+#endif\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA256:\n@@ -319,14 +337,18 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA384_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_384;\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\thash_oneblock_fn = mb_mgr->sha384_one_block;\n+#endif\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_384)) {\n \t\t\tIMB_SHA384(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\t\tkey_larger_block_size = 1;\n+#endif\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA384:\n@@ -335,14 +357,18 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA512_HMAC:\n \t\tsess->template_job.hash_alg = IMB_AUTH_HMAC_SHA_512;\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\thash_oneblock_fn = mb_mgr->sha512_one_block;\n+#endif\n \t\tif (xform->auth.key.length > get_auth_algo_blocksize(\n \t\t\t\tIMB_AUTH_HMAC_SHA_512)) {\n \t\t\tIMB_SHA512(mb_mgr,\n \t\t\t\txform->auth.key.data,\n \t\t\t\txform->auth.key.length,\n \t\t\t\thashed_key);\n+#if IMB_VERSION(1, 3, 0) >= IMB_VERSION_NUM\n \t\t\tkey_larger_block_size = 1;\n+#endif\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_AUTH_SHA512:\n@@ -376,6 +402,11 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\treturn 0;\n \n \t/* Calculate Authentication precomputes */\n+#if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM\n+\t\timb_hmac_ipad_opad(mb_mgr, sess->template_job.hash_alg,\n+\t\t\t\t\txform->auth.key.data, xform->auth.key.length,\n+\t\t\t\t\tsess->auth.pads.inner, sess->auth.pads.outer);\n+#else\n \tif (key_larger_block_size) {\n \t\tcalculate_auth_precomputes(hash_oneblock_fn,\n \t\t\tsess->auth.pads.inner, sess->auth.pads.outer,\n@@ -389,6 +420,7 @@ aesni_mb_set_session_auth_parameters(const IMB_MGR *mb_mgr,\n \t\t\txform->auth.key.length,\n \t\t\tget_auth_algo_blocksize(sess->template_job.hash_alg));\n \t}\n+#endif\n \tsess->template_job.u.HMAC._hashed_auth_key_xor_ipad =\n \t\tsess->auth.pads.inner;\n \tsess->template_job.u.HMAC._hashed_auth_key_xor_opad =\n",
    "prefixes": [
        "v1"
    ]
}