Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13518/?format=api
{ "id": 13518, "url": "https://patches.dpdk.org/api/patches/13518/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com", "date": "2016-06-13T09:48:54", "name": "[dpdk-dev] mk: fix missing DEPDIRS to avoid libarary underlinking", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2296639f34c148c7de841d5a858ec964fe01a4df", "submitter": { "id": 382, "url": "https://patches.dpdk.org/api/people/382/?format=api", "name": "Christian Ehrhardt", "email": "christian.ehrhardt@canonical.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/13518/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/13518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AC20647CD;\n\tMon, 13 Jun 2016 11:49:01 +0200 (CEST)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 2B0C3475E\n\tfor <dev@dpdk.org>; Mon, 13 Jun 2016 11:49:00 +0200 (CEST)", "from [10.172.196.172] (helo=localhost.localdomain)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <christian.ehrhardt@canonical.com>)\n\tid 1bCOUM-0005El-7i; Mon, 13 Jun 2016 09:48:58 +0000" ], "From": "Christian Ehrhardt <christian.ehrhardt@canonical.com>", "To": "christian.ehrhardt@canonical.com, ferruh.yigit@intel.com,\n\tthomas.monjalon@6wind.com, dev@dpdk.org", "Date": "Mon, 13 Jun 2016 11:48:54 +0200", "Message-Id": "<1465811334-22395-1-git-send-email-christian.ehrhardt@canonical.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<CAATJJ0K5PLibRiR3+-ZZSjZozipiKPTGk9wufP48vX0ma_CsKA@mail.gmail.com>", "References": "<CAATJJ0K5PLibRiR3+-ZZSjZozipiKPTGk9wufP48vX0ma_CsKA@mail.gmail.com>", "Subject": "[dpdk-dev] [PATCH] mk: fix missing DEPDIRS to avoid libarary\n\tunderlinking", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After several cleanups libraries are now linked against the libs the\nrefer as DEPDIR which is great. But that now made it visible that some DEPDIRS\nwhere still missing.\n\nThis patch is adding the missing depdirs to avoid any library referring to\nsymbols they are not linked against (found with dpkg-shlibs).\n\nSigned-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>\n---\n drivers/crypto/null/Makefile | 2 ++\n drivers/net/af_packet/Makefile | 1 +\n drivers/net/bonding/Makefile | 2 ++\n drivers/net/fm10k/Makefile | 1 +\n drivers/net/null/Makefile | 1 +\n drivers/net/pcap/Makefile | 1 +\n drivers/net/vhost/Makefile | 3 +++\n lib/librte_ip_frag/Makefile | 1 +\n lib/librte_pipeline/Makefile | 1 +\n lib/librte_port/Makefile | 1 +\n lib/librte_sched/Makefile | 1 +\n 11 files changed, 15 insertions(+)", "diff": "diff --git a/drivers/crypto/null/Makefile b/drivers/crypto/null/Makefile\nindex 2173277..573894f 100644\n--- a/drivers/crypto/null/Makefile\n+++ b/drivers/crypto/null/Makefile\n@@ -55,5 +55,7 @@ SYMLINK-y-include +=\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_eal\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_cryptodev\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_ring\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += lib/librte_kvargs\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/net/af_packet/Makefile b/drivers/net/af_packet/Makefile\nindex cb1a7ae..132f1d9 100644\n--- a/drivers/net/af_packet/Makefile\n+++ b/drivers/net/af_packet/Makefile\n@@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += rte_eth_af_packet.c\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_kvargs\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_eal\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile\nindex 10c794c..504f2e8 100644\n--- a/drivers/net/bonding/Makefile\n+++ b/drivers/net/bonding/Makefile\n@@ -64,5 +64,7 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_eal\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_kvargs\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_cmdline\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_mempool\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += lib/librte_ring\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/net/fm10k/Makefile b/drivers/net/fm10k/Makefile\nindex cf141ae..afcbd1d 100644\n--- a/drivers/net/fm10k/Makefile\n+++ b/drivers/net/fm10k/Makefile\n@@ -100,5 +100,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR) += fm10k_rxtx_vec.c\n DEPDIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += lib/librte_eal lib/librte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += lib/librte_mempool lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += lib/librte_net\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += lib/librte_kvargs\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/net/null/Makefile b/drivers/net/null/Makefile\nindex 2202389..3502095 100644\n--- a/drivers/net/null/Makefile\n+++ b/drivers/net/null/Makefile\n@@ -57,5 +57,6 @@ SYMLINK-y-include += rte_eth_null.h\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_kvargs\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_eal\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/net/pcap/Makefile b/drivers/net/pcap/Makefile\nindex b41d8a2..85179ad 100644\n--- a/drivers/net/pcap/Makefile\n+++ b/drivers/net/pcap/Makefile\n@@ -59,5 +59,6 @@ SYMLINK-y-include +=\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += lib/librte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += lib/librte_kvargs\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += lib/librte_eal\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/drivers/net/vhost/Makefile b/drivers/net/vhost/Makefile\nindex f49a69b..dd318a8 100644\n--- a/drivers/net/vhost/Makefile\n+++ b/drivers/net/vhost/Makefile\n@@ -36,6 +36,8 @@ include $(RTE_SDK)/mk/rte.vars.mk\n #\n LIB = librte_pmd_vhost.a\n \n+LDLIBS += -lpthread\n+\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n \n@@ -58,5 +60,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += lib/librte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += lib/librte_kvargs\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += lib/librte_vhost\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += lib/librte_eal\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_ip_frag/Makefile b/lib/librte_ip_frag/Makefile\nindex 9d06780..2b91f73 100644\n--- a/lib/librte_ip_frag/Makefile\n+++ b/lib/librte_ip_frag/Makefile\n@@ -55,5 +55,6 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_IP_FRAG)-include += rte_ip_frag.h\n \n # this library depends on rte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += lib/librte_mempool lib/librte_ether\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += lib/librte_eal\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_pipeline/Makefile b/lib/librte_pipeline/Makefile\nindex 822fd41..a3b00f4 100644\n--- a/lib/librte_pipeline/Makefile\n+++ b/lib/librte_pipeline/Makefile\n@@ -54,5 +54,6 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_PIPELINE)-include += rte_pipeline.h\n # this lib depends upon:\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) := lib/librte_table\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += lib/librte_port\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += lib/librte_eal\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile\nindex d4de5af..dc6a601 100644\n--- a/lib/librte_port/Makefile\n+++ b/lib/librte_port/Makefile\n@@ -75,5 +75,6 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mempool\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ether\n DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ip_frag\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_sched\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_sched/Makefile b/lib/librte_sched/Makefile\nindex a782cd1..0766fb9 100644\n--- a/lib/librte_sched/Makefile\n+++ b/lib/librte_sched/Makefile\n@@ -61,5 +61,6 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_reciprocal.h\n # this lib depends upon:\n DEPDIRS-$(CONFIG_RTE_LIBRTE_SCHED) += lib/librte_mempool lib/librte_mbuf\n DEPDIRS-$(CONFIG_RTE_LIBRTE_SCHED) += lib/librte_net lib/librte_timer\n+DEPDIRS-$(CONFIG_RTE_LIBRTE_SCHED) += lib/librte_eal\n \n include $(RTE_SDK)/mk/rte.lib.mk\n", "prefixes": [ "dpdk-dev" ] }