Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130818/?format=api
{ "id": 130818, "url": "https://patches.dpdk.org/api/patches/130818/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230829075829.208413-12-wanry@3snic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230829075829.208413-12-wanry@3snic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230829075829.208413-12-wanry@3snic.com", "date": "2023-08-29T07:58:08", "name": "[11/32] net/sssnic: add dev MAC ops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b0c61775542716a8a4c12e8d0a1b3275d092a84c", "submitter": { "id": 3119, "url": "https://patches.dpdk.org/api/people/3119/?format=api", "name": "Renyong Wan", "email": "wanry@3snic.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230829075829.208413-12-wanry@3snic.com/mbox/", "series": [ { "id": 29358, "url": "https://patches.dpdk.org/api/series/29358/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29358", "date": "2023-08-29T07:57:57", "name": "Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters", "version": 1, "mbox": "https://patches.dpdk.org/series/29358/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/130818/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/130818/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1FAEF41F53;\n\tTue, 29 Aug 2023 10:09:20 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0B007402D6;\n\tTue, 29 Aug 2023 10:09:16 +0200 (CEST)", "from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])\n by mails.dpdk.org (Postfix) with ESMTP id 9D046402A2\n for <dev@dpdk.org>; Tue, 29 Aug 2023 10:09:12 +0200 (CEST)", "from V12DG1MBS03.ramaxel.local ([172.26.18.33])\n by VLXDG1SPAM1.ramaxel.com with ESMTP id 37T7wrM9080563;\n Tue, 29 Aug 2023 15:59:03 +0800 (GMT-8)\n (envelope-from wanry@3snic.com)", "from localhost.localdomain (10.64.136.151) by\n V12DG1MBS03.ramaxel.local (172.26.18.33) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2375.17; Tue, 29 Aug 2023 15:58:41 +0800" ], "From": "<wanry@3snic.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, Renyong Wan <wanry@3snic.com>, Steven Song\n <steven.song@3snic.com>", "Subject": "[PATCH 11/32] net/sssnic: add dev MAC ops", "Date": "Tue, 29 Aug 2023 15:58:08 +0800", "Message-ID": "<20230829075829.208413-12-wanry@3snic.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230829075829.208413-1-wanry@3snic.com>", "References": "<20230829075829.208413-1-wanry@3snic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.64.136.151]", "X-ClientProxiedBy": "V12DG1MBS03.ramaxel.local (172.26.18.33) To\n V12DG1MBS03.ramaxel.local (172.26.18.33)", "X-DNSRBL": "", "X-SPAM-SOURCE-CHECK": "pass", "X-MAIL": "VLXDG1SPAM1.ramaxel.com 37T7wrM9080563", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Renyong Wan <wanry@3snic.com>\n\nSigned-off-by: Steven Song <steven.song@3snic.com>\nSigned-off-by: Renyong Wan <wanry@3snic.com>\n---\n doc/guides/nics/features/sssnic.ini | 2 +\n drivers/net/sssnic/base/sssnic_api.c | 174 +++++++++++++++++\n drivers/net/sssnic/base/sssnic_api.h | 4 +\n drivers/net/sssnic/base/sssnic_cmd.h | 25 +++\n drivers/net/sssnic/base/sssnic_hw.h | 1 +\n drivers/net/sssnic/sssnic_ethdev.c | 270 ++++++++++++++++++++++++++-\n drivers/net/sssnic/sssnic_ethdev.h | 2 +\n 7 files changed, 477 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/nics/features/sssnic.ini b/doc/guides/nics/features/sssnic.ini\nindex 6d9786db7e..602839d301 100644\n--- a/doc/guides/nics/features/sssnic.ini\n+++ b/doc/guides/nics/features/sssnic.ini\n@@ -4,6 +4,8 @@\n ; Refer to default.ini for the full list of available PMD features.\n ;\n [Features]\n+Unicast MAC filter = Y\n+Multicast MAC filter = Y\n Linux = Y\n ARMv8 = Y\n x86-64 = Y\ndiff --git a/drivers/net/sssnic/base/sssnic_api.c b/drivers/net/sssnic/base/sssnic_api.c\nindex bf0859cd63..76266dfbae 100644\n--- a/drivers/net/sssnic/base/sssnic_api.c\n+++ b/drivers/net/sssnic/base/sssnic_api.c\n@@ -133,3 +133,177 @@ sssnic_capability_get(struct sssnic_hw *hw, struct sssnic_capability *capa)\n \n \treturn 0;\n }\n+\n+int\n+sssnic_mac_addr_get(struct sssnic_hw *hw, uint8_t *addr)\n+{\n+\tint ret;\n+\tstruct sssnic_mac_addr_cmd cmd;\n+\tstruct sssnic_msg msg;\n+\tuint32_t cmd_len;\n+\tuint16_t func;\n+\n+\tif (hw == NULL || addr == NULL)\n+\t\treturn -EINVAL;\n+\n+\tif (SSSNIC_FUNC_TYPE(hw) == SSSNIC_FUNC_TYPE_VF)\n+\t\tfunc = SSSNIC_PF_FUNC_IDX(hw);\n+\telse\n+\t\tfunc = SSSNIC_MPU_FUNC_IDX;\n+\n+\tmemset(&cmd, 0, sizeof(cmd));\n+\tcmd_len = sizeof(cmd);\n+\tcmd.function = SSSNIC_FUNC_IDX(hw);\n+\tsssnic_msg_init(&msg, (uint8_t *)&cmd, cmd_len, SSSNIC_GET_MAC_ADDR_CMD,\n+\t\tfunc, SSSNIC_LAN_MODULE, SSSNIC_MSG_TYPE_REQ);\n+\tret = sssnic_mbox_send(hw, &msg, (uint8_t *)&cmd, &cmd_len, 0);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send mbox message, ret=%d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tif (cmd_len == 0 || cmd.common.status != 0) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Bad response to SSSNIC_GET_DEF_MAC_ADDR_CMD, len=%u, status=%u\",\n+\t\t\tcmd_len, cmd.common.status);\n+\t\treturn -EIO;\n+\t}\n+\n+\trte_memcpy(addr, cmd.addr, 6);\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_mac_addr_update(struct sssnic_hw *hw, uint8_t *new, uint8_t *old)\n+{\n+\tint ret;\n+\tstruct sssnic_mac_addr_update_cmd cmd;\n+\tstruct sssnic_msg msg;\n+\tuint32_t cmd_len;\n+\tuint16_t func;\n+\n+\tif (hw == NULL || new == NULL || old == NULL)\n+\t\treturn -EINVAL;\n+\n+\tif (SSSNIC_FUNC_TYPE(hw) == SSSNIC_FUNC_TYPE_VF)\n+\t\tfunc = SSSNIC_PF_FUNC_IDX(hw);\n+\telse\n+\t\tfunc = SSSNIC_MPU_FUNC_IDX;\n+\n+\tmemset(&cmd, 0, sizeof(cmd));\n+\tcmd_len = sizeof(cmd);\n+\tcmd.function = SSSNIC_FUNC_IDX(hw);\n+\trte_memcpy(cmd.new_addr, new, 6);\n+\trte_memcpy(cmd.old_addr, old, 6);\n+\tsssnic_msg_init(&msg, (uint8_t *)&cmd, cmd_len,\n+\t\tSSSNIC_UPDATE_MAC_ADDR_CMD, func, SSSNIC_LAN_MODULE,\n+\t\tSSSNIC_MSG_TYPE_REQ);\n+\tret = sssnic_mbox_send(hw, &msg, (uint8_t *)&cmd, &cmd_len, 0);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send mbox message, ret=%d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tif (cmd_len == 0 || cmd.common.status != 0) {\n+\t\tif (cmd.common.status == SSSNIC_MAC_ADDR_CMD_STATUS_IGNORED) {\n+\t\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t\t\"MAC address operation is ignored\");\n+\t\t\treturn 0;\n+\t\t}\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Bad response to SSSNIC_UPDATE_MAC_ADDR_CMD, len=%u, status=%u\",\n+\t\t\tcmd_len, cmd.common.status);\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_mac_addr_add(struct sssnic_hw *hw, uint8_t *addr)\n+{\n+\tint ret;\n+\tstruct sssnic_mac_addr_cmd cmd;\n+\tstruct sssnic_msg msg;\n+\tuint32_t cmd_len;\n+\tuint16_t func;\n+\n+\tif (hw == NULL || addr == NULL)\n+\t\treturn -EINVAL;\n+\n+\tif (SSSNIC_FUNC_TYPE(hw) == SSSNIC_FUNC_TYPE_VF)\n+\t\tfunc = SSSNIC_PF_FUNC_IDX(hw);\n+\telse\n+\t\tfunc = SSSNIC_MPU_FUNC_IDX;\n+\n+\tmemset(&cmd, 0, sizeof(cmd));\n+\tcmd_len = sizeof(cmd);\n+\tcmd.function = SSSNIC_FUNC_IDX(hw);\n+\trte_memcpy(cmd.addr, addr, 6);\n+\tsssnic_msg_init(&msg, (uint8_t *)&cmd, cmd_len, SSSNIC_ADD_MAC_ADDR_CMD,\n+\t\tfunc, SSSNIC_LAN_MODULE, SSSNIC_MSG_TYPE_REQ);\n+\tret = sssnic_mbox_send(hw, &msg, (uint8_t *)&cmd, &cmd_len, 0);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send mbox message, ret=%d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tif (cmd_len == 0 || cmd.common.status != 0) {\n+\t\tif (cmd.common.status == SSSNIC_MAC_ADDR_CMD_STATUS_IGNORED) {\n+\t\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t\t\"MAC address operation is ignored\");\n+\t\t\treturn 0;\n+\t\t}\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Bad response to SSSNIC_ADD_MAC_ADDR_CMD, len=%u, status=%u\",\n+\t\t\tcmd_len, cmd.common.status);\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_mac_addr_del(struct sssnic_hw *hw, uint8_t *addr)\n+{\n+\tint ret;\n+\tstruct sssnic_mac_addr_cmd cmd;\n+\tstruct sssnic_msg msg;\n+\tuint32_t cmd_len;\n+\tuint16_t func;\n+\n+\tif (hw == NULL || addr == NULL)\n+\t\treturn -EINVAL;\n+\n+\tif (SSSNIC_FUNC_TYPE(hw) == SSSNIC_FUNC_TYPE_VF)\n+\t\tfunc = SSSNIC_PF_FUNC_IDX(hw);\n+\telse\n+\t\tfunc = SSSNIC_MPU_FUNC_IDX;\n+\n+\tmemset(&cmd, 0, sizeof(cmd));\n+\tcmd_len = sizeof(cmd);\n+\tcmd.function = SSSNIC_FUNC_IDX(hw);\n+\trte_memcpy(cmd.addr, addr, 6);\n+\tsssnic_msg_init(&msg, (uint8_t *)&cmd, cmd_len, SSSNIC_DEL_MAC_ADDR_CMD,\n+\t\tfunc, SSSNIC_LAN_MODULE, SSSNIC_MSG_TYPE_REQ);\n+\tret = sssnic_mbox_send(hw, &msg, (uint8_t *)&cmd, &cmd_len, 0);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send mbox message, ret=%d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tif (cmd_len == 0 || cmd.common.status != 0) {\n+\t\tif (cmd.common.status == SSSNIC_MAC_ADDR_CMD_STATUS_IGNORED) {\n+\t\t\tPMD_DRV_LOG(WARNING,\n+\t\t\t\t\"MAC address operation is ignored\");\n+\t\t\treturn 0;\n+\t\t}\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Bad response to SSSNIC_DEL_MAC_ADDR_CMD, len=%u, status=%u\",\n+\t\t\tcmd_len, cmd.common.status);\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/net/sssnic/base/sssnic_api.h b/drivers/net/sssnic/base/sssnic_api.h\nindex 8011cc8b0f..b985230595 100644\n--- a/drivers/net/sssnic/base/sssnic_api.h\n+++ b/drivers/net/sssnic/base/sssnic_api.h\n@@ -27,5 +27,9 @@ int sssnic_msix_attr_get(struct sssnic_hw *hw, uint16_t msix_idx,\n int sssnic_msix_attr_set(struct sssnic_hw *hw, uint16_t msix_idx,\n \tstruct sssnic_msix_attr *attr);\n int sssnic_capability_get(struct sssnic_hw *hw, struct sssnic_capability *capa);\n+int sssnic_mac_addr_get(struct sssnic_hw *hw, uint8_t *addr);\n+int sssnic_mac_addr_update(struct sssnic_hw *hw, uint8_t *new, uint8_t *old);\n+int sssnic_mac_addr_add(struct sssnic_hw *hw, uint8_t *addr);\n+int sssnic_mac_addr_del(struct sssnic_hw *hw, uint8_t *addr);\n \n #endif /* _SSSNIC_API_H_ */\ndiff --git a/drivers/net/sssnic/base/sssnic_cmd.h b/drivers/net/sssnic/base/sssnic_cmd.h\nindex 79192affbc..e70184866e 100644\n--- a/drivers/net/sssnic/base/sssnic_cmd.h\n+++ b/drivers/net/sssnic/base/sssnic_cmd.h\n@@ -20,6 +20,14 @@ enum sssnic_mgmt_cmd_id {\n \n #define SSSNIC_GET_CAPABILITY_CMD 0\n \n+#define SSSNIC_MAC_ADDR_CMD_STATUS_IGNORED 0x4\n+enum sssnic_mac_addr_cmd_id {\n+\tSSSNIC_GET_MAC_ADDR_CMD = 20,\n+\tSSSNIC_ADD_MAC_ADDR_CMD,\n+\tSSSNIC_DEL_MAC_ADDR_CMD,\n+\tSSSNIC_UPDATE_MAC_ADDR_CMD,\n+};\n+\n struct sssnic_cmd_common {\n \tuint8_t status;\n \tuint8_t version;\n@@ -125,4 +133,21 @@ struct sssnic_capability_get_cmd {\n \tuint32_t resvd3[63];\n };\n \n+struct sssnic_mac_addr_cmd {\n+\tstruct sssnic_cmd_common common;\n+\tuint16_t function;\n+\tuint16_t vlan;\n+\tuint16_t resvd;\n+\tuint8_t addr[6];\n+};\n+\n+struct sssnic_mac_addr_update_cmd {\n+\tstruct sssnic_cmd_common common;\n+\tuint16_t function;\n+\tuint16_t vlan;\n+\tuint16_t resvd0;\n+\tuint8_t old_addr[6];\n+\tuint16_t resvd1;\n+\tuint8_t new_addr[6];\n+};\n #endif /* _SSSNIC_CMD_H_ */\ndiff --git a/drivers/net/sssnic/base/sssnic_hw.h b/drivers/net/sssnic/base/sssnic_hw.h\nindex 5f20a9465d..f8fe2ac7e1 100644\n--- a/drivers/net/sssnic/base/sssnic_hw.h\n+++ b/drivers/net/sssnic/base/sssnic_hw.h\n@@ -70,6 +70,7 @@ struct sssnic_hw {\n #define SSSNIC_PHY_PORT(hw) ((hw)->phy_port)\n #define SSSNIC_FUNC_TYPE(hw) ((hw)->attr.func_type)\n #define SSSNIC_AF_FUNC_IDX(hw) ((hw)->attr.af_idx)\n+#define SSSNIC_PF_FUNC_IDX(hw) ((hw)->attr.pf_idx)\n \n enum sssnic_module {\n \tSSSNIC_COMM_MODULE = 0,\ndiff --git a/drivers/net/sssnic/sssnic_ethdev.c b/drivers/net/sssnic/sssnic_ethdev.c\nindex 517d53b587..82e0c38bf6 100644\n--- a/drivers/net/sssnic/sssnic_ethdev.c\n+++ b/drivers/net/sssnic/sssnic_ethdev.c\n@@ -8,6 +8,7 @@\n \n #include \"sssnic_log.h\"\n #include \"base/sssnic_hw.h\"\n+#include \"base/sssnic_api.h\"\n #include \"sssnic_ethdev.h\"\n \n static int\n@@ -64,6 +65,258 @@ sssnic_ethdev_infos_get(struct rte_eth_dev *ethdev,\n \treturn 0;\n }\n \n+static int\n+sssnic_ethdev_mac_addr_set(struct rte_eth_dev *ethdev,\n+\tstruct rte_ether_addr *mac_addr)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev;\n+\tstruct sssnic_hw *hw;\n+\tchar mac_str[RTE_ETHER_ADDR_FMT_SIZE];\n+\n+\tnetdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\thw = SSSNIC_NETDEV_TO_HW(netdev);\n+\n+\trte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, mac_addr);\n+\n+\tret = sssnic_mac_addr_update(hw, mac_addr->addr_bytes,\n+\t\tnetdev->default_addr.addr_bytes);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to update default MAC address: %s\",\n+\t\t\tmac_str);\n+\t\treturn ret;\n+\t}\n+\trte_ether_addr_copy(mac_addr, &netdev->default_addr);\n+\n+\tPMD_DRV_LOG(INFO, \"Updated default MAC address %s of port %u\", mac_str,\n+\t\tethdev->data->port_id);\n+\n+\treturn 0;\n+}\n+\n+static void\n+sssnic_ethdev_mac_addr_remove(struct rte_eth_dev *ethdev, uint32_t index)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev;\n+\tstruct sssnic_hw *hw;\n+\tstruct rte_ether_addr *mac;\n+\tchar mac_str[RTE_ETHER_ADDR_FMT_SIZE];\n+\n+\tnetdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\thw = SSSNIC_NETDEV_TO_HW(netdev);\n+\n+\tmac = ðdev->data->mac_addrs[index];\n+\tret = sssnic_mac_addr_del(hw, mac->addr_bytes);\n+\tif (ret != 0) {\n+\t\trte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, mac);\n+\t\tPMD_DRV_LOG(ERR, \"Failed to delete MAC address %s\", mac_str);\n+\t}\n+}\n+\n+static int\n+sssnic_ethdev_mac_addr_add(struct rte_eth_dev *ethdev,\n+\tstruct rte_ether_addr *mac_addr, __rte_unused uint32_t index,\n+\t__rte_unused uint32_t vmdq)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev;\n+\tstruct sssnic_hw *hw;\n+\tchar mac_str[RTE_ETHER_ADDR_FMT_SIZE];\n+\n+\tnetdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\thw = SSSNIC_NETDEV_TO_HW(netdev);\n+\n+\tif (rte_is_multicast_ether_addr(mac_addr)) {\n+\t\trte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,\n+\t\t\tmac_addr);\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Invalid MAC address:%s, cannot be multicast address\",\n+\t\t\tmac_str);\n+\t}\n+\n+\tret = sssnic_mac_addr_add(hw, mac_addr->addr_bytes);\n+\tif (ret != 0) {\n+\t\trte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,\n+\t\t\tmac_addr);\n+\t\tPMD_DRV_LOG(ERR, \"Failed to add MAC address %s\", mac_str);\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static void\n+sssnic_ethdev_mcast_addrs_clean(struct rte_eth_dev *ethdev)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev;\n+\tstruct sssnic_hw *hw;\n+\tint i;\n+\n+\tnetdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\thw = SSSNIC_NETDEV_TO_HW(netdev);\n+\n+\tfor (i = 0; i < SSSNIC_ETHDEV_MAX_NUM_MC_MAC; i++) {\n+\t\tif (rte_is_zero_ether_addr(&netdev->mcast_addrs[i]))\n+\t\t\tbreak;\n+\n+\t\tret = sssnic_mac_addr_del(hw,\n+\t\t\tnetdev->mcast_addrs[i].addr_bytes);\n+\t\tif (ret != 0)\n+\t\t\tPMD_DRV_LOG(WARNING, \"Failed to delete MAC address\");\n+\n+\t\tmemset(&netdev->mcast_addrs[i], 0,\n+\t\t\tsizeof(struct rte_ether_addr));\n+\t}\n+}\n+\n+static int\n+sssnic_ethdev_set_mc_addr_list(struct rte_eth_dev *ethdev,\n+\tstruct rte_ether_addr *mc_addr_set, uint32_t nb_mc_addr)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev;\n+\tstruct sssnic_hw *hw;\n+\tchar mac_str[RTE_ETHER_ADDR_FMT_SIZE];\n+\tuint32_t i;\n+\n+\tnetdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\thw = SSSNIC_NETDEV_TO_HW(netdev);\n+\n+\tif (nb_mc_addr > SSSNIC_ETHDEV_MAX_NUM_MC_MAC) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Failed to set mcast address list to port %u, excceds max number:%u\",\n+\t\t\tethdev->data->port_id, SSSNIC_ETHDEV_MAX_NUM_MC_MAC);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (i = 0; i < nb_mc_addr; i++) {\n+\t\tif (!rte_is_multicast_ether_addr(&mc_addr_set[i])) {\n+\t\t\trte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,\n+\t\t\t\t&mc_addr_set[i]);\n+\t\t\tPMD_DRV_LOG(ERR, \"Invalid Multicast MAC address: %s\",\n+\t\t\t\tmac_str);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t}\n+\n+\tsssnic_ethdev_mcast_addrs_clean(ethdev);\n+\n+\tfor (i = 0; i < nb_mc_addr; i++) {\n+\t\tret = sssnic_mac_addr_add(hw, mc_addr_set[i].addr_bytes);\n+\t\tif (ret != 0) {\n+\t\t\tsssnic_ethdev_mcast_addrs_clean(ethdev);\n+\t\t\trte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,\n+\t\t\t\t&mc_addr_set[i]);\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\"Failed to add Multicast MAC address: %s\",\n+\t\t\t\tmac_str);\n+\t\t\treturn ret;\n+\t\t}\n+\t\trte_ether_addr_copy(&mc_addr_set[i], &netdev->mcast_addrs[i]);\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+sssnic_ethdev_mac_addrs_init(struct rte_eth_dev *ethdev)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev;\n+\tstruct sssnic_hw *hw;\n+\tstruct rte_ether_addr default_addr;\n+\tchar mac_str[RTE_ETHER_ADDR_FMT_SIZE];\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tnetdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\thw = SSSNIC_NETDEV_TO_HW(netdev);\n+\n+\tethdev->data->mac_addrs = rte_zmalloc(NULL,\n+\t\tSSSNIC_ETHDEV_MAX_NUM_UC_MAC * sizeof(struct rte_ether_addr),\n+\t\t0);\n+\tif (ethdev->data->mac_addrs == NULL) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Failed to allocate memory to store %u mac addresses\",\n+\t\t\tSSSNIC_ETHDEV_MAX_NUM_UC_MAC);\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tnetdev->mcast_addrs = rte_zmalloc(NULL,\n+\t\tSSSNIC_ETHDEV_MAX_NUM_MC_MAC * sizeof(struct rte_ether_addr),\n+\t\t0);\n+\tif (netdev->mcast_addrs == NULL) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Failed to allocate memory to store %u mcast addresses\",\n+\t\t\tSSSNIC_ETHDEV_MAX_NUM_MC_MAC);\n+\t\tret = -ENOMEM;\n+\t\tgoto alloc_mcast_addr_fail;\n+\t}\n+\n+\t/* initialize default MAC address */\n+\tmemset(&default_addr, 0, sizeof(default_addr));\n+\tret = sssnic_mac_addr_get(hw, default_addr.addr_bytes);\n+\tif (ret != 0)\n+\t\tPMD_DRV_LOG(NOTICE,\n+\t\t\t\"Could not get default MAC address, will use random address\");\n+\n+\tif (rte_is_zero_ether_addr(&default_addr))\n+\t\trte_eth_random_addr(default_addr.addr_bytes);\n+\n+\trte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, &default_addr);\n+\n+\tret = sssnic_mac_addr_add(hw, default_addr.addr_bytes);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to add default MAC address: %s\",\n+\t\t\tmac_str);\n+\t\tgoto add_ether_addr_fail;\n+\t}\n+\n+\trte_ether_addr_copy(&default_addr, ðdev->data->mac_addrs[0]);\n+\trte_ether_addr_copy(&default_addr, &netdev->default_addr);\n+\n+\tPMD_DRV_LOG(INFO, \"Port %u default MAC address: %s\",\n+\t\tethdev->data->port_id, mac_str);\n+\n+\treturn 0;\n+\n+add_ether_addr_fail:\n+\trte_free(netdev->mcast_addrs);\n+\tnetdev->mcast_addrs = NULL;\n+alloc_mcast_addr_fail:\n+\trte_free(ethdev->data->mac_addrs);\n+\tethdev->data->mac_addrs = NULL;\n+\treturn ret;\n+}\n+\n+static void\n+sssnic_ethdev_mac_addrs_clean(struct rte_eth_dev *ethdev)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev;\n+\tstruct sssnic_hw *hw;\n+\tint i;\n+\n+\tnetdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\thw = SSSNIC_NETDEV_TO_HW(netdev);\n+\n+\tfor (i = 0; i < SSSNIC_ETHDEV_MAX_NUM_UC_MAC; i++) {\n+\t\tif (rte_is_zero_ether_addr(ðdev->data->mac_addrs[i]))\n+\t\t\tcontinue;\n+\n+\t\tret = sssnic_mac_addr_del(hw,\n+\t\t\tethdev->data->mac_addrs[i].addr_bytes);\n+\t\tif (ret != 0)\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\"Failed to delete MAC address from port %u\",\n+\t\t\t\tethdev->data->port_id);\n+\t}\n+\n+\tsssnic_ethdev_mcast_addrs_clean(ethdev);\n+}\n+\n static int\n sssnic_ethdev_configure(struct rte_eth_dev *ethdev)\n {\n@@ -81,6 +334,7 @@ sssnic_ethdev_release(struct rte_eth_dev *ethdev)\n {\n \tstruct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);\n \n+\tsssnic_ethdev_mac_addrs_clean(ethdev);\n \tsssnic_hw_shutdown(hw);\n \trte_free(hw);\n }\n@@ -88,6 +342,10 @@ sssnic_ethdev_release(struct rte_eth_dev *ethdev)\n static const struct eth_dev_ops sssnic_ethdev_ops = {\n \t.dev_configure = sssnic_ethdev_configure,\n \t.dev_infos_get = sssnic_ethdev_infos_get,\n+\t.mac_addr_set = sssnic_ethdev_mac_addr_set,\n+\t.mac_addr_remove = sssnic_ethdev_mac_addr_remove,\n+\t.mac_addr_add = sssnic_ethdev_mac_addr_add,\n+\t.set_mc_addr_list = sssnic_ethdev_set_mc_addr_list,\n };\n \n static int\n@@ -119,12 +377,22 @@ sssnic_ethdev_init(struct rte_eth_dev *ethdev)\n \t\treturn ret;\n \t}\n \n+\tret = sssnic_ethdev_mac_addrs_init(ethdev);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to initialize MAC addresses\");\n+\t\tgoto mac_addrs_init_fail;\n+\t}\n+\n \tnetdev->max_num_rxq = SSSNIC_MAX_NUM_RXQ(hw);\n \tnetdev->max_num_txq = SSSNIC_MAX_NUM_TXQ(hw);\n \n \tethdev->dev_ops = &sssnic_ethdev_ops;\n \n \treturn 0;\n+\n+mac_addrs_init_fail:\n+\tsssnic_hw_shutdown(0);\n+\treturn ret;\n }\n \n static int\n@@ -141,7 +409,7 @@ sssnic_ethdev_uninit(struct rte_eth_dev *ethdev)\n \n \tsssnic_ethdev_release(ethdev);\n \n-\treturn -EINVAL;\n+\treturn 0;\n }\n \n static int\ndiff --git a/drivers/net/sssnic/sssnic_ethdev.h b/drivers/net/sssnic/sssnic_ethdev.h\nindex 70dd43d5c0..636b3fd04c 100644\n--- a/drivers/net/sssnic/sssnic_ethdev.h\n+++ b/drivers/net/sssnic/sssnic_ethdev.h\n@@ -58,6 +58,8 @@\n \n struct sssnic_netdev {\n \tvoid *hw;\n+\tstruct rte_ether_addr *mcast_addrs;\n+\tstruct rte_ether_addr default_addr;\n \tuint16_t max_num_txq;\n \tuint16_t max_num_rxq;\n };\n", "prefixes": [ "11/32" ] }