Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127051/?format=api
{ "id": 127051, "url": "https://patches.dpdk.org/api/patches/127051/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230518214852.2364233-1-akozyrev@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230518214852.2364233-1-akozyrev@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230518214852.2364233-1-akozyrev@nvidia.com", "date": "2023-05-18T21:48:52", "name": "[v3] ethdev: add flow rule actions update API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "617cc22f3936332608727fd1a656d920db563739", "submitter": { "id": 1873, "url": "https://patches.dpdk.org/api/people/1873/?format=api", "name": "Alexander Kozyrev", "email": "akozyrev@nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230518214852.2364233-1-akozyrev@nvidia.com/mbox/", "series": [ { "id": 28070, "url": "https://patches.dpdk.org/api/series/28070/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28070", "date": "2023-05-18T21:48:52", "name": "[v3] ethdev: add flow rule actions update API", "version": 3, "mbox": "https://patches.dpdk.org/series/28070/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127051/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127051/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1EE3F42B3D;\n\tThu, 18 May 2023 23:49:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E7EAD41141;\n\tThu, 18 May 2023 23:49:39 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54])\n by mails.dpdk.org (Postfix) with ESMTP id E7D3D40E25\n for <dev@dpdk.org>; Thu, 18 May 2023 23:49:37 +0200 (CEST)", "from DS7PR03CA0304.namprd03.prod.outlook.com (2603:10b6:8:2b::16) by\n MN0PR12MB5977.namprd12.prod.outlook.com (2603:10b6:208:37c::22) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Thu, 18 May\n 2023 21:49:33 +0000", "from DS1PEPF0000E646.namprd02.prod.outlook.com\n (2603:10b6:8:2b:cafe::15) by DS7PR03CA0304.outlook.office365.com\n (2603:10b6:8:2b::16) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19 via Frontend\n Transport; Thu, 18 May 2023 21:49:32 +0000", "from mail.nvidia.com (216.228.117.161) by\n DS1PEPF0000E646.mail.protection.outlook.com (10.167.18.36) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6411.11 via Frontend Transport; Thu, 18 May 2023 21:49:32 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 18 May 2023\n 14:49:14 -0700", "from pegasus01.mtr.labs.mlnx (10.126.231.35) by\n rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.986.37; Thu, 18 May 2023 14:49:12 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=EsibfWckJTYdj2u5YeZ0y2A/zYJLeVDSeeUiUmgsU8pAS6TG7b/ITt3hCyFGgJkRwVKCwY5bOo5GQ3sRtI4NwiJ7CdtZRDY4wTtLETxvjifWhzEtpU0t8P6y2I9vmoxQN3ovURdffnUYO1hGV89GFyLjIjfr3DoGf2FVMncH61tu/ZfUR+L58zHd9IUDL+YkLEFH86/dvIHwjvS9yZ+L8punkKcldv0P2soTEcZ3S3WTf9EtkpEtCapZE4lLWp+lzSwfi133t0I9LruPE/NDDnY4Z9iVog0fN8wMd6QUvDNgGXmJb9wydIjZKfYq5yodz+PYEaJ0Mdx+mP6XvV6bcw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=B+qKt90oNp7KpBA9hZHl+iOT1c9rMnCOzxwl+V4rhA0=;\n b=BsH003+a0JZo9PqsnZqLp93mTfQGycOKUpR3QRgCozunEmU1SuVu66tJc7L1g2mE4mQ2y8BrpB4iqpQbLuNnxiAOkgQu2wsVEcZ4g62VtLg0xvSjhoxO2JtuQTL7TU/23GO3TKgfWwv+p2/Dqt2D1XaSDTEqnF23ghuMyiLojr+cs4RniXJJIEhUGZxv9DBr+eaKAP8XZsFbDACnb0Q+I8LTk2DkiIrgu02BOLe3fxXehcEbbE0QgXcuARbMbz7JsWPiKwzT8afCHV0MK7CVEEejbFZ5Q8X0k0xuVh8QG63WS6UhkV655fJXvv2XQPEvgi0J1jiMrcbKn4a3OdIMMw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=B+qKt90oNp7KpBA9hZHl+iOT1c9rMnCOzxwl+V4rhA0=;\n b=LHUz8/Y6Ig/cS+RWBM9JZsC0aOO6yAwA6ETfApCBrRAhtE6UQx3tPFv0RibsZyW0mG36GVR5M8YiviXDtmgKAoruXyGT6pnsTacLDmc6pDID1JCjqDiHDeVZcsY6q02jRYOZLnyF4yyDdqQDh9YkoWHb2j36N26lVLG2vqcGhdw3mvxdPhOwD6MuhTR/Ce3QF7eyoa5+wvJKv9OCsFlvvlVPzWDTH9+9/drBl2WTHrH58+l1MJjGHEjgaH+S9s1GgmCmz3ZwxTwuZVMqLrK4MXLI3waRewAXiGs7G9Tg/WI3QvEG3Y1pSpOkznfzXEe8R4kqHbD88IoT1evdfhIqQA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Alexander Kozyrev <akozyrev@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<orika@nvidia.com>, <matan@nvidia.com>, <thomas@monjalon.net>", "Subject": "[PATCH v3] ethdev: add flow rule actions update API", "Date": "Fri, 19 May 2023 00:48:52 +0300", "Message-ID": "<20230518214852.2364233-1-akozyrev@nvidia.com>", "X-Mailer": "git-send-email 2.18.2", "In-Reply-To": "<20230518194943.2338558-1-akozyrev@nvidia.com>", "References": "<20230518194943.2338558-1-akozyrev@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DS1PEPF0000E646:EE_|MN0PR12MB5977:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a98ffa5f-8a40-4451-bf34-08db57e9c377", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n hg5BwRr1SL5Vnz0sUXvswQ0e4RXYNpZusUcZoO+WTaD6OkDzOsXMljeNBV9ZzALtmEjEVg+1nAb19kZD56hGcF4ixaJ3mZQG8m7QCRvIXNCht4C4scJgBVTVBfQ5V4a36fZU6YhONlqcOi1vBEDDIN6Fo8wDftu3pmTsmhdxJ1gYGI+9PLwopsGQw/9tCZVJub27sBN9PcG0gmVjVd7lBpYWOv4S33zU72v5duvg9alWLgcI6qFGI8BkSiEV8+aShMiSEdrZh2atYvf2Ji9cMZzXgl91f2xNilZpK9MJW8CqId4Qd7mCF8XE4/l0XhZ/crv0OF5AXdYStiObPVHqF6vOuObmHvvx9m75NH5+S1I544d5FtVmHEgZ2+UcT9YWeb9hSrnrV5s054dp96XgX7UTuzCrPtP/e56OFyw+fCI8zDp174HEBER7RRHJqSV/7WveMYhF+JL0ZYrFiKbpYR/B4FbnpwdQuoTYlArk+HrekHzzYPy5ixmwezqQcGzJSkTF0/MDDzETZ2Qgs1RRqNF+noag96Ewj7fOQVx5RYjb0pxA2UiRZrRQQXaIpJtyzufZE/Ul0pdhWo9pZ5IwmiF2ceOgY6jH02VRp0qluf8HUBBmi6cy2fCAIBMy10Wr/wJZ1Wb919ILQqywxvOfj7fZ08YdDR4IJIyPMm6FaZptFVHdUhsVzIIA0yHr/l1cD0Si6dsdGFoCXnYLugkEtrx35rPscImQPIhE5ZTjFBoN2DWXAxwV1jOo/KeTLRN+", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(82310400005)(83380400001)(426003)(336012)(47076005)(36860700001)(6916009)(316002)(82740400003)(2906002)(356005)(7636003)(41300700001)(4326008)(478600001)(5660300002)(70586007)(40480700001)(2616005)(26005)(70206006)(40460700003)(8676002)(54906003)(86362001)(16526019)(8936002)(30864003)(15650500001)(186003)(1076003)(36756003)(6666004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 May 2023 21:49:32.0208 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a98ffa5f-8a40-4451-bf34-08db57e9c377", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DS1PEPF0000E646.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN0PR12MB5977", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Introduce the new rte_flow_update() API allowing users\nto update the action list in the already existing rule.\nFlow rules can be updated now without the need to destroy\nthe rule first and create a new one instead.\nA single API call ensures that no packets are lost by\nguaranteeing atomicity and flow state correctness.\nThe rte_flow_async_update() is added as well.\nThe matcher is not updated, only the action list is.\n\nSigned-off-by: Alexander Kozyrev <akozyrev@nvidia.com>\n---\n doc/guides/prog_guide/rte_flow.rst | 42 +++++++++++++++++\n doc/guides/rel_notes/release_23_07.rst | 4 ++\n lib/ethdev/ethdev_trace.h | 29 ++++++++++++\n lib/ethdev/ethdev_trace_points.c | 6 +++\n lib/ethdev/rte_flow.c | 53 ++++++++++++++++++++++\n lib/ethdev/rte_flow.h | 62 ++++++++++++++++++++++++++\n lib/ethdev/rte_flow_driver.h | 16 +++++++\n lib/ethdev/version.map | 2 +\n 8 files changed, 214 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex 32fc45516a..0930accfea 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -3446,6 +3446,31 @@ Return values:\n \n - 0 on success, a negative errno value otherwise and ``rte_errno`` is set.\n \n+Update\n+~~~~~~\n+\n+Update an existing flow rule with a new set of actions.\n+\n+.. code-block:: c\n+\n+ struct rte_flow *\n+ rte_flow_update(uint16_t port_id,\n+ struct rte_flow *flow,\n+ const struct rte_flow_action *actions[],\n+ struct rte_flow_error *error);\n+\n+Arguments:\n+\n+- ``port_id``: port identifier of Ethernet device.\n+- ``flow``: flow rule handle to update.\n+- ``actions``: associated actions (list terminated by the END action).\n+- ``error``: perform verbose error reporting if not NULL. PMDs initialize\n+ this structure in case of error only.\n+\n+Return values:\n+\n+- 0 on success, a negative errno value otherwise and ``rte_errno`` is set.\n+\n Flush\n ~~~~~\n \n@@ -3795,6 +3820,23 @@ Enqueueing a flow rule destruction operation is similar to simple destruction.\n void *user_data,\n struct rte_flow_error *error);\n \n+Enqueue update operation\n+~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Enqueueing a flow rule update operation to replace actions in the existing rule.\n+\n+.. code-block:: c\n+\n+ int\n+ rte_flow_async_update(uint16_t port_id,\n+ uint32_t queue_id,\n+ const struct rte_flow_op_attr *op_attr,\n+ struct rte_flow *flow,\n+ const struct rte_flow_action actions[],\n+ uint8_t actions_template_index,\n+ void *user_data,\n+ struct rte_flow_error *error);\n+\n Enqueue indirect action creation operation\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \ndiff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst\nindex a9b1293689..94e9f8b3ae 100644\n--- a/doc/guides/rel_notes/release_23_07.rst\n+++ b/doc/guides/rel_notes/release_23_07.rst\n@@ -55,6 +55,10 @@ New Features\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+ * **Added flow rule update to the Flow API.**\n+\n+ * Added API for updating the action list in the already existing rule.\n+ Introduced both rte_flow_update() and rte_flow_async_update() functions.\n \n Removed Items\n -------------\ndiff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h\nindex 3dc7d028b8..ba7871aa3e 100644\n--- a/lib/ethdev/ethdev_trace.h\n+++ b/lib/ethdev/ethdev_trace.h\n@@ -2220,6 +2220,17 @@ RTE_TRACE_POINT_FP(\n \trte_trace_point_emit_int(ret);\n )\n \n+/* Called in loop in app/test-flow-perf */\n+RTE_TRACE_POINT_FP(\n+\trte_flow_trace_update,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, const struct rte_flow *flow,\n+\t\tconst struct rte_flow_action *actions, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_ptr(flow);\n+\trte_trace_point_emit_ptr(actions);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n RTE_TRACE_POINT_FP(\n \trte_flow_trace_query,\n \tRTE_TRACE_POINT_ARGS(uint16_t port_id, const struct rte_flow *flow,\n@@ -2345,6 +2356,24 @@ RTE_TRACE_POINT_FP(\n \trte_trace_point_emit_ptr(flow);\n )\n \n+RTE_TRACE_POINT_FP(\n+\trte_flow_trace_async_update,\n+\tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,\n+\t\tconst struct rte_flow_op_attr *op_attr,\n+\t\tconst struct rte_flow *flow,\n+\t\tconst struct rte_flow_action *actions,\n+\t\tuint8_t actions_template_index,\n+\t\tconst void *user_data, int ret),\n+\trte_trace_point_emit_u16(port_id);\n+\trte_trace_point_emit_u32(queue_id);\n+\trte_trace_point_emit_ptr(op_attr);\n+\trte_trace_point_emit_ptr(flow);\n+\trte_trace_point_emit_ptr(actions);\n+\trte_trace_point_emit_u8(actions_template_index);\n+\trte_trace_point_emit_ptr(user_data);\n+\trte_trace_point_emit_int(ret);\n+)\n+\n RTE_TRACE_POINT_FP(\n \trte_flow_trace_pull,\n \tRTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,\ndiff --git a/lib/ethdev/ethdev_trace_points.c b/lib/ethdev/ethdev_trace_points.c\nindex 61010cae56..f7bc6f342b 100644\n--- a/lib/ethdev/ethdev_trace_points.c\n+++ b/lib/ethdev/ethdev_trace_points.c\n@@ -490,6 +490,9 @@ RTE_TRACE_POINT_REGISTER(rte_flow_trace_create,\n RTE_TRACE_POINT_REGISTER(rte_flow_trace_destroy,\n \tlib.ethdev.flow.destroy)\n \n+RTE_TRACE_POINT_REGISTER(rte_flow_trace_update,\n+\tlib.ethdev.flow.update)\n+\n RTE_TRACE_POINT_REGISTER(rte_flow_trace_flush,\n \tlib.ethdev.flow.flush)\n \n@@ -580,6 +583,9 @@ RTE_TRACE_POINT_REGISTER(rte_flow_trace_async_create,\n RTE_TRACE_POINT_REGISTER(rte_flow_trace_async_destroy,\n \tlib.ethdev.flow.async_destroy)\n \n+RTE_TRACE_POINT_REGISTER(rte_flow_trace_async_update,\n+\tlib.ethdev.flow.async_update)\n+\n RTE_TRACE_POINT_REGISTER(rte_flow_trace_push,\n \tlib.ethdev.flow.push)\n \ndiff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c\nindex 69e6e749f7..baef9e92ea 100644\n--- a/lib/ethdev/rte_flow.c\n+++ b/lib/ethdev/rte_flow.c\n@@ -441,6 +441,32 @@ rte_flow_destroy(uint16_t port_id,\n \t\t\t\t NULL, rte_strerror(ENOSYS));\n }\n \n+int\n+rte_flow_update(uint16_t port_id,\n+\t\tstruct rte_flow *flow,\n+\t\tconst struct rte_flow_action actions[],\n+\t\tstruct rte_flow_error *error)\n+{\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n+\tconst struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);\n+\tint ret;\n+\n+\tif (unlikely(!ops))\n+\t\treturn -rte_errno;\n+\tif (likely(!!ops->update)) {\n+\t\tfts_enter(dev);\n+\t\tret = ops->update(dev, flow, actions, error);\n+\t\tfts_exit(dev);\n+\n+\t\trte_flow_trace_update(port_id, flow, actions, ret);\n+\n+\t\treturn flow_err(port_id, ret, error);\n+\t}\n+\treturn rte_flow_error_set(error, ENOSYS,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t NULL, rte_strerror(ENOSYS));\n+}\n+\n /* Destroy all flow rules associated with a port. */\n int\n rte_flow_flush(uint16_t port_id,\n@@ -1985,6 +2011,33 @@ rte_flow_async_destroy(uint16_t port_id,\n \treturn ret;\n }\n \n+int\n+rte_flow_async_update(uint16_t port_id,\n+\t\t uint32_t queue_id,\n+\t\t const struct rte_flow_op_attr *op_attr,\n+\t\t struct rte_flow *flow,\n+\t\t const struct rte_flow_action actions[],\n+\t\t uint8_t actions_template_index,\n+\t\t void *user_data,\n+\t\t struct rte_flow_error *error)\n+{\n+\tstruct rte_eth_dev *dev = &rte_eth_devices[port_id];\n+\tconst struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);\n+\tint ret;\n+\n+\tret = flow_err(port_id,\n+\t\t ops->async_update(dev, queue_id, op_attr, flow,\n+\t\t\t\t\t actions, actions_template_index,\n+\t\t\t\t\t user_data, error),\n+\t\t error);\n+\n+\trte_flow_trace_async_update(port_id, queue_id, op_attr, flow,\n+\t\t\t\t actions, actions_template_index,\n+\t\t\t\t user_data, ret);\n+\n+\treturn ret;\n+}\n+\n int\n rte_flow_push(uint16_t port_id,\n \t uint32_t queue_id,\ndiff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h\nindex 713ba8b65c..79bfc07a1c 100644\n--- a/lib/ethdev/rte_flow.h\n+++ b/lib/ethdev/rte_flow.h\n@@ -4343,6 +4343,29 @@ rte_flow_destroy(uint16_t port_id,\n \t\t struct rte_flow *flow,\n \t\t struct rte_flow_error *error);\n \n+/**\n+ * Update a flow rule with new actions on a given port.\n+ *\n+ * @param port_id\n+ * Port identifier of Ethernet device.\n+ * @param flow\n+ * Flow rule handle to update.\n+ * @param[in] actions\n+ * Associated actions (list terminated by the END action).\n+ * @param[out] error\n+ * Perform verbose error reporting if not NULL. PMDs initialize this\n+ * structure in case of error only.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+__rte_experimental\n+int\n+rte_flow_update(uint16_t port_id,\n+\t\tstruct rte_flow *flow,\n+\t\tconst struct rte_flow_action actions[],\n+\t\tstruct rte_flow_error *error);\n+\n /**\n * Destroy all flow rules associated with a port.\n *\n@@ -5770,6 +5793,45 @@ rte_flow_async_destroy(uint16_t port_id,\n \t\t void *user_data,\n \t\t struct rte_flow_error *error);\n \n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice.\n+ *\n+ * Enqueue rule update operation.\n+ *\n+ * @param port_id\n+ * Port identifier of Ethernet device.\n+ * @param queue_id\n+ * Flow queue used to insert the rule.\n+ * @param[in] op_attr\n+ * Rule creation operation attributes.\n+ * @param[in] flow\n+ * Flow rule to be updated.\n+ * @param[in] actions\n+ * List of actions to be used.\n+ * The list order should match the order in the actions template.\n+ * @param[in] actions_template_index\n+ * Actions template index in the table.\n+ * @param[in] user_data\n+ * The user data that will be returned on the completion events.\n+ * @param[out] error\n+ * Perform verbose error reporting if not NULL.\n+ * PMDs initialize this structure in case of error only.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+__rte_experimental\n+int\n+rte_flow_async_update(uint16_t port_id,\n+\t\t uint32_t queue_id,\n+\t\t const struct rte_flow_op_attr *op_attr,\n+\t\t struct rte_flow *flow,\n+\t\t const struct rte_flow_action actions[],\n+\t\t uint8_t actions_template_index,\n+\t\t void *user_data,\n+\t\t struct rte_flow_error *error);\n+\n /**\n * @warning\n * @b EXPERIMENTAL: this API may change without prior notice.\ndiff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h\nindex a129a4605d..193b09a7d3 100644\n--- a/lib/ethdev/rte_flow_driver.h\n+++ b/lib/ethdev/rte_flow_driver.h\n@@ -302,6 +302,22 @@ struct rte_flow_ops {\n \t\t const void *update, void *query,\n \t\t enum rte_flow_query_update_mode qu_mode,\n \t\t void *user_data, struct rte_flow_error *error);\n+\t/** See rte_flow_update(). */\n+\tint (*update)\n+\t\t(struct rte_eth_dev *dev,\n+\t\t struct rte_flow *flow,\n+\t\t const struct rte_flow_action actions[],\n+\t\t struct rte_flow_error *error);\n+\t/** See rte_flow_async_update() */\n+\tint (*async_update)\n+\t\t(struct rte_eth_dev *dev,\n+\t\t uint32_t queue_id,\n+\t\t const struct rte_flow_op_attr *op_attr,\n+\t\t struct rte_flow *flow,\n+\t\t const struct rte_flow_action actions[],\n+\t\t uint8_t actions_template_index,\n+\t\t void *user_data,\n+\t\t struct rte_flow_error *error);\n };\n \n /**\ndiff --git a/lib/ethdev/version.map b/lib/ethdev/version.map\nindex 357d1a88c0..d4f49cb918 100644\n--- a/lib/ethdev/version.map\n+++ b/lib/ethdev/version.map\n@@ -299,6 +299,8 @@ EXPERIMENTAL {\n \trte_flow_action_handle_query_update;\n \trte_flow_async_action_handle_query_update;\n \trte_flow_async_create_by_index;\n+\trte_flow_update;\n+\trte_flow_async_update;\n };\n \n INTERNAL {\n", "prefixes": [ "v3" ] }