Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124605/?format=api
{ "id": 124605, "url": "https://patches.dpdk.org/api/patches/124605/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230301192659.601892-1-mingxia.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230301192659.601892-1-mingxia.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230301192659.601892-1-mingxia.liu@intel.com", "date": "2023-03-01T19:26:59", "name": "[v2] net/idpf: refine Rx/Tx queue model info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cae223db1e99c16c1c68316221c7a9a267337ba8", "submitter": { "id": 2514, "url": "https://patches.dpdk.org/api/people/2514/?format=api", "name": "Liu, Mingxia", "email": "mingxia.liu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230301192659.601892-1-mingxia.liu@intel.com/mbox/", "series": [ { "id": 27204, "url": "https://patches.dpdk.org/api/series/27204/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27204", "date": "2023-03-01T19:26:59", "name": "[v2] net/idpf: refine Rx/Tx queue model info", "version": 2, "mbox": "https://patches.dpdk.org/series/27204/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124605/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/124605/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5A4D41DA8;\n\tWed, 1 Mar 2023 12:12:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D4AC94161A;\n\tWed, 1 Mar 2023 12:12:05 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 66D944161A\n for <dev@dpdk.org>; Wed, 1 Mar 2023 12:12:04 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Mar 2023 03:12:02 -0800", "from dpdk-mingxial-ice.sh.intel.com ([10.67.110.191])\n by fmsmga004.fm.intel.com with ESMTP; 01 Mar 2023 03:12:01 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677669124; x=1709205124;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=XdZURruDGNFtPzjVA3UAzgR9fb8RSpc4QqgHuh949zU=;\n b=lgeDFd+a1EgVA+cQs9S3zhDv2kr02Bw0JtuXV0ZydLxPevxd34EXKz5S\n 90Bub/EL1SMGbwSiSFdFn8FA75y6q5b27zCDT/gy2utbbQvlv5cyUZdpl\n CNLK1p+KuRjh6SrMlnRfGEMDk53RVWB3nqU/suH0nYH9AXvTwqXCr0ev/\n JubOa91QyTr9pzbC3N8cpNOgm0zRbFXvP5lQpcPrKomVMJDE7Cde3rFgG\n bnszCHCIdzI/7tS0aPdt3eJ76vFtTBgfbN8EpGosCJCRYqGEojiNhnfU7\n ZK1rX5it01XsqwVqDWQkVmXj0fbExJegLYdH7ONxMbnYvpghJdIdTYAZx A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10635\"; a=\"331861576\"", "E=Sophos;i=\"5.98,224,1673942400\"; d=\"scan'208\";a=\"331861576\"", "E=McAfee;i=\"6500,9779,10635\"; a=\"743384140\"", "E=Sophos;i=\"5.98,224,1673942400\"; d=\"scan'208\";a=\"743384140\"" ], "X-ExtLoop1": "1", "From": "Mingxia Liu <mingxia.liu@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com, beilei.xing@intel.com,\n Mingxia Liu <mingxia.liu@intel.com>", "Subject": "[PATCH v2] net/idpf: refine Rx/Tx queue model info", "Date": "Wed, 1 Mar 2023 19:26:59 +0000", "Message-Id": "<20230301192659.601892-1-mingxia.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230301161605.436754-1-mingxia.liu@intel.com>", "References": "<20230301161605.436754-1-mingxia.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch updates queue mode info in struct idpf_adapter.\nUsing is_rx_singleq_model to diffentiate rx_singq and rx_splitq\nexplicitly, instead of deducing it from pointer values.\n\nSigned-off-by: Mingxia Liu <mingxia.liu@intel.com>\n---\n drivers/common/idpf/idpf_common_device.c | 4 ++--\n drivers/common/idpf/idpf_common_device.h | 4 ++--\n drivers/common/idpf/idpf_common_rxtx.c | 2 +-\n drivers/common/idpf/idpf_common_rxtx.h | 5 +++++\n drivers/net/idpf/idpf_ethdev.c | 4 ++--\n drivers/net/idpf/idpf_rxtx.c | 6 +++---\n 6 files changed, 15 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/common/idpf/idpf_common_device.c b/drivers/common/idpf/idpf_common_device.c\nindex 5475a3e52c..c5e7bbf66c 100644\n--- a/drivers/common/idpf/idpf_common_device.c\n+++ b/drivers/common/idpf/idpf_common_device.c\n@@ -623,7 +623,7 @@ idpf_vport_info_init(struct idpf_vport *vport,\n \tstruct idpf_adapter *adapter = vport->adapter;\n \n \tvport_info->vport_type = rte_cpu_to_le_16(VIRTCHNL2_VPORT_TYPE_DEFAULT);\n-\tif (adapter->txq_model == 0) {\n+\tif (!adapter->is_tx_singleq) {\n \t\tvport_info->txq_model =\n \t\t\trte_cpu_to_le_16(VIRTCHNL2_QUEUE_MODEL_SPLIT);\n \t\tvport_info->num_tx_q =\n@@ -636,7 +636,7 @@ idpf_vport_info_init(struct idpf_vport *vport,\n \t\tvport_info->num_tx_q = rte_cpu_to_le_16(IDPF_DEFAULT_TXQ_NUM);\n \t\tvport_info->num_tx_complq = 0;\n \t}\n-\tif (adapter->rxq_model == 0) {\n+\tif (!adapter->is_rx_singleq) {\n \t\tvport_info->rxq_model =\n \t\t\trte_cpu_to_le_16(VIRTCHNL2_QUEUE_MODEL_SPLIT);\n \t\tvport_info->num_rx_q = rte_cpu_to_le_16(IDPF_DEFAULT_RXQ_NUM);\ndiff --git a/drivers/common/idpf/idpf_common_device.h b/drivers/common/idpf/idpf_common_device.h\nindex 364a60221a..c2dc2f16b9 100644\n--- a/drivers/common/idpf/idpf_common_device.h\n+++ b/drivers/common/idpf/idpf_common_device.h\n@@ -43,8 +43,8 @@ struct idpf_adapter {\n \n \tuint32_t ptype_tbl[IDPF_MAX_PKT_TYPE] __rte_cache_min_aligned;\n \n-\tuint32_t txq_model; /* 0 - split queue model, non-0 - single queue model */\n-\tuint32_t rxq_model; /* 0 - split queue model, non-0 - single queue model */\n+\tbool is_tx_singleq; /* true - single queue model, false - split queue model */\n+\tbool is_rx_singleq; /* true - single queue model, false - split queue model */\n \n \t/* For timestamp */\n \tuint64_t time_hw;\ndiff --git a/drivers/common/idpf/idpf_common_rxtx.c b/drivers/common/idpf/idpf_common_rxtx.c\nindex d7e8df1895..fc87e3e243 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.c\n+++ b/drivers/common/idpf/idpf_common_rxtx.c\n@@ -309,7 +309,7 @@ idpf_qc_rx_queue_release(void *rxq)\n \t\treturn;\n \n \t/* Split queue */\n-\tif (q->bufq1 != NULL && q->bufq2 != NULL) {\n+\tif (!q->adapter->is_rx_singleq) {\n \t\tq->bufq1->ops->release_mbufs(q->bufq1);\n \t\trte_free(q->bufq1->sw_ring);\n \t\trte_memzone_free(q->bufq1->mz);\ndiff --git a/drivers/common/idpf/idpf_common_rxtx.h b/drivers/common/idpf/idpf_common_rxtx.h\nindex 7e6df080e6..d0f79783b5 100644\n--- a/drivers/common/idpf/idpf_common_rxtx.h\n+++ b/drivers/common/idpf/idpf_common_rxtx.h\n@@ -90,6 +90,11 @@\n #define PF_GLTSYN_SHTIME_L_5\t(PF_TIMESYNC_BAR4_BASE + 0x138)\n #define PF_GLTSYN_SHTIME_H_5\t(PF_TIMESYNC_BAR4_BASE + 0x13C)\n \n+enum idpf_rx_split_bufq_id {\n+\tIDPF_RX_SPLIT_BUFQ1_ID = 1,\n+\tIDPF_RX_SPLIT_BUFQ2_ID = 2\n+};\n+\n struct idpf_rx_stats {\n \tuint64_t mbuf_alloc_failed;\n };\ndiff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex 5b4f4fd82b..db58157ba3 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -993,12 +993,12 @@ idpf_parse_devargs(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *adap\n \t\tgoto bail;\n \n \tret = rte_kvargs_process(kvlist, IDPF_TX_SINGLE_Q, &parse_bool,\n-\t\t\t\t &adapter->base.txq_model);\n+\t\t\t\t &adapter->base.is_tx_singleq);\n \tif (ret != 0)\n \t\tgoto bail;\n \n \tret = rte_kvargs_process(kvlist, IDPF_RX_SINGLE_Q, &parse_bool,\n-\t\t\t\t &adapter->base.rxq_model);\n+\t\t\t\t &adapter->base.is_rx_singleq);\n \tif (ret != 0)\n \t\tgoto bail;\n \ndiff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c\nindex d16acd87fb..34205a1025 100644\n--- a/drivers/net/idpf/idpf_rxtx.c\n+++ b/drivers/net/idpf/idpf_rxtx.c\n@@ -189,9 +189,9 @@ idpf_rx_split_bufq_setup(struct rte_eth_dev *dev, struct idpf_rx_queue *rxq,\n \tbufq->ops = &def_rxq_ops;\n \tbufq->q_set = true;\n \n-\tif (bufq_id == 1) {\n+\tif (bufq_id == IDPF_RX_SPLIT_BUFQ1_ID) {\n \t\trxq->bufq1 = bufq;\n-\t} else if (bufq_id == 2) {\n+\t} else if (bufq_id == IDPF_RX_SPLIT_BUFQ2_ID) {\n \t\trxq->bufq2 = bufq;\n \t} else {\n \t\tPMD_INIT_LOG(ERR, \"Invalid buffer queue index.\");\n@@ -536,7 +536,7 @@ idpf_rx_queue_init(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\treturn -EIO;\n \t}\n \n-\tif (rxq->bufq1 == NULL) {\n+\tif (rxq->adapter->is_rx_singleq) {\n \t\t/* Single queue */\n \t\terr = idpf_qc_single_rxq_mbufs_alloc(rxq);\n \t\tif (err != 0) {\n", "prefixes": [ "v2" ] }