Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122843/?format=api
{ "id": 122843, "url": "https://patches.dpdk.org/api/patches/122843/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230201092310.23252-31-syalavarthi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230201092310.23252-31-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230201092310.23252-31-syalavarthi@marvell.com", "date": "2023-02-01T09:23:01", "name": "[v4,30/39] ml/cnxk: add support to get and reset device stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6fcdcd83621b8930bcafcf988373fb25838cd779", "submitter": { "id": 2480, "url": "https://patches.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230201092310.23252-31-syalavarthi@marvell.com/mbox/", "series": [ { "id": 26732, "url": "https://patches.dpdk.org/api/series/26732/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26732", "date": "2023-02-01T09:22:31", "name": "Implementation of ML CNXK driver", "version": 4, "mbox": "https://patches.dpdk.org/series/26732/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/122843/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/122843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F080541B9D;\n\tWed, 1 Feb 2023 10:26:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6648943027;\n\tWed, 1 Feb 2023 10:23:59 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6456D42D82\n for <dev@dpdk.org>; Wed, 1 Feb 2023 10:23:27 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 3116LRYD024189 for <dev@dpdk.org>; Wed, 1 Feb 2023 01:23:26 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3nfjr8rgv6-11\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 01 Feb 2023 01:23:26 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Wed, 1 Feb 2023 01:23:22 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Wed, 1 Feb 2023 01:23:22 -0800", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 37DDE3F7059;\n Wed, 1 Feb 2023 01:23:22 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=ADQhcmC1tJKfopXuAk7YePxRqSnJUOjSo57pOZXGej8=;\n b=FheWB7K92AWidpb2MOpMjBUbvJbpmYD3qzv6Wvx0jmdhH60fOwbSTDANGX8aAabiJ2EX\n yl88IekeScTKSmzSoDOt8TQsUswRzcPSHTxo7fO2hOhvKxI+DdPYdYvBEkpvbykpaBTO\n /rSkzSzYSmlSUDT6Hh8JYlagyzhnUHmXe9+GCd6hYvDkXVyTc98dxYkd2b0TQKAiaTj9\n 6S9JAqFcp2MUxzUEWWSxnuM+4nLqAnwowYVU4LWult0esOQXhEDHoHuAKVC5gCJNH95p\n sAbJY5SgdPrHvcIPSMgJvddsnt1vofgDy6Fu4eLuswkgx1rSrAc8Ul+XDU35T1z9OcKB Vg==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>, <jerinj@marvell.com>,\n <aprabhu@marvell.com>", "Subject": "[PATCH v4 30/39] ml/cnxk: add support to get and reset device stats", "Date": "Wed, 1 Feb 2023 01:23:01 -0800", "Message-ID": "<20230201092310.23252-31-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230201092310.23252-1-syalavarthi@marvell.com>", "References": "<20221208200220.20267-1-syalavarthi@marvell.com>\n <20230201092310.23252-1-syalavarthi@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "q5BamTKBJj7n4L8qV1p2x5IaW5DK7HPk", "X-Proofpoint-ORIG-GUID": "q5BamTKBJj7n4L8qV1p2x5IaW5DK7HPk", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1\n definitions=2023-02-01_03,2023-01-31_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enabled support to get and reset ML device stats. Device stats\ninclude number of requests enqueued/dequeued and error count.\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n drivers/ml/cnxk/cn10k_ml_ops.c | 55 ++++++++++++++++++++++++++++++++--\n drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++\n 2 files changed, 55 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c\nindex 8de5f9705a..3149e4153e 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ops.c\n+++ b/drivers/ml/cnxk/cn10k_ml_ops.c\n@@ -159,6 +159,10 @@ cn10k_ml_qp_create(const struct rte_ml_dev *dev, uint16_t qp_id, uint32_t nb_des\n \tqp->queue.tail = 0;\n \tqp->queue.wait_cycles = ML_CN10K_CMD_TIMEOUT * plt_tsc_hz();\n \tqp->nb_desc = nb_desc;\n+\tqp->stats.enqueued_count = 0;\n+\tqp->stats.dequeued_count = 0;\n+\tqp->stats.enqueue_err_count = 0;\n+\tqp->stats.dequeue_err_count = 0;\n \n \t/* Initialize job command */\n \tfor (i = 0; i < qp->nb_desc; i++) {\n@@ -678,6 +682,38 @@ cn10k_ml_dev_queue_pair_setup(struct rte_ml_dev *dev, uint16_t queue_pair_id,\n \treturn 0;\n }\n \n+static int\n+cn10k_ml_dev_stats_get(struct rte_ml_dev *dev, struct rte_ml_dev_stats *stats)\n+{\n+\tstruct cn10k_ml_qp *qp;\n+\tint qp_id;\n+\n+\tfor (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {\n+\t\tqp = dev->data->queue_pairs[qp_id];\n+\t\tstats->enqueued_count += qp->stats.enqueued_count;\n+\t\tstats->dequeued_count += qp->stats.dequeued_count;\n+\t\tstats->enqueue_err_count += qp->stats.enqueue_err_count;\n+\t\tstats->dequeue_err_count += qp->stats.dequeue_err_count;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static void\n+cn10k_ml_dev_stats_reset(struct rte_ml_dev *dev)\n+{\n+\tstruct cn10k_ml_qp *qp;\n+\tint qp_id;\n+\n+\tfor (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {\n+\t\tqp = dev->data->queue_pairs[qp_id];\n+\t\tqp->stats.enqueued_count = 0;\n+\t\tqp->stats.dequeued_count = 0;\n+\t\tqp->stats.enqueue_err_count = 0;\n+\t\tqp->stats.dequeue_err_count = 0;\n+\t}\n+}\n+\n static int\n cn10k_ml_dev_dump(struct rte_ml_dev *dev, FILE *fp)\n {\n@@ -1467,15 +1503,23 @@ static __rte_always_inline void\n cn10k_ml_result_update(struct rte_ml_dev *dev, int qp_id, struct cn10k_ml_result *result,\n \t\t struct rte_ml_op *op)\n {\n-\tPLT_SET_USED(dev);\n-\tPLT_SET_USED(qp_id);\n-\n \tstruct cn10k_ml_dev *mldev;\n+\tstruct cn10k_ml_qp *qp;\n \n \tif (likely(result->error_code.u64 == 0)) {\n+\t\tif (likely(qp_id >= 0)) {\n+\t\t\tqp = dev->data->queue_pairs[qp_id];\n+\t\t\tqp->stats.dequeued_count++;\n+\t\t}\n+\n \t\top->impl_opaque = result->error_code.u64;\n \t\top->status = RTE_ML_OP_STATUS_SUCCESS;\n \t} else {\n+\t\tif (likely(qp_id >= 0)) {\n+\t\t\tqp = dev->data->queue_pairs[qp_id];\n+\t\t\tqp->stats.dequeue_err_count++;\n+\t\t}\n+\n \t\t/* Handle driver error */\n \t\tif (result->error_code.s.etype == ML_ETYPE_DRIVER) {\n \t\t\tmldev = dev->data->dev_private;\n@@ -1549,6 +1593,7 @@ cn10k_ml_enqueue_burst(struct rte_ml_dev *dev, uint16_t qp_id, struct rte_ml_op\n \n jcmdq_full:\n \tqueue->head = head;\n+\tqp->stats.enqueued_count += count;\n \n \treturn count;\n }\n@@ -1697,6 +1742,10 @@ struct rte_ml_dev_ops cn10k_ml_ops = {\n \t.dev_queue_pair_setup = cn10k_ml_dev_queue_pair_setup,\n \t.dev_queue_pair_release = cn10k_ml_dev_queue_pair_release,\n \n+\t/* Stats ops */\n+\t.dev_stats_get = cn10k_ml_dev_stats_get,\n+\t.dev_stats_reset = cn10k_ml_dev_stats_reset,\n+\n \t/* Model ops */\n \t.model_load = cn10k_ml_model_load,\n \t.model_unload = cn10k_ml_model_unload,\ndiff --git a/drivers/ml/cnxk/cn10k_ml_ops.h b/drivers/ml/cnxk/cn10k_ml_ops.h\nindex 560310f835..fb82af414a 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ops.h\n+++ b/drivers/ml/cnxk/cn10k_ml_ops.h\n@@ -58,6 +58,9 @@ struct cn10k_ml_qp {\n \n \t/* Request queue */\n \tstruct cn10k_ml_queue queue;\n+\n+\t/* Statistics per queue-pair */\n+\tstruct rte_ml_dev_stats stats;\n };\n \n /* Device ops */\n", "prefixes": [ "v4", "30/39" ] }