Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121912/?format=api
{ "id": 121912, "url": "https://patches.dpdk.org/api/patches/121912/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230112113556.47485-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230112113556.47485-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230112113556.47485-2-bruce.richardson@intel.com", "date": "2023-01-12T11:35:56", "name": "[RFC,1/1] build: increase minimum C standard for DPDK builds", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cfa9630de08ed8002d17590d38c1d24132b22d34", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230112113556.47485-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 26506, "url": "https://patches.dpdk.org/api/series/26506/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26506", "date": "2023-01-12T11:35:55", "name": "Specify C-standard requirement for DPDK builds", "version": 1, "mbox": "https://patches.dpdk.org/series/26506/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121912/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/121912/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A9665423B5;\n\tThu, 12 Jan 2023 12:36:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9EE9842D2E;\n\tThu, 12 Jan 2023 12:36:19 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 329AE40E25\n for <dev@dpdk.org>; Thu, 12 Jan 2023 12:36:18 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jan 2023 03:36:17 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.166])\n by orsmga001.jf.intel.com with ESMTP; 12 Jan 2023 03:36:15 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673523378; x=1705059378;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=gN+R28btwZti9m0Bh9D7U5SwaJ+kJVE9HGMrj5MXqfk=;\n b=YuGPe5TpvZOP+WY60Dau/J1LBJmWwDG85UHFqV8PWLxoOBDBHFvS5fF2\n WFTq+xV5gUSgmSElLuwJx1RRGykii4mO/nYWIHto85BMh7fkhc/LA01Ra\n MLeO+UvQ+bslaQJGYemdE2AG6WzE/JUvaQ4Ndohsc7FEILXLZBAWdKV8R\n RD19hEkqjp9TPuCzhOv8+g3IU1LEcqpluuFjYfbhxKSz10aF8o/m95jAN\n Oh1zR1IvZ9bzw9901Jb09r8yd79LEquGM88GXlqNgfbRurKbJ5024hGFf\n Hm4r1YcOxvAiZd/ZazrQnsL7NamMyv4C3gb1NfdN2JJ9EzAfcgRrPWFMf A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10586\"; a=\"323742545\"", "E=Sophos;i=\"5.96,319,1665471600\"; d=\"scan'208\";a=\"323742545\"", "E=McAfee;i=\"6500,9779,10586\"; a=\"690102053\"", "E=Sophos;i=\"5.96,319,1665471600\"; d=\"scan'208\";a=\"690102053\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com, mb@smartsharesystems.com,\n roretzla@linux.microsoft.com, Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[RFC PATCH 1/1] build: increase minimum C standard for DPDK builds", "Date": "Thu, 12 Jan 2023 11:35:56 +0000", "Message-Id": "<20230112113556.47485-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230112113556.47485-1-bruce.richardson@intel.com>", "References": "<20230112113556.47485-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Set the default C language standard to be used for DPDK builds to C99.\nThis requires no actual code changes to build successfully.\n\nTo ensure compatibility is kept for external apps using DPDK headers, we\nexplicitly set the build parameters for the chkincs binary to the old\nminimum standard of \"gnu89\". [NOTE: DPDK code does not compile and has\npreviously not compiled for pure c89 standard, so that stricter\nrequirement need not be checked.] By adding this additional check, we\ncan separately manage C standards used internally in DPDK builds and\nthat required in the build flags for external apps using DPDK.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n buildtools/chkincs/meson.build | 1 +\n meson.build | 1 +\n 2 files changed, 2 insertions(+)", "diff": "diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build\nindex 378c2f19ef..322ac775ce 100644\n--- a/buildtools/chkincs/meson.build\n+++ b/buildtools/chkincs/meson.build\n@@ -30,6 +30,7 @@ executable('chkincs', sources,\n c_args: cflags,\n include_directories: includes,\n dependencies: deps,\n+ override_options: 'c_std=gnu89',\n install: false)\n \n # run tests for c++ builds also\ndiff --git a/meson.build b/meson.build\nindex f91d652bc5..9a2963cc16 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -9,6 +9,7 @@ project('DPDK', 'C',\n license: 'BSD',\n default_options: [\n 'buildtype=release',\n+ 'c_std=c99',\n 'default_library=static',\n 'warning_level=2',\n ],\n", "prefixes": [ "RFC", "1/1" ] }