Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121573/?format=api
{ "id": 121573, "url": "https://patches.dpdk.org/api/patches/121573/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230104113635.206506-1-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230104113635.206506-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20230104113635.206506-1-thomas@monjalon.net", "date": "2023-01-04T11:36:35", "name": "build: avoid deprecated function for Meson properties", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3abe00de5fa09189266036e1984a98a2b75a0266", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230104113635.206506-1-thomas@monjalon.net/mbox/", "series": [ { "id": 26385, "url": "https://patches.dpdk.org/api/series/26385/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=26385", "date": "2023-01-04T11:36:35", "name": "build: avoid deprecated function for Meson properties", "version": 1, "mbox": "https://patches.dpdk.org/series/26385/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/121573/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/121573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4ECB3A00C2;\n\tWed, 4 Jan 2023 12:36:54 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3341040697;\n\tWed, 4 Jan 2023 12:36:54 +0100 (CET)", "from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com\n [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id A9D494067B\n for <dev@dpdk.org>; Wed, 4 Jan 2023 12:36:52 +0100 (CET)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n by mailout.west.internal (Postfix) with ESMTP id 0BA8D320090C;\n Wed, 4 Jan 2023 06:36:50 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute4.internal (MEProxy); Wed, 04 Jan 2023 06:36:51 -0500", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 4 Jan 2023 06:36:49 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to\n :message-id:mime-version:reply-to:sender:subject:subject:to:to;\n s=fm2; t=1672832210; x=1672918610; bh=4631gfhlwA7msykbfqcQ8Hr08\n tfON/4lzSoqes9aAFs=; b=wXQtbKoabM0p98BLu2f3+KkXS2zqUZW78GzhktWFr\n tQs3IMu4HK5CWUZzQOEKQ5YPDc2b/AZ4LgTYkyRqFFIy9fW2/f78OY8GPiebChL9\n 907761nZ/+tHTQBbRJaE8ooKwNs5JhvK3xDVSr3vgYadIF4zQ1HPLznxEOnsoQHP\n AfAXJXryeKSHAy66Qd2WGyuCCqzost5LdvD0lddWQlMTjt49S3CMn4f9Z062tYz0\n W1QNF7c19gAWOr9CMzmgTzhN/aOLBNcR9OQuPL8I2iHF0izohRTlJWhXmzIWIl7z\n 9ovFbI10wQNatSmqFSf9PNR0lLEPTvnSQF6awGZ6vQmXA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding:date:date\n :feedback-id:feedback-id:from:from:in-reply-to:message-id\n :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy\n :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=\n 1672832210; x=1672918610; bh=4631gfhlwA7msykbfqcQ8Hr08tfON/4lzSo\n qes9aAFs=; b=Y2amCArj09f+W8D06bky2MLlAe3qVzX7rjzgKA3gDuXF2xol/l3\n l4EK5njf9qnUlDsmgwyVS+hpnraLhBRAa2xGKpMQzgOhcmNIp+59UbngU6EyN/r3\n q1RIJ4BgJXOzlf1+/du0EqIQmAwK0JT4lnkcWYQMOkYCshk2Adli2uqckuFOMAxr\n 5Cm3nCkVK23OxF422/Sl7KoikGNf/RJUElt4gLhZADmh3na9eSQ7ZVnEOkmjl7gd\n EJ7+QI+9TzC06rohmqlGB4dxyFhzjl8aiaSNYgPa7BpId0jANuFDFjF2IrK64urT\n nM0Dvd7Zbe+7DZWkeaXrEkZFyJ3VTNBliXQ==" ], "X-ME-Sender": "<xms:0mS1Y-LEvYv9TJv-b-Ux7ECv_1FarC0tRUhAEdb7GEExxzP_gcT9Kw>\n <xme:0mS1Y2L8_cLoklklcYDE7j7-C1mAcV11_MCJcdA2LbEZ_nwIWmgWzPGaKp-gJEDA9\n 0eYxiDfDGZYbAZ9kg>", "X-ME-Received": "\n <xmr:0mS1Y-vZnNQWOYnd58Ck-k0CHKqm1wmn9vH4SXfJJ4OxD86do_bxRaoYBXNz-ZIGQInismSi3Pu2GZ03_eQbuuvzuU6jjQE>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvhedrjeeigddvlecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgrshcu\n ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf\n grthhtvghrnhepveevfeevieeihfetudekgeekleeigeffueekveduteeuffeiudevteei\n udekfeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh\n epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:0mS1YzZXGWYQtpDbZ2ksbd-4dOkFogJqT16TMQAf8krDj1N-hHzI4Q>\n <xmx:0mS1Y1ZqMLMQ7FCi4DtfjSKru61yW9e8fjk0j_BhQ8kVpyClU_AWWg>\n <xmx:0mS1Y_AmVefc7yq274BbI6kj8wum-25dTIim7tZ4hs3_UDDiA2S2_g>\n <xmx:0mS1Y5F6gUsjT8EjYiGryM3yqm2wXvzv1QOIen0kBmTM3NruYmZqVA>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Ruifeng Wang <ruifeng.wang@arm.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>", "Cc": "dev@dpdk.org,\n\tDavid Marchand <david.marchand@redhat.com>", "Subject": "[PATCH] build: avoid deprecated function for Meson properties", "Date": "Wed, 4 Jan 2023 12:36:35 +0100", "Message-Id": "<20230104113635.206506-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.39.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function get_cross_property() has been deprecated in Meson 0.58,\nand is replaced by the function get_external_property() introduced\nin Meson 0.54.\n\nThis replacement requires to raise the minimal accepted Meson version\nfrom 0.53.2 to 0.54.0.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n config/arm/meson.build | 4 ++--\n config/meson.build | 6 +++---\n config/riscv/meson.build | 4 ++--\n doc/guides/linux_gsg/sys_reqs.rst | 2 +-\n drivers/meson.build | 4 ++--\n kernel/linux/meson.build | 4 ++--\n 6 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 6442ec9596..5a9411af75 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -503,7 +503,7 @@ if dpdk_conf.get('RTE_ARCH_32')\n dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)\n if meson.is_cross_build()\n update_flags = true\n- soc = meson.get_cross_property('platform', '')\n+ soc = meson.get_external_property('platform', '')\n if soc == ''\n error('Arm SoC must be specified in the cross file.')\n endif\n@@ -558,7 +558,7 @@ else\n endif\n else\n # cross build\n- soc = meson.get_cross_property('platform', '')\n+ soc = meson.get_external_property('platform', '')\n if soc == ''\n error('Arm SoC must be specified in the cross file.')\n endif\ndiff --git a/config/meson.build b/config/meson.build\nindex 6d9ffd4f4b..80564eec52 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -176,7 +176,7 @@ endif\n # check for libraries used in multiple places in DPDK\n has_libnuma = 0\n find_libnuma = true\n-if meson.is_cross_build() and not meson.get_cross_property('numa', true)\n+if meson.is_cross_build() and not meson.get_external_property('numa', true)\n # don't look for libnuma if explicitly disabled in cross build\n find_libnuma = false\n endif\n@@ -324,12 +324,12 @@ dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS', ','.join(compile_time_cpuflags))\n # apply cross-specific options\n if meson.is_cross_build()\n # configure RTE_MAX_LCORE and RTE_MAX_NUMA_NODES from cross file\n- cross_max_lcores = meson.get_cross_property('max_lcores', 0)\n+ cross_max_lcores = meson.get_external_property('max_lcores', 0)\n if cross_max_lcores != 0\n message('Setting RTE_MAX_LCORE from cross file')\n dpdk_conf.set('RTE_MAX_LCORE', cross_max_lcores)\n endif\n- cross_max_numa_nodes = meson.get_cross_property('max_numa_nodes', 0)\n+ cross_max_numa_nodes = meson.get_external_property('max_numa_nodes', 0)\n if cross_max_numa_nodes != 0\n message('Setting RTE_MAX_NUMA_NODES from cross file')\n dpdk_conf.set('RTE_MAX_NUMA_NODES', cross_max_numa_nodes)\ndiff --git a/config/riscv/meson.build b/config/riscv/meson.build\nindex 07d7d9da23..7562c6cb99 100644\n--- a/config/riscv/meson.build\n+++ b/config/riscv/meson.build\n@@ -84,8 +84,8 @@ if not meson.is_cross_build()\n endif\n else\n # cross build\n- vendor_id = meson.get_cross_property('vendor_id')\n- arch_id = meson.get_cross_property('arch_id')\n+ vendor_id = meson.get_external_property('vendor_id')\n+ arch_id = meson.get_external_property('arch_id')\n endif\n \n if not vendors.has_key(vendor_id)\ndiff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst\nindex a7e8261e22..e4f9b41251 100644\n--- a/doc/guides/linux_gsg/sys_reqs.rst\n+++ b/doc/guides/linux_gsg/sys_reqs.rst\n@@ -43,7 +43,7 @@ Compilation of the DPDK\n \n * Python 3.6 or later.\n \n-* Meson (version 0.53.2+) and ninja\n+* Meson (version 0.54+) and ninja\n \n * ``meson`` & ``ninja-build`` packages in most Linux distributions\n * If the packaged version is below the minimum version, the latest versions\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex c6d619200f..c17c92cca8 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -25,8 +25,8 @@ subdirs = [\n ]\n \n if meson.is_cross_build()\n- disable_drivers += ',' + meson.get_cross_property('disable_drivers', '')\n- enable_drivers += ',' + meson.get_cross_property('enable_drivers', '')\n+ disable_drivers += ',' + meson.get_external_property('disable_drivers', '')\n+ enable_drivers += ',' + meson.get_external_property('enable_drivers', '')\n endif\n \n # add cmdline disabled drivers and meson disabled drivers together\ndiff --git a/kernel/linux/meson.build b/kernel/linux/meson.build\nindex 16a0948994..66cbcd1dbf 100644\n--- a/kernel/linux/meson.build\n+++ b/kernel/linux/meson.build\n@@ -67,7 +67,7 @@ elif cross_compiler.endswith('clang')\n found_target = false\n # search for '-target' and use the arg that follows\n # (i.e. the value of '-target') as cross_prefix\n- foreach cross_c_arg : meson.get_cross_property('c_args')\n+ foreach cross_c_arg : meson.get_external_property('c_args')\n if found_target and cross_prefix == ''\n cross_prefix = cross_c_arg\n endif\n@@ -79,7 +79,7 @@ elif cross_compiler.endswith('clang')\n error('Did not find -target and its value in c_args in input cross-file.')\n endif\n linker = 'lld'\n- foreach cross_c_link_arg : meson.get_cross_property('c_link_args')\n+ foreach cross_c_link_arg : meson.get_external_property('c_link_args')\n if cross_c_link_arg.startswith('-fuse-ld')\n linker = cross_c_link_arg.split('=')[1]\n endif\n", "prefixes": [] }